{"thread":{"id":"36784","subject":"git-multimail: migration: Config is not iterable","startedAt":"2014-05-29T14:22:08Z","lastAt":"2014-05-31T15:21:50Z","messageCount":4,"participants":["Azat Khuzhin","Elijah Newren","Michael Haggerty"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"242945","messageId":"20140529142208.GB27005@azat","threadId":"36784","inReplyTo":null,"subject":"git-multimail: migration: Config is not iterable","fromName":"Azat Khuzhin","fromEmail":"a3at.mail@gmail.com","sentAt":"2014-05-29T14:22:08Z","receivedAt":"2014-05-29T14:22:08Z","isPatch":false,"sender":{"key":"a3at.mail@gmail.com","avatar":null},"body":"Hi there,\n\nUsing the latest version of git-multimail there is an issue with\nmigration:\n\n$ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite\nTraceback (most recent call last):\n  File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 271, in <module>\n    main(sys.argv[1:])\n  File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 268, in main\n    migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)\n  File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 159, in migrate_config\n    if not _check_old_config_exists(old):\n  File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 66, in _check_old_config_exists\n    if name in old:\nTypeError: argument of type 'Config' is not iterable\n\nTested on 2.6 and 2.7 python versions.\n\nIf you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 (\"Get Python files to\npass pep8's tests.\") there issue goes away. I understand that this is not the\nright solution and I'm not the guru of python, so just let you know.\n\nThanks\n"},{"id":"242947","messageId":"CABPp-BHfUbh31ZBZk6XTMvmZjNioe1-rNpTn6tsHPNge2c-yTw@mail.gmail.com","threadId":"36784","inReplyTo":"20140529142208.GB27005@azat","subject":"Re: git-multimail: migration: Config is not iterable","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2014-05-29T16:06:40Z","receivedAt":"2014-05-29T16:06:40Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, May 29, 2014 at 7:22 AM, Azat Khuzhin <a3at.mail@gmail.com> wrote:\n> Hi there,\n>\n> Using the latest version of git-multimail there is an issue with\n> migration:\n>\n> $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite\n> Traceback (most recent call last):\n...\n>   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 66, in _check_old_config_exists\n>     if name in old:\n> TypeError: argument of type 'Config' is not iterable\n\nThanks for the report.  I'm not the strongest on python data model and\nits special methods but I believe I've got a fix:\nhttps://github.com/mhagger/git-multimail/pull/58\n"},{"id":"243078","messageId":"5389EE61.9060108@alum.mit.edu","threadId":"36784","inReplyTo":"20140529142208.GB27005@azat","subject":"Re: git-multimail: migration: Config is not iterable","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2014-05-31T14:59:45Z","receivedAt":"2014-05-31T14:59:45Z","isPatch":false,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On 05/29/2014 04:22 PM, Azat Khuzhin wrote:\n> Using the latest version of git-multimail there is an issue with\n> migration:\n> \n> $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite\n> Traceback (most recent call last):\n>   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 271, in <module>\n>     main(sys.argv[1:])\n>   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 268, in main\n>     migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)\n>   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 159, in migrate_config\n>     if not _check_old_config_exists(old):\n>   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 66, in _check_old_config_exists\n>     if name in old:\n> TypeError: argument of type 'Config' is not iterable\n> \n> Tested on 2.6 and 2.7 python versions.\n> \n> If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 (\"Get Python files to\n> pass pep8's tests.\") there issue goes away. I understand that this is not the\n> right solution and I'm not the guru of python, so just let you know.\n\nThanks for the bug report and for narrowing it down to the broken\ncommit.  I just pushed a fix to GitHub.  Let me know if it works for you\nnow.\n\nElijah: your fix is also correct, but I didn't see it before I pushed my\nown solution.  Sorry about that.\n\nJunio: you don't have to worry about any of this, because the commit\nthat caused the breakage is not in your tree yet.\n\nMichael\n\n-- \nMichael Haggerty\nmhagger@alum.mit.edu\n"},{"id":"243080","messageId":"20140531151931.GJ27473@azat","threadId":"36784","inReplyTo":"5389EE61.9060108@alum.mit.edu","subject":"Re: git-multimail: migration: Config is not iterable","fromName":"Azat Khuzhin","fromEmail":"a3at.mail@gmail.com","sentAt":"2014-05-31T15:21:50Z","receivedAt":"2014-05-31T15:21:50Z","isPatch":false,"sender":{"key":"a3at.mail@gmail.com","avatar":null},"body":"On Sat, May 31, 2014 at 04:59:45PM +0200, Michael Haggerty wrote:\n> On 05/29/2014 04:22 PM, Azat Khuzhin wrote:\n> > Using the latest version of git-multimail there is an issue with\n> > migration:\n> > \n> > $ ~azat/git-multimail/git-multimail/migrate-mailhook-config --overwrite\n> > Traceback (most recent call last):\n> >   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 271, in <module>\n> >     main(sys.argv[1:])\n> >   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 268, in main\n> >     migrate_config(strict=options.strict, retain=options.retain, overwrite=options.overwrite)\n> >   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 159, in migrate_config\n> >     if not _check_old_config_exists(old):\n> >   File \"/home/azat/git-multimail/git-multimail/migrate-mailhook-config\", line 66, in _check_old_config_exists\n> >     if name in old:\n> > TypeError: argument of type 'Config' is not iterable\n> > \n> > Tested on 2.6 and 2.7 python versions.\n> > \n> > If you revert 09d0d5b92203f019763e43cef1e57f76f117d2b4 (\"Get Python files to\n> > pass pep8's tests.\") there issue goes away. I understand that this is not the\n> > right solution and I'm not the guru of python, so just let you know.\n> \n> Thanks for the bug report and for narrowing it down to the broken\n> commit.  I just pushed a fix to GitHub.  Let me know if it works for you\n> now.\n\nYeah, it works, thanks!\n\n-- \nRespectfully\nAzat Khuzhin\n"}]}