{"thread":{"id":"36783","subject":"[PATCH] tests: turn off git-daemon tests if FIFOs are not available","startedAt":"2014-05-29T11:36:14Z","lastAt":"2014-05-29T15:57:10Z","messageCount":2,"participants":["Stepan Kasal","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"242935","messageId":"20140529113614.GA24293@camelia.ucw.cz","threadId":"36783","inReplyTo":null,"subject":"[PATCH] tests: turn off git-daemon tests if FIFOs are not available","fromName":"Stepan Kasal","fromEmail":"kasal@ucw.cz","sentAt":"2014-05-29T11:36:14Z","receivedAt":"2014-05-29T11:36:14Z","isPatch":true,"sender":{"key":"kasal@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/1481596?v=4"},"body":"Signed-off-by: Stepan Kasal <kasal@ucw.cz>\n---\n\nHi,\n  mingw does not have FIFOs, so it cannot run git-daemon tests.\nStepan\n\n t/lib-git-daemon.sh | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/t/lib-git-daemon.sh b/t/lib-git-daemon.sh\nindex bc4b341..9b1271c 100644\n--- a/t/lib-git-daemon.sh\n+++ b/t/lib-git-daemon.sh\n@@ -23,6 +23,11 @@ then\n \ttest_done\n fi\n \n+if ! test_have_prereq PIPE\n+then\n+\ttest_skip_or_die $GIT_TEST_GIT_DAEMON \"file system does not support FIFOs\"\n+fi\n+\n LIB_GIT_DAEMON_PORT=${LIB_GIT_DAEMON_PORT-${this_test#t}}\n \n GIT_DAEMON_PID=\n-- \n1.9.2.msysgit.0.493.g4becbf6.dirty\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"242946","messageId":"20140529155710.GA3763@sigill.intra.peff.net","threadId":"36783","inReplyTo":"20140529113614.GA24293@camelia.ucw.cz","subject":"Re: [PATCH] tests: turn off git-daemon tests if FIFOs are not available","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-29T15:57:10Z","receivedAt":"2014-05-29T15:57:10Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, May 29, 2014 at 01:36:14PM +0200, Stepan Kasal wrote:\n\n> Signed-off-by: Stepan Kasal <kasal@ucw.cz>\n> ---\n> \n> Hi,\n>   mingw does not have FIFOs, so it cannot run git-daemon tests.\n\nThanks. I took a peek at the mkfifo call here. It is used to make sure\nthe daemon has started before we run the tests which depend on it. I\nsuspect we could do something with a regular pipe, but the code would be\nrather tricky.  Simply skipping the daemon tests is a reasonable\ncompromise until somebody feels like trying to make it work without a\nfifo.\n\n-Peff\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"}]}