{"thread":{"id":"36645","subject":"Bash prompt \"namespace\" issue","startedAt":"2014-05-13T06:18:49Z","lastAt":"2014-05-13T18:52:21Z","messageCount":2,"participants":["szeder@ira.uka.de","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"241335","messageId":"20140513081849.5dql886xw080ww88@webmail.informatik.kit.edu","threadId":"36645","inReplyTo":null,"subject":"Bash prompt \"namespace\" issue","fromName":"","fromEmail":"szeder@ira.uka.de","sentAt":"2014-05-13T06:18:49Z","receivedAt":"2014-05-13T06:18:49Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Hi,\n\nCommit 59d3924fb (prompt: fix missing file errors in zsh) added the  \nhelper function eread() to git-prompt.sh.  That function should be in  \nthe git \"namespace\", i.e. prefixed with __git_, otherwise it might  \ncollide with a function of the same name in the user's environment.\n\nIt's already in master and I don't have the means to send a patch  \nfixing this ATM, sorry.\n\nBest,\nGábor\n"},{"id":"241389","messageId":"xmqqoaz1o6je.fsf@gitster.dls.corp.google.com","threadId":"36645","inReplyTo":"20140513081849.5dql886xw080ww88@webmail.informatik.kit.edu","subject":"Re: Bash prompt \"namespace\" issue","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-05-13T18:52:21Z","receivedAt":"2014-05-13T18:52:21Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"szeder@ira.uka.de writes:\n\n> Commit 59d3924fb (prompt: fix missing file errors in zsh) added the  \n> helper function eread() to git-prompt.sh.  That function should be in  \n> the git \"namespace\", i.e. prefixed with __git_, otherwise it might  \n> collide with a function of the same name in the user's environment.\n>\n> It's already in master and I don't have the means to send a patch  \n> fixing this ATM, sorry.\n\nThanks.  I think the patch Felipe posted to rename it to __git_eread\nis a reasonable regression fix, so I'll queue it on top of the\nproblematic commit 59d3924f (prompt: fix missing file errors in zsh,\n2014-04-11) and merge the result to 'master'.\n"}]}