{"thread":{"id":"36603","subject":"[PATCH] shell doc: remove stray \"+\" in example","startedAt":"2014-05-07T23:44:01Z","lastAt":"2014-05-08T17:26:41Z","messageCount":3,"participants":["Jonathan Nieder","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"240977","messageId":"20140507234401.GY9218@google.com","threadId":"36603","inReplyTo":null,"subject":"[PATCH] shell doc: remove stray \"+\" in example","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-05-07T23:44:01Z","receivedAt":"2014-05-07T23:44:01Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"The git-shell(1) manpage says\n\n\tEXAMPLE\n\t       To disable interactive logins, displaying a greeting\n\t\tinstead:\n\n\t\t+\n\n\t\t   $ chsh -s /usr/bin/git-shell\n\t\t   $ mkdir $HOME/git-shell-commands\n[...]\n\nThe stray \"+\" has been there ever since the example was added in\nv1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a\ncustom message, 2013-03-09).  The \"+\" sign between paragraphs is\nneeded in asciidoc to attach extra paragraphs to a list item but here\nit is not needed and ends up rendered as a literal \"+\".  Remove it.\n\nA quick search with \"grep -e '<p>+' /usr/share/doc/git/html/*.html\"\ndoesn't find any other instances of this problem.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n Documentation/git-shell.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-shell.txt b/Documentation/git-shell.txt\nindex c35051b..e4bdd22 100644\n--- a/Documentation/git-shell.txt\n+++ b/Documentation/git-shell.txt\n@@ -66,7 +66,7 @@ EXAMPLE\n -------\n \n To disable interactive logins, displaying a greeting instead:\n-+\n+\n ----------------\n $ chsh -s /usr/bin/git-shell\n $ mkdir $HOME/git-shell-commands\n-- \n1.9.1.423.g4596e3a\n"},{"id":"240988","messageId":"20140508040438.GB26630@sigill.intra.peff.net","threadId":"36603","inReplyTo":"20140507234401.GY9218@google.com","subject":"Re: [PATCH] shell doc: remove stray \"+\" in example","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-08T04:04:38Z","receivedAt":"2014-05-08T04:04:38Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, May 07, 2014 at 04:44:01PM -0700, Jonathan Nieder wrote:\n\n> The git-shell(1) manpage says\n> \n> \tEXAMPLE\n> \t       To disable interactive logins, displaying a greeting\n> \t\tinstead:\n> \n> \t\t+\n> \n> \t\t   $ chsh -s /usr/bin/git-shell\n> \t\t   $ mkdir $HOME/git-shell-commands\n> [...]\n> \n> The stray \"+\" has been there ever since the example was added in\n> v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a\n> custom message, 2013-03-09).  The \"+\" sign between paragraphs is\n> needed in asciidoc to attach extra paragraphs to a list item but here\n> it is not needed and ends up rendered as a literal \"+\".  Remove it.\n> \n> A quick search with \"grep -e '<p>+' /usr/share/doc/git/html/*.html\"\n> doesn't find any other instances of this problem.\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n\nLooks good to me. I suspect it was copied from another spot where the\nexamples _were_ in a list (e.g., git-add's EXAMPLES section). Either\nway, your fix is the right thing to do.\n\n-Peff\n"},{"id":"241014","messageId":"xmqqsiok41wu.fsf@gitster.dls.corp.google.com","threadId":"36603","inReplyTo":"20140508040438.GB26630@sigill.intra.peff.net","subject":"Re: [PATCH] shell doc: remove stray \"+\" in example","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-05-08T17:26:41Z","receivedAt":"2014-05-08T17:26:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Wed, May 07, 2014 at 04:44:01PM -0700, Jonathan Nieder wrote:\n>\n>> The git-shell(1) manpage says\n>> \n>> \tEXAMPLE\n>> \t       To disable interactive logins, displaying a greeting\n>> \t\tinstead:\n>> \n>> \t\t+\n>> \n>> \t\t   $ chsh -s /usr/bin/git-shell\n>> \t\t   $ mkdir $HOME/git-shell-commands\n>> [...]\n>> \n>> The stray \"+\" has been there ever since the example was added in\n>> v1.8.3-rc0~210^2 (shell: new no-interactive-login command to print a\n>> custom message, 2013-03-09).  The \"+\" sign between paragraphs is\n>> needed in asciidoc to attach extra paragraphs to a list item but here\n>> it is not needed and ends up rendered as a literal \"+\".  Remove it.\n>> \n>> A quick search with \"grep -e '<p>+' /usr/share/doc/git/html/*.html\"\n>> doesn't find any other instances of this problem.\n>> \n>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n> Looks good to me. I suspect it was copied from another spot where the\n> examples _were_ in a list (e.g., git-add's EXAMPLES section). Either\n> way, your fix is the right thing to do.\n\nThanks, both.  Looks good to me, too.\n"}]}