{"thread":{"id":"36575","subject":"[PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","startedAt":"2014-05-03T12:49:30Z","lastAt":"2014-05-06T12:41:32Z","messageCount":14,"participants":["James Denholm","Jeff King"],"isPatch":true,"patchVersion":2,"patchTotal":5},"messages":[{"id":"240627","messageId":"1399121375-14727-1-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":null,"subject":"[PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:30Z","receivedAt":"2014-05-03T12:49:30Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"contrib/subtree/Makefile is a shambles in regards to it's consistency\nwith other makefiles, which makes subtree overly painful to include in\nbuild scripts.\n\nThe main issues are that calls are made to git itself in the build\nprocess, and that a subtree-exclusive variable is used for specifying\nthe exec path. Patches 1/5 through 3/5 resolve these.\n\nThe \"cleanup\" fixes (4/5 and 5/5) are based on precedents set by other\nmakefiles across the project.\n\nOne problem is foreseen: 3/5 will necessitate that package maintainers\nwho already have git-subtree included in their packages update their\nbuild-scripts.\n\nSigned-off-by: James Denholm \nBased-on-patch-by: Dan McGee \n\nJames Denholm (5):\n contrib/subtree/Makefile: scrap unused $(gitdir)\n contrib/subtree/Makefile: Use GIT-VERSION-FILE\n contrib/subtree/Makefile: s/libexecdir/gitexecdir\n contrib/subtree/Makefile: Doc-gen rules cleanup\n contrib/subtree/Makefile: clean rule cleanup\n\n contrib/subtree/Makefile | 40 ++++++++++++++++++++++++----------------\n 1 file changed, 24 insertions(+), 16 deletions(-)\n\n-- \n1.9.2\n"},{"id":"240628","messageId":"1399121375-14727-2-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":"1399121375-14727-1-git-send-email-nod.helm@gmail.com","subject":"[PATCH v2 1/5] contrib/subtree/Makefile: scrap unused $(gitdir)","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:31Z","receivedAt":"2014-05-03T12:49:31Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"All references were removed in 7ff8463dba0d74fc07a766bed457ae7afcc902b5,\nbut the assignment itself wasn't. Hence, drop gitdir assignment.\n\nSigned-off-by: James Denholm \n---\n contrib/subtree/Makefile | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex 4030a16..87797ed 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -4,7 +4,6 @@\n prefix ?= /usr/local\n mandir ?= $(prefix)/share/man\n libexecdir ?= $(prefix)/libexec/git-core\n-gitdir ?= $(shell git --exec-path)\n man1dir ?= $(mandir)/man1\n \n gitver ?= $(word 3,$(shell git --version))\n-- \n1.9.2\n"},{"id":"240630","messageId":"1399121375-14727-3-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":"1399121375-14727-2-git-send-email-nod.helm@gmail.com","subject":"[PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:32Z","receivedAt":"2014-05-03T12:49:32Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"GVF is already being used in most/all other makefiles in the project,\nand has been for _quite_ a while. Hence, drop file-unique gitver and\nreplace with GIT_VERSION.\n\nSigned-off-by: James Denholm \n---\n contrib/subtree/Makefile | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex 87797ed..f63334b 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -6,7 +6,10 @@ mandir ?= $(prefix)/share/man\n libexecdir ?= $(prefix)/libexec/git-core\n man1dir ?= $(mandir)/man1\n \n-gitver ?= $(word 3,$(shell git --version))\n+../../GIT-VERSION-FILE: FORCE\n+\t$(MAKE) -C ../../ GIT-VERSION-FILE\n+\n+-include ../../GIT-VERSION-FILE\n \n # this should be set to a 'standard' bsd-type install program\n INSTALL ?= install\n@@ -44,11 +47,11 @@ $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)\n \n $(GIT_SUBTREE_XML): $(GIT_SUBTREE_TXT)\n \tasciidoc -b docbook -d manpage -f $(ASCIIDOC_CONF) \\\n-\t\t-agit_version=$(gitver) $^\n+\t\t-agit_version=$(GIT_VERSION) $^\n \n $(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)\n \tasciidoc -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \\\n-\t\t-agit_version=$(gitver) $^\n+\t\t-agit_version=$(GIT_VERSION) $^\n \n test:\n \t$(MAKE) -C t/ test\n@@ -56,3 +59,5 @@ test:\n clean:\n \trm -f *~ *.xml *.html *.1\n \trm -rf subproj mainline\n+\n+.PHONY: FORCE\n-- \n1.9.2\n"},{"id":"240629","messageId":"1399121375-14727-4-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":"1399121375-14727-3-git-send-email-nod.helm@gmail.com","subject":"[PATCH v2 3/5] contrib/subtree/Makefile: s/libexecdir/gitexecdir","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:33Z","receivedAt":"2014-05-03T12:49:33Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"$(libexecdir) isn't used anywhere else in the project, while\n$(gitexecdir) is the standard in the other appropriate makefiles. Hence,\nreplace the former with the latter.\n\nSigned-off-by: James Denholm \n---\n contrib/subtree/Makefile | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex f63334b..579bb51 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -3,7 +3,7 @@\n \n prefix ?= /usr/local\n mandir ?= $(prefix)/share/man\n-libexecdir ?= $(prefix)/libexec/git-core\n+gitexecdir ?= $(prefix)/libexec/git-core\n man1dir ?= $(mandir)/man1\n \n ../../GIT-VERSION-FILE: FORCE\n@@ -33,8 +33,8 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)\n doc: $(GIT_SUBTREE_DOC) $(GIT_SUBTREE_HTML)\n \n install: $(GIT_SUBTREE)\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(libexecdir)\n-\t$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)\n+\t$(INSTALL) -d -m 755 $(DESTDIR)$(gitexecdir)\n+\t$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(gitexecdir)\n \n install-doc: install-man\n \n-- \n1.9.2\n"},{"id":"240631","messageId":"1399121375-14727-5-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":"1399121375-14727-4-git-send-email-nod.helm@gmail.com","subject":"[PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:34Z","receivedAt":"2014-05-03T12:49:34Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"git:Documentation/Makefile establishes asciidoc/xmlto calls as being\nhandled through their appropriate variables, Hence, change to bring into\ncongruency with.\n\nSimilarly, MANPAGE_XSL exists in git:Documentation/Makefile, while\nMANPAGE_NORMAL_XSL does not outside contrib/subtree. Hence, replace\nMANPAGE_NORMAL_XSL with MANPAGE_XSL.\n\nSigned-off-by: James Denholm \n---\n contrib/subtree/Makefile | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex 579bb51..f3834b5 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -14,8 +14,11 @@ man1dir ?= $(mandir)/man1\n # this should be set to a 'standard' bsd-type install program\n INSTALL ?= install\n \n-ASCIIDOC_CONF = ../../Documentation/asciidoc.conf\n-MANPAGE_NORMAL_XSL = ../../Documentation/manpage-normal.xsl\n+ASCIIDOC = asciidoc\n+XMLTO = xmlto\n+\n+ASCIIDOC_CONF = ../../Documentation/asciidoc.conf\n+MANPAGE_XSL = ../../Documentation/manpage-normal.xsl\n \n GIT_SUBTREE_SH := git-subtree.sh\n GIT_SUBTREE := git-subtree\n@@ -43,14 +46,14 @@ install-man: $(GIT_SUBTREE_DOC)\n \t$(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)\n \n $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)\n-\txmlto -m $(MANPAGE_NORMAL_XSL) man $^\n+\t$(XMLTO) -m $(MANPAGE_XSL) man $^\n \n $(GIT_SUBTREE_XML): $(GIT_SUBTREE_TXT)\n-\tasciidoc -b docbook -d manpage -f $(ASCIIDOC_CONF) \\\n+\t$(ASCIIDOC) -b docbook -d manpage -f $(ASCIIDOC_CONF) \\\n \t\t-agit_version=$(GIT_VERSION) $^\n \n $(GIT_SUBTREE_HTML): $(GIT_SUBTREE_TXT)\n-\tasciidoc -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \\\n+\t$(ASCIIDOC) -b xhtml11 -d manpage -f $(ASCIIDOC_CONF) \\\n \t\t-agit_version=$(GIT_VERSION) $^\n \n test:\n-- \n1.9.2\n"},{"id":"240632","messageId":"1399121375-14727-6-git-send-email-nod.helm@gmail.com","threadId":"36575","inReplyTo":"1399121375-14727-5-git-send-email-nod.helm@gmail.com","subject":"[PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-03T12:49:35Z","receivedAt":"2014-05-03T12:49:35Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"git:Documentation/Makefile and others establish \"RM ?= rm -f\" as a\nconvention for rm calls in clean rules, hence follow this convention\ninstead of simply forcing clean to use rm.\n\nsubproj and mainline no longer need to be removed in clean, as they are\nno longer created in git:contrib/subtree by \"make test\". Hence, remove\nthe rm call for those folders.\n\nOther makefiles don't remove \"*~\" files, remove the rm call to prevent\nunexpected behaviour in the future. Similarly, clean doesn't remove the\ninstallable file, so rectify this.\n\nSigned-off-by: James Denholm \n---\n\nAdmittedly, git:Makefile does not itself follow the \"RM ?= rm -f\"\nsetup, instead using \"RM = rm -f\", but I felt that there were probably\n$ARCANE_REASONS for this.\n\nAlso, Peff, you were right about the dirs.\n\n contrib/subtree/Makefile | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\nindex f3834b5..4f96a24 100644\n--- a/contrib/subtree/Makefile\n+++ b/contrib/subtree/Makefile\n@@ -11,8 +11,9 @@ man1dir ?= $(mandir)/man1\n \n -include ../../GIT-VERSION-FILE\n \n-# this should be set to a 'standard' bsd-type install program\n-INSTALL ?= install\n+# These should be set to 'standard' bsd-type programs\n+INSTALL ?= install\n+RM ?= rm -f\n \n ASCIIDOC = asciidoc\n XMLTO = xmlto\n@@ -60,7 +61,7 @@ test:\n \t$(MAKE) -C t/ test\n \n clean:\n-\trm -f *~ *.xml *.html *.1\n-\trm -rf subproj mainline\n+\t$(RM) $(GIT_SUBTREE)\n+\t$(RM) *.xml *.html *.1\n \n .PHONY: FORCE\n-- \n1.9.2\n"},{"id":"240715","messageId":"20140505050803.GA6569@sigill.intra.peff.net","threadId":"36575","inReplyTo":"1399121375-14727-1-git-send-email-nod.helm@gmail.com","subject":"Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-05T05:08:04Z","receivedAt":"2014-05-05T05:08:04Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:\n\n> The main issues are that calls are made to git itself in the build\n> process, and that a subtree-exclusive variable is used for specifying\n> the exec path. Patches 1/5 through 3/5 resolve these.\n> \n> The \"cleanup\" fixes (4/5 and 5/5) are based on precedents set by other\n> makefiles across the project.\n\nThanks, these all look sane to me (I do not use subtree, but since it's\njust about Makefiles, it was pretty easy to review).\n\n> One problem is foreseen: 3/5 will necessitate that package maintainers\n> who already have git-subtree included in their packages update their\n> build-scripts.\n\nI think that's probably OK. We strive for backwards compatibility in the\ntool itself, but refactoring Makefiles in contrib/ affects a pretty\nlimited audience.\n\n-Peff\n"},{"id":"240718","messageId":"20140505050938.GB6569@sigill.intra.peff.net","threadId":"36575","inReplyTo":"1399121375-14727-6-git-send-email-nod.helm@gmail.com","subject":"Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-05T05:09:39Z","receivedAt":"2014-05-05T05:09:39Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, May 03, 2014 at 10:49:35PM +1000, James Denholm wrote:\n\n> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\n> index f3834b5..4f96a24 100644\n> --- a/contrib/subtree/Makefile\n> +++ b/contrib/subtree/Makefile\n> @@ -11,8 +11,9 @@ man1dir ?= $(mandir)/man1\n> \n> -include ../../GIT-VERSION-FILE\n> \n> -# this should be set to a 'standard' bsd-type install program\n> -INSTALL ?= install\n> +# These should be set to 'standard' bsd-type programs\n> +INSTALL ?= install\n> +RM ?= rm -f\n\nI do not think BSD-ism matters for \"rm\", as it works pretty much the\nsame everywhere. \"install\", on the other hand, is a bit weirder between\nsystems. So you might want to leave that comment as-is.\n\nOTOH, we do not even bother with such a comment in the main Makefile.\n\n-Peff\n"},{"id":"240762","messageId":"40d16f4b-440c-4268-bd6a-e7f413d01801@email.android.com","threadId":"36575","inReplyTo":"20140505050938.GB6569@sigill.intra.peff.net","subject":"Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-05T21:41:29Z","receivedAt":"2014-05-05T21:41:29Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"On 5 May 2014 15:09:39 GMT+10:00, Jeff King wrote:\n>On Sat, May 03, 2014 at 10:49:35PM +1000, James Denholm wrote:\n>\n>> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile\n>> index f3834b5..4f96a24 100644\n>> --- a/contrib/subtree/Makefile\n>> +++ b/contrib/subtree/Makefile\n>> @@ -11,8 +11,9 @@ man1dir ?= $(mandir)/man1\n>> \n>> -include ../../GIT-VERSION-FILE\n>> \n>> -# this should be set to a 'standard' bsd-type install program\n>> -INSTALL ?= install\n>> +# These should be set to 'standard' bsd-type programs\n>> +INSTALL ?= install\n>> +RM ?= rm -f\n>\n>I do not think BSD-ism matters for \"rm\", as it works pretty much the\n>same everywhere. \"install\", on the other hand, is a bit weirder between\n>systems. So you might want to leave that comment as-is.\n\nTrue. I might just buff that out when sending the patch to Junio, unless\nprotocol dictates otherwise - a reroll for a single comment line seems\na bit excessive to me at the moment.\n\nRegards,\nJames Denholm.\n"},{"id":"240729","messageId":"20140505214930.GB16971@sigill.intra.peff.net","threadId":"36575","inReplyTo":"40d16f4b-440c-4268-bd6a-e7f413d01801@email.android.com","subject":"Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-05T21:49:30Z","receivedAt":"2014-05-05T21:49:30Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, May 06, 2014 at 07:41:29AM +1000, James Denholm wrote:\n\n> >I do not think BSD-ism matters for \"rm\", as it works pretty much the\n> >same everywhere. \"install\", on the other hand, is a bit weirder between\n> >systems. So you might want to leave that comment as-is.\n> \n> True. I might just buff that out when sending the patch to Junio, unless\n> protocol dictates otherwise - a reroll for a single comment line seems\n> a bit excessive to me at the moment.\n\nI don't think it is that big a deal either way.\n\nIt's fine to tweak when you send re-roll the final for Junio. Sometimes\nfor trivial fixups like this, Junio can just tweak it as he applies, but\nI do not know if he is even paying attention to this thread, so you may\nwant to re-post anyway to get his attention.\n\nEither way, feel free to add my:\n\n Reviewed-by: Jeff King \n\n-Peff\n"},{"id":"240757","messageId":"69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com","threadId":"36575","inReplyTo":"20140505050803.GA6569@sigill.intra.peff.net","subject":"Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-05T21:54:30Z","receivedAt":"2014-05-05T21:54:30Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"On 5 May 2014 15:08:04 GMT+10:00, Jeff King wrote:\n>On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:\n>\n>> The main issues are that calls are made to git itself in the build\n>> process, and that a subtree-exclusive variable is used for specifying\n>> the exec path. Patches 1/5 through 3/5 resolve these.\n>> \n>> The \"cleanup\" fixes (4/5 and 5/5) are based on precedents set by\n>other\n>> makefiles across the project.\n>\n>Thanks, these all look sane to me (I do not use subtree, but since it's\n>just about Makefiles, it was pretty easy to review).\n\nThanks for the review!\n\nGiven that subtree subtree doesn't really generate a lot of discussion,\nwould it be advisable to wrap this up (barring further discussion) and send\nit off to Junio rather than waiting for further community consensus?\n\nRegards,\nJames Denholm.\n"},{"id":"240761","messageId":"fbc4c901-9389-48ea-a675-73739a11a647@email.android.com","threadId":"36575","inReplyTo":"20140505214930.GB16971@sigill.intra.peff.net","subject":"Re: [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-05T21:59:22Z","receivedAt":"2014-05-05T21:59:22Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"On 6 May 2014 07:49:30 GMT+10:00, Jeff King wrote:\n>On Tue, May 06, 2014 at 07:41:29AM +1000, James Denholm wrote:\n>\n>> >I do not think BSD-ism matters for \"rm\", as it works pretty much the\n>> >same everywhere. \"install\", on the other hand, is a bit weirder\n>between\n>> >systems. So you might want to leave that comment as-is.\n>> \n>> True. I might just buff that out when sending the patch to Junio,\n>unless\n>> protocol dictates otherwise - a reroll for a single comment line\n>seems\n>> a bit excessive to me at the moment.\n>\n>I don't think it is that big a deal either way.\n>\n>It's fine to tweak when you send re-roll the final for Junio. Sometimes\n>for trivial fixups like this, Junio can just tweak it as he applies,\n>but\n>I do not know if he is even paying attention to this thread, so you may\n>want to re-post anyway to get his attention.\n\nSure, sounds good and will do.\n\n>Either way, feel free to add my:\n>\n> Reviewed-by: Jeff King \n\nAwesome, thanks again.\n\nRegards,\nJames Denholm.\n"},{"id":"240769","messageId":"20140505220112.GA17610@sigill.intra.peff.net","threadId":"36575","inReplyTo":"69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com","subject":"Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-05-05T22:01:12Z","receivedAt":"2014-05-05T22:01:12Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"[fixed David's address in cc list]\n\nOn Tue, May 06, 2014 at 07:54:30AM +1000, James Denholm wrote:\n\n> Given that subtree subtree doesn't really generate a lot of discussion,\n> would it be advisable to wrap this up (barring further discussion) and send\n> it off to Junio rather than waiting for further community consensus?\n\nI do not know if \"lack of discussion\" is a good reason to consider\nsomething in good shape; oftentimes it is a sign that nobody is\ninterested in the area. We usually rely on \"area maintainers\" to give an\nOK to the patches if they are not something that the maintainer himself\nhas an interest in.\n\nHowever, in this case, you did get review, and I think it is pretty easy\nto see the patches are good even if one does not care about the\nparticular area. So I think they are fine to pass on and apply.\n\nNote also that patches like this are a great place to get started, as\nthey help build trust in a contributor, who can later help out with\narea maintenance.\n\n-Peff\n"},{"id":"240789","messageId":"CAHYYfeGmQX3tBYA=1r9YCe0sTzHZaEWtBRcLXsrLsMv9AXTMEA@mail.gmail.com","threadId":"36575","inReplyTo":"20140505220112.GA17610@sigill.intra.peff.net","subject":"Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass","fromName":"James Denholm","fromEmail":"nod.helm@gmail.com","sentAt":"2014-05-06T12:41:32Z","receivedAt":"2014-05-06T12:41:32Z","isPatch":true,"sender":{"key":"nod.helm@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1721189?v=4"},"body":"On 6 May 2014 08:01, Jeff King wrote:\n> [fixed David's address in cc list]\n\nAh, right. Wasn't sure what was going on there.\n\n> On Tue, May 06, 2014 at 07:54:30AM +1000, James Denholm wrote:\n>\n>> Given that subtree subtree doesn't really generate a lot of discussion,\n>> would it be advisable to wrap this up (barring further discussion) and send\n>> it off to Junio rather than waiting for further community consensus?\n>\n> I do not know if \"lack of discussion\" is a good reason to consider\n> something in good shape; oftentimes it is a sign that nobody is\n> interested in the area. We usually rely on \"area maintainers\" to give an\n> OK to the patches if they are not something that the maintainer himself\n> has an interest in.\n\nYeah, I certainly only meant that in the context of this particular\npatch, post-review.\n\n> However, in this case, you did get review, and I think it is pretty easy\n> to see the patches are good even if one does not care about the\n> particular area. So I think they are fine to pass on and apply.\n\nSounds good, I'll send it on up now. Thanks again for the help.\n\n> Note also that patches like this are a great place to get started, as\n> they help build trust in a contributor, who can later help out with\n> area maintenance.\n\nYeah, to be honest, beyond the immediate goal of getting subtree in more\ndistros, that is kinda the plan. A bit of a practical experience in\ncontributing to the project, learning the specific ropes and such\nbefore proposing more substantial discussion and fixes/changes.\n\n---\nRegards,\nJames Denholm.\n"}]}