{"thread":{"id":"36564","subject":"Zsh submodule name completion borked","startedAt":"2014-05-01T22:23:31Z","lastAt":"2014-05-02T16:23:02Z","messageCount":4,"participants":["Phil Hord","Jonathan Nieder","Felipe Contreras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"240479","messageId":"CABURp0oS0qnyVhfV1rsaNXT-88QJvgpNn+meApNKRTGdULDXpA@mail.gmail.com","threadId":"36564","inReplyTo":null,"subject":"Zsh submodule name completion borked","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2014-05-01T22:23:31Z","receivedAt":"2014-05-01T22:23:31Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"When I use zsh tab-completion to complete the submodule name in 'git\nsubmodule init', I get more than I expected.\n\n>From the gerrit repository (which has plugins):\n $ git submodule init plugins/\n plugins/commit-message-length-validator\\ \\(v1.0-rc1-9-g545000b\\)\n plugins/reviewnotes\\ \\(v1.0-rc1-8-ge984300\\)\n plugins/replication\\ \\(v1.1-rc0-13-g4c3f4c9\\)\n\nIt works ok in bash. I tried to bisect the trouble, but it still\nfails in 1.8.3, so I'm beginning to think it's me. Does this happen\nto anyone else? Is it something in my local configuration causing\nthis?\n\nThanks,\nPhil\n"},{"id":"240480","messageId":"20140501223121.GD9218@google.com","threadId":"36564","inReplyTo":"CABURp0oS0qnyVhfV1rsaNXT-88QJvgpNn+meApNKRTGdULDXpA@mail.gmail.com","subject":"Re: Zsh submodule name completion borked","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-05-01T22:31:21Z","receivedAt":"2014-05-01T22:31:21Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nPhil Hord wrote:\n\n> When I use zsh tab-completion to complete the submodule name in 'git\n> submodule init', I get more than I expected.\n\nIs this using zsh's native tab-completion (i.e., not the tab\ncompletion bundled with git)? There might have been a change there.\n\nAnother place to look for hints would be ~/.gitconfig.\n\nHope that helps,\nJonathan\n"},{"id":"240481","messageId":"5362cc42ed06d_569a13852ecb@nysa.notmuch","threadId":"36564","inReplyTo":"CABURp0oS0qnyVhfV1rsaNXT-88QJvgpNn+meApNKRTGdULDXpA@mail.gmail.com","subject":"RE: Zsh submodule name completion borked","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2014-05-01T22:35:46Z","receivedAt":"2014-05-01T22:35:46Z","isPatch":false,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Phil Hord wrote:\n> When I use zsh tab-completion to complete the submodule name in 'git\n> submodule init', I get more than I expected.\n> \n> From the gerrit repository (which has plugins):\n> $ git submodule init plugins/\n> plugins/commit-message-length-validator\\ \\(v1.0-rc1-9-g545000b\\)\n> plugins/reviewnotes\\ \\(v1.0-rc1-8-ge984300\\)\n> plugins/replication\\ \\(v1.1-rc0-13-g4c3f4c9\\)\n> \n> It works ok in bash. I tried to bisect the trouble, but it still\n> fails in 1.8.3, so I'm beginning to think it's me. Does this happen\n> to anyone else? Is it something in my local configuration causing\n> this?\n\nDefine 'works' in bash. From what I can see from the bash completion,\nit's not doing anything special, so the completion you see are simply\nfiles.\n\n-- \nFelipe Contreras\n"},{"id":"240533","messageId":"CABURp0qdd6LYVfF0g8BWo_xjK36LbS=EnXkF_Kb4XQPM8U9r_g@mail.gmail.com","threadId":"36564","inReplyTo":"5362cc42ed06d_569a13852ecb@nysa.notmuch","subject":"Re: Zsh submodule name completion borked","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2014-05-02T16:23:02Z","receivedAt":"2014-05-02T16:23:02Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"On Thu, May 1, 2014 at 6:35 PM, Felipe Contreras\n wrote:\n> Phil Hord wrote:\n>> When I use zsh tab-completion to complete the submodule name in 'git\n>> submodule init', I get more than I expected.\n>>\n>> From the gerrit repository (which has plugins):\n>> $ git submodule init plugins/\n>> plugins/commit-message-length-validator\\ \\(v1.0-rc1-9-g545000b\\)\n>> plugins/reviewnotes\\ \\(v1.0-rc1-8-ge984300\\)\n>> plugins/replication\\ \\(v1.1-rc0-13-g4c3f4c9\\)\n>>\n>> It works ok in bash. I tried to bisect the trouble, but it still\n>> fails in 1.8.3, so I'm beginning to think it's me. Does this happen\n>> to anyone else? Is it something in my local configuration causing\n>> this?\n>\n\nIt seems to be something local. I thought the issue persisted with no\nlocal .zshrc config, but it looks like I only turned off my local\nconfig and not the global settings. The recent Ubuntu update is a\nlikely culprit. I'll investigate locally and turn my reports up to\nUbuntu/Debian/Zshell.\n\n> Define 'works' in bash. From what I can see from the bash completion,\n> it's not doing anything special, so the completion you see are simply\n> files.\n\nTo clarify my description in case anyone else sees it or is\ninterested, before I load /etc/zsh/zshrc, tab gives me simple filename\nexpansion.\n\nAfter I load /etc/zsh/zshrc, tab expands only submodules in HEAD. But\nfor some reason it gets the wrong kind of results in the expansion,\nreturning not just submodule paths, but submodule paths with tag info\nappended.\n\nSample session:\n $ zsh --norcs\n % git submodule init plugins/\n commit-message-length-validator/\n README\n reviewnotes/\n replication/\n ^C\n % source /etc/zsh/zshrc\n % git submodule init plugins/\n plugins/commit-message-length-validator\\ \\(v1.0-rc1-9-g545000b\\)\n plugins/reviewnotes\\ \\(v1.0-rc1-8-ge984300\\)\n plugins/replication\\ \\(v1.1-rc0-13-g4c3f4c9\\)\n"}]}