{"thread":{"id":"36554","subject":"[PATCH 03/14] t4006-diff-mode.sh: use the $( ... ) construct for command substitution","startedAt":"2014-04-30T16:22:54Z","lastAt":"2014-04-30T18:07:17Z","messageCount":16,"participants":["Elia Pinto","Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"240328","messageId":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":null,"subject":"[PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:22:54Z","receivedAt":"2014-04-30T16:22:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3905-stash-include-untracked.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3905-stash-include-untracked.sh b/t/t3905-stash-include-untracked.sh\nindex a5e7e6b..f372fc8 100755\n--- a/t/t3905-stash-include-untracked.sh\n+++ b/t/t3905-stash-include-untracked.sh\n@@ -96,8 +96,8 @@ test_expect_success 'stash pop after save --include-untracked leaves files untra\n \tgit stash pop &&\n \tgit status --porcelain >actual &&\n \ttest_cmp expect actual &&\n-\ttest \"1\" = \"`cat file2`\" &&\n-\ttest untracked = \"`cat untracked/untracked`\"\n+\ttest \"1\" = \"$(cat file2)\" &&\n+\ttest untracked = \"$(cat untracked/untracked)\"\n '\n \n git clean --force --quiet -d\n-- \n1.7.10.4\n"},{"id":"240331","messageId":"1398874987-14873-2-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/14] t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:22:55Z","receivedAt":"2014-04-30T16:22:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t3910-mac-os-precompose.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t3910-mac-os-precompose.sh b/t/t3910-mac-os-precompose.sh\nindex e4ba601..96941e9 100755\n--- a/t/t3910-mac-os-precompose.sh\n+++ b/t/t3910-mac-os-precompose.sh\n@@ -14,13 +14,13 @@ then\n fi\n \n # create utf-8 variables\n-Adiarnfc=`printf '\\303\\204'`\n-Adiarnfd=`printf 'A\\314\\210'`\n+Adiarnfc=$(printf '\\303\\204')\n+Adiarnfd=$(printf 'A\\314\\210')\n \n-Odiarnfc=`printf '\\303\\226'`\n-Odiarnfd=`printf 'O\\314\\210'`\n-AEligatu=`printf '\\303\\206'`\n-Invalidu=`printf '\\303\\377'`\n+Odiarnfc=$(printf '\\303\\226')\n+Odiarnfd=$(printf 'O\\314\\210')\n+AEligatu=$(printf '\\303\\206')\n+Invalidu=$(printf '\\303\\377')\n \n \n #Create a string with 255 bytes (decomposed)\n@@ -35,7 +35,7 @@ Alongc=$Alongc$Alongc$Alongc$Alongc$Alongc #250 Byte\n Alongc=$Alongc$AEligatu$AEligatu #254 Byte\n \n test_expect_success \"detect if nfd needed\" '\n-\tprecomposeunicode=`git config core.precomposeunicode` &&\n+\tprecomposeunicode=$(git config core.precomposeunicode) &&\n \ttest \"$precomposeunicode\" = true &&\n \tgit config core.precomposeunicode true\n '\n@@ -146,7 +146,7 @@ test_expect_success \"respect git config --global core.precomposeunicode\" '\n \tgit config --global core.precomposeunicode true &&\n \trm -rf .git &&\n \tgit init &&\n-\tprecomposeunicode=`git config core.precomposeunicode` &&\n+\tprecomposeunicode=$(git config core.precomposeunicode) &&\n \ttest \"$precomposeunicode\" = \"true\"\n '\n \n-- \n1.7.10.4\n"},{"id":"240318","messageId":"1398874987-14873-3-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/14] t4006-diff-mode.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:22:56Z","receivedAt":"2014-04-30T16:22:56Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4006-diff-mode.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4006-diff-mode.sh b/t/t4006-diff-mode.sh\nindex 0591149..76f643b 100755\n--- a/t/t4006-diff-mode.sh\n+++ b/t/t4006-diff-mode.sh\n@@ -13,7 +13,7 @@ sed_script='s/\\(:100644 100755\\) \\('\"$_x40\"'\\) \\2 /\\1 X X /'\n test_expect_success 'setup' '\n \techo frotz >rezrov &&\n \tgit update-index --add rezrov &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo $tree\n '\n \n-- \n1.7.10.4\n"},{"id":"240325","messageId":"1398874987-14873-4-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/14] t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:22:57Z","receivedAt":"2014-04-30T16:22:57Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4010-diff-pathspec.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh\nindex 2bb9736..bf07841 100755\n--- a/t/t4010-diff-pathspec.sh\n+++ b/t/t4010-diff-pathspec.sh\n@@ -18,7 +18,7 @@ test_expect_success \\\n mkdir path1 &&\n echo rezrov >path1/file1 &&\n git update-index --add file0 path1/file1 &&\n- tree=`git write-tree` &&\n+ tree=$(git write-tree) &&\n echo \"$tree\" &&\n echo nitfol >file0 &&\n echo yomin >path1/file1 &&\n@@ -131,7 +131,7 @@ test_expect_success 'diff multiple wildcard pathspecs' '\n \tmkdir path2 &&\n \techo rezrov >path2/file1 &&\n \tgit update-index --add path2/file1 &&\n-\ttree3=`git write-tree` &&\n+\ttree3=$(git write-tree) &&\n \tgit diff --name-only $tree $tree3 -- \"path2*1\" \"path1*1\" >actual &&\n \tcat <<-\\EOF >expect &&\n \tpath1/file1\n-- \n1.7.10.4\n"},{"id":"240319","messageId":"1398874987-14873-5-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/14] t4012-diff-binary.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:22:58Z","receivedAt":"2014-04-30T16:22:58Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4012-diff-binary.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\nindex 1215ae5..643d729 100755\n--- a/t/t4012-diff-binary.sh\n+++ b/t/t4012-diff-binary.sh\n@@ -67,18 +67,18 @@ test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '\n \tgit diff >output &&\n \tsed -e \"s/-CIT/xCIT/\" broken &&\n \ttest_must_fail git apply --stat --summary broken 2>detected &&\n-\tdetected=`cat detected` &&\n-\tdetected=`expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\"` &&\n-\tdetected=`sed -ne \"${detected}p\" broken` &&\n+\tdetected=$(cat detected) &&\n+\tdetected=$(expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\") &&\n+\tdetected=$(sed -ne \"${detected}p\" broken) &&\n \ttest \"$detected\" = xCIT\n '\n \n test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '\n \tgit diff --binary | sed -e \"s/-CIT/xCIT/\" >broken &&\n \ttest_must_fail git apply --stat --summary broken 2>detected &&\n-\tdetected=`cat detected` &&\n-\tdetected=`expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\"` &&\n-\tdetected=`sed -ne \"${detected}p\" broken` &&\n+\tdetected=$(cat detected) &&\n+\tdetected=$(expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\") &&\n+\tdetected=$(sed -ne \"${detected}p\" broken) &&\n \ttest \"$detected\" = xCIT\n '\n \n@@ -88,7 +88,7 @@ test_expect_success 'initial commit' 'git commit -a -m initial'\n test_expect_success 'diff-index with --binary' '\n \techo AIT >a && mv b e && echo CIT >c && cat e >d &&\n \tgit update-index --add --remove a b c d e &&\n-\ttree0=`git write-tree` &&\n+\ttree0=$(git write-tree) &&\n \tgit diff --cached --binary >current &&\n \tgit apply --stat --summary current\n '\n@@ -96,7 +96,7 @@ test_expect_success 'diff-index with --binary' '\n test_expect_success 'apply binary patch' '\n \tgit reset --hard &&\n \tgit apply --binary --index \n---\n t/t4013-diff-various.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh\nindex e77c09c..805b055 100755\n--- a/t/t4013-diff-various.sh\n+++ b/t/t4013-diff-various.sh\n@@ -107,14 +107,14 @@ test_expect_success setup '\n +*++ [initial] Initial\n EOF\n \n-V=`git version | sed -e 's/^git version //' -e 's/\\./\\\\./g'`\n+V=$(git version | sed -e 's/^git version //' -e 's/\\./\\\\./g')\n while read cmd\n do\n \tcase \"$cmd\" in\n \t'' | '#'*) continue ;;\n \tesac\n-\ttest=`echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g'`\n-\tpfx=`printf \"%04d\" $test_count`\n+\ttest=$(echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g')\n+\tpfx=$(printf \"%04d\" $test_count)\n \texpect=\"$TEST_DIRECTORY/t4013/diff.$test\"\n \tactual=\"$pfx-diff.$test\"\n \n-- \n1.7.10.4\n"},{"id":"240320","messageId":"1398874987-14873-7-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/14] t4014-format-patch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:00Z","receivedAt":"2014-04-30T16:23:00Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4014-format-patch.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex 9c80633..282bee4 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -43,7 +43,7 @@ test_expect_success setup '\n test_expect_success \"format-patch --ignore-if-in-upstream\" '\n \n \tgit format-patch --stdout master..side >patch0 &&\n-\tcnt=`grep \"^From \" patch0 | wc -l` &&\n+\tcnt=$(grep \"^From \" patch0 | wc -l) &&\n \ttest $cnt = 3\n \n '\n@@ -52,7 +52,7 @@ test_expect_success \"format-patch --ignore-if-in-upstream\" '\n \n \tgit format-patch --stdout \\\n \t\t--ignore-if-in-upstream master..side >patch1 &&\n-\tcnt=`grep \"^From \" patch1 | wc -l` &&\n+\tcnt=$(grep \"^From \" patch1 | wc -l) &&\n \ttest $cnt = 2\n \n '\n@@ -69,7 +69,7 @@ test_expect_success \"format-patch doesn't consider merge commits\" '\n \tgit checkout -b merger master &&\n \ttest_tick &&\n \tgit merge --no-ff slave &&\n-\tcnt=`git format-patch -3 --stdout | grep \"^From \" | wc -l` &&\n+\tcnt=$(git format-patch -3 --stdout | grep \"^From \" | wc -l) &&\n \ttest $cnt = 3\n '\n \n@@ -77,7 +77,7 @@ test_expect_success \"format-patch result applies\" '\n \n \tgit checkout -b rebuild-0 master &&\n \tgit am -3 patch0 &&\n-\tcnt=`git rev-list master.. | wc -l` &&\n+\tcnt=$(git rev-list master.. | wc -l) &&\n \ttest $cnt = 2\n '\n \n@@ -85,7 +85,7 @@ test_expect_success \"format-patch --ignore-if-in-upstream result applies\" '\n \n \tgit checkout -b rebuild-1 master &&\n \tgit am -3 patch1 &&\n-\tcnt=`git rev-list master.. | wc -l` &&\n+\tcnt=$(git rev-list master.. | wc -l) &&\n \ttest $cnt = 2\n '\n \n-- \n1.7.10.4\n"},{"id":"240330","messageId":"1398874987-14873-8-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/14] t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:01Z","receivedAt":"2014-04-30T16:23:01Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4036-format-patch-signer-mime.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4036-format-patch-signer-mime.sh b/t/t4036-format-patch-signer-mime.sh\nindex ba43f18..98d9713 100755\n--- a/t/t4036-format-patch-signer-mime.sh\n+++ b/t/t4036-format-patch-signer-mime.sh\n@@ -42,7 +42,7 @@ test_expect_success 'attach and signoff do not duplicate mime headers' '\n \n \tGIT_COMMITTER_NAME=\"はまの ふにおう\" \\\n \tgit format-patch -s --stdout -1 --attach >output &&\n-\ttest `grep -ci ^MIME-Version: output` = 1\n+\ttest $(grep -ci ^MIME-Version: output) = 1\n \n '\n \n-- \n1.7.10.4\n"},{"id":"240329","messageId":"1398874987-14873-9-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/14] t4038-diff-combined.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:02Z","receivedAt":"2014-04-30T16:23:02Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4038-diff-combined.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh\nindex 1019d7b..41913c3 100755\n--- a/t/t4038-diff-combined.sh\n+++ b/t/t4038-diff-combined.sh\n@@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' '\n \tblob=$(echo file | git hash-object --stdin -w) &&\n \tbase_tree=$(echo \"100644 blob $blob\tfile\" | git mktree) &&\n \ttrees= &&\n-\tfor i in `test_seq 1 40`\n+\tfor i in $(test_seq 1 40)\n \tdo\n \t\tblob=$(echo file$i | git hash-object --stdin -w) &&\n \t\ttrees=\"$trees$(echo \"100644 blob $blob\tfile\" | git mktree)$LF\"\n-- \n1.7.10.4\n"},{"id":"240327","messageId":"1398874987-14873-10-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/14] t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:03Z","receivedAt":"2014-04-30T16:23:03Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4057-diff-combined-paths.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-paths.sh\nindex 097e632..dff36b7 100755\n--- a/t/t4057-diff-combined-paths.sh\n+++ b/t/t4057-diff-combined-paths.sh\n@@ -5,7 +5,7 @@ test_description='combined diff show only paths that are different to all parent\n . ./test-lib.sh\n \n # verify that diffc.expect matches output of\n-# `git diff -c --name-only HEAD HEAD^ HEAD^2`\n+# $(git diff -c --name-only HEAD HEAD^ HEAD^2)\n diffc_verify () {\n \tgit diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual &&\n \ttest_cmp diffc.expect diffc.actual\n-- \n1.7.10.4\n"},{"id":"240323","messageId":"1398874987-14873-11-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 11/14] t4116-apply-reverse.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:04Z","receivedAt":"2014-04-30T16:23:04Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4116-apply-reverse.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4116-apply-reverse.sh b/t/t4116-apply-reverse.sh\nindex 1e4d438..ce8567f 100755\n--- a/t/t4116-apply-reverse.sh\n+++ b/t/t4116-apply-reverse.sh\n@@ -30,10 +30,10 @@ test_expect_success setup '\n \n test_expect_success 'apply in forward' '\n \n-\tT0=`git rev-parse \"second^{tree}\"` &&\n+\tT0=$(git rev-parse \"second^{tree}\") &&\n \tgit reset --hard initial &&\n \tgit apply --index --binary patch &&\n-\tT1=`git write-tree` &&\n+\tT1=$(git write-tree) &&\n \ttest \"$T0\" = \"$T1\"\n '\n \n@@ -62,22 +62,22 @@ test_expect_success 'setup separate repository lacking postimage' '\n \n test_expect_success 'apply in forward without postimage' '\n \n-\tT0=`git rev-parse \"second^{tree}\"` &&\n+\tT0=$(git rev-parse \"second^{tree}\") &&\n \t(\n \t\tcd initial &&\n \t\tgit apply --index --binary ../patch &&\n-\t\tT1=`git write-tree` &&\n+\t\tT1=$(git write-tree) &&\n \t\ttest \"$T0\" = \"$T1\"\n \t)\n '\n \n test_expect_success 'apply in reverse without postimage' '\n \n-\tT0=`git rev-parse \"initial^{tree}\"` &&\n+\tT0=$(git rev-parse \"initial^{tree}\") &&\n \t(\n \t\tcd second &&\n \t\tgit apply --index --binary --reverse ../patch &&\n-\t\tT1=`git write-tree` &&\n+\t\tT1=$(git write-tree) &&\n \t\ttest \"$T0\" = \"$T1\"\n \t)\n '\n-- \n1.7.10.4\n"},{"id":"240322","messageId":"1398874987-14873-12-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 12/14] t4119-apply-config.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:05Z","receivedAt":"2014-04-30T16:23:05Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4119-apply-config.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4119-apply-config.sh b/t/t4119-apply-config.sh\nindex 3d0384d..c393be6 100755\n--- a/t/t4119-apply-config.sh\n+++ b/t/t4119-apply-config.sh\n@@ -68,7 +68,7 @@ test_expect_success 'apply --whitespace=strip from config' '\n \tcheck_result sub/file1\n '\n \n-D=`pwd`\n+D=$(pwd)\n \n test_expect_success 'apply --whitespace=strip in subdir' '\n \n-- \n1.7.10.4\n"},{"id":"240324","messageId":"1398874987-14873-13-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 13/14] t4204-patch-id.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:06Z","receivedAt":"2014-04-30T16:23:06Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t4204-patch-id.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4204-patch-id.sh b/t/t4204-patch-id.sh\nindex d2c930d..7940f6f 100755\n--- a/t/t4204-patch-id.sh\n+++ b/t/t4204-patch-id.sh\n@@ -45,8 +45,8 @@ test_expect_success 'patch-id supports git-format-patch output' '\n \tgit checkout same &&\n \tgit format-patch -1 --stdout | calc_patch_id same &&\n \ttest_cmp patch-id_master patch-id_same &&\n-\tset `git format-patch -1 --stdout | git patch-id` &&\n-\ttest \"$2\" = `git rev-parse HEAD`\n+\tset $(git format-patch -1 --stdout | git patch-id) &&\n+\ttest \"$2\" = $(git rev-parse HEAD)\n '\n \n test_expect_success 'whitespace is irrelevant in footer' '\n-- \n1.7.10.4\n"},{"id":"240321","messageId":"1398874987-14873-14-git-send-email-gitter.spiros@gmail.com","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 14/14] t5000-tar-tree.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-30T16:23:07Z","receivedAt":"2014-04-30T16:23:07Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t5000-tar-tree.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex 1cf0a4e..74fc5a8 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -123,7 +123,7 @@ test_expect_success \\\n 'add files to repository' \\\n 'find a -type f | xargs git update-index --add &&\n find a -type l | xargs git update-index --add &&\n- treeid=`git write-tree` &&\n+ treeid=$(git write-tree) &&\n echo $treeid >treeid &&\n git update-ref HEAD $(TZ=GMT GIT_COMMITTER_DATE=\"2005-05-27 22:00:00\" \\\n git commit-tree $treeid remote.tar &&\n \ttest_must_fail git archive --remote=. $sha1 >remote.tar\n@@ -215,7 +215,7 @@ test_expect_success 'clients cannot access unreachable commits' '\n \n test_expect_success 'upload-archive can allow unreachable commits' '\n \ttest_commit unreachable1 &&\n-\tsha1=`git rev-parse HEAD` &&\n+\tsha1=$(git rev-parse HEAD) &&\n \tgit reset --hard HEAD^ &&\n \tgit archive $sha1 >remote.tar &&\n \ttest_config uploadarchive.allowUnreachable true &&\n-- \n1.7.10.4\n"},{"id":"240332","messageId":"vpq4n1alqf2.fsf@anie.imag.fr","threadId":"36554","inReplyTo":"1398874987-14873-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-04-30T16:42:41Z","receivedAt":"2014-04-30T16:42:41Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Patches 1/14 are\n\nReviewed-by: Matthieu Moy \n\nOn a side note, reviewing patches by batches of 14 patches actually\nturns out to be much less convenient for me than reviewing larger\nbatches.\n\nIf I'm counting correctly, there should be around 100 patches remaining.\nI'd suggest that the next batch contain them all (probably publishing\nthe branch somewhere and posting a merge request here would be better to\navoid sending 100 mails).\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"240342","messageId":"xmqqiopqg08a.fsf@gitster.dls.corp.google.com","threadId":"36554","inReplyTo":"vpq4n1alqf2.fsf@anie.imag.fr","subject":"Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-30T18:07:17Z","receivedAt":"2014-04-30T18:07:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Patches 1/14 are\n>\n> Reviewed-by: Matthieu Moy \n>\n> On a side note, reviewing patches by batches of 14 patches actually\n> turns out to be much less convenient for me than reviewing larger\n> batches.\n>\n> If I'm counting correctly, there should be around 100 patches remaining.\n> I'd suggest that the next batch contain them all (probably publishing\n> the branch somewhere and posting a merge request here would be better to\n> avoid sending 100 mails).\n\nI eyeballed these 28 patches so far (but not this round yet) and\neach of the batches did fit my attention span for a series while\nlooking at other topics also in flight. Tastes and preferences\ndiffer between us, I guess.\n\nI however can, and am very inclined to, trust your review blindly\nand apply further patches on this topic with your Reviewed-by:\nwithout even looking at the patches myself. If \"give us the whole\"\nis more convenient for you, I am perfectly happy with that approach.\n\nThanks for reviewing.\n"}]}