{"thread":{"id":"36543","subject":"[PATCH 0/3] Trivial cleanups","startedAt":"2014-04-29T21:49:35Z","lastAt":"2014-04-29T21:49:38Z","messageCount":4,"participants":["Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"240211","messageId":"1398808178-3703-1-git-send-email-felipe.contreras@gmail.com","threadId":"36543","inReplyTo":null,"subject":"[PATCH 0/3] Trivial cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2014-04-29T21:49:35Z","receivedAt":"2014-04-29T21:49:35Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Felipe Contreras (3):\n  config: avoid yoda conditions\n  add: avoid yoda condition\n  add: remove dead code\n\n builtin/add.c | 6 +-----\n config.c      | 4 ++--\n 2 files changed, 3 insertions(+), 7 deletions(-)\n\n-- \n1.9.2+fc1.3.gade8541\n"},{"id":"240212","messageId":"1398808178-3703-2-git-send-email-felipe.contreras@gmail.com","threadId":"36543","inReplyTo":"1398808178-3703-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 1/3] config: avoid yoda conditions","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2014-04-29T21:49:36Z","receivedAt":"2014-04-29T21:49:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n config.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/config.c b/config.c\nindex a30cb5c..bd69ad7 100644\n--- a/config.c\n+++ b/config.c\n@@ -616,7 +616,7 @@ static int git_config_maybe_bool_text(const char *name, const char *value)\n int git_config_maybe_bool(const char *name, const char *value)\n {\n \tint v = git_config_maybe_bool_text(name, value);\n-\tif (0 <= v)\n+\tif (v >= 0)\n \t\treturn v;\n \tif (git_parse_int(value, &v))\n \t\treturn !!v;\n@@ -626,7 +626,7 @@ int git_config_maybe_bool(const char *name, const char *value)\n int git_config_bool_or_int(const char *name, const char *value, int *is_bool)\n {\n \tint v = git_config_maybe_bool_text(name, value);\n-\tif (0 <= v) {\n+\tif (v >= 0) {\n \t\t*is_bool = 1;\n \t\treturn v;\n \t}\n-- \n1.9.2+fc1.3.gade8541\n"},{"id":"240213","messageId":"1398808178-3703-3-git-send-email-felipe.contreras@gmail.com","threadId":"36543","inReplyTo":"1398808178-3703-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 2/3] add: avoid yoda condition","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2014-04-29T21:49:37Z","receivedAt":"2014-04-29T21:49:37Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"18 is younger than person's age.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n builtin/add.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/add.c b/builtin/add.c\nindex 459208a..ac10bab 100644\n--- a/builtin/add.c\n+++ b/builtin/add.c\n@@ -321,7 +321,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)\n \targc--;\n \targv++;\n \n-\tif (0 <= addremove_explicit)\n+\tif (addremove_explicit >= 0)\n \t\taddremove = addremove_explicit;\n \telse if (take_worktree_changes && ADDREMOVE_DEFAULT)\n \t\taddremove = 0; /* \"-u\" was given but not \"-A\" */\n-- \n1.9.2+fc1.3.gade8541\n"},{"id":"240214","messageId":"1398808178-3703-4-git-send-email-felipe.contreras@gmail.com","threadId":"36543","inReplyTo":"1398808178-3703-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 3/3] add: remove dead code","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2014-04-29T21:49:38Z","receivedAt":"2014-04-29T21:49:38Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"addremove is already 1 by default.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n builtin/add.c | 4 ----\n 1 file changed, 4 deletions(-)\n\ndiff --git a/builtin/add.c b/builtin/add.c\nindex ac10bab..980e247 100644\n--- a/builtin/add.c\n+++ b/builtin/add.c\n@@ -329,10 +329,6 @@ int cmd_add(int argc, const char **argv, const char *prefix)\n \tif (addremove && take_worktree_changes)\n \t\tdie(_(\"-A and -u are mutually incompatible\"));\n \n-\tif (!take_worktree_changes && addremove_explicit < 0 && argc)\n-\t\t/* Turn \"git add pathspec...\" to \"git add -A pathspec...\" */\n-\t\taddremove = 1;\n-\n \tif (!show_only && ignore_missing)\n \t\tdie(_(\"Option --ignore-missing can only be used together with --dry-run\"));\n \n-- \n1.9.2+fc1.3.gade8541\n"}]}