{"thread":{"id":"36538","subject":"[PATCH] MSVC: link dynamically to the CRT","startedAt":"2014-04-29T10:25:09Z","lastAt":"2014-05-03T06:30:02Z","messageCount":6,"participants":["Stepan Kasal","Junio C Hamano","Sebastian Schuberth","Marat Radchenko"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"240155","messageId":"20140429102509.GA16706@camelia.ucw.cz","threadId":"36538","inReplyTo":null,"subject":"[PATCH] MSVC: link dynamically to the CRT","fromName":"Stepan Kasal","fromEmail":"kasal@ucw.cz","sentAt":"2014-04-29T10:25:09Z","receivedAt":"2014-04-29T10:25:09Z","isPatch":true,"sender":{"key":"kasal@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/1481596?v=4"},"body":"From: Karsten Blees \nDate: Fri, 7 Jan 2011 17:20:21 +0100\n\nDynamic linking is generally preferred over static linking, and MSVCRT.dll\nhas been integral part of Windows for a long time.\n\nThis also fixes linker warnings for _malloc and _free in zlib.lib, which\nseems to be compiled for MSVCRT.dll already.\n\nThe DLL version also exports some of the CRT initialization functions,\nwhich are hidden in the static libcmt.lib (e.g. __wgetmainargs, required by\nsubsequent Unicode patches).\n\nSigned-off-by: Karsten Blees \nSigned-off-by: Stepan Kasal \n---\n\nAnother patch from msysgit.\nCheers,\n Stepan\n\n config.mak.uname | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex efaed94..eebc847 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -365,16 +365,16 @@ ifeq ($(uname_S),Windows)\n \t\tcompat/win32/pthread.o compat/win32/syslog.o \\\n \t\tcompat/win32/dirent.o\n \tCOMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DNOGDI -DHAVE_STRING_H -DHAVE_ALLOCA_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\\\".exe\\\"\n-\tBASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE -NODEFAULTLIB:MSVCRT.lib\n+\tBASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE\n \tEXTLIBS = user32.lib advapi32.lib shell32.lib wininet.lib ws2_32.lib\n \tPTHREAD_LIBS =\n \tlib =\n ifndef DEBUG\n-\tBASIC_CFLAGS += -GL -Os -MT\n+\tBASIC_CFLAGS += -GL -Os -MD\n \tBASIC_LDFLAGS += -LTCG\n \tAR += -LTCG\n else\n-\tBASIC_CFLAGS += -Zi -MTd\n+\tBASIC_CFLAGS += -Zi -MDd\n endif\n \tX = .exe\n endif\n-- \n1.9.2.msysgit.0.158.g6070cee\n"},{"id":"240346","messageId":"xmqqa9b2fyve.fsf@gitster.dls.corp.google.com","threadId":"36538","inReplyTo":"20140429102509.GA16706@camelia.ucw.cz","subject":"Re: [PATCH] MSVC: link dynamically to the CRT","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-30T18:36:37Z","receivedAt":"2014-04-30T18:36:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stepan Kasal writes:\n\n> From: Karsten Blees \n> Date: Fri, 7 Jan 2011 17:20:21 +0100\n>\n> Dynamic linking is generally preferred over static linking, and MSVCRT.dll\n> has been integral part of Windows for a long time.\n>\n> This also fixes linker warnings for _malloc and _free in zlib.lib, which\n> seems to be compiled for MSVCRT.dll already.\n>\n> The DLL version also exports some of the CRT initialization functions,\n> which are hidden in the static libcmt.lib (e.g. __wgetmainargs, required by\n> subsequent Unicode patches).\n>\n> Signed-off-by: Karsten Blees \n> Signed-off-by: Stepan Kasal \n> ---\n>\n> Another patch from msysgit.\n> Cheers,\n> Stepan\n\nThanks.\n\nI am not intimate with the msysgit developer community, and I do not\nknow if it is appropriate for me to respond with a\n\n\tDoes this look OK with msysgit folks?\n\ncc'ed to the usual suspects (Erik Faye-Lund, Dscho and J6t). Just\nlike I do not have to ask \"does this look ok?\" question when seeing\na patch from Erik or J6t, is it unnecessary for me to do so for a\npatch from you?\n\n> config.mak.uname | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index efaed94..eebc847 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -365,16 +365,16 @@ ifeq ($(uname_S),Windows)\n> \t\tcompat/win32/pthread.o compat/win32/syslog.o \\\n> \t\tcompat/win32/dirent.o\n> \tCOMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DNOGDI -DHAVE_STRING_H -DHAVE_ALLOCA_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\\\".exe\\\"\n> -\tBASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE -NODEFAULTLIB:MSVCRT.lib\n> +\tBASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE\n> \tEXTLIBS = user32.lib advapi32.lib shell32.lib wininet.lib ws2_32.lib\n> \tPTHREAD_LIBS =\n> \tlib =\n> ifndef DEBUG\n> -\tBASIC_CFLAGS += -GL -Os -MT\n> +\tBASIC_CFLAGS += -GL -Os -MD\n> \tBASIC_LDFLAGS += -LTCG\n> \tAR += -LTCG\n> else\n> -\tBASIC_CFLAGS += -Zi -MTd\n> +\tBASIC_CFLAGS += -Zi -MDd\n> endif\n> \tX = .exe\n> endif\n"},{"id":"240353","messageId":"536150E8.20809@gmail.com","threadId":"36538","inReplyTo":"xmqqa9b2fyve.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] MSVC: link dynamically to the CRT","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2014-04-30T19:37:12Z","receivedAt":"2014-04-30T19:37:12Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On 30.04.2014 20:36, Junio C Hamano wrote:\n\n> I am not intimate with the msysgit developer community, and I do not\n> know if it is appropriate for me to respond with a\n>\n> \tDoes this look OK with msysgit folks?\n\nThis patch has been carried in the msysgit tree since more than 3 years, \nalthough strictly speaking it does not affect the msysgit build but only \nthe MSVC build. Stefan is just bringing Karsten's patch upstream with \nthis patch.\n\nSo yes, this is fine.\n\n> cc'ed to the usual suspects (Erik Faye-Lund, Dscho and J6t). Just\n> like I do not have to ask \"does this look ok?\" question when seeing\n> a patch from Erik or J6t, is it unnecessary for me to do so for a\n> patch from you?\n\nI'm putting Marat in CC who has been recently active in building Git \nwith MSVC.\n\n-- \nSebastian Schuberth\n"},{"id":"240359","messageId":"xmqqha5aegpk.fsf@gitster.dls.corp.google.com","threadId":"36538","inReplyTo":"536150E8.20809@gmail.com","subject":"Re: [PATCH] MSVC: link dynamically to the CRT","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-30T19:54:15Z","receivedAt":"2014-04-30T19:54:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sebastian Schuberth writes:\n\n> On 30.04.2014 20:36, Junio C Hamano wrote:\n>\n>> I am not intimate with the msysgit developer community, and I do not\n>> know if it is appropriate for me to respond with a\n>>\n>> \tDoes this look OK with msysgit folks?\n>\n> This patch has been carried in the msysgit tree since more than 3\n> years, although strictly speaking it does not affect the msysgit build\n> but only the MSVC build. Stefan is just bringing Karsten's patch\n> upstream with this patch.\n>\n> So yes, this is fine.\n>\n>> cc'ed to the usual suspects (Erik Faye-Lund, Dscho and J6t). Just\n>> like I do not have to ask \"does this look ok?\" question when seeing\n>> a patch from Erik or J6t, is it unnecessary for me to do so for a\n>> patch from you?\n>\n> I'm putting Marat in CC who has been recently active in building Git\n> with MSVC.\n\nThanks, very much appreciated.\n"},{"id":"240364","messageId":"20140430201733.GB21870@camelia.ucw.cz","threadId":"36538","inReplyTo":"xmqqa9b2fyve.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] MSVC: link dynamically to the CRT","fromName":"Stepan Kasal","fromEmail":"kasal@ucw.cz","sentAt":"2014-04-30T20:17:33Z","receivedAt":"2014-04-30T20:17:33Z","isPatch":true,"sender":{"key":"kasal@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/1481596?v=4"},"body":"Hello Junio,\n\nOn Wed, Apr 30, 2014 at 11:36:37AM -0700, Junio C Hamano wrote:\n> like I do not have to ask \"does this look ok?\" question when seeing\n> a patch from Erik or J6t, is it unnecessary for me to do so for a\n> patch from you?\n\nit _is_ necessary to ask, as I'm just a newcomer who has (fortunately)\nalmost no experience with Windows.\n\nBut I will try to point out iif it \"has been in msysgit for x years\".\nThat fact can be taken as an implicite ack from msysgit community.\n\nStepan\n"},{"id":"240610","messageId":"20140503063001.GA8433@seldon","threadId":"36538","inReplyTo":"xmqqha5aegpk.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] MSVC: link dynamically to the CRT","fromName":"Marat Radchenko","fromEmail":"marat@slonopotamus.org","sentAt":"2014-05-03T06:30:02Z","receivedAt":"2014-05-03T06:30:02Z","isPatch":true,"sender":{"key":"marat@slonopotamus.org","avatar":"https://avatars.githubusercontent.com/u/92637?v=4"},"body":"On Wed, Apr 30, 2014 at 12:54:15PM -0700, Junio C Hamano wrote:\n> Sebastian Schuberth writes:\n> \n> > On 30.04.2014 20:36, Junio C Hamano wrote:\n> >\n> >> I am not intimate with the msysgit developer community, and I do not\n> >> know if it is appropriate for me to respond with a\n> >>\n> >> \tDoes this look OK with msysgit folks?\n> >\n> > This patch has been carried in the msysgit tree since more than 3\n> > years, although strictly speaking it does not affect the msysgit build\n> > but only the MSVC build. Stefan is just bringing Karsten's patch\n> > upstream with this patch.\n> >\n> > So yes, this is fine.\n> >\n> >> cc'ed to the usual suspects (Erik Faye-Lund, Dscho and J6t). Just\n> >> like I do not have to ask \"does this look ok?\" question when seeing\n> >> a patch from Erik or J6t, is it unnecessary for me to do so for a\n> >> patch from you?\n> >\n> > I'm putting Marat in CC who has been recently active in building Git\n> > with MSVC.\n> \n> Thanks, very much appreciated.\n\nAck from me, sorry for delay.\n"}]}