{"thread":{"id":"36523","subject":"[PATCH/RFC] Makefile: do not depend on curl-config","startedAt":"2014-04-28T16:29:05Z","lastAt":"2014-05-05T15:03:27Z","messageCount":10,"participants":["Erik Faye-Lund","Junio C Hamano","'Dave Borowitz' via msysGit","Johannes Schindelin","Sebastian Schuberth","Thomas Braun"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"239972","messageId":"1398702545-9860-1-git-send-email-kusmabite@gmail.com","threadId":"36523","inReplyTo":null,"subject":"[PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T16:29:05Z","receivedAt":"2014-04-28T16:29:05Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"MinGW builds of cURL does not ship with curl-config unless built\nwith the autoconf based build system, which is not the practice\nrecommended by the documentation. MsysGit has had issues with\nbinaries of that sort, so it has switched away from autoconf-based\ncURL-builds.\n\nUnfortunately, broke pushing over WebDAV on Windows, because\nhttp-push.c depends on cURL's multi-threaded API, which we could\nnot determine the presence of any more.\n\nSince troublesome curl-versions are ancient, and not even present\nin RedHat 5, let's just assume cURL is capable instead of doing a\nnon-robust check.\n\nInstead, add a check for curl_multi_init to our configure-script,\nfor those on ancient system. They probably already need to do the\nconfigure-dance anyway.\n\nSigned-off-by: Erik Faye-Lund \n---\n\nOK, here's a proper patch. I've even tested it! ;)\n\n\n Makefile | 8 +++-----\n configure.ac | 11 +++++++++++\n 2 files changed, 14 insertions(+), 5 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex e90f57e..f6b5847 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1133,13 +1133,11 @@ else\n \tREMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n \tPROGRAM_OBJS += http-fetch.o\n \tPROGRAMS += $(REMOTE_CURL_NAMES)\n-\tcurl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)\n-\tifeq \"$(curl_check)\" \"070908\"\n-\t\tifndef NO_EXPAT\n+\tifndef NO_EXPAT\n+\t\tifndef NO_CURL_MULTI\n \t\t\tPROGRAM_OBJS += http-push.o\n \t\tendif\n-\tendif\n-\tifndef NO_EXPAT\n+\n \t\tifdef EXPATDIR\n \t\t\tBASIC_CFLAGS += -I$(EXPATDIR)/include\n \t\t\tEXPAT_LIBEXPAT = -L$(EXPATDIR)/$(lib) $(CC_LD_DYNPATH)$(EXPATDIR)/$(lib) -lexpat\ndiff --git a/configure.ac b/configure.ac\nindex 2f43393..e7ef9f7 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -513,6 +513,17 @@ AC_CHECK_LIB([curl], [curl_global_init],\n [NO_CURL=],\n [NO_CURL=YesPlease])\n \n+if test -z \"$NO_CURL\"; then\n+\n+AC_CHECK_DECLS([curl_multi_init],\n+[NO_CURL_MULTI=],\n+[NO_CURL_MULTI=UnfortunatelyYes],\n+[[#include ]])\n+\n+GIT_CONF_SUBST([NO_CURL_MULTI])\n+\n+fi\n+\n GIT_UNSTASH_FLAGS($CURLDIR)\n \n GIT_CONF_SUBST([NO_CURL])\n-- \n1.9.2.msysgit.2\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240302","messageId":"CABPQNSbvoYfUp6ZG8kMPPX5rcDetUCqunOGO2cX-yhPsGkCOTg@mail.gmail.com","threadId":"36523","inReplyTo":"1398702545-9860-1-git-send-email-kusmabite@gmail.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-30T13:08:14Z","receivedAt":"2014-04-30T13:08:14Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 6:29 PM, Erik Faye-Lund wrote:\n> MinGW builds of cURL does not ship with curl-config unless built\n> with the autoconf based build system, which is not the practice\n> recommended by the documentation. MsysGit has had issues with\n> binaries of that sort, so it has switched away from autoconf-based\n> cURL-builds.\n>\n> Unfortunately, broke pushing over WebDAV on Windows, because\n> http-push.c depends on cURL's multi-threaded API, which we could\n> not determine the presence of any more.\n>\n> Since troublesome curl-versions are ancient, and not even present\n> in RedHat 5, let's just assume cURL is capable instead of doing a\n> non-robust check.\n>\n> Instead, add a check for curl_multi_init to our configure-script,\n> for those on ancient system. They probably already need to do the\n> configure-dance anyway.\n>\n> Signed-off-by: Erik Faye-Lund \n\nJunio,\n\nthis patch still applies, and is required on Git for Windows for\nhttp-push to work, even after f3f11fa (\"Makefile: default to -lcurl\nwhen no CURL_CONFIG or CURLDIR\").\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240311","messageId":"xmqqfvkuhm77.fsf@gitster.dls.corp.google.com","threadId":"36523","inReplyTo":"1398702545-9860-1-git-send-email-kusmabite@gmail.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-30T15:27:24Z","receivedAt":"2014-04-30T15:27:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Erik Faye-Lund writes:\n\n> MinGW builds of cURL does not ship with curl-config unless built\n> with the autoconf based build system, which is not the practice\n> recommended by the documentation. MsysGit has had issues with\n> binaries of that sort, so it has switched away from autoconf-based\n> cURL-builds.\n>\n> Unfortunately, broke pushing over WebDAV on Windows, because\n> http-push.c depends on cURL's multi-threaded API, which we could\n> not determine the presence of any more.\n>\n> Since troublesome curl-versions are ancient, and not even present\n> in RedHat 5, let's just assume cURL is capable instead of doing a\n> non-robust check.\n>\n> Instead, add a check for curl_multi_init to our configure-script,\n> for those on ancient system. They probably already need to do the\n> configure-dance anyway.\n>\n> Signed-off-by: Erik Faye-Lund \n> ---\n>\n> OK, here's a proper patch. I've even tested it! ;)\n>\n>\n> Makefile | 8 +++-----\n> configure.ac | 11 +++++++++++\n> 2 files changed, 14 insertions(+), 5 deletions(-)\n>\n> diff --git a/Makefile b/Makefile\n> index e90f57e..f6b5847 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1133,13 +1133,11 @@ else\n> \tREMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n> \tPROGRAM_OBJS += http-fetch.o\n> \tPROGRAMS += $(REMOTE_CURL_NAMES)\n> -\tcurl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)\n> -\tifeq \"$(curl_check)\" \"070908\"\n> -\t\tifndef NO_EXPAT\n> +\tifndef NO_EXPAT\n> +\t\tifndef NO_CURL_MULTI\n> \t\t\tPROGRAM_OBJS += http-push.o\n> \t\tendif\n\nDave's \"ask curl-config about proper compilation options if\navailable\" and this change does *not* semantically conflict, as the\nformer should stress \"if available\" part (but note that the key word\nis \"should\").\n\nHow old/battle tested is this change? My inclination at this point\nis to revert the merge of Dave's series from 2.0 (yes, I know we\nhave been looking at fixing it and I _think_ the issue of unpleasant\nerror message you reported can be fixed, but at this rate we would\nnot know if we eradicated all the issues for platforms and distros\nwith confidence by the final), kick it back to 'next'/'pu', and\nqueue this change also in 'next'/'pu' and cook them so that we can\nmerge them early in the 2.1 cycle.\n\nThis new makefile variable needs a comment at the top, no?\n\n Makefile | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/Makefile b/Makefile\nindex f7d33da..3164b62 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -34,6 +34,10 @@ all::\n # git-http-push are not built, and you cannot use http:// and https://\n # transports (neither smart nor dumb).\n #\n+# Define NO_CURL_MULTI if your libcurl is sufficiently old and lacks\n+# curl_multi_init (\"git http-push\" to run the deprecated dumb push over\n+# http/webdab will not be built).\n+#\n # Define CURL_CONFIG to the path to a curl-config binary other than the\n # default 'curl-config'. If CURL_CONFIG is unset or points to a binary that\n # is not found, defaults to the CURLDIR behavior.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240312","messageId":"CAD0k6qRcv9M+kvmma1YZaM9Oam33wW0Sk8xuCET8R-9U+R9Tpg@mail.gmail.com","threadId":"36523","inReplyTo":"xmqqfvkuhm77.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"'Dave Borowitz' via msysGit","fromEmail":"msysgit@googlegroups.com","sentAt":"2014-04-30T15:29:30Z","receivedAt":"2014-04-30T15:29:30Z","isPatch":true,"sender":{"key":"name:'Dave Borowitz'","avatar":null},"body":"On Wed, Apr 30, 2014 at 8:27 AM, Junio C Hamano wrote:\n> How old/battle tested is this change? My inclination at this point\n> is to revert the merge of Dave's series from 2.0 (yes, I know we\n> have been looking at fixing it and I _think_ the issue of unpleasant\n> error message you reported can be fixed, but at this rate we would\n> not know if we eradicated all the issues for platforms and distros\n> with confidence by the final), kick it back to 'next'/'pu', and\n> queue this change also in 'next'/'pu' and cook them so that we can\n> merge them early in the 2.1 cycle.\n\nThis is fine by me FWIW.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240315","messageId":"CABPQNSZUCPd=1Eu8VUCP01tkdYkBC=xspFZuDuywuYZUH8ewvw@mail.gmail.com","threadId":"36523","inReplyTo":"xmqqfvkuhm77.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-30T15:53:29Z","receivedAt":"2014-04-30T15:53:29Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Wed, Apr 30, 2014 at 5:27 PM, Junio C Hamano wrote:\n> Erik Faye-Lund writes:\n>\n>> MinGW builds of cURL does not ship with curl-config unless built\n>> with the autoconf based build system, which is not the practice\n>> recommended by the documentation. MsysGit has had issues with\n>> binaries of that sort, so it has switched away from autoconf-based\n>> cURL-builds.\n>>\n>> Unfortunately, broke pushing over WebDAV on Windows, because\n>> http-push.c depends on cURL's multi-threaded API, which we could\n>> not determine the presence of any more.\n>>\n>> Since troublesome curl-versions are ancient, and not even present\n>> in RedHat 5, let's just assume cURL is capable instead of doing a\n>> non-robust check.\n>>\n>> Instead, add a check for curl_multi_init to our configure-script,\n>> for those on ancient system. They probably already need to do the\n>> configure-dance anyway.\n>>\n>> Signed-off-by: Erik Faye-Lund \n>> ---\n>>\n>> OK, here's a proper patch. I've even tested it! ;)\n>>\n>>\n>> Makefile | 8 +++-----\n>> configure.ac | 11 +++++++++++\n>> 2 files changed, 14 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/Makefile b/Makefile\n>> index e90f57e..f6b5847 100644\n>> --- a/Makefile\n>> +++ b/Makefile\n>> @@ -1133,13 +1133,11 @@ else\n>> REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n>> PROGRAM_OBJS += http-fetch.o\n>> PROGRAMS += $(REMOTE_CURL_NAMES)\n>> - curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null | sort -r | sed -ne 2p)\n>> - ifeq \"$(curl_check)\" \"070908\"\n>> - ifndef NO_EXPAT\n>> + ifndef NO_EXPAT\n>> + ifndef NO_CURL_MULTI\n>> PROGRAM_OBJS += http-push.o\n>> endif\n>\n> Dave's \"ask curl-config about proper compilation options if\n> available\" and this change does *not* semantically conflict, as the\n> former should stress \"if available\" part (but note that the key word\n> is \"should\").\n>\n> How old/battle tested is this change?\n\nNot very. I've successfully tested it on two systems, msysGit and RedHat 5.\n\n> My inclination at this point\n> is to revert the merge of Dave's series from 2.0 (yes, I know we\n> have been looking at fixing it and I _think_ the issue of unpleasant\n> error message you reported can be fixed, but at this rate we would\n> not know if we eradicated all the issues for platforms and distros\n> with confidence by the final), kick it back to 'next'/'pu', and\n> queue this change also in 'next'/'pu' and cook them so that we can\n> merge them early in the 2.1 cycle.\n\nSounds like a sensible plan to me. We can keep this patch in the\nmsysGit repo for the 2.0 release.\n\n> This new makefile variable needs a comment at the top, no?\n>\n> Makefile | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/Makefile b/Makefile\n> index f7d33da..3164b62 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -34,6 +34,10 @@ all::\n> # git-http-push are not built, and you cannot use http:// and https://\n> # transports (neither smart nor dumb).\n> #\n> +# Define NO_CURL_MULTI if your libcurl is sufficiently old and lacks\n> +# curl_multi_init (\"git http-push\" to run the deprecated dumb push over\n> +# http/webdab will not be built).\n> +#\n> # Define CURL_CONFIG to the path to a curl-config binary other than the\n> # default 'curl-config'. If CURL_CONFIG is unset or points to a binary that\n> # is not found, defaults to the CURLDIR behavior.\n\nAh yes. Sorry for missing that. Perhaps the text should even mention\nthe old break-off version, that is curl > v7.9.8 as far as I can\ntell...?\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240334","messageId":"alpine.DEB.1.00.1404301851210.14982@s15462909.onlinehome-server.info","threadId":"36523","inReplyTo":"CABPQNSZUCPd=1Eu8VUCP01tkdYkBC=xspFZuDuywuYZUH8ewvw@mail.gmail.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2014-04-30T16:52:38Z","receivedAt":"2014-04-30T16:52:38Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi kusma,\n\nOn Wed, 30 Apr 2014, Erik Faye-Lund wrote:\n\n> We can keep this patch in the msysGit repo for the 2.0 release.\n\nFWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is\nnot quite clear as of yet how patches will be managed with said\nenvironment.\n\nCiao,\nJohannes\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240355","messageId":"CAHGBnuPrQzSAVRZCneHdodAAQjA4dkGk0AguNm3xhW+cQ4XESQ@mail.gmail.com","threadId":"36523","inReplyTo":"alpine.DEB.1.00.1404301851210.14982@s15462909.onlinehome-server.info","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2014-04-30T19:46:38Z","receivedAt":"2014-04-30T19:46:38Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Wed, Apr 30, 2014 at 6:52 PM, Johannes Schindelin\n wrote:\n\n>> We can keep this patch in the msysGit repo for the 2.0 release.\n>\n> FWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is\n> not quite clear as of yet how patches will be managed with said\n> environment.\n\nThe environment is just that: The environment to build Git for\nWindows. This means that patches on top of Git for Windows could still\nbe maintained in msysgit/git (or a fork thereof) on GitHub.\n\n-- \nSebastian Schuberth\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240753","messageId":"CABPQNSb83H7EEeAfaxC7KVpZmv-KEqE1wavTf53kA=aoDQz4Tw@mail.gmail.com","threadId":"36523","inReplyTo":"CAHGBnuPrQzSAVRZCneHdodAAQjA4dkGk0AguNm3xhW+cQ4XESQ@mail.gmail.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-05-05T10:53:48Z","receivedAt":"2014-05-05T10:53:48Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Wed, Apr 30, 2014 at 9:46 PM, Sebastian Schuberth\n wrote:\n> On Wed, Apr 30, 2014 at 6:52 PM, Johannes Schindelin\n> wrote:\n>\n>>> We can keep this patch in the msysGit repo for the 2.0 release.\n>>\n>> FWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is\n>> not quite clear as of yet how patches will be managed with said\n>> environment.\n>\n> The environment is just that: The environment to build Git for\n> Windows. This means that patches on top of Git for Windows could still\n> be maintained in msysgit/git (or a fork thereof) on GitHub.\n\nThanks for the heads up. Even so, are you guys OK with me pushing this\npatch to our downstream repo?\n"},{"id":"240747","messageId":"CAHGBnuMTc8MuUd9_BtqkemJ--_fxmRroc0pym78hDF=Jc7KPLw@mail.gmail.com","threadId":"36523","inReplyTo":"CABPQNSb83H7EEeAfaxC7KVpZmv-KEqE1wavTf53kA=aoDQz4Tw@mail.gmail.com","subject":"Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2014-05-05T10:56:20Z","receivedAt":"2014-05-05T10:56:20Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On Mon, May 5, 2014 at 12:53 PM, Erik Faye-Lund wrote:\n\n>>> FWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is\n>>> not quite clear as of yet how patches will be managed with said\n>>> environment.\n>>\n>> The environment is just that: The environment to build Git for\n>> Windows. This means that patches on top of Git for Windows could still\n>> be maintained in msysgit/git (or a fork thereof) on GitHub.\n>\n> Thanks for the heads up. Even so, are you guys OK with me pushing this\n> patch to our downstream repo?\n\nFine with me.\n\n-- \nSebastian Schuberth\n"},{"id":"240741","messageId":"5367A83F.5010606@virtuell-zuhause.de","threadId":"36523","inReplyTo":"CABPQNSb83H7EEeAfaxC7KVpZmv-KEqE1wavTf53kA=aoDQz4Tw@mail.gmail.com","subject":"Re: [msysGit] Re: [PATCH/RFC] Makefile: do not depend on curl-config","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2014-05-05T15:03:27Z","receivedAt":"2014-05-05T15:03:27Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Am 05.05.2014 12:53, schrieb Erik Faye-Lund:\n> On Wed, Apr 30, 2014 at 9:46 PM, Sebastian Schuberth\n> wrote:\n>> On Wed, Apr 30, 2014 at 6:52 PM, Johannes Schindelin\n>> wrote:\n>>\n>>>> We can keep this patch in the msysGit repo for the 2.0 release.\n>>>\n>>> FWIW the plan is to switch to mingwGitDevEnv for the 2.0 release. It is\n>>> not quite clear as of yet how patches will be managed with said\n>>> environment.\n>>\n>> The environment is just that: The environment to build Git for\n>> Windows. This means that patches on top of Git for Windows could still\n>> be maintained in msysgit/git (or a fork thereof) on GitHub.\n> \n> Thanks for the heads up. Even so, are you guys OK with me pushing this\n> patch to our downstream repo?\n\nYes!\n"}]}