{"thread":{"id":"36519","subject":"[PATCH 02/14] t0010-racy-git.sh: use the $( ... ) construct for command substitution","startedAt":"2014-04-28T12:57:24Z","lastAt":"2014-04-28T13:56:53Z","messageCount":15,"participants":["Elia Pinto","Matthieu Moy"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"239906","messageId":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":null,"subject":"[PATCH 01/14] t0001-init.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:24Z","receivedAt":"2014-04-28T12:57:24Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0001-init.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex bbc9cb6..2f30203 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -185,14 +185,14 @@ test_expect_success 'init --bare/--shared overrides system/global config' '\n \tgit init --bare --shared=0666 init-bare-shared-override &&\n \tcheck_config init-bare-shared-override true unset &&\n \ttest x0666 = \\\n-\tx`git config -f init-bare-shared-override/config core.sharedRepository`\n+\tx$(git config -f init-bare-shared-override/config core.sharedRepository)\n '\n \n test_expect_success 'init honors global core.sharedRepository' '\n \ttest_config_global core.sharedRepository 0666 &&\n \tgit init shared-honor-global &&\n \ttest x0666 = \\\n-\tx`git config -f shared-honor-global/.git/config core.sharedRepository`\n+\tx$(git config -f shared-honor-global/.git/config core.sharedRepository)\n '\n \n test_expect_success 'init rejects insanely long --template' '\n@@ -285,7 +285,7 @@ test_expect_success 'init prefers command line to GIT_DIR' '\n test_expect_success 'init with separate gitdir' '\n \trm -rf newdir &&\n \tgit init --separate-git-dir realgitdir newdir &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest_path_is_dir realgitdir/refs\n '\n@@ -299,7 +299,7 @@ test_expect_success 're-init to update git link' '\n \tcd newdir &&\n \tgit init --separate-git-dir ../surrealgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/surrealgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/surrealgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest_path_is_dir surrealgitdir/refs &&\n \ttest_path_is_missing realgitdir/refs\n@@ -312,7 +312,7 @@ test_expect_success 're-init to move gitdir' '\n \tcd newdir &&\n \tgit init --separate-git-dir ../realgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest_path_is_dir realgitdir/refs\n '\n@@ -326,7 +326,7 @@ test_expect_success SYMLINKS 're-init to move gitdir symlink' '\n \tln -s here .git &&\n \tgit init --separate-git-dir ../realgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest_cmp expected newdir/here &&\n \ttest_path_is_dir realgitdir/refs\n-- \n1.7.10.4\n"},{"id":"239905","messageId":"1398689857-17014-2-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/14] t0010-racy-git.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:25Z","receivedAt":"2014-04-28T12:57:25Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0010-racy-git.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh\nindex e45a9e4..5657c5a 100755\n--- a/t/t0010-racy-git.sh\n+++ b/t/t0010-racy-git.sh\n@@ -14,7 +14,7 @@ do\n \tgit update-index --add infocom\n \techo xyzzy >infocom\n \n-\tfiles=`git diff-files -p`\n+\tfiles=$(git diff-files -p)\n \ttest_expect_success \\\n \t\"Racy GIT trial #$trial part A\" \\\n \t'test \"\" != \"$files\"'\n@@ -23,7 +23,7 @@ do\n \techo xyzzy >cornerstone\n \tgit update-index --add cornerstone\n \n-\tfiles=`git diff-files -p`\n+\tfiles=$(git diff-files -p)\n \ttest_expect_success \\\n \t\"Racy GIT trial #$trial part B\" \\\n \t'test \"\" != \"$files\"'\n-- \n1.7.10.4\n"},{"id":"239907","messageId":"1398689857-17014-3-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/14] t0020-crlf.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:26Z","receivedAt":"2014-04-28T12:57:26Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0020-crlf.sh | 42 +++++++++++++++++++++---------------------\n 1 file changed, 21 insertions(+), 21 deletions(-)\n\ndiff --git a/t/t0020-crlf.sh b/t/t0020-crlf.sh\nindex e526184..d2e51a8 100755\n--- a/t/t0020-crlf.sh\n+++ b/t/t0020-crlf.sh\n@@ -20,14 +20,14 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\tdir=`git rev-parse HEAD:dir` &&\n-\ttwo=`git rev-parse HEAD:dir/two` &&\n-\tthree=`git rev-parse HEAD:three` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\tdir=$(git rev-parse HEAD:dir) &&\n+\ttwo=$(git rev-parse HEAD:dir/two) &&\n+\tthree=$(git rev-parse HEAD:three) &&\n \n \tfor w in Some extra lines here; do echo $w; done >>one &&\n \tgit diff >patch.file &&\n-\tpatched=`git hash-object --stdin \n---\n t/t0025-crlf-auto.sh | 38 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)\n\ndiff --git a/t/t0025-crlf-auto.sh b/t/t0025-crlf-auto.sh\nindex f5f67a6..b0e5694 100755\n--- a/t/t0025-crlf-auto.sh\n+++ b/t/t0025-crlf-auto.sh\n@@ -19,9 +19,9 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\ttwo=`git rev-parse HEAD:two` &&\n-\tthree=`git rev-parse HEAD:three` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\ttwo=$(git rev-parse HEAD:two) &&\n+\tthree=$(git rev-parse HEAD:three) &&\n \n \techo happy.\n '\n@@ -33,9 +33,9 @@ test_expect_success 'default settings cause no changes' '\n \n \t! has_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -48,7 +48,7 @@ test_expect_success 'crlf=true causes a CRLF file to be normalized' '\n \n \t# Note, \"normalized\" means that git will normalize it if added\n \thas_cr two &&\n-\ttwodiff=`git diff two` &&\n+\ttwodiff=$(git diff two) &&\n \ttest -n \"$twodiff\"\n '\n \n@@ -60,7 +60,7 @@ test_expect_success 'text=true causes a CRLF file to be normalized' '\n \n \t# Note, \"normalized\" means that git will normalize it if added\n \thas_cr two &&\n-\ttwodiff=`git diff two` &&\n+\ttwodiff=$(git diff two) &&\n \ttest -n \"$twodiff\"\n '\n \n@@ -72,7 +72,7 @@ test_expect_success 'eol=crlf gives a normalized file CRLFs with autocrlf=false'\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -84,7 +84,7 @@ test_expect_success 'eol=crlf gives a normalized file CRLFs with autocrlf=input'\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -96,7 +96,7 @@ test_expect_success 'eol=lf gives a normalized file LFs with autocrlf=true' '\n \tgit read-tree --reset -u HEAD &&\n \n \t! has_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -108,9 +108,9 @@ test_expect_success 'autocrlf=true does not normalize CRLF files' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -123,9 +123,9 @@ test_expect_success 'text=auto, autocrlf=true _does_ normalize CRLF files' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -n \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -137,7 +137,7 @@ test_expect_success 'text=auto, autocrlf=true does not normalize binary files' '\n \tgit read-tree --reset -u HEAD &&\n \n \t! has_cr three &&\n-\tthreediff=`git diff three` &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$threediff\"\n '\n \n@@ -148,7 +148,7 @@ test_expect_success 'eol=crlf _does_ normalize binary files' '\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr three &&\n-\tthreediff=`git diff three` &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$threediff\"\n '\n \n-- \n1.7.10.4\n"},{"id":"239915","messageId":"1398689857-17014-5-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/14] t0026-eol-config.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:28Z","receivedAt":"2014-04-28T12:57:28Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0026-eol-config.sh | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh\nindex fe0164b..e1126aa 100755\n--- a/t/t0026-eol-config.sh\n+++ b/t/t0026-eol-config.sh\n@@ -20,8 +20,8 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\ttwo=`git rev-parse HEAD:two` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\ttwo=$(git rev-parse HEAD:two) &&\n \n \techo happy.\n '\n@@ -34,8 +34,8 @@ test_expect_success 'eol=lf puts LFs in normalized file' '\n \n \t! has_cr one &&\n \t! has_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -47,8 +47,8 @@ test_expect_success 'eol=crlf puts CRLFs in normalized file' '\n \n \thas_cr one &&\n \t! has_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -61,8 +61,8 @@ test_expect_success 'autocrlf=true overrides eol=lf' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -75,8 +75,8 @@ test_expect_success 'autocrlf=true overrides unset eol' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n-- \n1.7.10.4\n"},{"id":"239917","messageId":"1398689857-17014-6-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/14] t0030-stripspace.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:29Z","receivedAt":"2014-04-28T12:57:29Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0030-stripspace.sh | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh\nindex a8e84d8..0333dd9 100755\n--- a/t/t0030-stripspace.sh\n+++ b/t/t0030-stripspace.sh\n@@ -225,22 +225,22 @@ test_expect_success \\\n \n test_expect_success \\\n 'text without newline at end should end with newline' '\n- test `printf \"$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt$ttt\" | git stripspace | wc -l` -gt 0\n+ test $(printf \"$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt$ttt\" | git stripspace | wc -l) -gt 0\n '\n \n # text plus spaces at the end:\n \n test_expect_success \\\n 'text plus spaces without newline at end should end with newline' '\n- test `printf \"$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$sss$sss$sss\" | git stripspace | wc -l` -gt 0\n+ test $(printf \"$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$sss$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$sss$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$sss$sss$sss\" | git stripspace | wc -l) -gt 0\n '\n \n test_expect_success \\\n-- \n1.7.10.4\n"},{"id":"239918","messageId":"1398689857-17014-7-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/14] t0300-credentials.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:30Z","receivedAt":"2014-04-28T12:57:30Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t0300-credentials.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh\nindex 538ea5f..57ea5a1 100755\n--- a/t/t0300-credentials.sh\n+++ b/t/t0300-credentials.sh\n@@ -6,7 +6,7 @@ test_description='basic credential helper tests'\n \n test_expect_success 'setup helper scripts' '\n \tcat >dump <<-\\EOF &&\n-\twhoami=`echo $0 | sed s/.*git-credential-//`\n+\twhoami=$(echo $0 | sed s/.*git-credential-//)\n \techo >&2 \"$whoami: $*\"\n \tOIFS=$IFS\n \tIFS==\n-- \n1.7.10.4\n"},{"id":"239916","messageId":"1398689857-17014-8-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/14] t1000-read-tree-m-3way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:31Z","receivedAt":"2014-04-28T12:57:31Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1000-read-tree-m-3way.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1000-read-tree-m-3way.sh b/t/t1000-read-tree-m-3way.sh\nindex babcdd2..a0b79b4 100755\n--- a/t/t1000-read-tree-m-3way.sh\n+++ b/t/t1000-read-tree-m-3way.sh\n@@ -519,10 +519,10 @@ test_expect_success \\\n 'rm -f .git/index F16 &&\n echo F16 >F16 &&\n git update-index --add F16 &&\n- tree0=`git write-tree` &&\n+ tree0=$(git write-tree) &&\n echo E16 >F16 &&\n git update-index F16 &&\n- tree1=`git write-tree` &&\n+ tree1=$(git write-tree) &&\n read_tree_must_succeed -m $tree0 $tree1 $tree1 $tree0 &&\n git ls-files --stage'\n \n-- \n1.7.10.4\n"},{"id":"239913","messageId":"1398689857-17014-9-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 09/14] t1001-read-tree-m-2way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:32Z","receivedAt":"2014-04-28T12:57:32Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1001-read-tree-m-2way.sh | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/t/t1001-read-tree-m-2way.sh b/t/t1001-read-tree-m-2way.sh\nindex 3a24abf..db1b6f5 100755\n--- a/t/t1001-read-tree-m-2way.sh\n+++ b/t/t1001-read-tree-m-2way.sh\n@@ -36,7 +36,7 @@ compare_change () {\n }\n \n check_cache_at () {\n-\tclean_if_empty=`git diff-files -- \"$1\"`\n+\tclean_if_empty=$(git diff-files -- \"$1\")\n \tcase \"$clean_if_empty\" in\n \t'') echo \"$1: clean\" ;;\n \t?*) echo \"$1: dirty\" ;;\n@@ -68,14 +68,14 @@ test_expect_success \\\n echo rezrov >rezrov &&\n echo yomin >yomin &&\n git update-index --add nitfol bozbar rezrov &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH &&\n \n cat bozbar-new >bozbar &&\n git update-index --add frotz bozbar --force-remove rezrov &&\n git ls-files --stage >M.out &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git diff-tree $treeH $treeM'\n@@ -315,7 +315,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n echo DF >DF &&\n git update-index --add DF &&\n- treeDF=`git write-tree` &&\n+ treeDF=$(git write-tree) &&\n echo treeDF $treeDF &&\n git ls-tree $treeDF &&\n \n@@ -323,7 +323,7 @@ test_expect_success \\\n mkdir DF &&\n echo DF/DF >DF/DF &&\n git update-index --add --remove DF DF/DF &&\n- treeDFDF=`git write-tree` &&\n+ treeDFDF=$(git write-tree) &&\n echo treeDFDF $treeDFDF &&\n git ls-tree $treeDFDF &&\n git ls-files --stage >DFDF.out'\n@@ -345,7 +345,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n : >a &&\n git update-index --add a &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git ls-files --stage >treeM.out &&\n@@ -354,7 +354,7 @@ test_expect_success \\\n git update-index --remove a &&\n mkdir a &&\n : >a/b &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH'\n \n@@ -372,7 +372,7 @@ test_expect_success \\\n mkdir c &&\n : >c/d &&\n git update-index --add a c/d &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git ls-files --stage >treeM.out &&\n@@ -381,7 +381,7 @@ test_expect_success \\\n mkdir a &&\n : >a/b &&\n git update-index --add --remove a a/b &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH'\n \n-- \n1.7.10.4\n"},{"id":"239908","messageId":"1398689857-17014-10-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/14] t1002-read-tree-m-u-2way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:33Z","receivedAt":"2014-04-28T12:57:33Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1002-read-tree-m-u-2way.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t1002-read-tree-m-u-2way.sh b/t/t1002-read-tree-m-u-2way.sh\nindex a847709..fed877b 100755\n--- a/t/t1002-read-tree-m-u-2way.sh\n+++ b/t/t1002-read-tree-m-u-2way.sh\n@@ -21,7 +21,7 @@ compare_change () {\n }\n \n check_cache_at () {\n-\tclean_if_empty=`git diff-files -- \"$1\"`\n+\tclean_if_empty=$(git diff-files -- \"$1\")\n \tcase \"$clean_if_empty\" in\n \t'') echo \"$1: clean\" ;;\n \t?*) echo \"$1: dirty\" ;;\n@@ -41,14 +41,14 @@ test_expect_success \\\n echo bozbar >bozbar &&\n echo rezrov >rezrov &&\n git update-index --add nitfol bozbar rezrov &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH &&\n \n echo gnusto >bozbar &&\n git update-index --add frotz bozbar --force-remove rezrov &&\n git ls-files --stage >M.out &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n sum bozbar frotz nitfol >M.sum &&\n@@ -318,7 +318,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n echo DF >DF &&\n git update-index --add DF &&\n- treeDF=`git write-tree` &&\n+ treeDF=$(git write-tree) &&\n echo treeDF $treeDF &&\n git ls-tree $treeDF &&\n \n@@ -326,7 +326,7 @@ test_expect_success \\\n mkdir DF &&\n echo DF/DF >DF/DF &&\n git update-index --add --remove DF DF/DF &&\n- treeDFDF=`git write-tree` &&\n+ treeDFDF=$(git write-tree) &&\n echo treeDFDF $treeDFDF &&\n git ls-tree $treeDFDF &&\n git ls-files --stage >DFDF.out'\n-- \n1.7.10.4\n"},{"id":"239911","messageId":"1398689857-17014-11-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 11/14] t1003-read-tree-prefix.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:34Z","receivedAt":"2014-04-28T12:57:34Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1003-read-tree-prefix.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1003-read-tree-prefix.sh b/t/t1003-read-tree-prefix.sh\nindex 8c6d67e..b6111cd 100755\n--- a/t/t1003-read-tree-prefix.sh\n+++ b/t/t1003-read-tree-prefix.sh\n@@ -11,7 +11,7 @@ test_description='git read-tree --prefix test.\n test_expect_success setup '\n \techo hello >one &&\n \tgit update-index --add one &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo tree is $tree\n '\n \n-- \n1.7.10.4\n"},{"id":"239914","messageId":"1398689857-17014-12-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 12/14] t1004-read-tree-m-u-wf.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:35Z","receivedAt":"2014-04-28T12:57:35Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1004-read-tree-m-u-wf.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1004-read-tree-m-u-wf.sh b/t/t1004-read-tree-m-u-wf.sh\nindex 3e72aff..c70cf42 100755\n--- a/t/t1004-read-tree-m-u-wf.sh\n+++ b/t/t1004-read-tree-m-u-wf.sh\n@@ -30,7 +30,7 @@ test_expect_success 'two-way not clobbering' '\n \n \techo >file2 master creates untracked file2 &&\n \techo >subdir/file2 master creates untracked subdir/file2 &&\n-\tif err=`read_tree_u_must_succeed -m -u master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -43,7 +43,7 @@ echo file2 >.gitignore\n \n test_expect_success 'two-way with incorrect --exclude-per-directory (1)' '\n \n-\tif err=`read_tree_u_must_succeed -m --exclude-per-directory=.gitignore master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m --exclude-per-directory=.gitignore master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -54,7 +54,7 @@ test_expect_success 'two-way with incorrect --exclude-per-directory (1)' '\n \n test_expect_success 'two-way with incorrect --exclude-per-directory (2)' '\n \n-\tif err=`read_tree_u_must_succeed -m -u --exclude-per-directory=foo --exclude-per-directory=.gitignore master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u --exclude-per-directory=foo --exclude-per-directory=.gitignore master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -95,7 +95,7 @@ test_expect_success 'three-way not clobbering a working tree file' '\n \tgit checkout master &&\n \techo >file3 file three created in master, untracked &&\n \techo >subdir/file3 file three created in master, untracked &&\n-\tif err=`read_tree_u_must_succeed -m -u branch-point master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u branch-point master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n-- \n1.7.10.4\n"},{"id":"239909","messageId":"1398689857-17014-13-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 13/14] t1020-subdirectory.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:36Z","receivedAt":"2014-04-28T12:57:36Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1020-subdirectory.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t1020-subdirectory.sh b/t/t1020-subdirectory.sh\nindex 6902320..62c0d25 100755\n--- a/t/t1020-subdirectory.sh\n+++ b/t/t1020-subdirectory.sh\n@@ -20,27 +20,27 @@ test_expect_success setup '\n \n test_expect_success 'update-index and ls-files' '\n \tgit update-index --add one &&\n-\tcase \"`git ls-files`\" in\n+\tcase \"$(git ls-files)\" in\n \tone) echo pass one ;;\n \t*) echo bad one; exit 1 ;;\n \tesac &&\n \t(\n \t\tcd dir &&\n \t\tgit update-index --add two &&\n-\t\tcase \"`git ls-files`\" in\n+\t\tcase \"$(git ls-files)\" in\n \t\ttwo) echo pass two ;;\n \t\t*) echo bad two; exit 1 ;;\n \t\tesac\n \t) &&\n-\tcase \"`git ls-files`\" in\n+\tcase \"$(git ls-files)\" in\n \tdir/two\"$LF\"one) echo pass both ;;\n \t*) echo bad; exit 1 ;;\n \tesac\n '\n \n test_expect_success 'cat-file' '\n-\ttwo=`git ls-files -s dir/two` &&\n-\ttwo=`expr \"$two\" : \"[0-7]* \\\\([0-9a-f]*\\\\)\"` &&\n+\ttwo=$(git ls-files -s dir/two) &&\n+\ttwo=$(expr \"$two\" : \"[0-7]* \\\\([0-9a-f]*\\\\)\") &&\n \techo \"$two\" &&\n \tgit cat-file -p \"$two\" >actual &&\n \tcmp dir/two actual &&\n@@ -55,18 +55,18 @@ rm -f actual dir/actual\n test_expect_success 'diff-files' '\n \techo a >>one &&\n \techo d >>dir/two &&\n-\tcase \"`git diff-files --name-only`\" in\n+\tcase \"$(git diff-files --name-only)\" in\n \tdir/two\"$LF\"one) echo pass top ;;\n \t*) echo bad top; exit 1 ;;\n \tesac &&\n \t# diff should not omit leading paths\n \t(\n \t\tcd dir &&\n-\t\tcase \"`git diff-files --name-only`\" in\n+\t\tcase \"$(git diff-files --name-only)\" in\n \t\tdir/two\"$LF\"one) echo pass subdir ;;\n \t\t*) echo bad subdir; exit 1 ;;\n \t\tesac &&\n-\t\tcase \"`git diff-files --name-only .`\" in\n+\t\tcase \"$(git diff-files --name-only .)\" in\n \t\tdir/two) echo pass subdir limited ;;\n \t\t*) echo bad subdir limited; exit 1 ;;\n \t\tesac\n@@ -74,11 +74,11 @@ test_expect_success 'diff-files' '\n '\n \n test_expect_success 'write-tree' '\n-\ttop=`git write-tree` &&\n+\ttop=$(git write-tree) &&\n \techo $top &&\n \t(\n \t\tcd dir &&\n-\t\tsub=`git write-tree` &&\n+\t\tsub=$(git write-tree) &&\n \t\techo $sub &&\n \t\ttest \"z$top\" = \"z$sub\"\n \t)\n@@ -96,7 +96,7 @@ test_expect_success 'checkout-index' '\n \n test_expect_success 'read-tree' '\n \trm -f one dir/two &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \tread_tree_u_must_succeed --reset -u \"$tree\" &&\n \tcmp one original.one &&\n \tcmp dir/two original.two &&\n-- \n1.7.10.4\n"},{"id":"239910","messageId":"1398689857-17014-14-git-send-email-gitter.spiros@gmail.com","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 14/14] t1050-large.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-28T12:57:37Z","receivedAt":"2014-04-28T12:57:37Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/t1050-large.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1050-large.sh b/t/t1050-large.sh\nindex fd10528..aea4936 100755\n--- a/t/t1050-large.sh\n+++ b/t/t1050-large.sh\n@@ -131,7 +131,7 @@ test_expect_success 'git-show a large file' '\n '\n \n test_expect_success 'index-pack' '\n-\tgit clone file://\"`pwd`\"/.git foo &&\n+\tgit clone file://\"$(pwd)\"/.git foo &&\n \tGIT_DIR=non-existent git index-pack --strict --verify foo/.git/objects/pack/*.pack\n '\n \n@@ -140,7 +140,7 @@ test_expect_success 'repack' '\n '\n \n test_expect_success 'pack-objects with large loose object' '\n-\tSHA1=`git hash-object huge` &&\n+\tSHA1=$(git hash-object huge) &&\n \ttest_create_repo loose &&\n \techo $SHA1 | git pack-objects --stdout |\n \t\tGIT_ALLOC_LIMIT=0 GIT_DIR=loose/.git git unpack-objects &&\n-- \n1.7.10.4\n"},{"id":"239934","messageId":"vpqbnvlk15m.fsf@anie.imag.fr","threadId":"36519","inReplyTo":"1398689857-17014-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 01/14] t0001-init.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-04-28T13:56:53Z","receivedAt":"2014-04-28T13:56:53Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Patches 1 to 14/14 are\n\nReviewed-by: Matthieu Moy \n\n(in mailer and then log -p --color-words)\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}