{"thread":{"id":"36512","subject":"git version 1.9.0 missing git-http-push?","startedAt":"2014-04-28T06:19:26Z","lastAt":"2014-04-28T19:42:49Z","messageCount":15,"participants":["Silvola Tuomas","Marat Radchenko","Erik Faye-Lund","Johannes Schindelin","Junio C Hamano","'Dave Borowitz <dborowitz@google.com>' via msysGit"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"239832","messageId":"DAB1109C3DA82E48A383F6960A32A9E567020669@EXCH2010.inferno.local","threadId":"36512","inReplyTo":null,"subject":"git version 1.9.0 missing git-http-push?","fromName":"Silvola Tuomas","fromEmail":"tuomas.silvola@knowit.fi","sentAt":"2014-04-28T06:19:26Z","receivedAt":"2014-04-28T06:19:26Z","isPatch":false,"sender":{"key":"tuomas.silvola@knowit.fi","avatar":null},"body":"Hello,\n\nI installed git for windows 1.9.0 but any push operation I tried with it produced an error message saying \"git: 'http-push' is not a git command\". Other commands like pull, add, and commit worked just fine.\nAt the end of this day I noticed that C:\\Program Files (x86)\\Git\\libexec\\git-core just didn't have the file git-http-push. There were git-http-backend, git-http-fetch and git-imap-send and such but no git-http-push.\n\nI resolved my issue by uninstalling 1.9.0, installing an older version instead (1.8.1.2; this is when push started working) and 1.9.0 right on top of the older version. Now git push command works as expected.\n\nBr,\nTuomas Silvola\n"},{"id":"239837","messageId":"1398670610456-7608792.post@n2.nabble.com","threadId":"36512","inReplyTo":"DAB1109C3DA82E48A383F6960A32A9E567020669@EXCH2010.inferno.local","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Marat Radchenko","fromEmail":"marat@slonopotamus.org","sentAt":"2014-04-28T07:36:50Z","receivedAt":"2014-04-28T07:36:50Z","isPatch":false,"sender":{"key":"marat@slonopotamus.org","avatar":"https://avatars.githubusercontent.com/u/92637?v=4"},"body":"Silvola Tuomas wrote\n> Hello,\n> \n> I installed git for windows 1.9.0 but any push operation I tried with it\n> produced an error message saying \"git: 'http-push' is not a git command\".\n> Other commands like pull, add, and commit worked just fine.\n> At the end of this day I noticed that C:\\Program Files\n> (x86)\\Git\\libexec\\git-core just didn't have the file git-http-push. There\n> were git-http-backend, git-http-fetch and git-imap-send and such but no\n> git-http-push.\n> \n> I resolved my issue by uninstalling 1.9.0, installing an older version\n> instead (1.8.1.2; this is when push started working) and 1.9.0 right on\n> top of the older version. Now git push command works as expected.\n> \n> Br,\n> Tuomas Silvola\n\n>From Makefile:\n\n\tcurl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null |\nsort -r | sed -ne 2p)\n\tifeq \"$(curl_check)\" \"070908\"\n\t\tifndef NO_EXPAT\n\t\t\tPROGRAM_OBJS += http-push.o\n\t\tendif\n\tendif\n\nif there's no curl-config, http-push.c is silently skipped. This check also\ndoesn't play with cross-compiling when you cannot call curl-config because\nit is for other arch.\n\nThere's also a mystic git-http-push$X that is not referenced from anywhere.\n\n\n\n--\nView this message in context: http://git.661346.n2.nabble.com/git-version-1-9-0-missing-git-http-push-tp7608787p7608792.html\nSent from the git mailing list archive at Nabble.com.\n"},{"id":"239843","messageId":"CABPQNSY-bM2pv7mn2R+wsnn944BkKbW6Hz2EhwrruPuxUJpUEQ@mail.gmail.com","threadId":"36512","inReplyTo":"1398670610456-7608792.post@n2.nabble.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T08:48:32Z","receivedAt":"2014-04-28T08:48:32Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 9:36 AM, Marat Radchenko <marat@slonopotamus.org> wrote:\n> Silvola Tuomas wrote\n>> Hello,\n>>\n>> I installed git for windows 1.9.0 but any push operation I tried with it\n>> produced an error message saying \"git: 'http-push' is not a git command\".\n>> Other commands like pull, add, and commit worked just fine.\n>> At the end of this day I noticed that C:\\Program Files\n>> (x86)\\Git\\libexec\\git-core just didn't have the file git-http-push. There\n>> were git-http-backend, git-http-fetch and git-imap-send and such but no\n>> git-http-push.\n>>\n>> I resolved my issue by uninstalling 1.9.0, installing an older version\n>> instead (1.8.1.2; this is when push started working) and 1.9.0 right on\n>> top of the older version. Now git push command works as expected.\n>>\n>> Br,\n>> Tuomas Silvola\n>\n> From Makefile:\n>\n>         curl_check := $(shell (echo 070908; curl-config --vernum) 2>/dev/null |\n> sort -r | sed -ne 2p)\n>         ifeq \"$(curl_check)\" \"070908\"\n>                 ifndef NO_EXPAT\n>                         PROGRAM_OBJS += http-push.o\n>                 endif\n>         endif\n>\n> if there's no curl-config, http-push.c is silently skipped. This check also\n> doesn't play with cross-compiling when you cannot call curl-config because\n> it is for other arch.\n>\n> There's also a mystic git-http-push$X that is not referenced from anywhere.\n\nWe're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so\nwe should be able to include it. However, we do not have curl-config\ninstalled.\n\nLooking at 08900987 (\"Decide whether to build http-push in the\nMakefile\"), that commit is from 2005, so it seems we've broken\nsomething.\n\nFurther, looking a bit at our curl build-script, we don't seem to to\ninstall curl-config. HOWEVER, 37e42ab (\"curl: update to 7.28.1 and\nenable ipv6\"), dated 1. Feb 2013 adds a function to remove\ncurl-config. Pat, why is this?\n\nMy knee-jerk suspicion would be that it's because it's a stale\ncurl-config from a previous install (that *did* install it). However,\nit doesn't seem like the mingw32 Makefile (the one you get without\nrunning configure, it seems) even tries to build curl-config. In fact,\nit seems this is simply built by configure itself. Which we don't run,\nagain since 37e42ab (\"curl: update to 7.28.1 and enable ipv6\").\n\nSo it seems that 08900987 (\"Decide whether to build http-push in the\nMakefile\") makes a bad assumption about the availability of\ncurl-config on new libcurl installations; it's not present on \"stock\"\nWindows builds.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239849","messageId":"CABPQNSZh1GePGwm6_cC9Zf7N1LaeiavbnOxG4JoWMAab4GcfQQ@mail.gmail.com","threadId":"36512","inReplyTo":"CABPQNSY-bM2pv7mn2R+wsnn944BkKbW6Hz2EhwrruPuxUJpUEQ@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T09:01:37Z","receivedAt":"2014-04-28T09:01:37Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> So it seems that 08900987 (\"Decide whether to build http-push in the\n> Makefile\") makes a bad assumption about the availability of\n> curl-config on new libcurl installations; it's not present on \"stock\"\n> Windows builds.\n\nI wonder, though. That check is over 8 years old. Are that old systems\n(that haven't been upgraded) still able to build Git? Even my old\nRedHat 5 setup has curl 7.15.5...\n\nPerhaps the following is the right thing to do? If not, perhaps we\ncould move this complication to configure.ac, which could get the\nversion number from the header-file instead? That way, quirks only\naffect quirky systems...\n\n(white-space damaged, I'll post a proper patch if there's some agreement)\n---\n\ndiff --git a/Makefile b/Makefile\nindex 29a555d..6da72e7 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1133,13 +1133,8 @@ else\n     REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n     PROGRAM_OBJS += http-fetch.o\n     PROGRAMS += $(REMOTE_CURL_NAMES)\n-    curl_check := $(shell (echo 070908; curl-config --vernum)\n2>/dev/null | sort -r | sed -ne 2p)\n-    ifeq \"$(curl_check)\" \"070908\"\n-        ifndef NO_EXPAT\n-            PROGRAM_OBJS += http-push.o\n-        endif\n-    endif\n     ifndef NO_EXPAT\n+        PROGRAM_OBJS += http-push.o\n         ifdef EXPATDIR\n             BASIC_CFLAGS += -I$(EXPATDIR)/include\n             EXPAT_LIBEXPAT = -L$(EXPATDIR)/$(lib)\n$(CC_LD_DYNPATH)$(EXPATDIR)/$(lib) -lexpat\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239860","messageId":"CABPQNSYsrSy2iONZOA5gjruBqGwEy6Tc1K+5_zYq3q=EMgzE9Q@mail.gmail.com","threadId":"36512","inReplyTo":"CABPQNSZh1GePGwm6_cC9Zf7N1LaeiavbnOxG4JoWMAab4GcfQQ@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T09:43:22Z","receivedAt":"2014-04-28T09:43:22Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> So it seems that 08900987 (\"Decide whether to build http-push in the\n>> Makefile\") makes a bad assumption about the availability of\n>> curl-config on new libcurl installations; it's not present on \"stock\"\n>> Windows builds.\n>\n> I wonder, though. That check is over 8 years old. Are that old systems\n> (that haven't been upgraded) still able to build Git? Even my old\n> RedHat 5 setup has curl 7.15.5...\n>\n> Perhaps the following is the right thing to do? If not, perhaps we\n> could move this complication to configure.ac, which could get the\n> version number from the header-file instead? That way, quirks only\n> affect quirky systems...\n\nAnd here's a stab at that. Not really tested, as I don't have an\naffected system, so it's probably broken somehow ;)\n\nBut if someone want's to pick it up, at least there's a starting-point.\n\n---\n\ndiff --git a/Makefile b/Makefile\nindex 29a555d..b94f830 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1133,11 +1133,8 @@ else\n  REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n  PROGRAM_OBJS += http-fetch.o\n  PROGRAMS += $(REMOTE_CURL_NAMES)\n- curl_check := $(shell (echo 070908; curl-config --vernum)\n2>/dev/null | sort -r | sed -ne 2p)\n- ifeq \"$(curl_check)\" \"070908\"\n- ifndef NO_EXPAT\n- PROGRAM_OBJS += http-push.o\n- endif\n+ ifndef NO_CAPABLE_CURL\n+ PROGRAM_OBJS += http-push.o\n  endif\n  ifndef NO_EXPAT\n  ifdef EXPATDIR\ndiff --git a/configure.ac b/configure.ac\nindex 2f43393..47991c0 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -513,6 +513,16 @@ AC_CHECK_LIB([curl], [curl_global_init],\n [NO_CURL=],\n [NO_CURL=YesPlease])\n\n+AC_COMPILE_IFELSE(\n+ [AC_LANG_PROGRAM([#include <curlver.h>],\n+ [#if LIBCURL_VERSION_NUM < 0x070908\n+#error version too old\n+#endif\n+ ])],\n+ [NO_CAPABLE_CURL=YesPlease],\n+ [NO_CAPABLE_CURL=])\n+GIT_CONF_SUBST([NO_CAPABLE_CURL])\n+\n GIT_UNSTASH_FLAGS($CURLDIR)\n\n GIT_CONF_SUBST([NO_CURL])\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239919","messageId":"CABPQNSbPkF20h4Bu6Xi_f6tGvQVh9AReZEYzXn2R=79PSJTdVg@mail.gmail.com","threadId":"36512","inReplyTo":"CABPQNSZh1GePGwm6_cC9Zf7N1LaeiavbnOxG4JoWMAab4GcfQQ@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T13:12:13Z","receivedAt":"2014-04-28T13:12:13Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 11:01 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> So it seems that 08900987 (\"Decide whether to build http-push in the\n>> Makefile\") makes a bad assumption about the availability of\n>> curl-config on new libcurl installations; it's not present on \"stock\"\n>> Windows builds.\n>\n> I wonder, though. That check is over 8 years old. Are that old systems\n> (that haven't been upgraded) still able to build Git? Even my old\n> RedHat 5 setup has curl 7.15.5...\n>\n> Perhaps the following is the right thing to do? If not, perhaps we\n> could move this complication to configure.ac, which could get the\n> version number from the header-file instead? That way, quirks only\n> affect quirky systems...\n>\n> (white-space damaged, I'll post a proper patch if there's some agreement)\n> ---\n>\n> diff --git a/Makefile b/Makefile\n> index 29a555d..6da72e7 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1133,13 +1133,8 @@ else\n>      REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n>      PROGRAM_OBJS += http-fetch.o\n>      PROGRAMS += $(REMOTE_CURL_NAMES)\n> -    curl_check := $(shell (echo 070908; curl-config --vernum)\n> 2>/dev/null | sort -r | sed -ne 2p)\n> -    ifeq \"$(curl_check)\" \"070908\"\n> -        ifndef NO_EXPAT\n> -            PROGRAM_OBJS += http-push.o\n> -        endif\n> -    endif\n>      ifndef NO_EXPAT\n> +        PROGRAM_OBJS += http-push.o\n>          ifdef EXPATDIR\n>              BASIC_CFLAGS += -I$(EXPATDIR)/include\n>              EXPAT_LIBEXPAT = -L$(EXPATDIR)/$(lib)\n> $(CC_LD_DYNPATH)$(EXPATDIR)/$(lib) -lexpat\n\nI've built an installer with this patch applied, and it seems to do the trick:\n\nhttps://dl.dropboxusercontent.com/u/1737924/Git-1.9.2-http-push.exe\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239920","messageId":"alpine.DEB.1.00.1404281519060.14982@s15462909.onlinehome-server.info","threadId":"36512","inReplyTo":"CABPQNSZh1GePGwm6_cC9Zf7N1LaeiavbnOxG4JoWMAab4GcfQQ@mail.gmail.com","subject":"Re: Re: git version 1.9.0 missing git-http-push?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2014-04-28T13:20:46Z","receivedAt":"2014-04-28T13:20:46Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi kusma,\n\nOn Mon, 28 Apr 2014, Erik Faye-Lund wrote:\n\n> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n> > So it seems that 08900987 (\"Decide whether to build http-push in the\n> > Makefile\") makes a bad assumption about the availability of\n> > curl-config on new libcurl installations; it's not present on \"stock\"\n> > Windows builds.\n> \n> I wonder, though. That check is over 8 years old. Are that old systems\n> (that haven't been upgraded) still able to build Git? Even my old\n> RedHat 5 setup has curl 7.15.5...\n\nThe easiest way in my humble opinion would be to install a script like\nthis into /mingw/bin/:\n\n-- snip --\n#!/bin/sh\n\ncase \"$1\" in\n--vernum)\n\tversion=\"$(curl -V)\" || exit\n\tversion=\"$(echo \"${version%% (*)*}\" | tr . \\ )\"\n\teval printf \"%02d%02d%02d\" ${version#curl }\n\t;;\n--cflags)\n\t;;\n--libs)\n\techo -lcurl\n\t;;\nesac\n-- snap --\n\nThat way, upstream Git does not have anything to change (and we avoid\ndiscussing five versions of essentially the same patch :-P).\n\nHmm?\n\nCiao,\nDscho\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239921","messageId":"CABPQNSY22+gJKEguT1dwTrnp-f0y05TKSVi41JR5GNAap4Qu1g@mail.gmail.com","threadId":"36512","inReplyTo":"alpine.DEB.1.00.1404281519060.14982@s15462909.onlinehome-server.info","subject":"Re: Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T13:24:12Z","receivedAt":"2014-04-28T13:24:12Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 3:20 PM, Johannes Schindelin\n<Johannes.Schindelin@gmx.de> wrote:\n> Hi kusma,\n>\n> On Mon, 28 Apr 2014, Erik Faye-Lund wrote:\n>\n>> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@gmail.com> wrote:\n>> > So it seems that 08900987 (\"Decide whether to build http-push in the\n>> > Makefile\") makes a bad assumption about the availability of\n>> > curl-config on new libcurl installations; it's not present on \"stock\"\n>> > Windows builds.\n>>\n>> I wonder, though. That check is over 8 years old. Are that old systems\n>> (that haven't been upgraded) still able to build Git? Even my old\n>> RedHat 5 setup has curl 7.15.5...\n>\n> The easiest way in my humble opinion would be to install a script like\n> this into /mingw/bin/:\n>\n> -- snip --\n> #!/bin/sh\n>\n> case \"$1\" in\n> --vernum)\n>         version=\"$(curl -V)\" || exit\n>         version=\"$(echo \"${version%% (*)*}\" | tr . \\ )\"\n>         eval printf \"%02d%02d%02d\" ${version#curl }\n>         ;;\n> --cflags)\n>         ;;\n> --libs)\n>         echo -lcurl\n>         ;;\n> esac\n> -- snap --\n>\n> That way, upstream Git does not have anything to change (and we avoid\n> discussing five versions of essentially the same patch :-P).\n\nHuh? I think I only really proposed one patch...?\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239922","messageId":"20140428134742.GA18447@seldon","threadId":"36512","inReplyTo":"alpine.DEB.1.00.1404281519060.14982@s15462909.onlinehome-server.info","subject":"Re: Re: git version 1.9.0 missing git-http-push?","fromName":"Marat Radchenko","fromEmail":"marat@slonopotamus.org","sentAt":"2014-04-28T13:47:42Z","receivedAt":"2014-04-28T13:47:42Z","isPatch":false,"sender":{"key":"marat@slonopotamus.org","avatar":"https://avatars.githubusercontent.com/u/92637?v=4"},"body":"On Mon, Apr 28, 2014 at 03:20:46PM +0200, Johannes Schindelin wrote:\n> That way, upstream Git does not have anything to change (and we avoid\n> discussing five versions of essentially the same patch :-P).\n\nThis bug isn't specific to msysGit but also affects all environments\nwhere curl-config is not available or cannot be run for some reason,\nfor example during cross-compilation.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239932","messageId":"CABPQNSYuoTP6wyQQs5dm5y+3++4m7__c3QZtLTb76=zREWE4Bg@mail.gmail.com","threadId":"36512","inReplyTo":"20140428134742.GA18447@seldon","subject":"Re: Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T13:53:58Z","receivedAt":"2014-04-28T13:53:58Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 3:47 PM, Marat Radchenko <marat@slonopotamus.org> wrote:\n> On Mon, Apr 28, 2014 at 03:20:46PM +0200, Johannes Schindelin wrote:\n>> That way, upstream Git does not have anything to change (and we avoid\n>> discussing five versions of essentially the same patch :-P).\n>\n> This bug isn't specific to msysGit but also affects all environments\n> where curl-config is not available or cannot be run for some reason,\n> for example during cross-compilation.\n\nTrue. I think the assumption simply was a bad one, and it has probably\ngone unnoticed for a while because pushing over WebDAV is not all that\ncommon.\n\nIf anyone turns up a system with an old enough libcurl, they should\nprobably consult curlver.h instead. And if so, they are probably on a\nsystem so crippled they need to run automake anyway.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239978","messageId":"xmqqsioxqp9i.fsf@gitster.dls.corp.google.com","threadId":"36512","inReplyTo":"CABPQNSY-bM2pv7mn2R+wsnn944BkKbW6Hz2EhwrruPuxUJpUEQ@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-28T18:31:53Z","receivedAt":"2014-04-28T18:31:53Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Erik Faye-Lund <kusmabite@gmail.com> writes:\n\n> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so\n> we should be able to include it. However, we do not have curl-config\n> installed.\n\nHmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use\ncurl-config to determine curl flags, 2014-04-15) merged already,\nwhich makes this assumption and a claim based on that assumption:\n\n    curl-config should always be installed alongside a curl\n    distribution, and its purpose is to provide flags for building\n    against libcurl, so use it instead of guessing flags and\n    dependent libraries.\n\nwhich may make things worse for you guys, unless you are explicitly\nsetting CURLDIR and other Makefile variables.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239979","messageId":"CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com","threadId":"36512","inReplyTo":"xmqqsioxqp9i.fsf@gitster.dls.corp.google.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"'Dave Borowitz <dborowitz@google.com>' via msysGit","fromEmail":"msysgit@googlegroups.com","sentAt":"2014-04-28T18:39:43Z","receivedAt":"2014-04-28T18:39:43Z","isPatch":false,"sender":{"key":"name:'Dave Borowitz <dborowitz@google.com>'","avatar":null},"body":"On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> Erik Faye-Lund <kusmabite@gmail.com> writes:\n>\n>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so\n>> we should be able to include it. However, we do not have curl-config\n>> installed.\n>\n> Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use\n> curl-config to determine curl flags, 2014-04-15) merged already,\n> which makes this assumption and a claim based on that assumption:\n>\n>     curl-config should always be installed alongside a curl\n>     distribution, and its purpose is to provide flags for building\n>     against libcurl, so use it instead of guessing flags and\n>     dependent libraries.\n>\n> which may make things worse for you guys, unless you are explicitly\n> setting CURLDIR and other Makefile variables.\n\nYes, I can see that assumption may not always hold. But I'm slightly\nsurprised this worked in the first place; are you saying this is a\nsystem where:\n-curl-config is not installed\n-but -lcurl still works\n-without setting CURLDIR\n?\n\nI think I should probably re-roll the patch to default to the old\nbehavior (blind -lcurl) if curl-config returns the empty string, which\nI believe is also the case when the binary is not found.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"239980","messageId":"CABPQNSaOVrUJVQcE8pyfohP4tgvD+bRPScw-igsFj08H3EoRWA@mail.gmail.com","threadId":"36512","inReplyTo":"CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2014-04-28T19:02:19Z","receivedAt":"2014-04-28T19:02:19Z","isPatch":false,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"On Mon, Apr 28, 2014 at 8:39 PM, Dave Borowitz <dborowitz@google.com> wrote:\n> On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano <gitster@pobox.com> wrote:\n>> Erik Faye-Lund <kusmabite@gmail.com> writes:\n>>\n>>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so\n>>> we should be able to include it. However, we do not have curl-config\n>>> installed.\n>>\n>> Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use\n>> curl-config to determine curl flags, 2014-04-15) merged already,\n>> which makes this assumption and a claim based on that assumption:\n>>\n>>     curl-config should always be installed alongside a curl\n>>     distribution, and its purpose is to provide flags for building\n>>     against libcurl, so use it instead of guessing flags and\n>>     dependent libraries.\n>>\n>> which may make things worse for you guys, unless you are explicitly\n>> setting CURLDIR and other Makefile variables.\n>\n> Yes, I can see that assumption may not always hold. But I'm slightly\n> surprised this worked in the first place; are you saying this is a\n> system where:\n> -curl-config is not installed\n> -but -lcurl still works\n> -without setting CURLDIR\n> ?\n\nYes, our cURL is installed globally together with the system libraries.\n\n> I think I should probably re-roll the patch to default to the old\n> behavior (blind -lcurl) if curl-config returns the empty string, which\n> I believe is also the case when the binary is not found.\n\nThat sounds like it would work for MsysGit, yeah.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240011","messageId":"xmqqy4ypp7jd.fsf@gitster.dls.corp.google.com","threadId":"36512","inReplyTo":"CAD0k6qSUYANxbjjbE4jTW4EeVwOYgBD=bXkSu=akiYC_CB7Ffw@mail.gmail.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-28T19:40:06Z","receivedAt":"2014-04-28T19:40:06Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"'Dave Borowitz <dborowitz@google.com>' via msysGit\"\n<msysgit@googlegroups.com> writes:\n\n> I think I should probably re-roll the patch to default to the old\n> behavior (blind -lcurl) if curl-config returns the empty string, which\n> I believe is also the case when the binary is not found.\n\nThanks for a prompt response; as this may indicate a possible\nregression on what is already in 2.0-rc1, I am tempted to say that\nwe should revert the merge in the meantime.\n\nUnless such an update can be done in a fairly trivial way, that is.\n\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"},{"id":"240012","messageId":"CAD0k6qQ9aT983e=yzO+jw11FAzX-PMW59iDaY1wba0FJBtmE8Q@mail.gmail.com","threadId":"36512","inReplyTo":"xmqqy4ypp7jd.fsf@gitster.dls.corp.google.com","subject":"Re: git version 1.9.0 missing git-http-push?","fromName":"'Dave Borowitz <dborowitz@google.com>' via msysGit","fromEmail":"msysgit@googlegroups.com","sentAt":"2014-04-28T19:42:49Z","receivedAt":"2014-04-28T19:42:49Z","isPatch":false,"sender":{"key":"name:'Dave Borowitz <dborowitz@google.com>'","avatar":null},"body":"On Mon, Apr 28, 2014 at 12:40 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> \"'Dave Borowitz <dborowitz@google.com>' via msysGit\"\n> <msysgit@googlegroups.com> writes:\n>\n>> I think I should probably re-roll the patch to default to the old\n>> behavior (blind -lcurl) if curl-config returns the empty string, which\n>> I believe is also the case when the binary is not found.\n>\n> Thanks for a prompt response; as this may indicate a possible\n> regression on what is already in 2.0-rc1, I am tempted to say that\n> we should revert the merge in the meantime.\n>\n> Unless such an update can be done in a fairly trivial way, that is.\n\nI already sent the update. There's a bit more (unavoidable) complexity\nin the conditionals but it should still be fairly straightforward.\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/d/optout.\n"}]}