{"thread":{"id":"36480","subject":"[PATCH 01/14] t9365-continuing-queries.sh: use the $( ... ) construct for command substitution","startedAt":"2014-04-23T13:43:53Z","lastAt":"2014-04-28T19:20:07Z","messageCount":20,"participants":["Elia Pinto","Matthieu Moy","brian m. carlson","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":14},"messages":[{"id":"239425","messageId":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":null,"subject":"[PATCH 01/14] t9365-continuing-queries.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:53Z","receivedAt":"2014-04-23T13:43:53Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n contrib/mw-to-git/t/t9365-continuing-queries.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/mw-to-git/t/t9365-continuing-queries.sh b/contrib/mw-to-git/t/t9365-continuing-queries.sh\nindex 27e267f..0164547 100755\n--- a/contrib/mw-to-git/t/t9365-continuing-queries.sh\n+++ b/contrib/mw-to-git/t/t9365-continuing-queries.sh\n@@ -9,7 +9,7 @@ test_check_precond\n \n test_expect_success 'creating page w/ >500 revisions' '\n \twiki_reset &&\n-\tfor i in `test_seq 501`\n+\tfor i in $(test_seq 501)\n \tdo\n \t\techo \"creating revision $i\" &&\n \t\twiki_editpage foo \"revision $i
\" true\n-- \n1.7.10.4\n"},{"id":"239438","messageId":"1398260646-2660-2-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 02/14] test-gitmw-lib.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:54Z","receivedAt":"2014-04-23T13:43:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n contrib/mw-to-git/t/test-gitmw-lib.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/mw-to-git/t/test-gitmw-lib.sh b/contrib/mw-to-git/t/test-gitmw-lib.sh\nindex 3372b2a..c783752 100755\n--- a/contrib/mw-to-git/t/test-gitmw-lib.sh\n+++ b/contrib/mw-to-git/t/test-gitmw-lib.sh\n@@ -90,7 +90,7 @@ test_diff_directories () {\n #\n # Check that contains exactly files\n test_contains_N_files () {\n-\tif test `ls -- \"$1\" | wc -l` -ne \"$2\"; then\n+\tif test $(ls -- \"$1\" | wc -l) -ne \"$2\"; then\n \t\techo \"directory $1 should contain $2 files\"\n \t\techo \"it contains these files:\"\n \t\tls \"$1\"\n@@ -341,10 +341,10 @@ wiki_install () {\n \t\t\t\"http://download.wikimedia.org/mediawiki/$MW_VERSION_MAJOR/\"\\\n \t\t\t\"$MW_FILENAME. \"\\\n \t\t\t\"Please fix your connection and launch the script again.\"\n-\t\techo \"$MW_FILENAME downloaded in `pwd`. \"\\\n+\t\techo \"$MW_FILENAME downloaded in $(pwd). \"\\\n \t\t\t\"You can delete it later if you want.\"\n \telse\n-\t\techo \"Reusing existing $MW_FILENAME downloaded in `pwd`.\"\n+\t\techo \"Reusing existing $MW_FILENAME downloaded in $(pwd).\"\n \tfi\n \tarchive_abs_path=$(pwd)/$MW_FILENAME\n \tcd \"$WIKI_DIR_INST/$WIKI_DIR_NAME/\" ||\n-- \n1.7.10.4\n"},{"id":"239435","messageId":"1398260646-2660-3-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 03/14] t7900-subtree.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:55Z","receivedAt":"2014-04-23T13:43:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n contrib/subtree/t/t7900-subtree.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh\nindex 66ce4b0..b22b710 100755\n--- a/contrib/subtree/t/t7900-subtree.sh\n+++ b/contrib/subtree/t/t7900-subtree.sh\n@@ -76,7 +76,7 @@ test_expect_success 'add sub1' '\n \n # Save this hash for testing later.\n \n-subdir_hash=`git rev-parse HEAD`\n+subdir_hash=$(git rev-parse HEAD)\n \n test_expect_success 'add sub2' '\n create sub2 &&\n-- \n1.7.10.4\n"},{"id":"239437","messageId":"1398260646-2660-4-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:56Z","receivedAt":"2014-04-23T13:43:56Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n contrib/thunderbird-patch-inline/appp.sh | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/contrib/thunderbird-patch-inline/appp.sh b/contrib/thunderbird-patch-inline/appp.sh\nindex 5eb4a51..8dc73ec 100755\n--- a/contrib/thunderbird-patch-inline/appp.sh\n+++ b/contrib/thunderbird-patch-inline/appp.sh\n@@ -10,7 +10,7 @@ CONFFILE=~/.appprc\n \n SEP=\"-=-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-\"\n if [ -e \"$CONFFILE\" ] ; then\n-\tLAST_DIR=`grep -m 1 \"^LAST_DIR=\" \"${CONFFILE}\"|sed -e 's/^LAST_DIR=//'`\n+\tLAST_DIR=$(grep -m 1 \"^LAST_DIR=\" \"${CONFFILE}\"|sed -e 's/^LAST_DIR=//')\n \tcd \"${LAST_DIR}\"\n else\n \tcd > /dev/null\n@@ -25,11 +25,11 @@ fi\n \n cd - > /dev/null\n \n-SUBJECT=`sed -n -e '/^Subject: /p' \"${PATCH}\"`\n-HEADERS=`sed -e '/^'\"${SEP}\"'$/,$d' $1`\n-BODY=`sed -e \"1,/${SEP}/d\" $1`\n-CMT_MSG=`sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\"`\n-DIFF=`sed -e '1,/^---$/d' \"${PATCH}\"`\n+SUBJECT=$(sed -n -e '/^Subject: /p' \"${PATCH}\")\n+HEADERS=$(sed -e '/^'\"${SEP}\"'$/,$d' $1)\n+BODY=$(sed -e \"1,/${SEP}/d\" $1)\n+CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\")\n+DIFF=$(sed -e '1,/^---$/d' \"${PATCH}\")\n \n CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n \t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n@@ -48,7 +48,7 @@ if [ \"x${BODY}x\" != \"xx\" ] ; then\n fi\n echo \"$DIFF\" >> $1\n \n-LAST_DIR=`dirname \"${PATCH}\"`\n+LAST_DIR=$(dirname \"${PATCH}\")\n \n grep -v \"^LAST_DIR=\" \"${CONFFILE}\" > \"${CONFFILE}_\"\n echo \"LAST_DIR=${LAST_DIR}\" >> \"${CONFFILE}_\"\n-- \n1.7.10.4\n"},{"id":"239426","messageId":"1398260646-2660-5-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 05/14] txt-to-pot.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:57Z","receivedAt":"2014-04-23T13:43:57Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n git-gui/po/glossary/txt-to-pot.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-gui/po/glossary/txt-to-pot.sh b/git-gui/po/glossary/txt-to-pot.sh\nindex 49bf7c5..8249915 100755\n--- a/git-gui/po/glossary/txt-to-pot.sh\n+++ b/git-gui/po/glossary/txt-to-pot.sh\n@@ -11,7 +11,7 @@\n if [ $# -eq 0 ]\n then\n \tcat < git-gui-glossary.pot\n+Usage: $(basename $0) git-gui-glossary.txt > git-gui-glossary.pot\n !\n \texit 1;\n fi\n@@ -33,7 +33,7 @@ cat <\\n\"\n \"Language-Team: LANGUAGE \\n\"\n-- \n1.7.10.4\n"},{"id":"239430","messageId":"1398260646-2660-6-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 06/14] git-pull.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:58Z","receivedAt":"2014-04-23T13:43:58Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n git-pull.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-pull.sh b/git-pull.sh\nindex 6cd8ebc..cfc589d 100755\n--- a/git-pull.sh\n+++ b/git-pull.sh\n@@ -108,7 +108,7 @@ do\n \t-s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tstrategy=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'` ;;\n+\t\t\tstrategy=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)') ;;\n \t\t1,*)\n \t\t\tusage ;;\n \t\t*)\n-- \n1.7.10.4\n"},{"id":"239436","messageId":"1398260646-2660-7-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 07/14] git-rebase--merge.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:43:59Z","receivedAt":"2014-04-23T13:43:59Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n git-rebase--merge.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-rebase--merge.sh b/git-rebase--merge.sh\nindex 71429fd..6d77b3c 100644\n--- a/git-rebase--merge.sh\n+++ b/git-rebase--merge.sh\n@@ -24,7 +24,7 @@ continue_merge () {\n \t\tdie \"$resolvemsg\"\n \tfi\n \n-\tcmt=`cat \"$state_dir/current\"`\n+\tcmt=$(cat \"$state_dir/current\")\n \tif ! git diff-index --quiet --ignore-submodules HEAD --\n \tthen\n \t\tif ! git commit ${gpg_sign_opt:+\"$gpg_sign_opt\"} --no-verify -C \"$cmt\"\n@@ -143,7 +143,7 @@ echo \"$onto_name\" > \"$state_dir/onto_name\"\n write_basic_state\n \n msgnum=0\n-for cmt in `git rev-list --reverse --no-merges \"$revisions\"`\n+for cmt in $(git rev-list --reverse --no-merges \"$revisions\")\n do\n \tmsgnum=$(($msgnum + 1))\n \techo \"$cmt\" > \"$state_dir/cmt.$msgnum\"\n-- \n1.7.10.4\n"},{"id":"239431","messageId":"1398260646-2660-8-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 08/14] git-rebase.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:00Z","receivedAt":"2014-04-23T13:44:00Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n git-rebase.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/git-rebase.sh b/git-rebase.sh\nindex 4543815..5c7a0a1 100755\n--- a/git-rebase.sh\n+++ b/git-rebase.sh\n@@ -457,8 +457,8 @@ then\n else\n \tif test -z \"$onto\"\n \tthen\n-\t\tempty_tree=`git hash-object -t tree /dev/null`\n-\t\tonto=`git commit-tree $empty_tree \n---\n git-stash.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 4798bcf..af549c7 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -13,7 +13,7 @@ USAGE=\"list []\n \n SUBDIRECTORY_OK=Yes\n OPTIONS_SPEC=\n-START_DIR=`pwd`\n+START_DIR=$(pwd)\n . git-sh-setup\n . git-sh-i18n\n require_work_tree\n-- \n1.7.10.4\n"},{"id":"239428","messageId":"1398260646-2660-10-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 10/14] git-web--browse.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:02Z","receivedAt":"2014-04-23T13:44:02Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n git-web--browse.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-web--browse.sh b/git-web--browse.sh\nindex ebdfba6..ae15253 100755\n--- a/git-web--browse.sh\n+++ b/git-web--browse.sh\n@@ -59,7 +59,7 @@ do\n \t-b|--browser*|-t|--tool*)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tbrowser=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'`\n+\t\t\tbrowser=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)')\n \t\t\t;;\n \t\t1,*)\n \t\t\tusage ;;\n@@ -71,7 +71,7 @@ do\n \t-c|--config*)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tconf=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'`\n+\t\t\tconf=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)')\n \t\t\t;;\n \t\t1,*)\n \t\t\tusage ;;\n@@ -100,7 +100,7 @@ then\n \tfor opt in \"$conf\" \"web.browser\"\n \tdo\n \t\ttest -z \"$opt\" && continue\n-\t\tbrowser=\"`git config $opt`\"\n+\t\tbrowser=\"$(git config $opt)\"\n \t\ttest -z \"$browser\" || break\n \tdone\n \tif test -n \"$browser\" && ! valid_tool \"$browser\"; then\n-- \n1.7.10.4\n"},{"id":"239433","messageId":"1398260646-2660-11-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 11/14] lib-credential.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:03Z","receivedAt":"2014-04-23T13:44:03Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/lib-credential.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/lib-credential.sh b/t/lib-credential.sh\nindex 957ae93..9e7d796 100755\n--- a/t/lib-credential.sh\n+++ b/t/lib-credential.sh\n@@ -281,7 +281,7 @@ helper_test_timeout() {\n cat >askpass <<\\EOF\n #!/bin/sh\n echo >&2 askpass: $*\n-what=`echo $1 | cut -d\" \" -f1 | tr A-Z a-z | tr -cd a-z`\n+what=$(echo $1 | cut -d\" \" -f1 | tr A-Z a-z | tr -cd a-z)\n echo \"askpass-$what\"\n EOF\n chmod +x askpass\n-- \n1.7.10.4\n"},{"id":"239434","messageId":"1398260646-2660-12-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 12/14] lib-cvs.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:04Z","receivedAt":"2014-04-23T13:44:04Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/lib-cvs.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/lib-cvs.sh b/t/lib-cvs.sh\nindex 5076718..9b2bcfb 100644\n--- a/t/lib-cvs.sh\n+++ b/t/lib-cvs.sh\n@@ -13,7 +13,7 @@ fi\n CVS=\"cvs -f\"\n export CVS\n \n-cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`\n+cvsps_version=$(cvsps -h 2>&1 | sed -ne 's/cvsps version //p')\n case \"$cvsps_version\" in\n 2.1 | 2.2*)\n \t;;\n-- \n1.7.10.4\n"},{"id":"239429","messageId":"1398260646-2660-13-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 13/14] lib-gpg.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:05Z","receivedAt":"2014-04-23T13:44:05Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/lib-gpg.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/lib-gpg.sh b/t/lib-gpg.sh\nindex 05824fa..fd499e7 100755\n--- a/t/lib-gpg.sh\n+++ b/t/lib-gpg.sh\n@@ -1,6 +1,6 @@\n #!/bin/sh\n \n-gpg_version=`gpg --version 2>&1`\n+gpg_version=$(gpg --version 2>&1)\n if test $? = 127; then\n \tsay \"You do not seem to have gpg installed\"\n else\n-- \n1.7.10.4\n"},{"id":"239427","messageId":"1398260646-2660-14-git-send-email-gitter.spiros@gmail.com","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH 14/14] p5302-pack-index.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-04-23T13:44:06Z","receivedAt":"2014-04-23T13:44:06Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $(...) construct for command\nsubstitution instead of using the backquotes `...`.\n\nThe backquoted form is the traditional method for command\nsubstitution, and is supported by POSIX. However, all but the\nsimplest uses become complicated quickly. In particular, embedded\ncommand substitutions and/or the use of double quotes require\ncareful escaping with the backslash character.\n\nThe patch was generated by:\n\nfor _f in $(find . -name \"*.sh\")\ndo\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nand then carefully proof-read.\n\nSigned-off-by: Elia Pinto \n---\n t/perf/p5302-pack-index.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh\nindex 6cb5b0d..5ee9211 100755\n--- a/t/perf/p5302-pack-index.sh\n+++ b/t/perf/p5302-pack-index.sh\n@@ -8,7 +8,7 @@ test_perf_large_repo\n \n test_expect_success 'repack' '\n \tgit repack -ad &&\n-\tPACK=`ls .git/objects/pack/*.pack | head -n1` &&\n+\tPACK=$(ls .git/objects/pack/*.pack | head -n1) &&\n \ttest -f \"$PACK\" &&\n \texport PACK\n '\n-- \n1.7.10.4\n"},{"id":"239441","messageId":"vpq4n1kw1fl.fsf@anie.imag.fr","threadId":"36480","inReplyTo":"1398260646-2660-5-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 05/14] txt-to-pot.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-04-23T14:44:14Z","receivedAt":"2014-04-23T14:44:14Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Elia Pinto writes:\n\n> git-gui/po/glossary/txt-to-pot.sh | 4 ++--\n\ngit-gui is a separate project, patches are normally applied to git-gui\nfirst, and then pulled by Junio.\n\nI'd suggest dropping this patch, it's probably not worth the trouble\n(although the patch is correct).\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"239442","messageId":"vpqy4ywumt0.fsf@anie.imag.fr","threadId":"36480","inReplyTo":"1398260646-2660-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 01/14] t9365-continuing-queries.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-04-23T14:45:31Z","receivedAt":"2014-04-23T14:45:31Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Patches 01 to 14/14 are\n\nReviewed-by: Matthieu Moy \n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"239724","messageId":"20140425225843.GA238861@vauxhall.crustytoothpaste.net","threadId":"36480","inReplyTo":"1398260646-2660-4-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-04-25T22:58:43Z","receivedAt":"2014-04-25T22:58:43Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Wed, Apr 23, 2014 at 06:43:56AM -0700, Elia Pinto wrote:\n> @@ -25,11 +25,11 @@ fi\n> \n> cd - > /dev/null\n> \n> -SUBJECT=`sed -n -e '/^Subject: /p' \"${PATCH}\"`\n> -HEADERS=`sed -e '/^'\"${SEP}\"'$/,$d' $1`\n> -BODY=`sed -e \"1,/${SEP}/d\" $1`\n> -CMT_MSG=`sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\"`\n> -DIFF=`sed -e '1,/^---$/d' \"${PATCH}\"`\n> +SUBJECT=$(sed -n -e '/^Subject: /p' \"${PATCH}\")\n> +HEADERS=$(sed -e '/^'\"${SEP}\"'$/,$d' $1)\n> +BODY=$(sed -e \"1,/${SEP}/d\" $1)\n> +CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\")\n> +DIFF=$(sed -e '1,/^---$/d' \"${PATCH}\")\n> \n> CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n> \t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n\nIt looks like you may have missed a usage here due to the line break.\n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"239983","messageId":"xmqq61lts5m9.fsf@gitster.dls.corp.google.com","threadId":"36480","inReplyTo":"20140425225843.GA238861@vauxhall.crustytoothpaste.net","subject":"Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-28T17:53:18Z","receivedAt":"2014-04-28T17:53:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" writes:\n\n>> CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n>> \t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n>\n> It looks like you may have missed a usage here due to the line break.\n\nGood eyes ;-)\n\nThe following may be an obvious replacement patch, but alternatively\nwe could just drop the whole thing (contrib/ material is not\nsomething we would need to police strictly for the style---nobody\nshould be mimicking their styles as they are not part of _our_\ncodebase in the first place).\n\n contrib/thunderbird-patch-inline/appp.sh | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/contrib/thunderbird-patch-inline/appp.sh b/contrib/thunderbird-patch-inline/appp.sh\nindex 5eb4a51..1053872 100755\n--- a/contrib/thunderbird-patch-inline/appp.sh\n+++ b/contrib/thunderbird-patch-inline/appp.sh\n@@ -10,7 +10,7 @@ CONFFILE=~/.appprc\n \n SEP=\"-=-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-\"\n if [ -e \"$CONFFILE\" ] ; then\n-\tLAST_DIR=`grep -m 1 \"^LAST_DIR=\" \"${CONFFILE}\"|sed -e 's/^LAST_DIR=//'`\n+\tLAST_DIR=$(grep -m 1 \"^LAST_DIR=\" \"${CONFFILE}\"|sed -e 's/^LAST_DIR=//')\n \tcd \"${LAST_DIR}\"\n else\n \tcd > /dev/null\n@@ -25,14 +25,14 @@ fi\n \n cd - > /dev/null\n \n-SUBJECT=`sed -n -e '/^Subject: /p' \"${PATCH}\"`\n-HEADERS=`sed -e '/^'\"${SEP}\"'$/,$d' $1`\n-BODY=`sed -e \"1,/${SEP}/d\" $1`\n-CMT_MSG=`sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\"`\n-DIFF=`sed -e '1,/^---$/d' \"${PATCH}\"`\n+SUBJECT=$(sed -n -e '/^Subject: /p' \"${PATCH}\")\n+HEADERS=$(sed -e '/^'\"${SEP}\"'$/,$d' $1)\n+BODY=$(sed -e \"1,/${SEP}/d\" $1)\n+CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' \"${PATCH}\")\n+DIFF=$(sed -e '1,/^---$/d' \"${PATCH}\")\n \n-CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n-\t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n+CCS=$(echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n+\t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp')\n \n echo \"$SUBJECT\" > $1\n echo \"Cc: $CCS\" >> $1\n@@ -48,7 +48,7 @@ if [ \"x${BODY}x\" != \"xx\" ] ; then\n fi\n echo \"$DIFF\" >> $1\n \n-LAST_DIR=`dirname \"${PATCH}\"`\n+LAST_DIR=$(dirname \"${PATCH}\")\n \n grep -v \"^LAST_DIR=\" \"${CONFFILE}\" > \"${CONFFILE}_\"\n echo \"LAST_DIR=${LAST_DIR}\" >> \"${CONFFILE}_\"\n"},{"id":"239988","messageId":"vpqmwf572fx.fsf@anie.imag.fr","threadId":"36480","inReplyTo":"xmqq61lts5m9.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-04-28T18:07:30Z","receivedAt":"2014-04-28T18:07:30Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> \"brian m. carlson\" writes:\n>\n>>> CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n>>> \t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n>>\n>> It looks like you may have missed a usage here due to the line break.\n>\n> Good eyes ;-)\n>\n> The following may be an obvious replacement patch, but alternatively\n> we could just drop the whole thing (contrib/ material is not\n> something we would need to police strictly for the style---nobody\n> should be mimicking their styles as they are not part of _our_\n> codebase in the first place).\n\nMy vote goes for keeping the patch as it is, so that future people\ngrepping for `...` construct do not find any after the series is\nfinished.\n\n(and because it's simple to do)\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"239994","messageId":"xmqq7g69qn14.fsf@gitster.dls.corp.google.com","threadId":"36480","inReplyTo":"vpqmwf572fx.fsf@anie.imag.fr","subject":"Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-28T19:20:07Z","receivedAt":"2014-04-28T19:20:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Junio C Hamano writes:\n>\n>> \"brian m. carlson\" writes:\n>>\n>>>> CCS=`echo -e \"$CMT_MSG\\n$HEADERS\" | sed -n -e 's/^Cc: \\(.*\\)$/\\1,/gp' \\\n>>>> \t-e 's/^Signed-off-by: \\(.*\\)/\\1,/gp'`\n>>>\n>>> It looks like you may have missed a usage here due to the line break.\n>>\n>> Good eyes ;-)\n>>\n>> The following may be an obvious replacement patch, but alternatively\n>> we could just drop the whole thing (contrib/ material is not\n>> something we would need to police strictly for the style---nobody\n>> should be mimicking their styles as they are not part of _our_\n>> codebase in the first place).\n>\n> My vote goes for keeping the patch as it is, so that future people\n> grepping for `...` construct do not find any after the series is\n> finished.\n>\n> (and because it's simple to do)\n\nSure, let's do that.\n"}]}