{"thread":{"id":"36427","subject":"[PATCH] tag: add -i and --introduced modifier for --contains","startedAt":"2014-04-16T20:58:58Z","lastAt":"2014-04-22T17:58:08Z","messageCount":16,"participants":["Luis R. Rodriguez","Junio C Hamano","Andreas Schwab","Jeff King","W. Trevor King","Jan Kara"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"238981","messageId":"1397681938-18594-1-git-send-email-mcgrof@do-not-panic.com","threadId":"36427","inReplyTo":null,"subject":"[PATCH] tag: add -i and --introduced modifier for --contains","fromName":"Luis R. Rodriguez","fromEmail":"mcgrof@do-not-panic.com","sentAt":"2014-04-16T20:58:58Z","receivedAt":"2014-04-16T20:58:58Z","isPatch":true,"sender":{"key":"mcgrof@do-not-panic.com","avatar":null},"body":"From: \"Luis R. Rodriguez\" \n\nUpstream Linux kernel commit c5905afb was introduced on v3.4 but\ngit describe --contains yields v3.5 while if we use git to look\nfor the first parent with git describe --first-parent yields\nv3.3. The reason for this seems to be that the merge commit that\nintroduced c5905afb was based on v3.3. At least for --contains\nits unclear to me why we get v3.5, the result is not intuitive,\nas for --first-parent the issue is that the first parent actually\n*is* v3.3. The easiest way to address this it to rely on on the\ngit tag --contains implmenetation and add a modifier that specifies\nyou want the tag that first introduced the specified commit.\n\nmcgrof@ergon ~/linux (git::master)$ git tag -i --contains c5905afb\nv3.4\n\nmcgrof@ergon ~/linux (git::master)$ git tag --introduced --contains c5905afb\nv3.4\n\nCc: Jiri Slaby \nCc: Andreas Schwab \nCc: Jan Kara \nSigned-off-by: Luis R. Rodriguez \n---\n builtin/tag.c | 21 ++++++++++++++++-----\n 1 file changed, 16 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin/tag.c b/builtin/tag.c\nindex 6c7c6bd..65a939b 100644\n--- a/builtin/tag.c\n+++ b/builtin/tag.c\n@@ -21,7 +21,7 @@\n static const char * const git_tag_usage[] = {\n \tN_(\"git tag [-a|-s|-u ] [-f] [-m |-F ] []\"),\n \tN_(\"git tag -d ...\"),\n-\tN_(\"git tag -l [-n[]] [--contains ] [--points-at