{"thread":{"id":"36343","subject":"[PATCH] MSVC: allow using ExtUtils::MakeMaker","startedAt":"2014-04-03T07:34:03Z","lastAt":"2014-04-04T18:57:27Z","messageCount":2,"participants":["Marat Radchenko","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"238342","messageId":"1396510443-29087-1-git-send-email-marat@slonopotamus.org","threadId":"36343","inReplyTo":null,"subject":"[PATCH] MSVC: allow using ExtUtils::MakeMaker","fromName":"Marat Radchenko","fromEmail":"marat@slonopotamus.org","sentAt":"2014-04-03T07:34:03Z","receivedAt":"2014-04-03T07:34:03Z","isPatch":true,"sender":{"key":"marat@slonopotamus.org","avatar":"https://avatars.githubusercontent.com/u/92637?v=4"},"body":"Drop NO_PERL_MAKEMAKER from config.mak.uname for the MSVC platform.\n\nMakeMaker is available on Windows Perl implementations and\ninstalls modules to correct location, unlike NO_PERL_MAKEMAKER Makefile.\n\nSigned-off-by: Marat Radchenko <marat@slonopotamus.org>\n---\n config.mak.uname | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex fc5616d..6db4193 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -338,7 +338,6 @@ ifeq ($(uname_S),Windows)\n \tNO_MKSTEMPS = YesPlease\n \tSNPRINTF_RETURNS_BOGUS = YesPlease\n \tNO_SVN_TESTS = YesPlease\n-\tNO_PERL_MAKEMAKER = YesPlease\n \tRUNTIME_PREFIX = YesPlease\n \tNO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease\n \tNO_NSEC = YesPlease\n-- \n1.9.1\n"},{"id":"238379","messageId":"xmqqeh1cq5wo.fsf@gitster.dls.corp.google.com","threadId":"36343","inReplyTo":"1396510443-29087-1-git-send-email-marat@slonopotamus.org","subject":"Re: [PATCH] MSVC: allow using ExtUtils::MakeMaker","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-04-04T18:57:27Z","receivedAt":"2014-04-04T18:57:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marat Radchenko <marat@slonopotamus.org> writes:\n\n> Drop NO_PERL_MAKEMAKER from config.mak.uname for the MSVC platform.\n>\n> MakeMaker is available on Windows Perl implementations and\n> installs modules to correct location, unlike NO_PERL_MAKEMAKER Makefile.\n>\n> Signed-off-by: Marat Radchenko <marat@slonopotamus.org>\n> ---\n\nAs nobody seems to object to this change (and I do not have an\nenvironment nor inclination to test MSVC builds myself), I'll apply\nthis directly to 'master', hoping that doing so reasonably ahead of\n2.0-rc0 would give people enough time to complain if needed.\n\nThanks.\n\n\n>  config.mak.uname | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index fc5616d..6db4193 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -338,7 +338,6 @@ ifeq ($(uname_S),Windows)\n>  \tNO_MKSTEMPS = YesPlease\n>  \tSNPRINTF_RETURNS_BOGUS = YesPlease\n>  \tNO_SVN_TESTS = YesPlease\n> -\tNO_PERL_MAKEMAKER = YesPlease\n>  \tRUNTIME_PREFIX = YesPlease\n>  \tNO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease\n>  \tNO_NSEC = YesPlease\n"}]}