{"thread":{"id":"36291","subject":"[PATCH v2 006/142] git-stash.sh: use the $( ... ) construct for command substitution","startedAt":"2014-03-25T17:22:21Z","lastAt":"2014-03-26T12:19:54Z","messageCount":101,"participants":["Elia Pinto","Junio C Hamano","Matthieu Moy","Eric Sunshine","David Kastrup"],"isPatch":true,"patchVersion":2,"patchTotal":142},"messages":[{"id":"237754","messageId":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":null,"subject":"[PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:21Z","receivedAt":"2014-03-25T17:22:21Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"\nThis patch series changes everywhere the back-quotes construct for command\nsubstitution with the $( ... ). The Git CodingGuidelines prefer \nthe $( ... ) construct for command substitution instead of using the back-quotes\n, or grave accents (`..`).\n \nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell. Because this construct uses distinct\nopening and closing delimiters, it is much easier to follow. \nAlso now the embedded double quotes no longer need escaping.\n\nThe patch is simple but involves a large number of files with different authors. \nBeing simple I think it is wasteful to cc a large number of different people\nfor doing a review. \n\nThis is a second reroll after the \nMatthieu Moy review. Changes from v1:\n\n- Dropped the silly patches to t6111-rev-list-treesame.sh, \n t0204-gettext-reencode-sanity.sh.\n\n- Simple reformatting of the commit message.\n\n- added the toy script used for doing the patch.\n\nElia Pinto (142):\n check-builtins.sh: use the $( ... ) construct for command\n substitution\n git-am.sh: use the $( ... ) construct for command substitution\n git-pull.sh: use the $( ... ) construct for command substitution\n git-rebase--merge.sh: use the $( ... ) construct for command\n substitution\n git-rebase.sh: use the $( ... ) construct for command substitution\n git-stash.sh: use the $( ... ) construct for command substitution\n git-web--browse.sh: use the $( ... ) construct for command\n substitution\n unimplemented.sh: use the $( ... ) construct for command substitution\n t0001-init.sh: use the $( ... ) construct for command substitution\n t0010-racy-git.sh: use the $( ... ) construct for command\n substitution\n t0020-crlf.sh: use the $( ... ) construct for command substitution\n t0025-crlf-auto.sh: use the $( ... ) construct for command\n substitution\n t0026-eol-config.sh: use the $( ... ) construct for command\n substitution\n t0030-stripspace.sh: use the $( ... ) construct for command\n substitution\n t0300-credentials.sh: use the $( ... ) construct for command\n substitution\n t1000-read-tree-m-3way.sh: use the $( ... ) construct for command\n substitution\n t1001-read-tree-m-2way.sh: use the $( ... ) construct for command\n substitution\n t1002-read-tree-m-u-2way.sh: use the $( ... ) construct for command\n substitution\n t1003-read-tree-prefix.sh: use the $( ... ) construct for command\n substitution\n t1004-read-tree-m-u-wf.sh: use the $( ... ) construct for command\n substitution\n t1020-subdirectory.sh: use the $( ... ) construct for command\n substitution\n t1050-large.sh: use the $( ... ) construct for command substitution\n t1100-commit-tree-options.sh: use the $( ... ) construct for command\n substitution\n t1401-symbolic-ref.sh: use the $( ... ) construct for command\n substitution\n t1410-reflog.sh: use the $( ... ) construct for command substitution\n t1511-rev-parse-caret.sh: use the $( ... ) construct for command\n substitution\n t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for\n command substitution\n t2102-update-index-symlinks.sh: use the $( ... ) construct for\n command substitution\n t3030-merge-recursive.sh: use the $( ... ) construct for command\n substitution\n t3100-ls-tree-restrict.sh: use the $( ... ) construct for command\n substitution\n t3101-ls-tree-dirname.sh: use the $( ... ) construct for command\n substitution\n t3210-pack-refs.sh: use the $( ... ) construct for command\n substitution\n t3403-rebase-skip.sh: use the $( ... ) construct for command\n substitution\n t3511-cherry-pick-x.sh: use the $( ... ) construct for command\n substitution\n t3600-rm.sh: use the $( ... ) construct for command substitution\n t3700-add.sh: use the $( ... ) construct for command substitution\n t3905-stash-include-untracked.sh: use the $( ... ) construct for\n command substitution\n t3910-mac-os-precompose.sh: use the $( ... ) construct for command\n substitution\n t4006-diff-mode.sh: use the $( ... ) construct for command\n substitution\n t4010-diff-pathspec.sh: use the $( ... ) construct for command\n substitution\n t4012-diff-binary.sh: use the $( ... ) construct for command\n substitution\n t4013-diff-various.sh: use the $( ... ) construct for command\n substitution\n t4014-format-patch.sh: use the $( ... ) construct for command\n substitution\n t4036-format-patch-signer-mime.sh: use the $( ... ) construct for\n command substitution\n t4038-diff-combined.sh: use the $( ... ) construct for command\n substitution\n t4057-diff-combined-paths.sh: use the $( ... ) construct for command\n substitution\n t4116-apply-reverse.sh: use the $( ... ) construct for command\n substitution\n t4119-apply-config.sh: use the $( ... ) construct for command\n substitution\n t4204-patch-id.sh: use the $( ... ) construct for command\n substitution\n t5000-tar-tree.sh: use the $( ... ) construct for command\n substitution\n t5003-archive-zip.sh: use the $( ... ) construct for command\n substitution\n t5100-mailinfo.sh: use the $( ... ) construct for command\n substitution\n t5300-pack-object.sh: use the $( ... ) construct for command\n substitution\n t5301-sliding-window.sh: use the $( ... ) construct for command\n substitution\n t5302-pack-index.sh: use the $( ... ) construct for command\n substitution\n t5303-pack-corruption-resilience.sh: use the $( ... ) construct for\n command substitution\n t5304-prune.sh: use the $( ... ) construct for command substitution\n t5305-include-tag.sh: use the $( ... ) construct for command\n substitution\n t5500-fetch-pack.sh: use the $( ... ) construct for command\n substitution\n t5505-remote.sh: use the $( ... ) construct for command substitution\n t5506-remote-groups.sh: use the $( ... ) construct for command\n substitution\n t5510-fetch.sh: use the $( ... ) construct for command substitution\n t5515-fetch-merge-logic.sh: use the $( ... ) construct for command\n substitution\n t5516-fetch-push.sh: use the $( ... ) construct for command\n substitution\n t5517-push-mirror.sh: use the $( ... ) construct for command\n substitution\n t5520-pull.sh: use the $( ... ) construct for command substitution\n t5522-pull-symlink.sh: use the $( ... ) construct for command\n substitution\n t5530-upload-pack-error.sh: use the $( ... ) construct for command\n substitution\n t5537-fetch-shallow.sh: use the $( ... ) construct for command\n substitution\n t5538-push-shallow.sh: use the $( ... ) construct for command\n substitution\n t5550-http-fetch-dumb.sh: use the $( ... ) construct for command\n substitution\n t5551-http-fetch-smart.sh: use the $( ... ) construct for command\n substitution\n t5570-git-daemon.sh: use the $( ... ) construct for command\n substitution\n t5601-clone.sh: use the $( ... ) construct for command substitution\n t5700-clone-reference.sh: use the $( ... ) construct for command\n substitution\n t5710-info-alternate.sh: use the $( ... ) construct for command\n substitution\n t5900-repo-selection.sh: use the $( ... ) construct for command\n substitution\n t6001-rev-list-graft.sh: use the $( ... ) construct for command\n substitution\n t6002-rev-list-bisect.sh: use the $( ... ) construct for command\n substitution\n t6015-rev-list-show-all-parents.sh: use the $( ... ) construct for\n command substitution\n t6032-merge-large-rename.sh: use the $( ... ) construct for command\n substitution\n t6034-merge-rename-nocruft.sh: use the $( ... ) construct for command\n substitution\n t6132-pathspec-exclude.sh: use the $( ... ) construct for command\n substitution\n t7001-mv.sh: use the $( ... ) construct for command substitution\n t7003-filter-branch.sh: use the $( ... ) construct for command\n substitution\n t7004-tag.sh: use the $( ... ) construct for command substitution\n t7006-pager.sh: use the $( ... ) construct for command substitution\n t7103-reset-bare.sh: use the $( ... ) construct for command\n substitution\n t7406-submodule-update.sh: use the $( ... ) construct for command\n substitution\n t7408-submodule-reference.sh: use the $( ... ) construct for command\n substitution\n t7504-commit-msg-hook.sh: use the $( ... ) construct for command\n substitution\n t7505-prepare-commit-msg-hook.sh: use the $( ... ) construct for\n command substitution\n t7602-merge-octopus-many.sh: use the $( ... ) construct for command\n substitution\n t7700-repack.sh: use the $( ... ) construct for command substitution\n t8003-blame-corner-cases.sh: use the $( ... ) construct for command\n substitution\n t9001-send-email.sh: use the $( ... ) construct for command\n substitution\n t9101-git-svn-props.sh: use the $( ... ) construct for command\n substitution\n t9104-git-svn-follow-parent.sh: use the $( ... ) construct for\n command substitution\n t9105-git-svn-commit-diff.sh: use the $( ... ) construct for command\n substitution\n t9107-git-svn-migrate.sh: use the $( ... ) construct for command\n substitution\n t9108-git-svn-glob.sh: use the $( ... ) construct for command\n substitution\n t9109-git-svn-multi-glob.sh: use the $( ... ) construct for command\n substitution\n t9110-git-svn-use-svm-props.sh: use the $( ... ) construct for\n command substitution\n t9114-git-svn-dcommit-merge.sh: use the $( ... ) construct for\n command substitution\n t9118-git-svn-funky-branch-names.sh: use the $( ... ) construct for\n command substitution\n t9119-git-svn-info.sh: use the $( ... ) construct for command\n substitution\n t9129-git-svn-i18n-commitencoding.sh: use the $( ... ) construct for\n command substitution\n t9130-git-svn-authors-file.sh: use the $( ... ) construct for command\n substitution\n t9132-git-svn-broken-symlink.sh: use the $( ... ) construct for\n command substitution\n t9137-git-svn-dcommit-clobber-series.sh: use the $( ... ) construct\n for command substitution\n t9138-git-svn-authors-prog.sh: use the $( ... ) construct for command\n substitution\n t9145-git-svn-master-branch.sh: use the $( ... ) construct for\n command substitution\n t9150-svk-mergetickets.sh: use the $( ... ) construct for command\n substitution\n t9300-fast-import.sh: use the $( ... ) construct for command\n substitution\n t9350-fast-export.sh: use the $( ... ) construct for command\n substitution\n t9501-gitweb-standalone-http-status.sh: use the $( ... ) construct\n for command substitution\n t9901-git-web--browse.sh: use the $( ... ) construct for command\n substitution\n test-lib-functions.sh: use the $( ... ) construct for command\n substitution\n lib-credential.sh: use the $( ... ) construct for command\n substitution\n lib-cvs.sh: use the $( ... ) construct for command substitution\n lib-gpg.sh: use the $( ... ) construct for command substitution\n p5302-pack-index.sh: use the $( ... ) construct for command\n substitution\n howto-index.sh: use the $( ... ) construct for command substitution\n install-webdoc.sh: use the $( ... ) construct for command\n substitution\n git-checkout.sh: use the $( ... ) construct for command substitution\n git-clone.sh: use the $( ... ) construct for command substitution\n git-commit.sh: use the $( ... ) construct for command substitution\n git-fetch.sh: use the $( ... ) construct for command substitution\n git-ls-remote.sh: use the $( ... ) construct for command substitution\n git-merge.sh: use the $( ... ) construct for command substitution\n git-repack.sh: use the $( ... ) construct for command substitution\n git-resolve.sh: use the $( ... ) construct for command substitution\n git-revert.sh: use the $( ... ) construct for command substitution\n git-tag.sh: use the $( ... ) construct for command substitution\n t9360-mw-to-git-clone.sh: use the $( ... ) construct for command\n substitution\n t9362-mw-to-git-utf8.sh: use the $( ... ) construct for command\n substitution\n t9365-continuing-queries.sh: use the $( ... ) construct for command\n substitution\n test-gitmw-lib.sh: use the $( ... ) construct for command\n substitution\n t7900-subtree.sh: use the $( ... ) construct for command substitution\n appp.sh: use the $( ... ) construct for command substitution\n txt-to-pot.sh: use the $( ... ) construct for command substitution\n t9100-git-svn-basic.sh: use the $( ... ) construct for command\n substitution\n\n Documentation/howto-index.sh | 12 ++--\n Documentation/install-webdoc.sh | 6 +-\n check-builtins.sh | 4 +-\n contrib/examples/git-checkout.sh | 8 +--\n contrib/examples/git-clone.sh | 20 +++----\n contrib/examples/git-commit.sh | 10 ++--\n contrib/examples/git-fetch.sh | 6 +-\n contrib/examples/git-ls-remote.sh | 4 +-\n contrib/examples/git-merge.sh | 4 +-\n contrib/examples/git-repack.sh | 2 +-\n contrib/examples/git-resolve.sh | 2 +-\n contrib/examples/git-revert.sh | 2 +-\n contrib/examples/git-tag.sh | 2 +-\n contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 14 ++---\n contrib/mw-to-git/t/t9362-mw-to-git-utf8.sh | 4 +-\n contrib/mw-to-git/t/t9365-continuing-queries.sh | 2 +-\n contrib/mw-to-git/t/test-gitmw-lib.sh | 6 +-\n contrib/subtree/t/t7900-subtree.sh | 2 +-\n contrib/thunderbird-patch-inline/appp.sh | 14 ++---\n git-am.sh | 30 +++++-----\n git-gui/po/glossary/txt-to-pot.sh | 4 +-\n git-pull.sh | 2 +-\n git-rebase--merge.sh | 4 +-\n git-rebase.sh | 8 +--\n git-stash.sh | 2 +-\n git-web--browse.sh | 6 +-\n t/lib-credential.sh | 2 +-\n t/lib-cvs.sh | 2 +-\n t/lib-gpg.sh | 2 +-\n t/perf/p5302-pack-index.sh | 2 +-\n t/t0001-init.sh | 12 ++--\n t/t0010-racy-git.sh | 4 +-\n t/t0020-crlf.sh | 42 +++++++-------\n t/t0025-crlf-auto.sh | 38 ++++++-------\n t/t0026-eol-config.sh | 20 +++----\n t/t0030-stripspace.sh | 20 +++----\n t/t0300-credentials.sh | 2 +-\n t/t1000-read-tree-m-3way.sh | 4 +-\n t/t1001-read-tree-m-2way.sh | 18 +++---\n t/t1002-read-tree-m-u-2way.sh | 10 ++--\n t/t1003-read-tree-prefix.sh | 2 +-\n t/t1004-read-tree-m-u-wf.sh | 8 +--\n t/t1020-subdirectory.sh | 22 ++++----\n t/t1050-large.sh | 4 +-\n t/t1100-commit-tree-options.sh | 4 +-\n t/t1401-symbolic-ref.sh | 2 +-\n t/t1410-reflog.sh | 24 ++++----\n t/t1511-rev-parse-caret.sh | 4 +-\n t/t1512-rev-parse-disambiguation.sh | 8 +--\n t/t2102-update-index-symlinks.sh | 2 +-\n t/t3030-merge-recursive.sh | 2 +-\n t/t3100-ls-tree-restrict.sh | 2 +-\n t/t3101-ls-tree-dirname.sh | 2 +-\n t/t3210-pack-refs.sh | 2 +-\n t/t3403-rebase-skip.sh | 2 +-\n t/t3511-cherry-pick-x.sh | 14 ++---\n t/t3600-rm.sh | 4 +-\n t/t3700-add.sh | 16 +++---\n t/t3905-stash-include-untracked.sh | 4 +-\n t/t3910-mac-os-precompose.sh | 16 +++---\n t/t4006-diff-mode.sh | 2 +-\n t/t4010-diff-pathspec.sh | 4 +-\n t/t4012-diff-binary.sh | 16 +++---\n t/t4013-diff-various.sh | 6 +-\n t/t4014-format-patch.sh | 10 ++--\n t/t4036-format-patch-signer-mime.sh | 2 +-\n t/t4038-diff-combined.sh | 2 +-\n t/t4057-diff-combined-paths.sh | 2 +-\n t/t4116-apply-reverse.sh | 12 ++--\n t/t4119-apply-config.sh | 2 +-\n t/t4204-patch-id.sh | 4 +-\n t/t5000-tar-tree.sh | 6 +-\n t/t5003-archive-zip.sh | 2 +-\n t/t5100-mailinfo.sh | 12 ++--\n t/t5300-pack-object.sh | 18 +++---\n t/t5301-sliding-window.sh | 14 ++---\n t/t5302-pack-index.sh | 34 ++++++------\n t/t5303-pack-corruption-resilience.sh | 8 +--\n t/t5304-prune.sh | 2 +-\n t/t5305-include-tag.sh | 8 +--\n t/t5500-fetch-pack.sh | 16 +++---\n t/t5505-remote.sh | 2 +-\n t/t5506-remote-groups.sh | 2 +-\n t/t5510-fetch.sh | 10 ++--\n t/t5515-fetch-merge-logic.sh | 4 +-\n t/t5516-fetch-push.sh | 4 +-\n t/t5517-push-mirror.sh | 2 +-\n t/t5520-pull.sh | 10 ++--\n t/t5522-pull-symlink.sh | 2 +-\n t/t5530-upload-pack-error.sh | 2 +-\n t/t5537-fetch-shallow.sh | 4 +-\n t/t5538-push-shallow.sh | 4 +-\n t/t5550-http-fetch-dumb.sh | 8 +--\n t/t5551-http-fetch-smart.sh | 2 +-\n t/t5570-git-daemon.sh | 8 +--\n t/t5601-clone.sh | 2 +-\n t/t5700-clone-reference.sh | 2 +-\n t/t5710-info-alternate.sh | 2 +-\n t/t5900-repo-selection.sh | 2 +-\n t/t6001-rev-list-graft.sh | 12 ++--\n t/t6002-rev-list-bisect.sh | 6 +-\n t/t6015-rev-list-show-all-parents.sh | 6 +-\n t/t6032-merge-large-rename.sh | 2 +-\n t/t6034-merge-rename-nocruft.sh | 2 +-\n t/t6132-pathspec-exclude.sh | 2 +-\n t/t7001-mv.sh | 4 +-\n t/t7003-filter-branch.sh | 6 +-\n t/t7004-tag.sh | 16 +++---\n t/t7006-pager.sh | 2 +-\n t/t7103-reset-bare.sh | 2 +-\n t/t7406-submodule-update.sh | 4 +-\n t/t7408-submodule-reference.sh | 2 +-\n t/t7504-commit-msg-hook.sh | 2 +-\n t/t7505-prepare-commit-msg-hook.sh | 32 +++++------\n t/t7602-merge-octopus-many.sh | 8 +--\n t/t7700-repack.sh | 4 +-\n t/t8003-blame-corner-cases.sh | 4 +-\n t/t9001-send-email.sh | 10 ++--\n t/t9100-git-svn-basic.sh | 24 ++++----\n t/t9101-git-svn-props.sh | 30 +++++-----\n t/t9104-git-svn-follow-parent.sh | 48 ++++++++--------\n t/t9105-git-svn-commit-diff.sh | 4 +-\n t/t9107-git-svn-migrate.sh | 16 +++---\n t/t9108-git-svn-glob.sh | 20 +++----\n t/t9109-git-svn-multi-glob.sh | 32 +++++------\n t/t9110-git-svn-use-svm-props.sh | 2 +-\n t/t9114-git-svn-dcommit-merge.sh | 12 ++--\n t/t9118-git-svn-funky-branch-names.sh | 2 +-\n t/t9119-git-svn-info.sh | 2 +-\n t/t9129-git-svn-i18n-commitencoding.sh | 4 +-\n t/t9130-git-svn-authors-file.sh | 12 ++--\n t/t9132-git-svn-broken-symlink.sh | 4 +-\n t/t9137-git-svn-dcommit-clobber-series.sh | 24 ++++----\n t/t9138-git-svn-authors-prog.sh | 2 +-\n t/t9145-git-svn-master-branch.sh | 4 +-\n t/t9150-svk-mergetickets.sh | 2 +-\n t/t9300-fast-import.sh | 68 +++++++++++------------\n t/t9350-fast-export.sh | 6 +-\n t/t9501-gitweb-standalone-http-status.sh | 6 +-\n t/t9901-git-web--browse.sh | 2 +-\n t/test-lib-functions.sh | 8 +--\n unimplemented.sh | 2 +-\n 142 files changed, 609 insertions(+), 609 deletions(-)\n\n-- \n1.7.10.4\n"},{"id":"237757","messageId":"1395768283-31135-2-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:22Z","receivedAt":"2014-03-25T17:22:22Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n check-builtins.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/check-builtins.sh b/check-builtins.sh\nindex d6fe6cf..07cff69 100755\n--- a/check-builtins.sh\n+++ b/check-builtins.sh\n@@ -14,8 +14,8 @@ sort |\n bad=0\n while read builtin\n do\n-\tbase=`expr \"$builtin\" : 'git-\\(.*\\)'`\n-\tx=`sed -ne 's/.*{ \"'$base'\", \\(cmd_[^, ]*\\).*/'$base'\t\\1/p' git.c`\n+\tbase=$(expr \"$builtin\" : 'git-\\(.*\\)')\n+\tx=$(sed -ne 's/.*{ \"'$base'\", \\(cmd_[^, ]*\\).*/'$base'\t\\1/p' git.c)\n \tif test -z \"$x\"\n \tthen\n \t\techo \"$base is builtin but not listed in git.c command list\"\n-- \n1.7.10.4\n"},{"id":"237761","messageId":"1395768283-31135-3-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 002/142] git-am.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:23Z","receivedAt":"2014-03-25T17:22:23Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n git-am.sh | 30 +++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex 78517f2..1b638e8 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -125,7 +125,7 @@ cannot_fallback () {\n }\n \n fall_back_3way () {\n- O_OBJECT=`cd \"$GIT_OBJECT_DIRECTORY\" && pwd`\n+ O_OBJECT=$(cd \"$GIT_OBJECT_DIRECTORY\" && pwd)\n \n rm -fr \"$dotest\"/patch-merge-*\n mkdir \"$dotest/patch-merge-tmp-dir\"\n@@ -275,7 +275,7 @@ split_patches () {\n \t\tthen\n \t\t\tclean_abort \"$(gettext \"Only one StGIT patch series can be applied at once\")\"\n \t\tfi\n-\t\tseries_dir=`dirname \"$1\"`\n+\t\tseries_dir=$(dirname \"$1\")\n \t\tseries_file=\"$1\"\n \t\tshift\n \t\t{\n@@ -298,8 +298,8 @@ split_patches () {\n \t\tthis=0\n \t\tfor stgit in \"$@\"\n \t\tdo\n-\t\t\tthis=`expr \"$this\" + 1`\n-\t\t\tmsgnum=`printf \"%0${prec}d\" $this`\n+\t\t\tthis=$(expr \"$this\" + 1)\n+\t\t\tmsgnum=$(printf \"%0${prec}d\" $this)\n \t\t\t# Perl version of StGIT parse_patch. The first nonemptyline\n \t\t\t# not starting with Author, From or Date is the\n \t\t\t# subject, and the body starts with the next nonempty\n@@ -644,26 +644,26 @@ fi\n git_apply_opt=$(cat \"$dotest/apply-opt\")\n if test \"$(cat \"$dotest/sign\")\" = t\n then\n-\tSIGNOFF=`git var GIT_COMMITTER_IDENT | sed -e '\n+\tSIGNOFF=$(git var GIT_COMMITTER_IDENT | sed -e '\n \t\t\ts/>.*/>/\n \t\t\ts/^/Signed-off-by: /'\n-\t\t`\n+\t\t)\n else\n \tSIGNOFF=\n fi\n \n-last=`cat \"$dotest/last\"`\n-this=`cat \"$dotest/next\"`\n+last=$(cat \"$dotest/last\")\n+this=$(cat \"$dotest/next\")\n if test \"$skip\" = t\n then\n-\tthis=`expr \"$this\" + 1`\n+\tthis=$(expr \"$this\" + 1)\n \tresume=\n fi\n \n while test \"$this\" -le \"$last\"\n do\n-\tmsgnum=`printf \"%0${prec}d\" $this`\n-\tnext=`expr \"$this\" + 1`\n+\tmsgnum=$(printf \"%0${prec}d\" $this)\n+\tnext=$(expr \"$this\" + 1)\n \ttest -f \"$dotest/$msgnum\" || {\n \t\tresume=\n \t\tgo_next\n@@ -739,16 +739,16 @@ To restore the original branch and stop patching run \\\"\\$cmdline --abort\\\".\"\n \t'')\n \t if test '' != \"$SIGNOFF\"\n \t then\n-\t\tLAST_SIGNED_OFF_BY=`\n+\t\tLAST_SIGNED_OFF_BY=$(\n \t\t sed -ne '/^Signed-off-by: /p' \\\n \t\t \"$dotest/msg-clean\" |\n \t\t sed -ne '$p'\n-\t\t`\n-\t\tADD_SIGNOFF=`\n+\t\t)\n+\t\tADD_SIGNOFF=$(\n \t\t test \"$LAST_SIGNED_OFF_BY\" = \"$SIGNOFF\" || {\n \t\t test '' = \"$LAST_SIGNED_OFF_BY\" && echo\n \t\t echo \"$SIGNOFF\"\n-\t\t}`\n+\t\t})\n \t else\n \t\tADD_SIGNOFF=\n \t fi\n-- \n1.7.10.4\n"},{"id":"237762","messageId":"1395768283-31135-4-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 003/142] git-pull.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:24Z","receivedAt":"2014-03-25T17:22:24Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n git-pull.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-pull.sh b/git-pull.sh\nindex 6cd8ebc..cfc589d 100755\n--- a/git-pull.sh\n+++ b/git-pull.sh\n@@ -108,7 +108,7 @@ do\n \t-s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tstrategy=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'` ;;\n+\t\t\tstrategy=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)') ;;\n \t\t1,*)\n \t\t\tusage ;;\n \t\t*)\n-- \n1.7.10.4\n"},{"id":"237680","messageId":"1395768283-31135-5-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 004/142] git-rebase--merge.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:25Z","receivedAt":"2014-03-25T17:22:25Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n git-rebase--merge.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-rebase--merge.sh b/git-rebase--merge.sh\nindex 5381857..dc064f8 100644\n--- a/git-rebase--merge.sh\n+++ b/git-rebase--merge.sh\n@@ -24,7 +24,7 @@ continue_merge () {\n \t\tdie \"$resolvemsg\"\n \tfi\n \n-\tcmt=`cat \"$state_dir/current\"`\n+\tcmt=$(cat \"$state_dir/current\")\n \tif ! git diff-index --quiet --ignore-submodules HEAD --\n \tthen\n \t\tif ! git commit ${gpg_sign_opt:+\"$gpg_sign_opt\"} --no-verify -C \"$cmt\"\n@@ -132,7 +132,7 @@ echo \"$onto_name\" > \"$state_dir/onto_name\"\n write_basic_state\n \n msgnum=0\n-for cmt in `git rev-list --reverse --no-merges \"$revisions\"`\n+for cmt in $(git rev-list --reverse --no-merges \"$revisions\")\n do\n \tmsgnum=$(($msgnum + 1))\n \techo \"$cmt\" > \"$state_dir/cmt.$msgnum\"\n-- \n1.7.10.4\n"},{"id":"237723","messageId":"1395768283-31135-6-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 005/142] git-rebase.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:26Z","receivedAt":"2014-03-25T17:22:26Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n git-rebase.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/git-rebase.sh b/git-rebase.sh\nindex 5f6732b..a209ab9 100755\n--- a/git-rebase.sh\n+++ b/git-rebase.sh\n@@ -462,8 +462,8 @@ then\n else\n \tif test -z \"$onto\"\n \tthen\n-\t\tempty_tree=`git hash-object -t tree /dev/null`\n-\t\tonto=`git commit-tree $empty_tree \n---\n git-stash.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 4798bcf..af549c7 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -13,7 +13,7 @@ USAGE=\"list []\n \n SUBDIRECTORY_OK=Yes\n OPTIONS_SPEC=\n-START_DIR=`pwd`\n+START_DIR=$(pwd)\n . git-sh-setup\n . git-sh-i18n\n require_work_tree\n-- \n1.7.10.4\n"},{"id":"237674","messageId":"1395768283-31135-8-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 007/142] git-web--browse.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:28Z","receivedAt":"2014-03-25T17:22:28Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n git-web--browse.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/git-web--browse.sh b/git-web--browse.sh\nindex ebdfba6..ae15253 100755\n--- a/git-web--browse.sh\n+++ b/git-web--browse.sh\n@@ -59,7 +59,7 @@ do\n \t-b|--browser*|-t|--tool*)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tbrowser=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'`\n+\t\t\tbrowser=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)')\n \t\t\t;;\n \t\t1,*)\n \t\t\tusage ;;\n@@ -71,7 +71,7 @@ do\n \t-c|--config*)\n \t\tcase \"$#,$1\" in\n \t\t*,*=*)\n-\t\t\tconf=`expr \"z$1\" : 'z-[^=]*=\\(.*\\)'`\n+\t\t\tconf=$(expr \"z$1\" : 'z-[^=]*=\\(.*\\)')\n \t\t\t;;\n \t\t1,*)\n \t\t\tusage ;;\n@@ -100,7 +100,7 @@ then\n \tfor opt in \"$conf\" \"web.browser\"\n \tdo\n \t\ttest -z \"$opt\" && continue\n-\t\tbrowser=\"`git config $opt`\"\n+\t\tbrowser=\"$(git config $opt)\"\n \t\ttest -z \"$browser\" || break\n \tdone\n \tif test -n \"$browser\" && ! valid_tool \"$browser\"; then\n-- \n1.7.10.4\n"},{"id":"237758","messageId":"1395768283-31135-9-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 008/142] unimplemented.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:29Z","receivedAt":"2014-03-25T17:22:29Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n unimplemented.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/unimplemented.sh b/unimplemented.sh\nindex 5252de4..fee21d2 100644\n--- a/unimplemented.sh\n+++ b/unimplemented.sh\n@@ -1,4 +1,4 @@\n #!/bin/sh\n \n-echo >&2 \"fatal: git was built without support for `basename $0` (@@REASON@@).\"\n+echo >&2 \"fatal: git was built without support for $(basename $0) (@@REASON@@).\"\n exit 128\n-- \n1.7.10.4\n"},{"id":"237679","messageId":"1395768283-31135-10-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 009/142] t0001-init.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:30Z","receivedAt":"2014-03-25T17:22:30Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0001-init.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t0001-init.sh b/t/t0001-init.sh\nindex 9fb582b..32821fe 100755\n--- a/t/t0001-init.sh\n+++ b/t/t0001-init.sh\n@@ -250,7 +250,7 @@ test_expect_success 'init --bare/--shared overrides system/global config' '\n \t) &&\n \tcheck_config init-bare-shared-override true unset &&\n \ttest x0666 = \\\n-\tx`git config -f init-bare-shared-override/config core.sharedRepository`\n+\tx$(git config -f init-bare-shared-override/config core.sharedRepository)\n '\n \n test_expect_success 'init honors global core.sharedRepository' '\n@@ -262,7 +262,7 @@ test_expect_success 'init honors global core.sharedRepository' '\n \t\tgit init\n \t) &&\n \ttest x0666 = \\\n-\tx`git config -f shared-honor-global/.git/config core.sharedRepository`\n+\tx$(git config -f shared-honor-global/.git/config core.sharedRepository)\n '\n \n test_expect_success 'init rejects insanely long --template' '\n@@ -374,7 +374,7 @@ test_expect_success 'init prefers command line to GIT_DIR' '\n test_expect_success 'init with separate gitdir' '\n \trm -rf newdir &&\n \tgit init --separate-git-dir realgitdir newdir &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest -d realgitdir/refs\n '\n@@ -388,7 +388,7 @@ test_expect_success 're-init to update git link' '\n \tcd newdir &&\n \tgit init --separate-git-dir ../surrealgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/surrealgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/surrealgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest -d surrealgitdir/refs &&\n \t! test -d realgitdir/refs\n@@ -401,7 +401,7 @@ test_expect_success 're-init to move gitdir' '\n \tcd newdir &&\n \tgit init --separate-git-dir ../realgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest -d realgitdir/refs\n '\n@@ -415,7 +415,7 @@ test_expect_success SYMLINKS 're-init to move gitdir symlink' '\n \tln -s here .git &&\n \tgit init --separate-git-dir ../realgitdir\n \t) &&\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected newdir/.git &&\n \ttest -d realgitdir/refs &&\n \t! test -d newdir/here\n-- \n1.7.10.4\n"},{"id":"237677","messageId":"1395768283-31135-11-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 010/142] t0010-racy-git.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:31Z","receivedAt":"2014-03-25T17:22:31Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0010-racy-git.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0010-racy-git.sh b/t/t0010-racy-git.sh\nindex e45a9e4..5657c5a 100755\n--- a/t/t0010-racy-git.sh\n+++ b/t/t0010-racy-git.sh\n@@ -14,7 +14,7 @@ do\n \tgit update-index --add infocom\n \techo xyzzy >infocom\n \n-\tfiles=`git diff-files -p`\n+\tfiles=$(git diff-files -p)\n \ttest_expect_success \\\n \t\"Racy GIT trial #$trial part A\" \\\n \t'test \"\" != \"$files\"'\n@@ -23,7 +23,7 @@ do\n \techo xyzzy >cornerstone\n \tgit update-index --add cornerstone\n \n-\tfiles=`git diff-files -p`\n+\tfiles=$(git diff-files -p)\n \ttest_expect_success \\\n \t\"Racy GIT trial #$trial part B\" \\\n \t'test \"\" != \"$files\"'\n-- \n1.7.10.4\n"},{"id":"237759","messageId":"1395768283-31135-12-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 011/142] t0020-crlf.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:32Z","receivedAt":"2014-03-25T17:22:32Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0020-crlf.sh | 42 +++++++++++++++++++++---------------------\n 1 file changed, 21 insertions(+), 21 deletions(-)\n\ndiff --git a/t/t0020-crlf.sh b/t/t0020-crlf.sh\nindex e526184..d2e51a8 100755\n--- a/t/t0020-crlf.sh\n+++ b/t/t0020-crlf.sh\n@@ -20,14 +20,14 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\tdir=`git rev-parse HEAD:dir` &&\n-\ttwo=`git rev-parse HEAD:dir/two` &&\n-\tthree=`git rev-parse HEAD:three` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\tdir=$(git rev-parse HEAD:dir) &&\n+\ttwo=$(git rev-parse HEAD:dir/two) &&\n+\tthree=$(git rev-parse HEAD:three) &&\n \n \tfor w in Some extra lines here; do echo $w; done >>one &&\n \tgit diff >patch.file &&\n-\tpatched=`git hash-object --stdin \n---\n t/t0025-crlf-auto.sh | 38 +++++++++++++++++++-------------------\n 1 file changed, 19 insertions(+), 19 deletions(-)\n\ndiff --git a/t/t0025-crlf-auto.sh b/t/t0025-crlf-auto.sh\nindex f5f67a6..b0e5694 100755\n--- a/t/t0025-crlf-auto.sh\n+++ b/t/t0025-crlf-auto.sh\n@@ -19,9 +19,9 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\ttwo=`git rev-parse HEAD:two` &&\n-\tthree=`git rev-parse HEAD:three` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\ttwo=$(git rev-parse HEAD:two) &&\n+\tthree=$(git rev-parse HEAD:three) &&\n \n \techo happy.\n '\n@@ -33,9 +33,9 @@ test_expect_success 'default settings cause no changes' '\n \n \t! has_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -48,7 +48,7 @@ test_expect_success 'crlf=true causes a CRLF file to be normalized' '\n \n \t# Note, \"normalized\" means that git will normalize it if added\n \thas_cr two &&\n-\ttwodiff=`git diff two` &&\n+\ttwodiff=$(git diff two) &&\n \ttest -n \"$twodiff\"\n '\n \n@@ -60,7 +60,7 @@ test_expect_success 'text=true causes a CRLF file to be normalized' '\n \n \t# Note, \"normalized\" means that git will normalize it if added\n \thas_cr two &&\n-\ttwodiff=`git diff two` &&\n+\ttwodiff=$(git diff two) &&\n \ttest -n \"$twodiff\"\n '\n \n@@ -72,7 +72,7 @@ test_expect_success 'eol=crlf gives a normalized file CRLFs with autocrlf=false'\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -84,7 +84,7 @@ test_expect_success 'eol=crlf gives a normalized file CRLFs with autocrlf=input'\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -96,7 +96,7 @@ test_expect_success 'eol=lf gives a normalized file LFs with autocrlf=true' '\n \tgit read-tree --reset -u HEAD &&\n \n \t! has_cr one &&\n-\tonediff=`git diff one` &&\n+\tonediff=$(git diff one) &&\n \ttest -z \"$onediff\"\n '\n \n@@ -108,9 +108,9 @@ test_expect_success 'autocrlf=true does not normalize CRLF files' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -123,9 +123,9 @@ test_expect_success 'text=auto, autocrlf=true _does_ normalize CRLF files' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n-\tthreediff=`git diff three` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$onediff\" -a -n \"$twodiff\" -a -z \"$threediff\"\n '\n \n@@ -137,7 +137,7 @@ test_expect_success 'text=auto, autocrlf=true does not normalize binary files' '\n \tgit read-tree --reset -u HEAD &&\n \n \t! has_cr three &&\n-\tthreediff=`git diff three` &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$threediff\"\n '\n \n@@ -148,7 +148,7 @@ test_expect_success 'eol=crlf _does_ normalize binary files' '\n \tgit read-tree --reset -u HEAD &&\n \n \thas_cr three &&\n-\tthreediff=`git diff three` &&\n+\tthreediff=$(git diff three) &&\n \ttest -z \"$threediff\"\n '\n \n-- \n1.7.10.4\n"},{"id":"237676","messageId":"1395768283-31135-14-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 013/142] t0026-eol-config.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:34Z","receivedAt":"2014-03-25T17:22:34Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0026-eol-config.sh | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t0026-eol-config.sh b/t/t0026-eol-config.sh\nindex fe0164b..e1126aa 100755\n--- a/t/t0026-eol-config.sh\n+++ b/t/t0026-eol-config.sh\n@@ -20,8 +20,8 @@ test_expect_success setup '\n \n \tgit commit -m initial &&\n \n-\tone=`git rev-parse HEAD:one` &&\n-\ttwo=`git rev-parse HEAD:two` &&\n+\tone=$(git rev-parse HEAD:one) &&\n+\ttwo=$(git rev-parse HEAD:two) &&\n \n \techo happy.\n '\n@@ -34,8 +34,8 @@ test_expect_success 'eol=lf puts LFs in normalized file' '\n \n \t! has_cr one &&\n \t! has_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -47,8 +47,8 @@ test_expect_success 'eol=crlf puts CRLFs in normalized file' '\n \n \thas_cr one &&\n \t! has_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -61,8 +61,8 @@ test_expect_success 'autocrlf=true overrides eol=lf' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n@@ -75,8 +75,8 @@ test_expect_success 'autocrlf=true overrides unset eol' '\n \n \thas_cr one &&\n \thas_cr two &&\n-\tonediff=`git diff one` &&\n-\ttwodiff=`git diff two` &&\n+\tonediff=$(git diff one) &&\n+\ttwodiff=$(git diff two) &&\n \ttest -z \"$onediff\" -a -z \"$twodiff\"\n '\n \n-- \n1.7.10.4\n"},{"id":"237756","messageId":"1395768283-31135-15-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 014/142] t0030-stripspace.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:35Z","receivedAt":"2014-03-25T17:22:35Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0030-stripspace.sh | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh\nindex a8e84d8..0333dd9 100755\n--- a/t/t0030-stripspace.sh\n+++ b/t/t0030-stripspace.sh\n@@ -225,22 +225,22 @@ test_expect_success \\\n \n test_expect_success \\\n 'text without newline at end should end with newline' '\n- test `printf \"$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt$ttt\" | git stripspace | wc -l` -gt 0\n+ test $(printf \"$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt$ttt\" | git stripspace | wc -l) -gt 0\n '\n \n # text plus spaces at the end:\n \n test_expect_success \\\n 'text plus spaces without newline at end should end with newline' '\n- test `printf \"$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$ttt$sss$sss\" | git stripspace | wc -l` -gt 0 &&\n- test `printf \"$ttt$sss$sss$sss\" | git stripspace | wc -l` -gt 0\n+ test $(printf \"$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$ttt$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$sss$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$ttt$sss$sss\" | git stripspace | wc -l) -gt 0 &&\n+ test $(printf \"$ttt$sss$sss$sss\" | git stripspace | wc -l) -gt 0\n '\n \n test_expect_success \\\n-- \n1.7.10.4\n"},{"id":"237741","messageId":"1395768283-31135-16-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 015/142] t0300-credentials.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:36Z","receivedAt":"2014-03-25T17:22:36Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t0300-credentials.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh\nindex 538ea5f..57ea5a1 100755\n--- a/t/t0300-credentials.sh\n+++ b/t/t0300-credentials.sh\n@@ -6,7 +6,7 @@ test_description='basic credential helper tests'\n \n test_expect_success 'setup helper scripts' '\n \tcat >dump <<-\\EOF &&\n-\twhoami=`echo $0 | sed s/.*git-credential-//`\n+\twhoami=$(echo $0 | sed s/.*git-credential-//)\n \techo >&2 \"$whoami: $*\"\n \tOIFS=$IFS\n \tIFS==\n-- \n1.7.10.4\n"},{"id":"237751","messageId":"1395768283-31135-17-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 016/142] t1000-read-tree-m-3way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:37Z","receivedAt":"2014-03-25T17:22:37Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1000-read-tree-m-3way.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1000-read-tree-m-3way.sh b/t/t1000-read-tree-m-3way.sh\nindex babcdd2..a0b79b4 100755\n--- a/t/t1000-read-tree-m-3way.sh\n+++ b/t/t1000-read-tree-m-3way.sh\n@@ -519,10 +519,10 @@ test_expect_success \\\n 'rm -f .git/index F16 &&\n echo F16 >F16 &&\n git update-index --add F16 &&\n- tree0=`git write-tree` &&\n+ tree0=$(git write-tree) &&\n echo E16 >F16 &&\n git update-index F16 &&\n- tree1=`git write-tree` &&\n+ tree1=$(git write-tree) &&\n read_tree_must_succeed -m $tree0 $tree1 $tree1 $tree0 &&\n git ls-files --stage'\n \n-- \n1.7.10.4\n"},{"id":"237755","messageId":"1395768283-31135-18-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 017/142] t1001-read-tree-m-2way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:38Z","receivedAt":"2014-03-25T17:22:38Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1001-read-tree-m-2way.sh | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/t/t1001-read-tree-m-2way.sh b/t/t1001-read-tree-m-2way.sh\nindex acaab07..f0d8eb9 100755\n--- a/t/t1001-read-tree-m-2way.sh\n+++ b/t/t1001-read-tree-m-2way.sh\n@@ -36,7 +36,7 @@ compare_change () {\n }\n \n check_cache_at () {\n-\tclean_if_empty=`git diff-files -- \"$1\"`\n+\tclean_if_empty=$(git diff-files -- \"$1\")\n \tcase \"$clean_if_empty\" in\n \t'') echo \"$1: clean\" ;;\n \t?*) echo \"$1: dirty\" ;;\n@@ -68,14 +68,14 @@ test_expect_success \\\n echo rezrov >rezrov &&\n echo yomin >yomin &&\n git update-index --add nitfol bozbar rezrov &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH &&\n \n cat bozbar-new >bozbar &&\n git update-index --add frotz bozbar --force-remove rezrov &&\n git ls-files --stage >M.out &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git diff-tree $treeH $treeM'\n@@ -315,7 +315,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n echo DF >DF &&\n git update-index --add DF &&\n- treeDF=`git write-tree` &&\n+ treeDF=$(git write-tree) &&\n echo treeDF $treeDF &&\n git ls-tree $treeDF &&\n \n@@ -323,7 +323,7 @@ test_expect_success \\\n mkdir DF &&\n echo DF/DF >DF/DF &&\n git update-index --add --remove DF DF/DF &&\n- treeDFDF=`git write-tree` &&\n+ treeDFDF=$(git write-tree) &&\n echo treeDFDF $treeDFDF &&\n git ls-tree $treeDFDF &&\n git ls-files --stage >DFDF.out'\n@@ -345,7 +345,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n : >a &&\n git update-index --add a &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git ls-files --stage >treeM.out &&\n@@ -354,7 +354,7 @@ test_expect_success \\\n git update-index --remove a &&\n mkdir a &&\n : >a/b &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH'\n \n@@ -372,7 +372,7 @@ test_expect_success \\\n mkdir c &&\n : >c/d &&\n git update-index --add a c/d &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n git ls-files --stage >treeM.out &&\n@@ -381,7 +381,7 @@ test_expect_success \\\n mkdir a &&\n : >a/b &&\n git update-index --add --remove a a/b &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH'\n \n-- \n1.7.10.4\n"},{"id":"237744","messageId":"1395768283-31135-19-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 018/142] t1002-read-tree-m-u-2way.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:39Z","receivedAt":"2014-03-25T17:22:39Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1002-read-tree-m-u-2way.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t1002-read-tree-m-u-2way.sh b/t/t1002-read-tree-m-u-2way.sh\nindex a847709..fed877b 100755\n--- a/t/t1002-read-tree-m-u-2way.sh\n+++ b/t/t1002-read-tree-m-u-2way.sh\n@@ -21,7 +21,7 @@ compare_change () {\n }\n \n check_cache_at () {\n-\tclean_if_empty=`git diff-files -- \"$1\"`\n+\tclean_if_empty=$(git diff-files -- \"$1\")\n \tcase \"$clean_if_empty\" in\n \t'') echo \"$1: clean\" ;;\n \t?*) echo \"$1: dirty\" ;;\n@@ -41,14 +41,14 @@ test_expect_success \\\n echo bozbar >bozbar &&\n echo rezrov >rezrov &&\n git update-index --add nitfol bozbar rezrov &&\n- treeH=`git write-tree` &&\n+ treeH=$(git write-tree) &&\n echo treeH $treeH &&\n git ls-tree $treeH &&\n \n echo gnusto >bozbar &&\n git update-index --add frotz bozbar --force-remove rezrov &&\n git ls-files --stage >M.out &&\n- treeM=`git write-tree` &&\n+ treeM=$(git write-tree) &&\n echo treeM $treeM &&\n git ls-tree $treeM &&\n sum bozbar frotz nitfol >M.sum &&\n@@ -318,7 +318,7 @@ test_expect_success \\\n 'rm -f .git/index &&\n echo DF >DF &&\n git update-index --add DF &&\n- treeDF=`git write-tree` &&\n+ treeDF=$(git write-tree) &&\n echo treeDF $treeDF &&\n git ls-tree $treeDF &&\n \n@@ -326,7 +326,7 @@ test_expect_success \\\n mkdir DF &&\n echo DF/DF >DF/DF &&\n git update-index --add --remove DF DF/DF &&\n- treeDFDF=`git write-tree` &&\n+ treeDFDF=$(git write-tree) &&\n echo treeDFDF $treeDFDF &&\n git ls-tree $treeDFDF &&\n git ls-files --stage >DFDF.out'\n-- \n1.7.10.4\n"},{"id":"237675","messageId":"1395768283-31135-20-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 019/142] t1003-read-tree-prefix.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:40Z","receivedAt":"2014-03-25T17:22:40Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1003-read-tree-prefix.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1003-read-tree-prefix.sh b/t/t1003-read-tree-prefix.sh\nindex 8c6d67e..b6111cd 100755\n--- a/t/t1003-read-tree-prefix.sh\n+++ b/t/t1003-read-tree-prefix.sh\n@@ -11,7 +11,7 @@ test_description='git read-tree --prefix test.\n test_expect_success setup '\n \techo hello >one &&\n \tgit update-index --add one &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo tree is $tree\n '\n \n-- \n1.7.10.4\n"},{"id":"237742","messageId":"1395768283-31135-21-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 020/142] t1004-read-tree-m-u-wf.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:41Z","receivedAt":"2014-03-25T17:22:41Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1004-read-tree-m-u-wf.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1004-read-tree-m-u-wf.sh b/t/t1004-read-tree-m-u-wf.sh\nindex 3e72aff..c70cf42 100755\n--- a/t/t1004-read-tree-m-u-wf.sh\n+++ b/t/t1004-read-tree-m-u-wf.sh\n@@ -30,7 +30,7 @@ test_expect_success 'two-way not clobbering' '\n \n \techo >file2 master creates untracked file2 &&\n \techo >subdir/file2 master creates untracked subdir/file2 &&\n-\tif err=`read_tree_u_must_succeed -m -u master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -43,7 +43,7 @@ echo file2 >.gitignore\n \n test_expect_success 'two-way with incorrect --exclude-per-directory (1)' '\n \n-\tif err=`read_tree_u_must_succeed -m --exclude-per-directory=.gitignore master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m --exclude-per-directory=.gitignore master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -54,7 +54,7 @@ test_expect_success 'two-way with incorrect --exclude-per-directory (1)' '\n \n test_expect_success 'two-way with incorrect --exclude-per-directory (2)' '\n \n-\tif err=`read_tree_u_must_succeed -m -u --exclude-per-directory=foo --exclude-per-directory=.gitignore master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u --exclude-per-directory=foo --exclude-per-directory=.gitignore master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n@@ -95,7 +95,7 @@ test_expect_success 'three-way not clobbering a working tree file' '\n \tgit checkout master &&\n \techo >file3 file three created in master, untracked &&\n \techo >subdir/file3 file three created in master, untracked &&\n-\tif err=`read_tree_u_must_succeed -m -u branch-point master side 2>&1`\n+\tif err=$(read_tree_u_must_succeed -m -u branch-point master side 2>&1)\n \tthen\n \t\techo should have complained\n \t\tfalse\n-- \n1.7.10.4\n"},{"id":"237747","messageId":"1395768283-31135-22-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 021/142] t1020-subdirectory.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:42Z","receivedAt":"2014-03-25T17:22:42Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1020-subdirectory.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t1020-subdirectory.sh b/t/t1020-subdirectory.sh\nindex 6902320..62c0d25 100755\n--- a/t/t1020-subdirectory.sh\n+++ b/t/t1020-subdirectory.sh\n@@ -20,27 +20,27 @@ test_expect_success setup '\n \n test_expect_success 'update-index and ls-files' '\n \tgit update-index --add one &&\n-\tcase \"`git ls-files`\" in\n+\tcase \"$(git ls-files)\" in\n \tone) echo pass one ;;\n \t*) echo bad one; exit 1 ;;\n \tesac &&\n \t(\n \t\tcd dir &&\n \t\tgit update-index --add two &&\n-\t\tcase \"`git ls-files`\" in\n+\t\tcase \"$(git ls-files)\" in\n \t\ttwo) echo pass two ;;\n \t\t*) echo bad two; exit 1 ;;\n \t\tesac\n \t) &&\n-\tcase \"`git ls-files`\" in\n+\tcase \"$(git ls-files)\" in\n \tdir/two\"$LF\"one) echo pass both ;;\n \t*) echo bad; exit 1 ;;\n \tesac\n '\n \n test_expect_success 'cat-file' '\n-\ttwo=`git ls-files -s dir/two` &&\n-\ttwo=`expr \"$two\" : \"[0-7]* \\\\([0-9a-f]*\\\\)\"` &&\n+\ttwo=$(git ls-files -s dir/two) &&\n+\ttwo=$(expr \"$two\" : \"[0-7]* \\\\([0-9a-f]*\\\\)\") &&\n \techo \"$two\" &&\n \tgit cat-file -p \"$two\" >actual &&\n \tcmp dir/two actual &&\n@@ -55,18 +55,18 @@ rm -f actual dir/actual\n test_expect_success 'diff-files' '\n \techo a >>one &&\n \techo d >>dir/two &&\n-\tcase \"`git diff-files --name-only`\" in\n+\tcase \"$(git diff-files --name-only)\" in\n \tdir/two\"$LF\"one) echo pass top ;;\n \t*) echo bad top; exit 1 ;;\n \tesac &&\n \t# diff should not omit leading paths\n \t(\n \t\tcd dir &&\n-\t\tcase \"`git diff-files --name-only`\" in\n+\t\tcase \"$(git diff-files --name-only)\" in\n \t\tdir/two\"$LF\"one) echo pass subdir ;;\n \t\t*) echo bad subdir; exit 1 ;;\n \t\tesac &&\n-\t\tcase \"`git diff-files --name-only .`\" in\n+\t\tcase \"$(git diff-files --name-only .)\" in\n \t\tdir/two) echo pass subdir limited ;;\n \t\t*) echo bad subdir limited; exit 1 ;;\n \t\tesac\n@@ -74,11 +74,11 @@ test_expect_success 'diff-files' '\n '\n \n test_expect_success 'write-tree' '\n-\ttop=`git write-tree` &&\n+\ttop=$(git write-tree) &&\n \techo $top &&\n \t(\n \t\tcd dir &&\n-\t\tsub=`git write-tree` &&\n+\t\tsub=$(git write-tree) &&\n \t\techo $sub &&\n \t\ttest \"z$top\" = \"z$sub\"\n \t)\n@@ -96,7 +96,7 @@ test_expect_success 'checkout-index' '\n \n test_expect_success 'read-tree' '\n \trm -f one dir/two &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \tread_tree_u_must_succeed --reset -u \"$tree\" &&\n \tcmp one original.one &&\n \tcmp dir/two original.two &&\n-- \n1.7.10.4\n"},{"id":"237733","messageId":"1395768283-31135-23-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 022/142] t1050-large.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:43Z","receivedAt":"2014-03-25T17:22:43Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1050-large.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1050-large.sh b/t/t1050-large.sh\nindex fd10528..aea4936 100755\n--- a/t/t1050-large.sh\n+++ b/t/t1050-large.sh\n@@ -131,7 +131,7 @@ test_expect_success 'git-show a large file' '\n '\n \n test_expect_success 'index-pack' '\n-\tgit clone file://\"`pwd`\"/.git foo &&\n+\tgit clone file://\"$(pwd)\"/.git foo &&\n \tGIT_DIR=non-existent git index-pack --strict --verify foo/.git/objects/pack/*.pack\n '\n \n@@ -140,7 +140,7 @@ test_expect_success 'repack' '\n '\n \n test_expect_success 'pack-objects with large loose object' '\n-\tSHA1=`git hash-object huge` &&\n+\tSHA1=$(git hash-object huge) &&\n \ttest_create_repo loose &&\n \techo $SHA1 | git pack-objects --stdout |\n \t\tGIT_ALLOC_LIMIT=0 GIT_DIR=loose/.git git unpack-objects &&\n-- \n1.7.10.4\n"},{"id":"237673","messageId":"1395768283-31135-24-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 023/142] t1100-commit-tree-options.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:44Z","receivedAt":"2014-03-25T17:22:44Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1100-commit-tree-options.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh\nindex f8457f9..b7e9b4fc 100755\n--- a/t/t1100-commit-tree-options.sh\n+++ b/t/t1100-commit-tree-options.sh\n@@ -35,11 +35,11 @@ test_expect_success \\\n GIT_COMMITTER_NAME=\"Committer Name\" \\\n GIT_COMMITTER_EMAIL=\"committer@email\" \\\n GIT_COMMITTER_DATE=\"2005-05-26 23:30\" \\\n- TZ=GMT git commit-tree `cat treeid` >commitid 2>/dev/null'\n+ TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null'\n \n test_expect_success \\\n 'read commit' \\\n- 'git cat-file commit `cat commitid` >commit'\n+ 'git cat-file commit $(cat commitid) >commit'\n \n test_expect_success \\\n 'compare commit' \\\n-- \n1.7.10.4\n"},{"id":"237740","messageId":"1395768283-31135-25-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 024/142] t1401-symbolic-ref.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:45Z","receivedAt":"2014-03-25T17:22:45Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1401-symbolic-ref.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh\nindex 36378b0..6ea8985 100755\n--- a/t/t1401-symbolic-ref.sh\n+++ b/t/t1401-symbolic-ref.sh\n@@ -29,7 +29,7 @@ reset_to_sane\n \n test_expect_success 'symbolic-ref refuses bare sha1' '\n \techo content >file && git add file && git commit -m one &&\n-\ttest_must_fail git symbolic-ref HEAD `git rev-parse HEAD`\n+\ttest_must_fail git symbolic-ref HEAD $(git rev-parse HEAD)\n '\n reset_to_sane\n \n-- \n1.7.10.4\n"},{"id":"237749","messageId":"1395768283-31135-26-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 025/142] t1410-reflog.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:46Z","receivedAt":"2014-03-25T17:22:46Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1410-reflog.sh | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh\nindex 236b13a..0a9502a 100755\n--- a/t/t1410-reflog.sh\n+++ b/t/t1410-reflog.sh\n@@ -62,18 +62,18 @@ test_expect_success setup '\n \tgit add . &&\n \n \ttest_tick && git commit -m rabbit &&\n-\tH=`git rev-parse --verify HEAD` &&\n-\tA=`git rev-parse --verify HEAD:A` &&\n-\tB=`git rev-parse --verify HEAD:A/B` &&\n-\tC=`git rev-parse --verify HEAD:C` &&\n-\tD=`git rev-parse --verify HEAD:A/D` &&\n-\tE=`git rev-parse --verify HEAD:A/B/E` &&\n+\tH=$(git rev-parse --verify HEAD) &&\n+\tA=$(git rev-parse --verify HEAD:A) &&\n+\tB=$(git rev-parse --verify HEAD:A/B) &&\n+\tC=$(git rev-parse --verify HEAD:C) &&\n+\tD=$(git rev-parse --verify HEAD:A/D) &&\n+\tE=$(git rev-parse --verify HEAD:A/B/E) &&\n \tcheck_fsck &&\n \n \ttest_chmod +x C &&\n \tgit add C &&\n \ttest_tick && git commit -m dragon &&\n-\tL=`git rev-parse --verify HEAD` &&\n+\tL=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \trm -f C A/B/E &&\n@@ -81,15 +81,15 @@ test_expect_success setup '\n \techo horse >A/G &&\n \tgit add F A/G &&\n \ttest_tick && git commit -a -m sheep &&\n-\tF=`git rev-parse --verify HEAD:F` &&\n-\tG=`git rev-parse --verify HEAD:A/G` &&\n-\tI=`git rev-parse --verify HEAD:A` &&\n-\tJ=`git rev-parse --verify HEAD` &&\n+\tF=$(git rev-parse --verify HEAD:F) &&\n+\tG=$(git rev-parse --verify HEAD:A/G) &&\n+\tI=$(git rev-parse --verify HEAD:A) &&\n+\tJ=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \trm -f A/G &&\n \ttest_tick && git commit -a -m monkey &&\n-\tK=`git rev-parse --verify HEAD` &&\n+\tK=$(git rev-parse --verify HEAD) &&\n \tcheck_fsck &&\n \n \tcheck_have A B C D E F G H I J K L &&\n-- \n1.7.10.4\n"},{"id":"237745","messageId":"1395768283-31135-27-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 026/142] t1511-rev-parse-caret.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:47Z","receivedAt":"2014-03-25T17:22:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1511-rev-parse-caret.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh\nindex 15973f2..7043ba7 100755\n--- a/t/t1511-rev-parse-caret.sh\n+++ b/t/t1511-rev-parse-caret.sh\n@@ -6,11 +6,11 @@ test_description='tests for ref^{stuff}'\n \n test_expect_success 'setup' '\n \techo blob >a-blob &&\n-\tgit tag -a -m blob blob-tag `git hash-object -w a-blob` &&\n+\tgit tag -a -m blob blob-tag $(git hash-object -w a-blob) &&\n \tmkdir a-tree &&\n \techo moreblobs >a-tree/another-blob &&\n \tgit add . &&\n-\tTREE_SHA1=`git write-tree` &&\n+\tTREE_SHA1=$(git write-tree) &&\n \tgit tag -a -m tree tree-tag \"$TREE_SHA1\" &&\n \tgit commit -m Initial &&\n \tgit tag -a -m commit commit-tag &&\n-- \n1.7.10.4\n"},{"id":"237684","messageId":"1395768283-31135-28-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 027/142] t1512-rev-parse-disambiguation.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:48Z","receivedAt":"2014-03-25T17:22:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t1512-rev-parse-disambiguation.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t1512-rev-parse-disambiguation.sh b/t/t1512-rev-parse-disambiguation.sh\nindex 4a155c8..e221167 100755\n--- a/t/t1512-rev-parse-disambiguation.sh\n+++ b/t/t1512-rev-parse-disambiguation.sh\n@@ -275,19 +275,19 @@ test_expect_success 'rev-parse --disambiguate' '\n \n test_expect_success 'ambiguous 40-hex ref' '\n \tTREE=$(git mktree err` = $REF &&\n+\ttest $(git rev-parse $REF 2>err) = $REF &&\n \tgrep \"refname.*${REF}.*ambiguous\" err\n '\n \n test_expect_success 'ambiguous short sha1 ref' '\n \tTREE=$(git mktree err` = $VAL &&\n+\ttest $(git rev-parse $REF 2>err) = $VAL &&\n \tgrep \"refname.*${REF}.*ambiguous\" err\n '\n \n-- \n1.7.10.4\n"},{"id":"237752","messageId":"1395768283-31135-29-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 028/142] t2102-update-index-symlinks.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:49Z","receivedAt":"2014-03-25T17:22:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t2102-update-index-symlinks.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t2102-update-index-symlinks.sh b/t/t2102-update-index-symlinks.sh\nindex 4d0d0a3..22f2c73 100755\n--- a/t/t2102-update-index-symlinks.sh\n+++ b/t/t2102-update-index-symlinks.sh\n@@ -23,7 +23,7 @@ git update-index symlink'\n \n test_expect_success \\\n 'the index entry must still be a symbolic link' '\n-case \"`git ls-files --stage --cached symlink`\" in\n+case \"$(git ls-files --stage --cached symlink)\" in\n 120000\" \"*symlink) echo pass;;\n *) echo fail; git ls-files --stage --cached symlink; (exit 1);;\n esac'\n-- \n1.7.10.4\n"},{"id":"237743","messageId":"1395768283-31135-30-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 029/142] t3030-merge-recursive.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:50Z","receivedAt":"2014-03-25T17:22:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3030-merge-recursive.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3030-merge-recursive.sh b/t/t3030-merge-recursive.sh\nindex 82e1854..e9757c4 100755\n--- a/t/t3030-merge-recursive.sh\n+++ b/t/t3030-merge-recursive.sh\n@@ -263,7 +263,7 @@ test_expect_success 'setup 8' '\n \ttest_ln_s_add e a &&\n \ttest_tick &&\n \tgit commit -m \"rename a->e, symlink a->e\" &&\n-\toln=`printf e | git hash-object --stdin`\n+\toln=$(printf e | git hash-object --stdin)\n '\n \n test_expect_success 'setup 9' '\n-- \n1.7.10.4\n"},{"id":"237753","messageId":"1395768283-31135-31-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 030/142] t3100-ls-tree-restrict.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:51Z","receivedAt":"2014-03-25T17:22:51Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3100-ls-tree-restrict.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3100-ls-tree-restrict.sh b/t/t3100-ls-tree-restrict.sh\nindex eb73c06..325114f 100755\n--- a/t/t3100-ls-tree-restrict.sh\n+++ b/t/t3100-ls-tree-restrict.sh\n@@ -28,7 +28,7 @@ test_expect_success \\\n echo Mi >path2/baz/b &&\n find path? \\( -type f -o -type l \\) -print |\n xargs git update-index --add &&\n- tree=`git write-tree` &&\n+ tree=$(git write-tree) &&\n echo $tree'\n \n test_output () {\n-- \n1.7.10.4\n"},{"id":"237686","messageId":"1395768283-31135-32-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 031/142] t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:52Z","receivedAt":"2014-03-25T17:22:52Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3101-ls-tree-dirname.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3101-ls-tree-dirname.sh b/t/t3101-ls-tree-dirname.sh\nindex 026f9f8..425d858 100755\n--- a/t/t3101-ls-tree-dirname.sh\n+++ b/t/t3101-ls-tree-dirname.sh\n@@ -35,7 +35,7 @@ test_expect_success 'setup' '\n \techo 222 >path3/2.txt &&\n \tfind *.txt path* \\( -type f -o -type l \\) -print |\n \txargs git update-index --add &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo $tree\n '\n \n-- \n1.7.10.4\n"},{"id":"237681","messageId":"1395768283-31135-33-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 032/142] t3210-pack-refs.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:53Z","receivedAt":"2014-03-25T17:22:53Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3210-pack-refs.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3210-pack-refs.sh b/t/t3210-pack-refs.sh\nindex 1a2080e..b0eaf22 100755\n--- a/t/t3210-pack-refs.sh\n+++ b/t/t3210-pack-refs.sh\n@@ -25,7 +25,7 @@ SHA1=\n test_expect_success \\\n 'see if git show-ref works as expected' \\\n 'git branch a &&\n- SHA1=`cat .git/refs/heads/a` &&\n+ SHA1=$(cat .git/refs/heads/a) &&\n echo \"$SHA1 refs/heads/a\" >expect &&\n git show-ref a >result &&\n test_cmp expect result'\n-- \n1.7.10.4\n"},{"id":"237682","messageId":"1395768283-31135-34-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 033/142] t3403-rebase-skip.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:54Z","receivedAt":"2014-03-25T17:22:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3403-rebase-skip.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3403-rebase-skip.sh b/t/t3403-rebase-skip.sh\nindex 3968020..1f5122b 100755\n--- a/t/t3403-rebase-skip.sh\n+++ b/t/t3403-rebase-skip.sh\n@@ -67,7 +67,7 @@ test_expect_success 'rebase --skip with --merge' '\n '\n \n test_expect_success 'merge and reference trees equal' '\n-\ttest -z \"`git diff-tree skip-merge skip-reference`\"\n+\ttest -z \"$(git diff-tree skip-merge skip-reference)\"\n '\n \n test_expect_success 'moved back to branch correctly' '\n-- \n1.7.10.4\n"},{"id":"237750","messageId":"1395768283-31135-35-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 034/142] t3511-cherry-pick-x.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:55Z","receivedAt":"2014-03-25T17:22:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3511-cherry-pick-x.sh | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t3511-cherry-pick-x.sh b/t/t3511-cherry-pick-x.sh\nindex f977279..f60a037 100755\n--- a/t/t3511-cherry-pick-x.sh\n+++ b/t/t3511-cherry-pick-x.sh\n@@ -59,7 +59,7 @@ test_expect_success setup '\n \n test_expect_success 'cherry-pick -x inserts blank line after one line subject' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-one-line^0` &&\n+\tsha1=$(git rev-parse mesg-one-line^0) &&\n \tgit cherry-pick -x mesg-one-line &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_one_line\n@@ -96,7 +96,7 @@ test_expect_success 'cherry-pick -s inserts blank line after non-conforming foot\n \n test_expect_success 'cherry-pick -x inserts blank line when conforming footer not found' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-no-footer^0` &&\n+\tsha1=$(git rev-parse mesg-no-footer^0) &&\n \tgit cherry-pick -x mesg-no-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_no_footer\n@@ -121,7 +121,7 @@ test_expect_success 'cherry-pick -s inserts blank line when conforming footer no\n \n test_expect_success 'cherry-pick -x -s inserts blank line when conforming footer not found' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-no-footer^0` &&\n+\tsha1=$(git rev-parse mesg-no-footer^0) &&\n \tgit cherry-pick -x -s mesg-no-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_no_footer\n@@ -146,7 +146,7 @@ test_expect_success 'cherry-pick -s adds sob when last sob doesnt match committe\n \n test_expect_success 'cherry-pick -x -s adds sob when last sob doesnt match committer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-footer^0) &&\n \tgit cherry-pick -x -s mesg-with-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_footer\n@@ -169,7 +169,7 @@ test_expect_success 'cherry-pick -s refrains from adding duplicate trailing sob'\n \n test_expect_success 'cherry-pick -x -s adds sob even when trailing sob exists for committer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-footer-sob^0` &&\n+\tsha1=$(git rev-parse mesg-with-footer-sob^0) &&\n \tgit cherry-pick -x -s mesg-with-footer-sob &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_footer_sob\n@@ -182,7 +182,7 @@ test_expect_success 'cherry-pick -x -s adds sob even when trailing sob exists fo\n \n test_expect_success 'cherry-pick -x treats \"(cherry picked from...\" line as part of footer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-cherry-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-cherry-footer^0) &&\n \tgit cherry-pick -x mesg-with-cherry-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_cherry_footer\n@@ -205,7 +205,7 @@ test_expect_success 'cherry-pick -s treats \"(cherry picked from...\" line as part\n \n test_expect_success 'cherry-pick -x -s treats \"(cherry picked from...\" line as part of footer' '\n \tpristine_detach initial &&\n-\tsha1=`git rev-parse mesg-with-cherry-footer^0` &&\n+\tsha1=$(git rev-parse mesg-with-cherry-footer^0) &&\n \tgit cherry-pick -x -s mesg-with-cherry-footer &&\n \tcat <<-EOF >expect &&\n \t\t$mesg_with_cherry_footer\n-- \n1.7.10.4\n"},{"id":"237683","messageId":"1395768283-31135-36-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 035/142] t3600-rm.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:56Z","receivedAt":"2014-03-25T17:22:56Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3600-rm.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3600-rm.sh b/t/t3600-rm.sh\nindex 3d30581..96f7949 100755\n--- a/t/t3600-rm.sh\n+++ b/t/t3600-rm.sh\n@@ -115,7 +115,7 @@ test_expect_success '\"rm\" command printed' '\n \tgit add test-file &&\n \tgit commit -m \"add file for rm test\" &&\n \tgit rm test-file > rm-output &&\n-\ttest `grep \"^rm \" rm-output | wc -l` = 1 &&\n+\ttest $(grep \"^rm \" rm-output | wc -l) = 1 &&\n \trm -f test-file rm-output &&\n \tgit commit -m \"remove file from rm test\"\n '\n@@ -125,7 +125,7 @@ test_expect_success '\"rm\" command suppressed with --quiet' '\n \tgit add test-file &&\n \tgit commit -m \"add file for rm --quiet test\" &&\n \tgit rm --quiet test-file > rm-output &&\n-\ttest `wc -l < rm-output` = 0 &&\n+\ttest $(wc -l < rm-output) = 0 &&\n \trm -f test-file rm-output &&\n \tgit commit -m \"remove file from rm --quiet test\"\n '\n-- \n1.7.10.4\n"},{"id":"237746","messageId":"1395768283-31135-37-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 036/142] t3700-add.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:57Z","receivedAt":"2014-03-25T17:22:57Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3700-add.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t3700-add.sh b/t/t3700-add.sh\nindex fe274e2..95eb234 100755\n--- a/t/t3700-add.sh\n+++ b/t/t3700-add.sh\n@@ -25,7 +25,7 @@ test_expect_success \\\n \t echo foo >xfoo1 &&\n \t chmod 755 xfoo1 &&\n \t git add xfoo1 &&\n-\t case \"`git ls-files --stage xfoo1`\" in\n+\t case \"$(git ls-files --stage xfoo1)\" in\n \t 100644\" \"*xfoo1) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo1; (exit 1);;\n \t esac'\n@@ -33,7 +33,7 @@ test_expect_success \\\n test_expect_success 'git add: filemode=0 should not get confused by symlink' '\n \trm -f xfoo1 &&\n \ttest_ln_s_add foo xfoo1 &&\n-\tcase \"`git ls-files --stage xfoo1`\" in\n+\tcase \"$(git ls-files --stage xfoo1)\" in\n \t120000\" \"*xfoo1) echo pass;;\n \t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n \tesac\n@@ -45,7 +45,7 @@ test_expect_success \\\n \t echo foo >xfoo2 &&\n \t chmod 755 xfoo2 &&\n \t git update-index --add xfoo2 &&\n-\t case \"`git ls-files --stage xfoo2`\" in\n+\t case \"$(git ls-files --stage xfoo2)\" in\n \t 100644\" \"*xfoo2) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo2; (exit 1);;\n \t esac'\n@@ -53,7 +53,7 @@ test_expect_success \\\n test_expect_success 'git add: filemode=0 should not get confused by symlink' '\n \trm -f xfoo2 &&\n \ttest_ln_s_add foo xfoo2 &&\n-\tcase \"`git ls-files --stage xfoo2`\" in\n+\tcase \"$(git ls-files --stage xfoo2)\" in\n \t120000\" \"*xfoo2) echo pass;;\n \t*) echo fail; git ls-files --stage xfoo2; (exit 1);;\n \tesac\n@@ -63,7 +63,7 @@ test_expect_success \\\n \t'git update-index --add: Test that executable bit is not used...' \\\n \t'git config core.filemode 0 &&\n \t test_ln_s_add xfoo2 xfoo3 &&\t# runs git update-index --add\n-\t case \"`git ls-files --stage xfoo3`\" in\n+\t case \"$(git ls-files --stage xfoo3)\" in\n \t 120000\" \"*xfoo3) echo pass;;\n \t *) echo fail; git ls-files --stage xfoo3; (exit 1);;\n \t esac'\n@@ -166,14 +166,14 @@ test_expect_success 'git add with filemode=0, symlinks=0 prefers stage 2 over st\n \n test_expect_success 'git add --refresh' '\n \t>foo && git add foo && git commit -a -m \"commit all\" &&\n-\ttest -z \"`git diff-index HEAD -- foo`\" &&\n+\ttest -z \"$(git diff-index HEAD -- foo)\" &&\n \tgit read-tree HEAD &&\n-\tcase \"`git diff-index HEAD -- foo`\" in\n+\tcase \"$(git diff-index HEAD -- foo)\" in\n \t:100644\" \"*\"M\tfoo\") echo pass;;\n \t*) echo fail; (exit 1);;\n \tesac &&\n \tgit add --refresh -- foo &&\n-\ttest -z \"`git diff-index HEAD -- foo`\"\n+\ttest -z \"$(git diff-index HEAD -- foo)\"\n '\n \n test_expect_success 'git add --refresh with pathspec' '\n-- \n1.7.10.4\n"},{"id":"237748","messageId":"1395768283-31135-38-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 037/142] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:58Z","receivedAt":"2014-03-25T17:22:58Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3905-stash-include-untracked.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3905-stash-include-untracked.sh b/t/t3905-stash-include-untracked.sh\nindex a5e7e6b..f372fc8 100755\n--- a/t/t3905-stash-include-untracked.sh\n+++ b/t/t3905-stash-include-untracked.sh\n@@ -96,8 +96,8 @@ test_expect_success 'stash pop after save --include-untracked leaves files untra\n \tgit stash pop &&\n \tgit status --porcelain >actual &&\n \ttest_cmp expect actual &&\n-\ttest \"1\" = \"`cat file2`\" &&\n-\ttest untracked = \"`cat untracked/untracked`\"\n+\ttest \"1\" = \"$(cat file2)\" &&\n+\ttest untracked = \"$(cat untracked/untracked)\"\n '\n \n git clean --force --quiet -d\n-- \n1.7.10.4\n"},{"id":"237685","messageId":"1395768283-31135-39-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 038/142] t3910-mac-os-precompose.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:22:59Z","receivedAt":"2014-03-25T17:22:59Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t3910-mac-os-precompose.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t3910-mac-os-precompose.sh b/t/t3910-mac-os-precompose.sh\nindex e4ba601..96941e9 100755\n--- a/t/t3910-mac-os-precompose.sh\n+++ b/t/t3910-mac-os-precompose.sh\n@@ -14,13 +14,13 @@ then\n fi\n \n # create utf-8 variables\n-Adiarnfc=`printf '\\303\\204'`\n-Adiarnfd=`printf 'A\\314\\210'`\n+Adiarnfc=$(printf '\\303\\204')\n+Adiarnfd=$(printf 'A\\314\\210')\n \n-Odiarnfc=`printf '\\303\\226'`\n-Odiarnfd=`printf 'O\\314\\210'`\n-AEligatu=`printf '\\303\\206'`\n-Invalidu=`printf '\\303\\377'`\n+Odiarnfc=$(printf '\\303\\226')\n+Odiarnfd=$(printf 'O\\314\\210')\n+AEligatu=$(printf '\\303\\206')\n+Invalidu=$(printf '\\303\\377')\n \n \n #Create a string with 255 bytes (decomposed)\n@@ -35,7 +35,7 @@ Alongc=$Alongc$Alongc$Alongc$Alongc$Alongc #250 Byte\n Alongc=$Alongc$AEligatu$AEligatu #254 Byte\n \n test_expect_success \"detect if nfd needed\" '\n-\tprecomposeunicode=`git config core.precomposeunicode` &&\n+\tprecomposeunicode=$(git config core.precomposeunicode) &&\n \ttest \"$precomposeunicode\" = true &&\n \tgit config core.precomposeunicode true\n '\n@@ -146,7 +146,7 @@ test_expect_success \"respect git config --global core.precomposeunicode\" '\n \tgit config --global core.precomposeunicode true &&\n \trm -rf .git &&\n \tgit init &&\n-\tprecomposeunicode=`git config core.precomposeunicode` &&\n+\tprecomposeunicode=$(git config core.precomposeunicode) &&\n \ttest \"$precomposeunicode\" = \"true\"\n '\n \n-- \n1.7.10.4\n"},{"id":"237738","messageId":"1395768283-31135-40-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 039/142] t4006-diff-mode.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:00Z","receivedAt":"2014-03-25T17:23:00Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4006-diff-mode.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4006-diff-mode.sh b/t/t4006-diff-mode.sh\nindex 0591149..76f643b 100755\n--- a/t/t4006-diff-mode.sh\n+++ b/t/t4006-diff-mode.sh\n@@ -13,7 +13,7 @@ sed_script='s/\\(:100644 100755\\) \\('\"$_x40\"'\\) \\2 /\\1 X X /'\n test_expect_success 'setup' '\n \techo frotz >rezrov &&\n \tgit update-index --add rezrov &&\n-\ttree=`git write-tree` &&\n+\ttree=$(git write-tree) &&\n \techo $tree\n '\n \n-- \n1.7.10.4\n"},{"id":"237690","messageId":"1395768283-31135-41-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 040/142] t4010-diff-pathspec.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:01Z","receivedAt":"2014-03-25T17:23:01Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4010-diff-pathspec.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec.sh\nindex 2bb9736..bf07841 100755\n--- a/t/t4010-diff-pathspec.sh\n+++ b/t/t4010-diff-pathspec.sh\n@@ -18,7 +18,7 @@ test_expect_success \\\n mkdir path1 &&\n echo rezrov >path1/file1 &&\n git update-index --add file0 path1/file1 &&\n- tree=`git write-tree` &&\n+ tree=$(git write-tree) &&\n echo \"$tree\" &&\n echo nitfol >file0 &&\n echo yomin >path1/file1 &&\n@@ -131,7 +131,7 @@ test_expect_success 'diff multiple wildcard pathspecs' '\n \tmkdir path2 &&\n \techo rezrov >path2/file1 &&\n \tgit update-index --add path2/file1 &&\n-\ttree3=`git write-tree` &&\n+\ttree3=$(git write-tree) &&\n \tgit diff --name-only $tree $tree3 -- \"path2*1\" \"path1*1\" >actual &&\n \tcat <<-\\EOF >expect &&\n \tpath1/file1\n-- \n1.7.10.4\n"},{"id":"237687","messageId":"1395768283-31135-42-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 041/142] t4012-diff-binary.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:02Z","receivedAt":"2014-03-25T17:23:02Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4012-diff-binary.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh\nindex 1215ae5..643d729 100755\n--- a/t/t4012-diff-binary.sh\n+++ b/t/t4012-diff-binary.sh\n@@ -67,18 +67,18 @@ test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '\n \tgit diff >output &&\n \tsed -e \"s/-CIT/xCIT/\" broken &&\n \ttest_must_fail git apply --stat --summary broken 2>detected &&\n-\tdetected=`cat detected` &&\n-\tdetected=`expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\"` &&\n-\tdetected=`sed -ne \"${detected}p\" broken` &&\n+\tdetected=$(cat detected) &&\n+\tdetected=$(expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\") &&\n+\tdetected=$(sed -ne \"${detected}p\" broken) &&\n \ttest \"$detected\" = xCIT\n '\n \n test_expect_success C_LOCALE_OUTPUT 'apply detecting corrupt patch correctly' '\n \tgit diff --binary | sed -e \"s/-CIT/xCIT/\" >broken &&\n \ttest_must_fail git apply --stat --summary broken 2>detected &&\n-\tdetected=`cat detected` &&\n-\tdetected=`expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\"` &&\n-\tdetected=`sed -ne \"${detected}p\" broken` &&\n+\tdetected=$(cat detected) &&\n+\tdetected=$(expr \"$detected\" : \"fatal.*at line \\\\([0-9]*\\\\)\\$\") &&\n+\tdetected=$(sed -ne \"${detected}p\" broken) &&\n \ttest \"$detected\" = xCIT\n '\n \n@@ -88,7 +88,7 @@ test_expect_success 'initial commit' 'git commit -a -m initial'\n test_expect_success 'diff-index with --binary' '\n \techo AIT >a && mv b e && echo CIT >c && cat e >d &&\n \tgit update-index --add --remove a b c d e &&\n-\ttree0=`git write-tree` &&\n+\ttree0=$(git write-tree) &&\n \tgit diff --cached --binary >current &&\n \tgit apply --stat --summary current\n '\n@@ -96,7 +96,7 @@ test_expect_success 'diff-index with --binary' '\n test_expect_success 'apply binary patch' '\n \tgit reset --hard &&\n \tgit apply --binary --index \n---\n t/t4013-diff-various.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh\nindex e77c09c..805b055 100755\n--- a/t/t4013-diff-various.sh\n+++ b/t/t4013-diff-various.sh\n@@ -107,14 +107,14 @@ test_expect_success setup '\n +*++ [initial] Initial\n EOF\n \n-V=`git version | sed -e 's/^git version //' -e 's/\\./\\\\./g'`\n+V=$(git version | sed -e 's/^git version //' -e 's/\\./\\\\./g')\n while read cmd\n do\n \tcase \"$cmd\" in\n \t'' | '#'*) continue ;;\n \tesac\n-\ttest=`echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g'`\n-\tpfx=`printf \"%04d\" $test_count`\n+\ttest=$(echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g')\n+\tpfx=$(printf \"%04d\" $test_count)\n \texpect=\"$TEST_DIRECTORY/t4013/diff.$test\"\n \tactual=\"$pfx-diff.$test\"\n \n-- \n1.7.10.4\n"},{"id":"237694","messageId":"1395768283-31135-44-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 043/142] t4014-format-patch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:04Z","receivedAt":"2014-03-25T17:23:04Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4014-format-patch.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh\nindex 73194b2..f9ed598 100755\n--- a/t/t4014-format-patch.sh\n+++ b/t/t4014-format-patch.sh\n@@ -43,7 +43,7 @@ test_expect_success setup '\n test_expect_success \"format-patch --ignore-if-in-upstream\" '\n \n \tgit format-patch --stdout master..side >patch0 &&\n-\tcnt=`grep \"^From \" patch0 | wc -l` &&\n+\tcnt=$(grep \"^From \" patch0 | wc -l) &&\n \ttest $cnt = 3\n \n '\n@@ -52,7 +52,7 @@ test_expect_success \"format-patch --ignore-if-in-upstream\" '\n \n \tgit format-patch --stdout \\\n \t\t--ignore-if-in-upstream master..side >patch1 &&\n-\tcnt=`grep \"^From \" patch1 | wc -l` &&\n+\tcnt=$(grep \"^From \" patch1 | wc -l) &&\n \ttest $cnt = 2\n \n '\n@@ -69,7 +69,7 @@ test_expect_success \"format-patch doesn't consider merge commits\" '\n \tgit checkout -b merger master &&\n \ttest_tick &&\n \tgit merge --no-ff slave &&\n-\tcnt=`git format-patch -3 --stdout | grep \"^From \" | wc -l` &&\n+\tcnt=$(git format-patch -3 --stdout | grep \"^From \" | wc -l) &&\n \ttest $cnt = 3\n '\n \n@@ -77,7 +77,7 @@ test_expect_success \"format-patch result applies\" '\n \n \tgit checkout -b rebuild-0 master &&\n \tgit am -3 patch0 &&\n-\tcnt=`git rev-list master.. | wc -l` &&\n+\tcnt=$(git rev-list master.. | wc -l) &&\n \ttest $cnt = 2\n '\n \n@@ -85,7 +85,7 @@ test_expect_success \"format-patch --ignore-if-in-upstream result applies\" '\n \n \tgit checkout -b rebuild-1 master &&\n \tgit am -3 patch1 &&\n-\tcnt=`git rev-list master.. | wc -l` &&\n+\tcnt=$(git rev-list master.. | wc -l) &&\n \ttest $cnt = 2\n '\n \n-- \n1.7.10.4\n"},{"id":"237695","messageId":"1395768283-31135-45-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 044/142] t4036-format-patch-signer-mime.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:05Z","receivedAt":"2014-03-25T17:23:05Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4036-format-patch-signer-mime.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4036-format-patch-signer-mime.sh b/t/t4036-format-patch-signer-mime.sh\nindex ba43f18..98d9713 100755\n--- a/t/t4036-format-patch-signer-mime.sh\n+++ b/t/t4036-format-patch-signer-mime.sh\n@@ -42,7 +42,7 @@ test_expect_success 'attach and signoff do not duplicate mime headers' '\n \n \tGIT_COMMITTER_NAME=\"はまの ふにおう\" \\\n \tgit format-patch -s --stdout -1 --attach >output &&\n-\ttest `grep -ci ^MIME-Version: output` = 1\n+\ttest $(grep -ci ^MIME-Version: output) = 1\n \n '\n \n-- \n1.7.10.4\n"},{"id":"237689","messageId":"1395768283-31135-46-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 045/142] t4038-diff-combined.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:06Z","receivedAt":"2014-03-25T17:23:06Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4038-diff-combined.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh\nindex 1019d7b..41913c3 100755\n--- a/t/t4038-diff-combined.sh\n+++ b/t/t4038-diff-combined.sh\n@@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' '\n \tblob=$(echo file | git hash-object --stdin -w) &&\n \tbase_tree=$(echo \"100644 blob $blob\tfile\" | git mktree) &&\n \ttrees= &&\n-\tfor i in `test_seq 1 40`\n+\tfor i in $(test_seq 1 40)\n \tdo\n \t\tblob=$(echo file$i | git hash-object --stdin -w) &&\n \t\ttrees=\"$trees$(echo \"100644 blob $blob\tfile\" | git mktree)$LF\"\n-- \n1.7.10.4\n"},{"id":"237691","messageId":"1395768283-31135-47-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 046/142] t4057-diff-combined-paths.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:07Z","receivedAt":"2014-03-25T17:23:07Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4057-diff-combined-paths.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-paths.sh\nindex 097e632..dff36b7 100755\n--- a/t/t4057-diff-combined-paths.sh\n+++ b/t/t4057-diff-combined-paths.sh\n@@ -5,7 +5,7 @@ test_description='combined diff show only paths that are different to all parent\n . ./test-lib.sh\n \n # verify that diffc.expect matches output of\n-# `git diff -c --name-only HEAD HEAD^ HEAD^2`\n+# $(git diff -c --name-only HEAD HEAD^ HEAD^2)\n diffc_verify () {\n \tgit diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual &&\n \ttest_cmp diffc.expect diffc.actual\n-- \n1.7.10.4\n"},{"id":"237707","messageId":"1395768283-31135-48-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 047/142] t4116-apply-reverse.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:08Z","receivedAt":"2014-03-25T17:23:08Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4116-apply-reverse.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t4116-apply-reverse.sh b/t/t4116-apply-reverse.sh\nindex 1e4d438..ce8567f 100755\n--- a/t/t4116-apply-reverse.sh\n+++ b/t/t4116-apply-reverse.sh\n@@ -30,10 +30,10 @@ test_expect_success setup '\n \n test_expect_success 'apply in forward' '\n \n-\tT0=`git rev-parse \"second^{tree}\"` &&\n+\tT0=$(git rev-parse \"second^{tree}\") &&\n \tgit reset --hard initial &&\n \tgit apply --index --binary patch &&\n-\tT1=`git write-tree` &&\n+\tT1=$(git write-tree) &&\n \ttest \"$T0\" = \"$T1\"\n '\n \n@@ -62,22 +62,22 @@ test_expect_success 'setup separate repository lacking postimage' '\n \n test_expect_success 'apply in forward without postimage' '\n \n-\tT0=`git rev-parse \"second^{tree}\"` &&\n+\tT0=$(git rev-parse \"second^{tree}\") &&\n \t(\n \t\tcd initial &&\n \t\tgit apply --index --binary ../patch &&\n-\t\tT1=`git write-tree` &&\n+\t\tT1=$(git write-tree) &&\n \t\ttest \"$T0\" = \"$T1\"\n \t)\n '\n \n test_expect_success 'apply in reverse without postimage' '\n \n-\tT0=`git rev-parse \"initial^{tree}\"` &&\n+\tT0=$(git rev-parse \"initial^{tree}\") &&\n \t(\n \t\tcd second &&\n \t\tgit apply --index --binary --reverse ../patch &&\n-\t\tT1=`git write-tree` &&\n+\t\tT1=$(git write-tree) &&\n \t\ttest \"$T0\" = \"$T1\"\n \t)\n '\n-- \n1.7.10.4\n"},{"id":"237735","messageId":"1395768283-31135-49-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 048/142] t4119-apply-config.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:09Z","receivedAt":"2014-03-25T17:23:09Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4119-apply-config.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4119-apply-config.sh b/t/t4119-apply-config.sh\nindex 3d0384d..c393be6 100755\n--- a/t/t4119-apply-config.sh\n+++ b/t/t4119-apply-config.sh\n@@ -68,7 +68,7 @@ test_expect_success 'apply --whitespace=strip from config' '\n \tcheck_result sub/file1\n '\n \n-D=`pwd`\n+D=$(pwd)\n \n test_expect_success 'apply --whitespace=strip in subdir' '\n \n-- \n1.7.10.4\n"},{"id":"237739","messageId":"1395768283-31135-50-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 049/142] t4204-patch-id.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:10Z","receivedAt":"2014-03-25T17:23:10Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t4204-patch-id.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4204-patch-id.sh b/t/t4204-patch-id.sh\nindex d2c930d..7940f6f 100755\n--- a/t/t4204-patch-id.sh\n+++ b/t/t4204-patch-id.sh\n@@ -45,8 +45,8 @@ test_expect_success 'patch-id supports git-format-patch output' '\n \tgit checkout same &&\n \tgit format-patch -1 --stdout | calc_patch_id same &&\n \ttest_cmp patch-id_master patch-id_same &&\n-\tset `git format-patch -1 --stdout | git patch-id` &&\n-\ttest \"$2\" = `git rev-parse HEAD`\n+\tset $(git format-patch -1 --stdout | git patch-id) &&\n+\ttest \"$2\" = $(git rev-parse HEAD)\n '\n \n test_expect_success 'whitespace is irrelevant in footer' '\n-- \n1.7.10.4\n"},{"id":"237731","messageId":"1395768283-31135-51-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 050/142] t5000-tar-tree.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:11Z","receivedAt":"2014-03-25T17:23:11Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5000-tar-tree.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex 1cf0a4e..74fc5a8 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -123,7 +123,7 @@ test_expect_success \\\n 'add files to repository' \\\n 'find a -type f | xargs git update-index --add &&\n find a -type l | xargs git update-index --add &&\n- treeid=`git write-tree` &&\n+ treeid=$(git write-tree) &&\n echo $treeid >treeid &&\n git update-ref HEAD $(TZ=GMT GIT_COMMITTER_DATE=\"2005-05-27 22:00:00\" \\\n git commit-tree $treeid remote.tar &&\n \ttest_must_fail git archive --remote=. $sha1 >remote.tar\n@@ -215,7 +215,7 @@ test_expect_success 'clients cannot access unreachable commits' '\n \n test_expect_success 'upload-archive can allow unreachable commits' '\n \ttest_commit unreachable1 &&\n-\tsha1=`git rev-parse HEAD` &&\n+\tsha1=$(git rev-parse HEAD) &&\n \tgit reset --hard HEAD^ &&\n \tgit archive $sha1 >remote.tar &&\n \ttest_config uploadarchive.allowUnreachable true &&\n-- \n1.7.10.4\n"},{"id":"237724","messageId":"1395768283-31135-52-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 051/142] t5003-archive-zip.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:12Z","receivedAt":"2014-03-25T17:23:12Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5003-archive-zip.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5003-archive-zip.sh b/t/t5003-archive-zip.sh\nindex c72f71e..8f04a56 100755\n--- a/t/t5003-archive-zip.sh\n+++ b/t/t5003-archive-zip.sh\n@@ -65,7 +65,7 @@ test_expect_success \\\n 'add files to repository' \\\n 'find a -type f | xargs git update-index --add &&\n find a -type l | xargs git update-index --add &&\n- treeid=`git write-tree` &&\n+ treeid=$(git write-tree) &&\n echo $treeid >treeid &&\n git update-ref HEAD $(TZ=GMT GIT_COMMITTER_DATE=\"2005-05-27 22:00:00\" \\\n git commit-tree $treeid \n---\n t/t5100-mailinfo.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t5100-mailinfo.sh b/t/t5100-mailinfo.sh\nindex 3e64a7a..c279410 100755\n--- a/t/t5100-mailinfo.sh\n+++ b/t/t5100-mailinfo.sh\n@@ -9,9 +9,9 @@ test_description='git mailinfo and git mailsplit test'\n \n test_expect_success 'split sample box' \\\n \t'git mailsplit -o. \"$TEST_DIRECTORY\"/t5100/sample.mbox >last &&\n-\tlast=`cat last` &&\n+\tlast=$(cat last) &&\n \techo total is $last &&\n-\ttest `cat last` = 17'\n+\ttest $(cat last) = 17'\n \n check_mailinfo () {\n \tmail=$1 opt=$2\n@@ -23,7 +23,7 @@ check_mailinfo () {\n }\n \n \n-for mail in `echo 00*`\n+for mail in $(echo 00*)\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tcheck_mailinfo $mail \"\" &&\n@@ -43,11 +43,11 @@ test_expect_success 'split box with rfc2047 samples' \\\n \t'mkdir rfc2047 &&\n \tgit mailsplit -orfc2047 \"$TEST_DIRECTORY\"/t5100/rfc2047-samples.mbox \\\n \t >rfc2047/last &&\n-\tlast=`cat rfc2047/last` &&\n+\tlast=$(cat rfc2047/last) &&\n \techo total is $last &&\n-\ttest `cat rfc2047/last` = 11'\n+\ttest $(cat rfc2047/last) = 11'\n \n-for mail in `echo rfc2047/00*`\n+for mail in $(echo rfc2047/00*)\n do\n \ttest_expect_success \"mailinfo $mail\" '\n \t\tgit mailinfo -u $mail-msg $mail-patch <$mail >$mail-info &&\n-- \n1.7.10.4\n"},{"id":"237688","messageId":"1395768283-31135-54-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 053/142] t5300-pack-object.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:14Z","receivedAt":"2014-03-25T17:23:14Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5300-pack-object.sh | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)\n\ndiff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh\nindex 20c1961..fc2be63 100755\n--- a/t/t5300-pack-object.sh\n+++ b/t/t5300-pack-object.sh\n@@ -8,7 +8,7 @@ test_description='git pack-object\n '\n . ./test-lib.sh\n \n-TRASH=`pwd`\n+TRASH=$(pwd)\n \n test_expect_success \\\n 'setup' \\\n@@ -20,8 +20,8 @@ test_expect_success \\\n test-genrandom \"seed b\" 2097152 > b_big &&\n git update-index --add a a_big b b_big c &&\n cat c >d && echo foo >>d && git update-index --add d &&\n- tree=`git write-tree` &&\n- commit=`git commit-tree $tree expect'\n@@ -147,7 +147,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -162,7 +162,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -177,7 +177,7 @@ test_expect_success \\\n \t git diff-tree --root -p $commit &&\n \t while read object\n \t do\n-\t t=`git cat-file -t $object` &&\n+\t t=$(git cat-file -t $object) &&\n \t git cat-file $t $object || return 1\n \t done current &&\n@@ -252,8 +252,8 @@ test_expect_success \\\n \n test_expect_success \\\n 'verify-pack catches a corrupted sum of the index file itself' \\\n- 'l=`wc -c test-3.pack &&\n printf \"%20s\" \"\" | dd of=test-3.idx count=20 bs=1 conv=notrunc seek=$l &&\n if git verify-pack test-3.pack\n-- \n1.7.10.4\n"},{"id":"237719","messageId":"1395768283-31135-55-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 054/142] t5301-sliding-window.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:15Z","receivedAt":"2014-03-25T17:23:15Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5301-sliding-window.sh | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t5301-sliding-window.sh b/t/t5301-sliding-window.sh\nindex 2fc5af6..cae8c2e 100755\n--- a/t/t5301-sliding-window.sh\n+++ b/t/t5301-sliding-window.sh\n@@ -16,12 +16,12 @@ test_expect_success \\\n git update-index --add $i || return 1\n done &&\n echo d >d && cat c >>d && git update-index --add d &&\n- tree=`git write-tree` &&\n- commit1=`git commit-tree $tree \n---\n t/t5302-pack-index.sh | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)\n\ndiff --git a/t/t5302-pack-index.sh b/t/t5302-pack-index.sh\nindex 4bbb718..442ee5c 100755\n--- a/t/t5302-pack-index.sh\n+++ b/t/t5302-pack-index.sh\n@@ -14,21 +14,21 @@ test_expect_success \\\n i=1 &&\n while test $i -le 100\n do\n- iii=`printf '%03i' $i`\n+ iii=$(printf '%03i' $i)\n test-genrandom \"bar\" 200 > wide_delta_$iii &&\n test-genrandom \"baz $iii\" 50 >> wide_delta_$iii &&\n test-genrandom \"foo\"$i 100 > deep_delta_$iii &&\n- test-genrandom \"foo\"`expr $i + 1` 100 >> deep_delta_$iii &&\n- test-genrandom \"foo\"`expr $i + 2` 100 >> deep_delta_$iii &&\n+ test-genrandom \"foo\"$(expr $i + 1) 100 >> deep_delta_$iii &&\n+ test-genrandom \"foo\"$(expr $i + 2) 100 >> deep_delta_$iii &&\n echo $iii >file_$iii &&\n test-genrandom \"$iii\" 8192 >>file_$iii &&\n git update-index --add file_$iii deep_delta_$iii wide_delta_$iii &&\n- i=`expr $i + 1` || return 1\n+ i=$(expr $i + 1) || return 1\n done &&\n { echo 101 && test-genrandom 100 8192; } >file_101 &&\n git update-index --add file_101 &&\n- tree=`git write-tree` &&\n- commit=`git commit-tree $tree obj-list &&\n@@ -152,10 +152,10 @@ test_expect_success \\\n '[index v1] 2) create a stealth corruption in a delta base reference' \\\n '# This test assumes file_101 is a delta smaller than 16 bytes.\n # It should be against file_100 but we substitute its base for file_099\n- sha1_101=`git hash-object file_101` &&\n- sha1_099=`git hash-object file_099` &&\n- offs_101=`index_obj_offset 1.idx $sha1_101` &&\n- nr_099=`index_obj_nr 1.idx $sha1_099` &&\n+ sha1_101=$(git hash-object file_101) &&\n+ sha1_099=$(git hash-object file_099) &&\n+ offs_101=$(index_obj_offset 1.idx $sha1_101) &&\n+ nr_099=$(index_obj_nr 1.idx $sha1_099) &&\n chmod +w \".git/objects/pack/pack-${pack1}.pack\" &&\n dd of=\".git/objects/pack/pack-${pack1}.pack\" seek=$(($offs_101 + 1)) \\\n if=\".git/objects/pack/pack-${pack1}.idx\" \\\n@@ -193,10 +193,10 @@ test_expect_success \\\n '[index v2] 2) create a stealth corruption in a delta base reference' \\\n '# This test assumes file_101 is a delta smaller than 16 bytes.\n # It should be against file_100 but we substitute its base for file_099\n- sha1_101=`git hash-object file_101` &&\n- sha1_099=`git hash-object file_099` &&\n- offs_101=`index_obj_offset 1.idx $sha1_101` &&\n- nr_099=`index_obj_nr 1.idx $sha1_099` &&\n+ sha1_101=$(git hash-object file_101) &&\n+ sha1_099=$(git hash-object file_099) &&\n+ offs_101=$(index_obj_offset 1.idx $sha1_101) &&\n+ nr_099=$(index_obj_nr 1.idx $sha1_099) &&\n chmod +w \".git/objects/pack/pack-${pack1}.pack\" &&\n dd of=\".git/objects/pack/pack-${pack1}.pack\" seek=$(($offs_101 + 1)) \\\n if=\".git/objects/pack/pack-${pack1}.idx\" \\\n@@ -222,11 +222,11 @@ test_expect_success \\\n 'rm -f .git/objects/pack/* &&\n git index-pack --index-version=2 --stdin < \"test-1-${pack1}.pack\" &&\n git verify-pack \".git/objects/pack/pack-${pack1}.pack\" &&\n- obj=`git hash-object file_001` &&\n- nr=`index_obj_nr \".git/objects/pack/pack-${pack1}.idx\" $obj` &&\n+ obj=$(git hash-object file_001) &&\n+ nr=$(index_obj_nr \".git/objects/pack/pack-${pack1}.idx\" $obj) &&\n chmod +w \".git/objects/pack/pack-${pack1}.idx\" &&\n printf xxxx | dd of=\".git/objects/pack/pack-${pack1}.idx\" conv=notrunc \\\n- bs=1 count=4 seek=$((8 + 256 * 4 + `wc -l /dev/null || exit 1\n done \n---\n t/t5303-pack-corruption-resilience.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh\nindex 663b02b..98bed18 100755\n--- a/t/t5303-pack-corruption-resilience.sh\n+++ b/t/t5303-pack-corruption-resilience.sh\n@@ -32,9 +32,9 @@ create_test_files() {\n create_new_pack() {\n rm -rf .git &&\n git init &&\n- blob_1=`git hash-object -t blob -w file_1` &&\n- blob_2=`git hash-object -t blob -w file_2` &&\n- blob_3=`git hash-object -t blob -w file_3` &&\n+ blob_1=$(git hash-object -t blob -w file_1) &&\n+ blob_2=$(git hash-object -t blob -w file_2) &&\n+ blob_3=$(git hash-object -t blob -w file_3) &&\n pack=`printf \"$blob_1\\n$blob_2\\n$blob_3\\n\" |\n git pack-objects $@ .git/objects/pack/pack` &&\n pack=\".git/objects/pack/pack-${pack}\" &&\n@@ -48,7 +48,7 @@ do_repack() {\n }\n \n do_corrupt_object() {\n- ofs=`git show-index < ${pack}.idx | grep $1 | cut -f1 -d\" \"` &&\n+ ofs=$(git show-index < ${pack}.idx | grep $1 | cut -f1 -d\" \") &&\n ofs=$(($ofs + $2)) &&\n chmod +w ${pack}.pack &&\n dd of=${pack}.pack bs=1 conv=notrunc seek=$ofs &&\n-- \n1.7.10.4\n"},{"id":"237718","messageId":"1395768283-31135-58-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 057/142] t5304-prune.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:18Z","receivedAt":"2014-03-25T17:23:18Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5304-prune.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5304-prune.sh b/t/t5304-prune.sh\nindex 66c9a41..84501a5 100755\n--- a/t/t5304-prune.sh\n+++ b/t/t5304-prune.sh\n@@ -222,7 +222,7 @@ EOF\n '\n \n test_expect_success 'prune .git/shallow' '\n-\tSHA1=`echo hi|git commit-tree HEAD^{tree}` &&\n+\tSHA1=$(echo hi|git commit-tree HEAD^{tree}) &&\n \techo $SHA1 >.git/shallow &&\n \tgit prune --dry-run >out &&\n \tgrep $SHA1 .git/shallow &&\n-- \n1.7.10.4\n"},{"id":"237725","messageId":"1395768283-31135-59-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 058/142] t5305-include-tag.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:19Z","receivedAt":"2014-03-25T17:23:19Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5305-include-tag.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh\nindex b061864..74b4a03 100755\n--- a/t/t5305-include-tag.sh\n+++ b/t/t5305-include-tag.sh\n@@ -3,20 +3,20 @@\n test_description='git pack-object --include-tag'\n . ./test-lib.sh\n \n-TRASH=`pwd`\n+TRASH=$(pwd)\n \n test_expect_success setup '\n \techo c >d &&\n \tgit update-index --add d &&\n-\ttree=`git write-tree` &&\n-\tcommit=`git commit-tree $tree sig &&\n \techo \"type commit\" >>sig &&\n \techo \"tag mytag\" >>sig &&\n \techo \"tagger $(git var GIT_COMMITTER_IDENT)\" >>sig &&\n \techo >>sig &&\n \techo \"our test tag\" >>sig &&\n-\ttag=`git mktag \n---\n t/t5500-fetch-pack.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh\nindex 5b2b1c2..99b81e2 100755\n--- a/t/t5500-fetch-pack.sh\n+++ b/t/t5500-fetch-pack.sh\n@@ -14,7 +14,7 @@ test_description='Testing multi_ack pack fetching'\n add () {\n \tname=$1 &&\n \ttext=\"$@\" &&\n-\tbranch=`echo $name | sed -e 's/^\\(.\\).*$/\\1/'` &&\n+\tbranch=$(echo $name | sed -e 's/^\\(.\\).*$/\\1/') &&\n \tparents=\"\" &&\n \n \tshift &&\n@@ -56,12 +56,12 @@ pull_to_client () {\n \t\t\tgit fsck --full &&\n \n \t\t\tmv .git/objects/pack/pack-* . &&\n-\t\t\tp=`ls -1 pack-*.pack` &&\n+\t\t\tp=$(ls -1 pack-*.pack) &&\n \t\t\tgit unpack-objects <$p &&\n \t\t\tgit fsck --full &&\n \n-\t\t\tidx=`echo pack-*.idx` &&\n-\t\t\tpack_count=`git show-index <$idx | wc -l` &&\n+\t\t\tidx=$(echo pack-*.idx) &&\n+\t\t\tpack_count=$(git show-index <$idx | wc -l) &&\n \t\t\ttest $pack_count = $count &&\n \t\t\trm -f pack-*\n \t\t)\n@@ -132,13 +132,13 @@ test_expect_success 'single given branch clone' '\n \n test_expect_success 'clone shallow depth 1' '\n \tgit clone --no-single-branch --depth 1 \"file://$(pwd)/.\" shallow0 &&\n-\ttest \"`git --git-dir=shallow0/.git rev-list --count HEAD`\" = 1\n+\ttest \"$(git --git-dir=shallow0/.git rev-list --count HEAD)\" = 1\n '\n \n test_expect_success 'clone shallow depth 1 with fsck' '\n \tgit config --global fetch.fsckobjects true &&\n \tgit clone --no-single-branch --depth 1 \"file://$(pwd)/.\" shallow0fsck &&\n-\ttest \"`git --git-dir=shallow0fsck/.git rev-list --count HEAD`\" = 1 &&\n+\ttest \"$(git --git-dir=shallow0fsck/.git rev-list --count HEAD)\" = 1 &&\n \tgit config --global --unset fetch.fsckobjects\n '\n \n@@ -147,7 +147,7 @@ test_expect_success 'clone shallow' '\n '\n \n test_expect_success 'clone shallow depth count' '\n-\ttest \"`git --git-dir=shallow/.git rev-list --count HEAD`\" = 2\n+\ttest \"$(git --git-dir=shallow/.git rev-list --count HEAD)\" = 2\n '\n \n test_expect_success 'clone shallow object count' '\n@@ -273,7 +273,7 @@ test_expect_success 'additional simple shallow deepenings' '\n '\n \n test_expect_success 'clone shallow depth count' '\n-\ttest \"`git --git-dir=shallow/.git rev-list --count HEAD`\" = 11\n+\ttest \"$(git --git-dir=shallow/.git rev-list --count HEAD)\" = 11\n '\n \n test_expect_success 'clone shallow object count' '\n-- \n1.7.10.4\n"},{"id":"237701","messageId":"1395768283-31135-61-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 060/142] t5505-remote.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:21Z","receivedAt":"2014-03-25T17:23:21Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5505-remote.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5505-remote.sh b/t/t5505-remote.sh\nindex ac79dd9..366a583 100755\n--- a/t/t5505-remote.sh\n+++ b/t/t5505-remote.sh\n@@ -85,7 +85,7 @@ test_expect_success C_LOCALE_OUTPUT 'check remote-tracking' '\n test_expect_success 'remote forces tracking branches' '\n \t(\n \t\tcd test &&\n-\t\tcase `git config remote.second.fetch` in\n+\t\tcase $(git config remote.second.fetch) in\n \t\t+*) true ;;\n \t\t *) false ;;\n \t\tesac\n-- \n1.7.10.4\n"},{"id":"237737","messageId":"1395768283-31135-62-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 061/142] t5506-remote-groups.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:22Z","receivedAt":"2014-03-25T17:23:22Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5506-remote-groups.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5506-remote-groups.sh b/t/t5506-remote-groups.sh\nindex 530b016..83d5558 100755\n--- a/t/t5506-remote-groups.sh\n+++ b/t/t5506-remote-groups.sh\n@@ -20,7 +20,7 @@ update_repos() {\n }\n \n repo_fetched() {\n-\tif test \"`git log -1 --pretty=format:%s $1 --`\" = \"`cat mark`\"; then\n+\tif test \"$(git log -1 --pretty=format:%s $1 --)\" = \"$(cat mark)\"; then\n \t\techo >&2 \"repo was fetched: $1\"\n \t\treturn 0\n \tfi\n-- \n1.7.10.4\n"},{"id":"237730","messageId":"1395768283-31135-63-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 062/142] t5510-fetch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:23Z","receivedAt":"2014-03-25T17:23:23Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5510-fetch.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh\nindex ab28594..31b185e 100755\n--- a/t/t5510-fetch.sh\n+++ b/t/t5510-fetch.sh\n@@ -7,7 +7,7 @@ test_description='Per branch config variables affects \"git fetch\".\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n test_bundle_object_count () {\n \tgit verify-pack -v \"$1\" >verify.out &&\n@@ -64,8 +64,8 @@ test_expect_success \"fetch test\" '\n \tcd two &&\n \tgit fetch &&\n \ttest -f .git/refs/heads/one &&\n-\tmine=`git rev-parse refs/heads/one` &&\n-\this=`cd ../one && git rev-parse refs/heads/master` &&\n+\tmine=$(git rev-parse refs/heads/one) &&\n+\this=$(cd ../one && git rev-parse refs/heads/master) &&\n \ttest \"z$mine\" = \"z$his\"\n '\n \n@@ -75,8 +75,8 @@ test_expect_success \"fetch test for-merge\" '\n \tgit fetch &&\n \ttest -f .git/refs/heads/two &&\n \ttest -f .git/refs/heads/one &&\n-\tmaster_in_two=`cd ../two && git rev-parse master` &&\n-\tone_in_two=`cd ../two && git rev-parse one` &&\n+\tmaster_in_two=$(cd ../two && git rev-parse master) &&\n+\tone_in_two=$(cd ../two && git rev-parse one) &&\n \t{\n \t\techo \"$one_in_two\t\"\n \t\techo \"$master_in_two\tnot-for-merge\"\n-- \n1.7.10.4\n"},{"id":"237720","messageId":"1395768283-31135-64-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 063/142] t5515-fetch-merge-logic.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:24Z","receivedAt":"2014-03-25T17:23:24Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5515-fetch-merge-logic.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5515-fetch-merge-logic.sh b/t/t5515-fetch-merge-logic.sh\nindex dbb927d..36b0dbc 100755\n--- a/t/t5515-fetch-merge-logic.sh\n+++ b/t/t5515-fetch-merge-logic.sh\n@@ -128,8 +128,8 @@ do\n \tcase \"$cmd\" in\n \t'' | '#'*) continue ;;\n \tesac\n-\ttest=`echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g'`\n-\tpfx=`printf \"%04d\" $test_count`\n+\ttest=$(echo \"$cmd\" | sed -e 's|[/ ][/ ]*|_|g')\n+\tpfx=$(printf \"%04d\" $test_count)\n \texpect_f=\"$TEST_DIRECTORY/t5515/fetch.$test\"\n \tactual_f=\"$pfx-fetch.$test\"\n \texpect_r=\"$TEST_DIRECTORY/t5515/refs.$test\"\n-- \n1.7.10.4\n"},{"id":"237728","messageId":"1395768283-31135-65-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 064/142] t5516-fetch-push.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:25Z","receivedAt":"2014-03-25T17:23:25Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5516-fetch-push.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh\nindex 67e0ab3..a9ed84e 100755\n--- a/t/t5516-fetch-push.sh\n+++ b/t/t5516-fetch-push.sh\n@@ -15,7 +15,7 @@ This test checks the following functionality:\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n mk_empty () {\n \trepo_name=\"$1\"\n@@ -421,7 +421,7 @@ test_expect_success 'push tag with non-existent, incomplete dest' '\n test_expect_success 'push sha1 with non-existent, incomplete dest' '\n \n \tmk_test testrepo &&\n-\ttest_must_fail git push testrepo `git rev-parse master`:foo\n+\ttest_must_fail git push testrepo $(git rev-parse master):foo\n \n '\n \n-- \n1.7.10.4\n"},{"id":"237700","messageId":"1395768283-31135-66-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 065/142] t5517-push-mirror.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:26Z","receivedAt":"2014-03-25T17:23:26Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5517-push-mirror.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5517-push-mirror.sh b/t/t5517-push-mirror.sh\nindex 12a5dfb..02f160a 100755\n--- a/t/t5517-push-mirror.sh\n+++ b/t/t5517-push-mirror.sh\n@@ -4,7 +4,7 @@ test_description='pushing to a mirror repository'\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n invert () {\n \tif \"$@\"; then\n-- \n1.7.10.4\n"},{"id":"237697","messageId":"1395768283-31135-67-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 066/142] t5520-pull.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:27Z","receivedAt":"2014-03-25T17:23:27Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5520-pull.sh | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5520-pull.sh b/t/t5520-pull.sh\nindex 227d293..a68c099 100755\n--- a/t/t5520-pull.sh\n+++ b/t/t5520-pull.sh\n@@ -9,7 +9,7 @@ modify () {\n \tmv \"$2.x\" \"$2\"\n }\n \n-D=`pwd`\n+D=$(pwd)\n \n test_expect_success setup '\n \n@@ -94,9 +94,9 @@ test_expect_success 'test . as a remote' '\n \techo updated >file &&\n \tgit commit -a -m updated &&\n \tgit checkout copy &&\n-\ttest `cat file` = file &&\n+\ttest $(cat file) = file &&\n \tgit pull &&\n-\ttest `cat file` = updated\n+\ttest $(cat file) = updated\n '\n \n test_expect_success 'the default remote . should not break explicit pull' '\n@@ -105,9 +105,9 @@ test_expect_success 'the default remote . should not break explicit pull' '\n \tgit commit -a -m modified &&\n \tgit checkout copy &&\n \tgit reset --hard HEAD^ &&\n-\ttest `cat file` = file &&\n+\ttest $(cat file) = file &&\n \tgit pull . second &&\n-\ttest `cat file` = modified\n+\ttest $(cat file) = modified\n '\n \n test_expect_success '--rebase' '\n-- \n1.7.10.4\n"},{"id":"237717","messageId":"1395768283-31135-68-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 067/142] t5522-pull-symlink.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:28Z","receivedAt":"2014-03-25T17:23:28Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5522-pull-symlink.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5522-pull-symlink.sh b/t/t5522-pull-symlink.sh\nindex 8e9b204..bcff460 100755\n--- a/t/t5522-pull-symlink.sh\n+++ b/t/t5522-pull-symlink.sh\n@@ -54,7 +54,7 @@ test_expect_success SYMLINKS 'pulling from real subdir' '\n # git rev-parse --show-cdup printed a path relative to\n # clone-repo/subdir/, not subdir-link/. Git rev-parse --show-cdup\n # used the correct .git, but when the git pull shell script did\n-# \"cd `git rev-parse --show-cdup`\", it ended up in the wrong\n+# \"cd $(git rev-parse --show-cdup)\", it ended up in the wrong\n # directory. A POSIX shell's \"cd\" works a little differently\n # than chdir() in C; \"cd -P\" is much closer to chdir().\n #\n-- \n1.7.10.4\n"},{"id":"237703","messageId":"1395768283-31135-69-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 068/142] t5530-upload-pack-error.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:29Z","receivedAt":"2014-03-25T17:23:29Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5530-upload-pack-error.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5530-upload-pack-error.sh b/t/t5530-upload-pack-error.sh\nindex 3932e79..4f6e32b 100755\n--- a/t/t5530-upload-pack-error.sh\n+++ b/t/t5530-upload-pack-error.sh\n@@ -4,7 +4,7 @@ test_description='errors in upload-pack'\n \n . ./test-lib.sh\n \n-D=`pwd`\n+D=$(pwd)\n \n corrupt_repo () {\n \tobject_sha1=$(git rev-parse \"$1\") &&\n-- \n1.7.10.4\n"},{"id":"237709","messageId":"1395768283-31135-70-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 069/142] t5537-fetch-shallow.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:30Z","receivedAt":"2014-03-25T17:23:30Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5537-fetch-shallow.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh\nindex be951a4..d9ea98a 100755\n--- a/t/t5537-fetch-shallow.sh\n+++ b/t/t5537-fetch-shallow.sh\n@@ -98,7 +98,7 @@ EOF\n test_expect_success 'fetch something upstream has but hidden by clients shallow boundaries' '\n \t# the blob \"1\" is available in .git but hidden by the\n \t# shallow2/.git/shallow and it should be resent\n-\t! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` >/dev/null &&\n+\t! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null &&\n \techo 1 >1.t &&\n \tgit add 1.t &&\n \tgit commit -m add-1-back &&\n@@ -114,7 +114,7 @@ add-1-back\n EOF\n \ttest_cmp expect actual\n \t) &&\n-\tgit --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` >/dev/null\n+\tgit --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) >/dev/null\n \n '\n \n-- \n1.7.10.4\n"},{"id":"237699","messageId":"1395768283-31135-71-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 070/142] t5538-push-shallow.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:31Z","receivedAt":"2014-03-25T17:23:31Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5538-push-shallow.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5538-push-shallow.sh b/t/t5538-push-shallow.sh\nindex 8e54ac5..23a729a 100755\n--- a/t/t5538-push-shallow.sh\n+++ b/t/t5538-push-shallow.sh\n@@ -104,7 +104,7 @@ EOF\n '\n \n test_expect_success 'push from full to shallow' '\n-\t! git --git-dir=shallow2/.git cat-file blob `echo 1|git hash-object --stdin` &&\n+\t! git --git-dir=shallow2/.git cat-file blob $(echo 1|git hash-object --stdin) &&\n \tcommit 1 &&\n \tgit push shallow2/.git +master:refs/remotes/top/master &&\n \t(\n@@ -117,7 +117,7 @@ test_expect_success 'push from full to shallow' '\n 3\n EOF\n \ttest_cmp expect actual &&\n-\tgit cat-file blob `echo 1|git hash-object --stdin` >/dev/null\n+\tgit cat-file blob $(echo 1|git hash-object --stdin) >/dev/null\n \t)\n '\n \n-- \n1.7.10.4\n"},{"id":"237727","messageId":"1395768283-31135-72-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 071/142] t5550-http-fetch-dumb.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:32Z","receivedAt":"2014-03-25T17:23:32Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5550-http-fetch-dumb.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\nindex 1a3a2b6..5ccb271 100755\n--- a/t/t5550-http-fetch-dumb.sh\n+++ b/t/t5550-http-fetch-dumb.sh\n@@ -138,7 +138,7 @@ test_expect_success 'fetch packed objects' '\n test_expect_success 'fetch notices corrupt pack' '\n \tcp -R \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n \t(cd \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n-\t p=`ls objects/pack/pack-*.pack` &&\n+\t p=$(ls objects/pack/pack-*.pack) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -146,14 +146,14 @@ test_expect_success 'fetch notices corrupt pack' '\n \t(cd repo_bad1.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad1.git &&\n-\t test 0 = `ls objects/pack/pack-*.pack | wc -l`\n+\t test 0 = $(ls objects/pack/pack-*.pack | wc -l)\n \t)\n '\n \n test_expect_success 'fetch notices corrupt idx' '\n \tcp -R \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n \t(cd \"$HTTPD_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n-\t p=`ls objects/pack/pack-*.idx` &&\n+\t p=$(ls objects/pack/pack-*.idx) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -161,7 +161,7 @@ test_expect_success 'fetch notices corrupt idx' '\n \t(cd repo_bad2.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch $HTTPD_URL/dumb/repo_bad2.git &&\n-\t test 0 = `ls objects/pack | wc -l`\n+\t test 0 = $(ls objects/pack | wc -l)\n \t)\n '\n \n-- \n1.7.10.4\n"},{"id":"237734","messageId":"1395768283-31135-73-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 072/142] t5551-http-fetch-smart.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:33Z","receivedAt":"2014-03-25T17:23:33Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5551-http-fetch-smart.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh\nindex e07eaf3..232c5ac 100755\n--- a/t/t5551-http-fetch-smart.sh\n+++ b/t/t5551-http-fetch-smart.sh\n@@ -218,7 +218,7 @@ test -n \"$GIT_TEST_LONG\" && test_set_prereq EXPENSIVE\n test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '\n \t(\n \tcd \"$HTTPD_DOCUMENT_ROOT_PATH/repo.git\" &&\n-\tfor i in `test_seq 50000`\n+\tfor i in $(test_seq 50000)\n \tdo\n \t\techo \"commit refs/heads/too-many-refs\"\n \t\techo \"mark :$i\"\n-- \n1.7.10.4\n"},{"id":"237710","messageId":"1395768283-31135-74-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 073/142] t5570-git-daemon.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:34Z","receivedAt":"2014-03-25T17:23:34Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5570-git-daemon.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh\nindex 6b16379..eb07dbe 100755\n--- a/t/t5570-git-daemon.sh\n+++ b/t/t5570-git-daemon.sh\n@@ -57,7 +57,7 @@ test_expect_success 'prepare pack objects' '\n test_expect_success 'fetch notices corrupt pack' '\n \tcp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n \t(cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad1.git &&\n-\t p=`ls objects/pack/pack-*.pack` &&\n+\t p=$(ls objects/pack/pack-*.pack) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -65,14 +65,14 @@ test_expect_success 'fetch notices corrupt pack' '\n \t(cd repo_bad1.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad1.git\" &&\n-\t test 0 = `ls objects/pack/pack-*.pack | wc -l`\n+\t test 0 = $(ls objects/pack/pack-*.pack | wc -l)\n \t)\n '\n \n test_expect_success 'fetch notices corrupt idx' '\n \tcp -R \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_pack.git \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n \t(cd \"$GIT_DAEMON_DOCUMENT_ROOT_PATH\"/repo_bad2.git &&\n-\t p=`ls objects/pack/pack-*.idx` &&\n+\t p=$(ls objects/pack/pack-*.idx) &&\n \t chmod u+w $p &&\n \t printf %0256d 0 | dd of=$p bs=256 count=1 seek=1 conv=notrunc\n \t) &&\n@@ -80,7 +80,7 @@ test_expect_success 'fetch notices corrupt idx' '\n \t(cd repo_bad2.git &&\n \t git --bare init &&\n \t test_must_fail git --bare fetch \"$GIT_DAEMON_URL/repo_bad2.git\" &&\n-\t test 0 = `ls objects/pack | wc -l`\n+\t test 0 = $(ls objects/pack | wc -l)\n \t)\n '\n \n-- \n1.7.10.4\n"},{"id":"237722","messageId":"1395768283-31135-75-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 074/142] t5601-clone.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:35Z","receivedAt":"2014-03-25T17:23:35Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5601-clone.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex 5e67035..fbe83a1 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -221,7 +221,7 @@ test_expect_success 'clone separate gitdir' '\n '\n \n test_expect_success 'clone separate gitdir: output' '\n-\techo \"gitdir: `pwd`/realgitdir\" >expected &&\n+\techo \"gitdir: $(pwd)/realgitdir\" >expected &&\n \ttest_cmp expected dst/.git\n '\n \n-- \n1.7.10.4\n"},{"id":"237696","messageId":"1395768283-31135-76-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 075/142] t5700-clone-reference.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:36Z","receivedAt":"2014-03-25T17:23:36Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5700-clone-reference.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5700-clone-reference.sh b/t/t5700-clone-reference.sh\nindex 6537911..571aee4 100755\n--- a/t/t5700-clone-reference.sh\n+++ b/t/t5700-clone-reference.sh\n@@ -6,7 +6,7 @@\n test_description='test clone --reference'\n . ./test-lib.sh\n \n-base_dir=`pwd`\n+base_dir=$(pwd)\n \n U=$base_dir/UPLOAD_LOG\n \n-- \n1.7.10.4\n"},{"id":"237706","messageId":"1395768283-31135-77-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 076/142] t5710-info-alternate.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:37Z","receivedAt":"2014-03-25T17:23:37Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5710-info-alternate.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh\nindex 5a6e49d..9cd2626 100755\n--- a/t/t5710-info-alternate.sh\n+++ b/t/t5710-info-alternate.sh\n@@ -21,7 +21,7 @@ test_valid_repo() {\n \ttest_line_count = 0 fsck.log\n }\n \n-base_dir=`pwd`\n+base_dir=$(pwd)\n \n test_expect_success 'preparing first repository' \\\n 'test_create_repo A && cd A &&\n-- \n1.7.10.4\n"},{"id":"237726","messageId":"1395768283-31135-78-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 077/142] t5900-repo-selection.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:38Z","receivedAt":"2014-03-25T17:23:38Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t5900-repo-selection.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5900-repo-selection.sh b/t/t5900-repo-selection.sh\nindex 3d5b418..14e59c5 100755\n--- a/t/t5900-repo-selection.sh\n+++ b/t/t5900-repo-selection.sh\n@@ -15,7 +15,7 @@ make_tree() {\n make_bare() {\n \tgit init --bare \"$1\" &&\n \t(cd \"$1\" &&\n-\t tree=`git hash-object -w -t tree /dev/null` &&\n+\t tree=$(git hash-object -w -t tree /dev/null) &&\n \t commit=$(echo \"$1\" | git commit-tree $tree) &&\n \t git update-ref HEAD $commit\n \t)\n-- \n1.7.10.4\n"},{"id":"237736","messageId":"1395768283-31135-79-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 078/142] t6001-rev-list-graft.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:39Z","receivedAt":"2014-03-25T17:23:39Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6001-rev-list-graft.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t6001-rev-list-graft.sh b/t/t6001-rev-list-graft.sh\nindex 8efcd13..05ddc69 100755\n--- a/t/t6001-rev-list-graft.sh\n+++ b/t/t6001-rev-list-graft.sh\n@@ -10,15 +10,15 @@ test_expect_success setup '\n \techo >subdir/fileB fileB &&\n \tgit add fileA subdir/fileB &&\n \tgit commit -a -m \"Initial in one history.\" &&\n-\tA0=`git rev-parse --verify HEAD` &&\n+\tA0=$(git rev-parse --verify HEAD) &&\n \n \techo >fileA fileA modified &&\n \tgit commit -a -m \"Second in one history.\" &&\n-\tA1=`git rev-parse --verify HEAD` &&\n+\tA1=$(git rev-parse --verify HEAD) &&\n \n \techo >subdir/fileB fileB modified &&\n \tgit commit -a -m \"Third in one history.\" &&\n-\tA2=`git rev-parse --verify HEAD` &&\n+\tA2=$(git rev-parse --verify HEAD) &&\n \n \trm -f .git/refs/heads/master .git/index &&\n \n@@ -26,15 +26,15 @@ test_expect_success setup '\n \techo >subdir/fileB fileB again &&\n \tgit add fileA subdir/fileB &&\n \tgit commit -a -m \"Initial in alternate history.\" &&\n-\tB0=`git rev-parse --verify HEAD` &&\n+\tB0=$(git rev-parse --verify HEAD) &&\n \n \techo >fileA fileA modified in alternate history &&\n \tgit commit -a -m \"Second in alternate history.\" &&\n-\tB1=`git rev-parse --verify HEAD` &&\n+\tB1=$(git rev-parse --verify HEAD) &&\n \n \techo >subdir/fileB fileB modified in alternate history &&\n \tgit commit -a -m \"Third in alternate history.\" &&\n-\tB2=`git rev-parse --verify HEAD` &&\n+\tB2=$(git rev-parse --verify HEAD) &&\n \t: done\n '\n \n-- \n1.7.10.4\n"},{"id":"237714","messageId":"1395768283-31135-80-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 079/142] t6002-rev-list-bisect.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:40Z","receivedAt":"2014-03-25T17:23:40Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6002-rev-list-bisect.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t6002-rev-list-bisect.sh b/t/t6002-rev-list-bisect.sh\nindex 43ad772..3bf2759 100755\n--- a/t/t6002-rev-list-bisect.sh\n+++ b/t/t6002-rev-list-bisect.sh\n@@ -27,9 +27,9 @@ test_bisection_diff()\n \t# Test if bisection size is close to half of list size within\n \t# tolerance.\n \t#\n-\t_bisect_err=`expr $_list_size - $_bisection_size \\* 2`\n-\ttest \"$_bisect_err\" -lt 0 && _bisect_err=`expr 0 - $_bisect_err`\n-\t_bisect_err=`expr $_bisect_err / 2` ; # floor\n+\t_bisect_err=$(expr $_list_size - $_bisection_size \\* 2)\n+\ttest \"$_bisect_err\" -lt 0 && _bisect_err=$(expr 0 - $_bisect_err)\n+\t_bisect_err=$(expr $_bisect_err / 2) ; # floor\n \n \ttest_expect_success \\\n \t\"bisection diff $_bisect_option $_head $* <= $_max_diff\" \\\n-- \n1.7.10.4\n"},{"id":"237716","messageId":"1395768283-31135-81-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 080/142] t6015-rev-list-show-all-parents.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:41Z","receivedAt":"2014-03-25T17:23:41Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6015-rev-list-show-all-parents.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t6015-rev-list-show-all-parents.sh b/t/t6015-rev-list-show-all-parents.sh\nindex 8b146fb..3c73c93 100755\n--- a/t/t6015-rev-list-show-all-parents.sh\n+++ b/t/t6015-rev-list-show-all-parents.sh\n@@ -6,11 +6,11 @@ test_description='--show-all --parents does not rewrite TREESAME commits'\n \n test_expect_success 'set up --show-all --parents test' '\n \ttest_commit one foo.txt &&\n-\tcommit1=`git rev-list -1 HEAD` &&\n+\tcommit1=$(git rev-list -1 HEAD) &&\n \ttest_commit two bar.txt &&\n-\tcommit2=`git rev-list -1 HEAD` &&\n+\tcommit2=$(git rev-list -1 HEAD) &&\n \ttest_commit three foo.txt &&\n-\tcommit3=`git rev-list -1 HEAD`\n+\tcommit3=$(git rev-list -1 HEAD)\n \t'\n \n test_expect_success '--parents rewrites TREESAME parents correctly' '\n-- \n1.7.10.4\n"},{"id":"237708","messageId":"1395768283-31135-82-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 081/142] t6032-merge-large-rename.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:42Z","receivedAt":"2014-03-25T17:23:42Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6032-merge-large-rename.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t6032-merge-large-rename.sh b/t/t6032-merge-large-rename.sh\nindex 15beecc..36019df 100755\n--- a/t/t6032-merge-large-rename.sh\n+++ b/t/t6032-merge-large-rename.sh\n@@ -20,7 +20,7 @@ test_expect_success 'setup (initial)' '\n \n make_text() {\n \techo $1: $2\n-\tfor i in `count 20`; do\n+\tfor i in $(count 20); do\n \t\techo $1: $i\n \tdone\n \techo $1: $3\n-- \n1.7.10.4\n"},{"id":"237698","messageId":"1395768283-31135-83-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 082/142] t6034-merge-rename-nocruft.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:43Z","receivedAt":"2014-03-25T17:23:43Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6034-merge-rename-nocruft.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t6034-merge-rename-nocruft.sh b/t/t6034-merge-rename-nocruft.sh\nindex 65be95f..34f17be 100755\n--- a/t/t6034-merge-rename-nocruft.sh\n+++ b/t/t6034-merge-rename-nocruft.sh\n@@ -117,7 +117,7 @@ test_expect_success 'merge blue into white (A->B, mod A, A untracked)' \\\n \t\techo \"BAD: A does not exist in working directory\"\n \t\treturn 1\n \t}\n-\ttest `cat A` = dirty || {\n+\ttest $(cat A) = dirty || {\n \t\techo \"BAD: A content is wrong\"\n \t\treturn 1\n \t}\n-- \n1.7.10.4\n"},{"id":"237705","messageId":"1395768283-31135-84-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 083/142] t6132-pathspec-exclude.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:44Z","receivedAt":"2014-03-25T17:23:44Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t6132-pathspec-exclude.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t6132-pathspec-exclude.sh b/t/t6132-pathspec-exclude.sh\nindex 62049be..801afae 100755\n--- a/t/t6132-pathspec-exclude.sh\n+++ b/t/t6132-pathspec-exclude.sh\n@@ -7,7 +7,7 @@ test_description='test case exclude pathspec'\n test_expect_success 'setup' '\n \tfor p in file sub/file sub/sub/file sub/file2 sub/sub/sub/file sub2/file; do\n \t\tif echo $p | grep /; then\n-\t\t\tmkdir -p `dirname $p`\n+\t\t\tmkdir -p $(dirname $p)\n \t\tfi &&\n \t\t: >$p &&\n \t\tgit add $p &&\n-- \n1.7.10.4\n"},{"id":"237721","messageId":"1395768283-31135-85-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 084/142] t7001-mv.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:45Z","receivedAt":"2014-03-25T17:23:45Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7001-mv.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t7001-mv.sh b/t/t7001-mv.sh\nindex e3c8c2c..23564bf 100755\n--- a/t/t7001-mv.sh\n+++ b/t/t7001-mv.sh\n@@ -156,11 +156,11 @@ test_expect_success \"Michael Cassar's test case\" '\n \techo b > partA/outline.txt &&\n \techo c > papers/unsorted/_another &&\n \tgit add papers partA &&\n-\tT1=`git write-tree` &&\n+\tT1=$(git write-tree) &&\n \n \tgit mv papers/unsorted/Thesis.pdf papers/all-papers/moo-blah.pdf &&\n \n-\tT=`git write-tree` &&\n+\tT=$(git write-tree) &&\n \tgit ls-tree -r $T | grep partA/outline.txt || {\n \t\tgit ls-tree -r $T\n \t\t(exit 1)\n-- \n1.7.10.4\n"},{"id":"237713","messageId":"1395768283-31135-86-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 085/142] t7003-filter-branch.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:46Z","receivedAt":"2014-03-25T17:23:46Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7003-filter-branch.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh\nindex 9496736..87459a5 100755\n--- a/t/t7003-filter-branch.sh\n+++ b/t/t7003-filter-branch.sh\n@@ -362,7 +362,7 @@ test_expect_success 'setup submodule' '\n \tgit branch original HEAD\n '\n \n-orig_head=`git show-ref --hash --head HEAD`\n+orig_head=$(git show-ref --hash --head HEAD)\n \n test_expect_success 'rewrite submodule with another content' '\n \tgit filter-branch --tree-filter \"test -d submod && {\n@@ -371,7 +371,7 @@ test_expect_success 'rewrite submodule with another content' '\n \t\t\t\t\t mkdir submod &&\n \t\t\t\t\t : > submod/file\n \t\t\t\t\t } || :\" HEAD &&\n-\ttest $orig_head != `git show-ref --hash --head HEAD`\n+\ttest $orig_head != $(git show-ref --hash --head HEAD)\n '\n \n test_expect_success 'replace submodule revision' '\n@@ -380,7 +380,7 @@ test_expect_success 'replace submodule revision' '\n \t \"if git ls-files --error-unmatch -- submod > /dev/null 2>&1\n \t then git update-index --cacheinfo 160000 0123456789012345678901234567890123456789 submod\n \t fi\" HEAD &&\n-\ttest $orig_head != `git show-ref --hash --head HEAD`\n+\ttest $orig_head != $(git show-ref --hash --head HEAD)\n '\n \n test_done\n-- \n1.7.10.4\n"},{"id":"237704","messageId":"1395768283-31135-87-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 086/142] t7004-tag.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:47Z","receivedAt":"2014-03-25T17:23:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7004-tag.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\nindex 143a8ea..2ed8fc0 100755\n--- a/t/t7004-tag.sh\n+++ b/t/t7004-tag.sh\n@@ -23,8 +23,8 @@ test_expect_success 'listing all tags in an empty tree should succeed' '\n '\n \n test_expect_success 'listing all tags in an empty tree should output nothing' '\n-\ttest `git tag -l | wc -l` -eq 0 &&\n-\ttest `git tag | wc -l` -eq 0\n+\ttest $(git tag -l | wc -l) -eq 0 &&\n+\ttest $(git tag | wc -l) -eq 0\n '\n \n test_expect_success 'looking for a tag in an empty tree should fail' \\\n@@ -60,8 +60,8 @@ test_expect_success 'listing all tags if one exists should succeed' '\n '\n \n test_expect_success 'listing all tags if one exists should output that tag' '\n-\ttest `git tag -l` = mytag &&\n-\ttest `git tag` = mytag\n+\ttest $(git tag -l) = mytag &&\n+\ttest $(git tag) = mytag\n '\n \n # pattern matching:\n@@ -71,7 +71,7 @@ test_expect_success 'listing a tag using a matching pattern should succeed' \\\n \n test_expect_success \\\n \t'listing a tag using a matching pattern should output that tag' \\\n-\t'test `git tag -l mytag` = mytag'\n+\t'test $(git tag -l mytag) = mytag'\n \n # todo: git tag -l now returns always zero, when fixed, change this test\n test_expect_success \\\n@@ -80,7 +80,7 @@ test_expect_success \\\n \n test_expect_success \\\n \t'listing tags using a non-matching pattern should output nothing' \\\n-\t'test `git tag -l xxx | wc -l` -eq 0'\n+\t'test $(git tag -l xxx | wc -l) -eq 0'\n \n # special cases for creating tags:\n \n@@ -90,13 +90,13 @@ test_expect_success \\\n \n test_expect_success \\\n \t'trying to create a tag with a non-valid name should fail' '\n-\ttest `git tag -l | wc -l` -eq 1 &&\n+\ttest $(git tag -l | wc -l) -eq 1 &&\n \ttest_must_fail git tag \"\" &&\n \ttest_must_fail git tag .othertag &&\n \ttest_must_fail git tag \"other tag\" &&\n \ttest_must_fail git tag \"othertag^\" &&\n \ttest_must_fail git tag \"other~tag\" &&\n-\ttest `git tag -l | wc -l` -eq 1\n+\ttest $(git tag -l | wc -l) -eq 1\n '\n \n test_expect_success 'creating a tag using HEAD directly should succeed' '\n-- \n1.7.10.4\n"},{"id":"237715","messageId":"1395768283-31135-88-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 087/142] t7006-pager.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:48Z","receivedAt":"2014-03-25T17:23:48Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7006-pager.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7006-pager.sh b/t/t7006-pager.sh\nindex b9365b4..7576fa9 100755\n--- a/t/t7006-pager.sh\n+++ b/t/t7006-pager.sh\n@@ -436,7 +436,7 @@ test_expect_success TTY 'command-specific pager works for external commands' '\n \techo \"foo:initial\" >expect &&\n \t>actual &&\n \ttest_config pager.external \"sed s/^/foo:/ >actual\" &&\n-\ttest_terminal git --exec-path=\"`pwd`\" external log --format=%s -1 &&\n+\ttest_terminal git --exec-path=\"$(pwd)\" external log --format=%s -1 &&\n \ttest_cmp expect actual\n '\n \n-- \n1.7.10.4\n"},{"id":"237712","messageId":"1395768283-31135-89-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 088/142] t7103-reset-bare.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:49Z","receivedAt":"2014-03-25T17:23:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7103-reset-bare.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7103-reset-bare.sh b/t/t7103-reset-bare.sh\nindex 1eef93c..afe36a5 100755\n--- a/t/t7103-reset-bare.sh\n+++ b/t/t7103-reset-bare.sh\n@@ -63,7 +63,7 @@ test_expect_success '\"mixed\" reset is not allowed in bare' '\n \n test_expect_success '\"soft\" reset is allowed in bare' '\n \tgit reset --soft HEAD^ &&\n-\ttest \"`git show --pretty=format:%s | head -n 1`\" = \"one\"\n+\ttest \"$(git show --pretty=format:%s | head -n 1)\" = \"one\"\n '\n \n test_done\n-- \n1.7.10.4\n"},{"id":"237711","messageId":"1395768283-31135-90-git-send-email-gitter.spiros@gmail.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"[PATCH v2 089/142] t7406-submodule-update.sh: use the $( ... ) construct for command substitution","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-25T17:23:50Z","receivedAt":"2014-03-25T17:23:50Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"The Git CodingGuidelines prefer the $( ... ) construct for command\nsubstitution instead of using the back-quotes, or grave accents (`..`).\n\nThe backquoted form is the historical method for command substitution,\nand is supported by POSIX. However, all but the simplest uses become\ncomplicated quickly. In particular, embedded command substitutions\nand/or the use of double quotes require careful escaping with the backslash\ncharacter. Because of this the POSIX shell adopted the $(…) feature from\nthe Korn shell.\n\nThe patch was generated by the simple script\n\nfor _f in $(find . -name \"*.sh\")\ndo\n  sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\ndone\n\nSigned-off-by: Elia Pinto \n---\n t/t7406-submodule-update.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh\nindex 28ca763..294a4a6 100755\n--- a/t/t7406-submodule-update.sh\n+++ b/t/t7406-submodule-update.sh\n@@ -14,8 +14,8 @@ submodule and \"git submodule update --rebase/--merge\" does not detach the HEAD.\n \n compare_head()\n {\n- sha_master=`git rev-list --max-count=1 master`\n- sha_head=`git rev-list --max-count=1 HEAD`\n+ sha_master=$(git rev-list --max-count=1 master)\n+ sha_head=$(git rev-list --max-count=1 HEAD)\n \n test \"$sha_master\" = \"$sha_head\"\n }\n-- \n1.7.10.4\n"},{"id":"237765","messageId":"xmqqy4zyktng.fsf@gitster.dls.corp.google.com","threadId":"36291","inReplyTo":"1395768283-31135-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-25T18:41:39Z","receivedAt":"2014-03-25T18:41:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto writes:\n\n> This is a second reroll after the \n> Matthieu Moy review. Changes from v1:\n>\n> - Dropped the silly patches to t6111-rev-list-treesame.sh, \n> t0204-gettext-reencode-sanity.sh.\n>\n> - Simple reformatting of the commit message.\n>\n> - added the toy script used for doing the patch.\n\nIn other words, Mattheiu pointed out two examples of breakages and\nthey were the only mistakes after you re-reviewed the mechanical\nchanges, and there is no more?\n\n - Cleaning up is a good thing, but\n\n - Mechanical and mindless conversion is always error-prone, and\n\n - Eyeballing each and every change is required, but\n\n - Nobody has time or energy to go through 140+ patches in one go,\n with enough concentration necessary to do so without making\n mistakes (this applies to yourself, too---producing mechanical\n replacement is a no-cost thing, finding mistakes in mechanical\n replacement takes real effort).\n\nThat is why we strongly discourage people from such a whole-tree\nclean-up just for the sake of clean-up and nothing else, and instead\nencourage them to clean-up as a preparatory step for real work on\nthe files involved. Sure, it would not give us as wide a coverage\nas a mechanical whole-tree replacement in one-go, but that is the\nonly practical way to avoid mistakes.\n\nIf it were \"four patches per every Monday\" kind of trickle, we might\nbe able to spend some review bandwidth while reviewing other\npatches, though.\n\nSo.... I am not very enthused about reviewing and applying these\npatches in their current form.\n\nThanks.\n"},{"id":"237767","messageId":"xmqqtxamkq4b.fsf@gitster.dls.corp.google.com","threadId":"36291","inReplyTo":"1395768283-31135-2-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-25T19:57:56Z","receivedAt":"2014-03-25T19:57:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto writes:\n\n> The Git CodingGuidelines prefer the $( ... ) construct for command\n> substitution instead of using the back-quotes, or grave accents (`..`).\n>\n> The backquoted form is the historical method for command substitution,\n> and is supported by POSIX. However, all but the simplest uses become\n> complicated quickly. In particular, embedded command substitutions\n> and/or the use of double quotes require careful escaping with the backslash\n> character. Because of this the POSIX shell adopted the $(…) feature from\n> the Korn shell.\n>\n> The patch was generated by the simple script\n>\n> for _f in $(find . -name \"*.sh\")\n> do\n>   sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n> done\n\n\"and then carefully proofread\" is sorely needed here.\n\nWhat is that non-breaking space doing at the beginning of an\nindented line, or is it just my environment, by the way?\n\n> Signed-off-by: Elia Pinto \n> ---\n> check-builtins.sh | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/check-builtins.sh b/check-builtins.sh\n> index d6fe6cf..07cff69 100755\n> --- a/check-builtins.sh\n> +++ b/check-builtins.sh\n> @@ -14,8 +14,8 @@ sort |\n> bad=0\n> while read builtin\n> do\n> -\tbase=`expr \"$builtin\" : 'git-\\(.*\\)'`\n> -\tx=`sed -ne 's/.*{ \"'$base'\", \\(cmd_[^, ]*\\).*/'$base'\t\\1/p' git.c`\n> +\tbase=$(expr \"$builtin\" : 'git-\\(.*\\)')\n> +\tx=$(sed -ne 's/.*{ \"'$base'\", \\(cmd_[^, ]*\\).*/'$base'\t\\1/p' git.c)\n> \tif test -z \"$x\"\n> \tthen\n> \t\techo \"$base is builtin but not listed in git.c command list\"\n\nLooks ok to me.\n"},{"id":"237768","messageId":"xmqqpplakpx5.fsf@gitster.dls.corp.google.com","threadId":"36291","inReplyTo":"1395768283-31135-10-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH v2 009/142] t0001-init.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-25T20:02:14Z","receivedAt":"2014-03-25T20:02:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"This conflicts with a topic in flight.\n"},{"id":"237796","messageId":"8738i6uihf.fsf@fencepost.gnu.org","threadId":"36291","inReplyTo":"xmqqtxamkq4b.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2014-03-25T20:32:44Z","receivedAt":"2014-03-25T20:32:44Z","isPatch":true,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"Junio C Hamano writes:\n\n> Elia Pinto writes:\n>\n>> The Git CodingGuidelines prefer the $( ... ) construct for command\n>> substitution instead of using the back-quotes, or grave accents (`..`).\n>>\n>> The backquoted form is the historical method for command substitution,\n>> and is supported by POSIX. However, all but the simplest uses become\n>> complicated quickly. In particular, embedded command substitutions\n>> and/or the use of double quotes require careful escaping with the backslash\n>> character. Because of this the POSIX shell adopted the $(…) feature from\n>> the Korn shell.\n>>\n>> The patch was generated by the simple script\n>>\n>> for _f in $(find . -name \"*.sh\")\n>> do\n>>   sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n>> done\n>\n> \"and then carefully proofread\" is sorely needed here.\n\nIt would already help to skip comment lines.\n\n-- \nDavid Kastrup\n"},{"id":"237771","messageId":"xmqqeh1qkobn.fsf@gitster.dls.corp.google.com","threadId":"36291","inReplyTo":"xmqqtxamkq4b.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-25T20:36:44Z","receivedAt":"2014-03-25T20:36:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Elia Pinto writes:\n>\n>> The Git CodingGuidelines prefer the $( ... ) construct for command\n>> substitution instead of using the back-quotes, or grave accents (`..`).\n>>\n>> The backquoted form is the historical method for command substitution,\n>> and is supported by POSIX. However, all but the simplest uses become\n>> complicated quickly. In particular, embedded command substitutions\n>> and/or the use of double quotes require careful escaping with the backslash\n>> character. Because of this the POSIX shell adopted the $(…) feature from\n>> the Korn shell.\n>>\n>> The patch was generated by the simple script\n>>\n>> for _f in $(find . -name \"*.sh\")\n>> do\n>>   sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n>> done\n>\n> \"and then carefully proofread\" is sorely needed here.\n>\n> What is that non-breaking space doing at the beginning of an\n> indented line, or is it just my environment, by the way?\n\nI've reworded the above like so:\n\n check-builtins.sh: use the $(...) construct for command substitution\n \n The Git CodingGuidelines prefer the $(...) construct for command\n substitution instead of using the backquotes, or grave accents\n (`...`).\n \n The backquoted form is the historical method for command\n substitution, and is supported by POSIX. However, all but the\n simplest uses become complicated quickly. In particular, embedded\n command substitutions and/or the use of double quotes require\n careful escaping with the backslash character.\n \n The patch was generated by:\n \n for _f in $(find . -name \"*.sh\")\n do\n sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n done\n \n and then carefully proof-read.\n \n Signed-off-by: Elia Pinto \n Signed-off-by: Junio C Hamano \n\n\nI looked at [*1*] to pick between \"back-quote\" and \"backquote\"; this\nis a related tangent, but in that page, you will find this gem:\n\n Within the backquoted style of command substitution, \n shall retain its literal meaning, except when followed by: '$',\n '`', or .\n\nStated another way, `` => $() conversion will make backslash inside\nto bahave differently, and we would need to be careful when doing\nsuch a change.\n\nI've looked at and queued 001 and 002.\n\n\n[Reference]\n\n*1* http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_03\n"},{"id":"237772","messageId":"xmqqa9ceko8v.fsf@gitster.dls.corp.google.com","threadId":"36291","inReplyTo":"xmqqeh1qkobn.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-25T20:38:24Z","receivedAt":"2014-03-25T20:38:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> I've reworded the above like so:\n>\n> check-builtins.sh: use the $(...) construct for command substitution\n> \n> The Git CodingGuidelines prefer the $(...) construct for command\n> substitution instead of using the backquotes, or grave accents\n> (`...`).\n\n... but I think the \", or grave accents\" should go.\n"},{"id":"237780","messageId":"vpqppl98n1a.fsf@anie.imag.fr","threadId":"36291","inReplyTo":"1395768283-31135-2-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-03-26T06:57:37Z","receivedAt":"2014-03-26T06:57:37Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Elia Pinto writes:\n\n> for _f in $(find . -name \"*.sh\")\n> do\n>   sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n> done\n\nWhat does this do in the case there are multiple ` on the same line?\n(nested backquotes or multiple `...` `...` on the same line)\n\nThere are not many instances, and it seems no nested backquotes in Git's\nsource code:\n\n$ git grep '`.*`.*`' -- '*.sh'\nt/t5506-remote-groups.sh: if test \"`git log -1 --pretty=format:%s $1 --`\" = \"`cat mark`\"; then\nt/t9300-fast-import.sh: test `git rev-parse master` = `git rev-parse TEMP_TAG^`'\nt/t9300-fast-import.sh: test `git rev-parse N2^{tree}` = `git rev-parse N3^{tree}`'\nt/t9300-fast-import.sh: test `git rev-parse N3` = `git rev-parse O1`'\nt/t9300-fast-import.sh: test `git rev-parse N3` = `git rev-parse O2`'\nt/t9300-fast-import.sh: test `git rev-parse refs/tags/O3-2nd` = `git rev-parse O3^` &&\n\nThe instance in t5506-remote-groups.sh is correct (probably fixed by\nhand, which would deserve to be in the commit message).\n\nI did not receive the patch about t9300-fast-import.sh (the serie seems\nto have stopped at PATCH 105/144).\n\nThe other problematic case I can think of is `...` in comments. It seems\nI caught the problematic ones in t/t0204-gettext-reencode-sanity.sh and\nt/t6111-rev-list-treesame.sh, and git-pull.sh was correct already.\n\n$ git grep '#.*`.*`' -- '*.sh'\ngit-pull.sh:# Setup default fast-forward options via `pull.ff`\nt/t0204-gettext-reencode-sanity.sh:# FreeBSD: `einfaldar` og \"tvöfaldar\" [GNU libintl]\nt/t4057-diff-combined-paths.sh:# `git diff -c --name-only HEAD HEAD^ HEAD^2`\nt/t5522-pull-symlink.sh:# \"cd `git rev-parse --show-cdup`\", it ended up in the wrong\nt/t6111-rev-list-treesame.sh:# `-C-' `-*I-*J\nt/test-lib-functions.sh:# for i in `test_seq 100`; do\nt/test-lib-functions.sh:# for j in `test_seq 10 20`; do\nt/test-lib-functions.sh:# for k in `test_seq a z`; do\n\nAgain, something to mention in commit messages I think.\n\nThe first review I did was completely manual, but I would not call it a\nthorough one.\n\nIt's probably a better idea to publish your branch somewhere than to\ncontinue sending batches of 140 emails to the list for this kind of\ntopics.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"237781","messageId":"vpqlhvx8mt8.fsf@anie.imag.fr","threadId":"36291","inReplyTo":"xmqqy4zyktng.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-03-26T07:02:27Z","receivedAt":"2014-03-26T07:02:27Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> - Nobody has time or energy to go through 140+ patches in one go,\n> with enough concentration necessary to do so without making\n> mistakes (this applies to yourself, too---producing mechanical\n> replacement is a no-cost thing, finding mistakes in mechanical\n> replacement takes real effort).\n\nIt's a bit less bad than it seems:\n\n 142 files changed, 609 insertions(+), 609 deletions(-)\n\nThe first pass I did was a very quick one, but I already went through\nthe patches I received (apparently not the whole series) and it wasn't\nthat long.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"237789","messageId":"CAPig+cSaOK_EaEcyiuhNKDG=DGpt=NxhM+eJYq34C5=7pSuO1A@mail.gmail.com","threadId":"36291","inReplyTo":"vpqlhvx8mt8.fsf@anie.imag.fr","subject":"Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-26T07:44:25Z","receivedAt":"2014-03-26T07:44:25Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Mar 26, 2014 at 3:02 AM, Matthieu Moy\n wrote:\n> Junio C Hamano writes:\n>\n>> - Nobody has time or energy to go through 140+ patches in one go,\n>> with enough concentration necessary to do so without making\n>> mistakes (this applies to yourself, too---producing mechanical\n>> replacement is a no-cost thing, finding mistakes in mechanical\n>> replacement takes real effort).\n>\n> It's a bit less bad than it seems:\n>\n> 142 files changed, 609 insertions(+), 609 deletions(-)\n>\n> The first pass I did was a very quick one, but I already went through\n> the patches I received (apparently not the whole series) and it wasn't\n> that long.\n\nI also gave v2 a read-through. Nothing jumped out as a red-flag.\n"},{"id":"237793","messageId":"CA+EOSBk0m_XJd20eMAKN+KKd_06DOMGmcjgiLm3syCcLropP9A@mail.gmail.com","threadId":"36291","inReplyTo":"CAPig+cSaOK_EaEcyiuhNKDG=DGpt=NxhM+eJYq34C5=7pSuO1A@mail.gmail.com","subject":"Re: [PATCH v2 000/142] Use the $( ... ) construct for command substitution instead of using the back-quotes","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-03-26T09:41:24Z","receivedAt":"2014-03-26T09:41:24Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"2014-03-26 8:44 GMT+01:00 Eric Sunshine :\n> On Wed, Mar 26, 2014 at 3:02 AM, Matthieu Moy\n> wrote:\n>> Junio C Hamano writes:\n>>\n>>> - Nobody has time or energy to go through 140+ patches in one go,\n>>> with enough concentration necessary to do so without making\n>>> mistakes (this applies to yourself, too---producing mechanical\n>>> replacement is a no-cost thing, finding mistakes in mechanical\n>>> replacement takes real effort).\n>>\n>> It's a bit less bad than it seems:\n>>\n>> 142 files changed, 609 insertions(+), 609 deletions(-)\n>>\n>> The first pass I did was a very quick one, but I already went through\n>> the patches I received (apparently not the whole series) and it wasn't\n>> that long.\n>\n> I also gave v2 a read-through. Nothing jumped out as a red-flag.\n\nThank you all. I will change the comment as the maintainer wishes\n(75ee3d7078fbcc3b87a3ae5e0cf42f46256c5da4 for example) and send the\nother patches slowly (10 at a time every week, boring but that's\nokay).\n\nBest Regards\n"},{"id":"237798","messageId":"vpqha6l5ez9.fsf@anie.imag.fr","threadId":"36291","inReplyTo":"8738i6uihf.fsf@fencepost.gnu.org","subject":"Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-03-26T12:19:54Z","receivedAt":"2014-03-26T12:19:54Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"David Kastrup writes:\n\n> Junio C Hamano writes:\n>\n>> Elia Pinto writes:\n>>\n>>> The Git CodingGuidelines prefer the $( ... ) construct for command\n>>> substitution instead of using the back-quotes, or grave accents (`..`).\n>>>\n>>> The backquoted form is the historical method for command substitution,\n>>> and is supported by POSIX. However, all but the simplest uses become\n>>> complicated quickly. In particular, embedded command substitutions\n>>> and/or the use of double quotes require careful escaping with the backslash\n>>> character. Because of this the POSIX shell adopted the $(…) feature from\n>>> the Korn shell.\n>>>\n>>> The patch was generated by the simple script\n>>>\n>>> for _f in $(find . -name \"*.sh\")\n>>> do\n>>>   sed -i 's@`\\(.*\\)`@$(\\1)@g' ${_f}\n>>> done\n>>\n>> \"and then carefully proofread\" is sorely needed here.\n>\n> It would already help to skip comment lines.\n\nActually no: most comments including `...` are code examples that we\nwant to fix too, except 3 instances (see my other message).\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}