{"thread":{"id":"36234","subject":"[PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync","startedAt":"2014-03-19T19:43:53Z","lastAt":"2014-03-19T21:10:25Z","messageCount":3,"participants":["Sebastian Schuberth","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"237108","messageId":"5329F379.3010508@gmail.com","threadId":"36234","inReplyTo":null,"subject":"[PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2014-03-19T19:43:53Z","receivedAt":"2014-03-19T19:43:53Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On MINGW, \"pwd\" is defined as \"pwd -W\" in test-lib.sh. This usually is the\nright thing, but the absolute Windows path with a colon confuses rsync. We\ncould use $PWD in this case to work around the issue, but in fact there is\nno need to use an absolute path in the first place, so get rid of it.\n\nThis was discovered in the context of the mingwGitDevEnv project and only\ndid not surface before with msysgit because the latter does not ship\nrsync.\n\nSigned-off-by: Sebastian Schuberth <sschuberth@gmail.com>\n---\n t/t5510-fetch.sh | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh\nindex ab28594..5acd753 100755\n--- a/t/t5510-fetch.sh\n+++ b/t/t5510-fetch.sh\n@@ -301,7 +301,7 @@ test_expect_success 'fetch via rsync' '\n \tmkdir rsynced &&\n \t(cd rsynced &&\n \t git init --bare &&\n-\t git fetch \"rsync:$(pwd)/../.git\" master:refs/heads/master &&\n+\t git fetch \"rsync:../.git\" master:refs/heads/master &&\n \t git gc --prune &&\n \t test $(git rev-parse master) = $(cd .. && git rev-parse master) &&\n \t git fsck --full)\n@@ -312,7 +312,7 @@ test_expect_success 'push via rsync' '\n \t(cd rsynced2 &&\n \t git init) &&\n \t(cd rsynced &&\n-\t git push \"rsync:$(pwd)/../rsynced2/.git\" master) &&\n+\t git push \"rsync:../rsynced2/.git\" master) &&\n \t(cd rsynced2 &&\n \t git gc --prune &&\n \t test $(git rev-parse master) = $(cd .. && git rev-parse master) &&\n@@ -323,7 +323,7 @@ test_expect_success 'push via rsync' '\n \tmkdir rsynced3 &&\n \t(cd rsynced3 &&\n \t git init) &&\n-\tgit push --all \"rsync:$(pwd)/rsynced3/.git\" &&\n+\tgit push --all \"rsync:rsynced3/.git\" &&\n \t(cd rsynced3 &&\n \t test $(git rev-parse master) = $(cd .. && git rev-parse master) &&\n \t git fsck --full)\n-- \n1.8.5.2.msysgit.0\n"},{"id":"237112","messageId":"alpine.DEB.1.00.1403192103300.14982@s15462909.onlinehome-server.info","threadId":"36234","inReplyTo":"5329F379.3010508@gmail.com","subject":"Re: [PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2014-03-19T20:03:57Z","receivedAt":"2014-03-19T20:03:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Sebastian,\n\nOn Wed, 19 Mar 2014, Sebastian Schuberth wrote:\n\n> On MINGW, \"pwd\" is defined as \"pwd -W\" in test-lib.sh. This usually is the\n> right thing, but the absolute Windows path with a colon confuses rsync. We\n> could use $PWD in this case to work around the issue, but in fact there is\n> no need to use an absolute path in the first place, so get rid of it.\n> \n> This was discovered in the context of the mingwGitDevEnv project and only\n> did not surface before with msysgit because the latter does not ship\n> rsync.\n\nACK\n\nCiao,\nDscho\n"},{"id":"237117","messageId":"xmqqy50528u6.fsf@gitster.dls.corp.google.com","threadId":"36234","inReplyTo":"alpine.DEB.1.00.1403192103300.14982@s15462909.onlinehome-server.info","subject":"Re: [PATCH] t5510: Do not use $(pwd) when fetching / pushing / pulling via rsync","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-19T21:10:25Z","receivedAt":"2014-03-19T21:10:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Hi Sebastian,\n>\n> On Wed, 19 Mar 2014, Sebastian Schuberth wrote:\n>\n>> On MINGW, \"pwd\" is defined as \"pwd -W\" in test-lib.sh. This usually is the\n>> right thing, but the absolute Windows path with a colon confuses rsync. We\n>> could use $PWD in this case to work around the issue, but in fact there is\n>> no need to use an absolute path in the first place, so get rid of it.\n>> \n>> This was discovered in the context of the mingwGitDevEnv project and only\n>> did not surface before with msysgit because the latter does not ship\n>> rsync.\n>\n> ACK\n>\n> Ciao,\n> Dscho\n\nThanks.\n"}]}