{"thread":{"id":"36229","subject":"[PATCH v4 1/2] diff-no-index.c: rename read_directory()","startedAt":"2014-03-19T15:38:35Z","lastAt":"2014-03-19T17:47:08Z","messageCount":2,"participants":["Andrei Dinu","Matthieu Moy"],"isPatch":true,"patchVersion":4,"patchTotal":2},"messages":[{"id":"237078","messageId":"1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com","threadId":"36229","inReplyTo":null,"subject":"[PATCH v4 1/2] diff-no-index.c: rename read_directory()","fromName":"Andrei Dinu","fromEmail":"mandrei.dinu@gmail.com","sentAt":"2014-03-19T15:38:35Z","receivedAt":"2014-03-19T15:38:35Z","isPatch":true,"sender":{"key":"mandrei.dinu@gmail.com","avatar":null},"body":"\nSigned-off-by: Andrei Dinu <mandrei.dinu@gmail.com>\n\n---\n I plan on applying to GSoc 2014\n\n diff-no-index.c |    6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/diff-no-index.c b/diff-no-index.c\nindex 8e10bff..5e4a76c 100644\n--- a/diff-no-index.c\n+++ b/diff-no-index.c\n@@ -16,7 +16,7 @@\n #include \"builtin.h\"\n #include \"string-list.h\"\n \n-static int read_directory(const char *path, struct string_list *list)\n+static int read_directory_path(const char *path, struct string_list *list)\n {\n \tDIR *dir;\n \tstruct dirent *e;\n@@ -107,9 +107,9 @@ static int queue_diff(struct diff_options *o,\n \t\tint i1, i2, ret = 0;\n \t\tsize_t len1 = 0, len2 = 0;\n \n-\t\tif (name1 && read_directory(name1, &p1))\n+\t\tif (name1 && read_directory_path(name1, &p1))\n \t\t\treturn -1;\n-\t\tif (name2 && read_directory(name2, &p2)) {\n+\t\tif (name2 && read_directory_path(name2, &p2)) {\n \t\t\tstring_list_clear(&p1, 0);\n \t\t\treturn -1;\n \t\t}\n-- \n1.7.9.5\n"},{"id":"237092","messageId":"vpqd2hidqsj.fsf@anie.imag.fr","threadId":"36229","inReplyTo":"1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com","subject":"Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2014-03-19T17:47:08Z","receivedAt":"2014-03-19T17:47:08Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Andrei Dinu <mandrei.dinu@gmail.com> writes:\n\n> Signed-off-by: Andrei Dinu <mandrei.dinu@gmail.com>\n\nThe commit message should explain why this is a good change. In general,\nthe \"why?\" question is more important than the \"what\" (the reader can\nsee from the patch that you renamed the function, but cannot guess why\nyou did so).\n\nAlso, when sending multiple patches, send them as a single thread. See\nfor example:\n\n  http://thread.gmane.org/gmane.comp.version-control.git/244441\n\nIn practice, call \"git send-email\" once, not once per patch. Try sending\nthe patches to yourself first to avoid disturbing the list in case of\nuser error.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}