{"thread":{"id":"3621","subject":"annotate.perl triggers rpm bug","startedAt":"2006-03-10T21:23:20Z","lastAt":"2006-03-11T07:39:28Z","messageCount":3,"participants":["sean","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"17441","messageId":"BAYC1-PASMTP0815EFABBF5266FB641C65AEED0@CEZ.ICE","threadId":"3621","inReplyTo":null,"subject":"annotate.perl triggers rpm bug","fromName":"sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-03-10T21:23:20Z","receivedAt":"2006-03-10T21:23:20Z","isPatch":false,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"Hi Ryan\n\nCommit 87475f4 exposes a problem in the creation of rpms (at least\non Fedora boxes).   RPM automatically creates a dependency for any\nperl \"use\" lines, and the above commit fools it into creating a false \ndependecy for the nonexistent perl package \"revs\" because of this\nportion of the diff:\n\n+       -S, --rev-file revs-file\n+                       use revs from revs-file instead of calling git-rev-list\n                        ^^ fools rpm\n\nObviously this creates a problem when someone goes to install the git-core\nrpm.  Any chance we could get a small change to work around this bug in rpm?\n\nThanks,\nSean\n\n\ndiff --git a/git-annotate.perl b/git-annotate.perl\nindex feea0a2..6805b8b 100755\n--- a/git-annotate.perl\n+++ b/git-annotate.perl\n@@ -20,7 +20,7 @@ sub usage() {\n        -r, --rename\n                        Follow renames (Defaults on).\n        -S, --rev-file revs-file\n-                       use revs from revs-file instead of calling git-rev-list\n+                       uses revs from revs-file instead of calling git-rev-list\n        -h, --help\n                        This message.\n ';\n"},{"id":"17454","messageId":"7v64mlxxq2.fsf@assigned-by-dhcp.cox.net","threadId":"3621","inReplyTo":"BAYC1-PASMTP0815EFABBF5266FB641C65AEED0@CEZ.ICE","subject":"Re: annotate.perl triggers rpm bug","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-03-11T07:11:01Z","receivedAt":"2006-03-11T07:11:01Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"sean <seanlkml@sympatico.ca> writes:\n\n> ....   RPM automatically creates a dependency for any\n> perl \"use\" lines, and the above commit fools it into creating a false \n> dependecy...\n\nSheesh -- broken packaging.\n\n> diff --git a/git-annotate.perl b/git-annotate.perl\n> index feea0a2..6805b8b 100755\n> --- a/git-annotate.perl\n> +++ b/git-annotate.perl\n> @@ -20,7 +20,7 @@ sub usage() {\n>         -r, --rename\n>                         Follow renames (Defaults on).\n>         -S, --rev-file revs-file\n> -                       use revs from revs-file instead of calling git-rev-list\n> +                       uses revs from revs-file instead of calling git-rev-list\n>         -h, --help\n>                         This message.\n>  ';\n\nHow about upcasing the word like other lines?\n"},{"id":"17455","messageId":"BAYC1-PASMTP05C2917E365D29EAEC88A0AEE20@CEZ.ICE","threadId":"3621","inReplyTo":"7v64mlxxq2.fsf@assigned-by-dhcp.cox.net","subject":"Re: annotate.perl triggers rpm bug","fromName":"sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-03-11T07:39:28Z","receivedAt":"2006-03-11T07:39:28Z","isPatch":false,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"On Fri, 10 Mar 2006 23:11:01 -0800\nJunio C Hamano <junkio@cox.net> wrote:\n\n> Sheesh -- broken packaging.\n\nYeah, not rpm's proudest moment.\n\n> How about upcasing the word like other lines?\n\nThat seems to fix the dependency problem too and makes a little\nmore sense.\n\nSean\n\n\ndiff --git a/git-annotate.perl b/git-annotate.perl\nindex feea0a2..9df72a1 100755\n--- a/git-annotate.perl\n+++ b/git-annotate.perl\n@@ -20,7 +20,7 @@ sub usage() {\n \t-r, --rename\n \t\t\tFollow renames (Defaults on).\n \t-S, --rev-file revs-file\n-\t\t\tuse revs from revs-file instead of calling git-rev-list\n+\t\t\tUse revs from revs-file instead of calling git-rev-list\n \t-h, --help\n \t\t\tThis message.\n ';\n"}]}