{"thread":{"id":"362","subject":"void return diff-cache.c","startedAt":"2005-04-28T01:22:49Z","lastAt":"2005-04-28T01:22:49Z","messageCount":1,"participants":["Dan Weber"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"1963","messageId":"Pine.LNX.4.62.0504272121230.9460@mirrorlynx.com","threadId":"362","inReplyTo":null,"subject":"void return diff-cache.c","fromName":"Dan Weber","fromEmail":"dan@mirrorlynx.com","sentAt":"2005-04-28T01:22:49Z","receivedAt":"2005-04-28T01:22:49Z","isPatch":false,"sender":{"key":"dan@mirrorlynx.com","avatar":null},"body":"While compiling cogito, I got a compiler warning about returning -1 in a \nvoid function.  Attached is the patch.\n\nDan\n\nCan not return -1 in a void function, but we can return there\n\n---\ncommit b34f64adc18ae04fe299257871a102307683d36b\ntree 29f7b7d146b689f7a724e94f8daddceab219942d\nparent 1e02ed14dc046dc47aafe93ef36587c99670a498\nauthor Dan Weber <dan@mirrorlynx.com> 1114651105 -0400\ncommitter Dan Weber <dan@mirrorlynx.com> 1114651105 -0400\n\nIndex: diff-cache.c\n===================================================================\n--- 3144235bc3b64961e133bc8e3a6b9c756923907a/diff-cache.c  (mode:100644 sha1:30804d2775d4a65a7892ae2bf0b35715812e939b)\n+++ 29f7b7d146b689f7a724e94f8daddceab219942d/diff-cache.c  (mode:100644 sha1:e365f713fa28526f8a883f03a0173755987eadea)\n@@ -45,7 +45,7 @@\n \n \t/* New file in the index: it might actually be different in the working copy */\n \tif (get_stat_data(new, &sha1, &mode) < 0)\n-\t\treturn -1;\n+\t\treturn;\n \n \tshow_file(\"+\", new, sha1, mode);\n }\n"}]}