{"thread":{"id":"36194","subject":"Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names","startedAt":"2014-03-17T09:21:56Z","lastAt":"2014-03-17T09:34:14Z","messageCount":2,"participants":["Kicer Jiao"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"236865","messageId":"CAGRPCXzJXfKtB1wkOMN_7dQ6RdXAs5YNQ+p70eoUYOr5zXkM_w@mail.gmail.com","threadId":"36194","inReplyTo":null,"subject":"Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names","fromName":"Kicer Jiao","fromEmail":"joykicer@gmail.com","sentAt":"2014-03-17T09:21:56Z","receivedAt":"2014-03-17T09:21:56Z","isPatch":true,"sender":{"key":"joykicer@gmail.com","avatar":null},"body":"Dear all,\n\nI have a git-project which source code use gbk encoding. When use\ngitweb blame view, it will report an error then stop parse:\n>    Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line 1595, <$fd> line 45.\n\nAfter apply this patch, blame view of gbk source file will back to normally.\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 79057b7..e6fdcfe 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -6704,7 +6704,6 @@ sub git_blame_common {\n                        $hash_base, '--', $file_name\n                        or die_error(500, \"Open git-blame --porcelain failed\");\n        }\n-       binmode $fd, ':utf8';\n\n        # incremental blame data returns early\n        if ($format eq 'data') {\n\nWhen I search the git.git log, this commit add the \"binmode ...\" line,\nmaybe should recheck this commit? Thanks.\nfd87004e51df835e5833bfe1bff3ad0137d42227  \"gitweb: Fix the author\ninitials in blame for non-ASCII names\"\n\n\nBR,\n2014-03-17\n"},{"id":"236867","messageId":"CAGRPCXyf_QtHm3g2DY9Q3+9qrHegbE+nXoR=YAw_YcQvS+kCRg@mail.gmail.com","threadId":"36194","inReplyTo":"CAGRPCXzJXfKtB1wkOMN_7dQ6RdXAs5YNQ+p70eoUYOr5zXkM_w@mail.gmail.com","subject":"Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names","fromName":"Kicer Jiao","fromEmail":"joykicer@gmail.com","sentAt":"2014-03-17T09:34:14Z","receivedAt":"2014-03-17T09:34:14Z","isPatch":true,"sender":{"key":"joykicer@gmail.com","avatar":null},"body":"Dear all,\n\nI have a git-project which source code use gbk encoding. When use\ngitweb blame view, it will report an error then stop parse:\n>    Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line 1595, <$fd> line 45.\n\nAfter apply this patch, blame view of gbk source file will back to normally.\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 79057b7..e6fdcfe 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -6704,7 +6704,6 @@ sub git_blame_common {\n                        $hash_base, '--', $file_name\n                        or die_error(500, \"Open git-blame --porcelain failed\");\n        }\n-       binmode $fd, ':utf8';\n\n        # incremental blame data returns early\n        if ($format eq 'data') {\n\nWhen I search the git.git log, this commit add the \"binmode ...\" line,\nmaybe should recheck this commit? Thanks.\nfd87004e51df835e5833bfe1bff3ad0137d42227  \"gitweb: Fix the author\ninitials in blame for non-ASCII names\"\n\n\nBR,\n2014-03-17\n"}]}