{"thread":{"id":"36128","subject":"[PATCH] sh-i18n--envsubst: retire unused string_list_member()","startedAt":"2014-03-11T22:46:44Z","lastAt":"2014-03-11T22:46:44Z","messageCount":1,"participants":["Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"236548","messageId":"1394578004-18638-1-git-send-email-sunshine@sunshineco.com","threadId":"36128","inReplyTo":null,"subject":"[PATCH] sh-i18n--envsubst: retire unused string_list_member()","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-11T22:46:44Z","receivedAt":"2014-03-11T22:46:44Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"This static function has no callers, nor has it had any since its\nintroduction in ba67aaf2d05d (git-sh-i18n--envsubst: our own envsubst(1)\nfor eval_gettext(), 2011-05-14). Remove it.\n\nSigned-off-by: Eric Sunshine <sunshine@sunshineco.com>\n---\n\nThe latest Apple developer tools (just released) has -Wunused-function\nenabled by default, thus it complains about this anomaly.\n\n sh-i18n--envsubst.c | 12 ------------\n 1 file changed, 12 deletions(-)\n\ndiff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c\nindex 5ddd688..855d28c 100644\n--- a/sh-i18n--envsubst.c\n+++ b/sh-i18n--envsubst.c\n@@ -237,18 +237,6 @@ string_list_sort (string_list_ty *slp)\n     qsort (slp->item, slp->nitems, sizeof (slp->item[0]), cmp_string);\n }\n \n-/* Test whether a string list contains a given string.  */\n-static inline int\n-string_list_member (const string_list_ty *slp, const char *s)\n-{\n-  size_t j;\n-\n-  for (j = 0; j < slp->nitems; ++j)\n-    if (strcmp (slp->item[j], s) == 0)\n-      return 1;\n-  return 0;\n-}\n-\n /* Test whether a sorted string list contains a given string.  */\n static int\n sorted_string_list_member (const string_list_ty *slp, const char *s)\n-- \n1.9.0.282.g01e9d92\n"}]}