{"thread":{"id":"36098","subject":"[PATCH] Use long for timezone in pretty.c:show_ident_date()","startedAt":"2014-03-07T18:47:56Z","lastAt":"2014-03-07T19:29:42Z","messageCount":2,"participants":["Brian Gernhardt","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"236269","messageId":"1394218076-70398-1-git-send-email-brian@gernhardtsoftware.com","threadId":"36098","inReplyTo":null,"subject":"[PATCH] Use long for timezone in pretty.c:show_ident_date()","fromName":"Brian Gernhardt","fromEmail":"brian@gernhardtsoftware.com","sentAt":"2014-03-07T18:47:56Z","receivedAt":"2014-03-07T18:47:56Z","isPatch":true,"sender":{"key":"brian@gernhardtsoftware.com","avatar":"https://avatars.githubusercontent.com/u/133455?v=4"},"body":"The value is parsed with strtol and compared against LONG_MIN and\nLONG_MAX, which doesn't make much sense for an int.\n\nSigned-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>\n---\n pretty.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/pretty.c b/pretty.c\nindex 3b811ed..29ebc4f 100644\n--- a/pretty.c\n+++ b/pretty.c\n@@ -397,7 +397,7 @@ static const char *show_ident_date(const struct ident_split *ident,\n \t\t\t\t   enum date_mode mode)\n {\n \tunsigned long date = 0;\n-\tint tz = 0;\n+\tlong tz = 0;\n \n \tif (ident->date_begin && ident->date_end)\n \t\tdate = strtoul(ident->date_begin, NULL, 10);\n-- \n1.9.0.281.gfc51f0a.dirty\n"},{"id":"236271","messageId":"CAPig+cSAGEmtKziqE49MxuQOsBdbbbVtLcsYVd+Uoptg2Ucr8A@mail.gmail.com","threadId":"36098","inReplyTo":"1394218076-70398-1-git-send-email-brian@gernhardtsoftware.com","subject":"Re: [PATCH] Use long for timezone in pretty.c:show_ident_date()","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-07T19:29:42Z","receivedAt":"2014-03-07T19:29:42Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Mar 7, 2014 at 1:47 PM, Brian Gernhardt\n<brian@gernhardtsoftware.com> wrote:\n> The value is parsed with strtol and compared against LONG_MIN and\n> LONG_MAX, which doesn't make much sense for an int.\n>\n> Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>\n\nThanks. Find a more complete fix here [1].\n\n[1]: http://thread.gmane.org/gmane.comp.version-control.git/243582/focus=243617\n\n> ---\n>  pretty.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/pretty.c b/pretty.c\n> index 3b811ed..29ebc4f 100644\n> --- a/pretty.c\n> +++ b/pretty.c\n> @@ -397,7 +397,7 @@ static const char *show_ident_date(const struct ident_split *ident,\n>                                    enum date_mode mode)\n>  {\n>         unsigned long date = 0;\n> -       int tz = 0;\n> +       long tz = 0;\n>\n>         if (ident->date_begin && ident->date_end)\n>                 date = strtoul(ident->date_begin, NULL, 10);\n> --\n> 1.9.0.281.gfc51f0a.dirty\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"}]}