{"thread":{"id":"36045","subject":"[PATCH] git-bisect.sh: fix a few style issues","startedAt":"2014-03-04T00:21:43Z","lastAt":"2014-03-04T02:30:58Z","messageCount":2,"participants":["Jacopo Notarstefano","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"235969","messageId":"1393892503-12765-1-git-send-email-jacopo.notarstefano@gmail.com","threadId":"36045","inReplyTo":null,"subject":"[PATCH] git-bisect.sh: fix a few style issues","fromName":"Jacopo Notarstefano","fromEmail":"jacopo.notarstefano@gmail.com","sentAt":"2014-03-04T00:21:43Z","receivedAt":"2014-03-04T00:21:43Z","isPatch":true,"sender":{"key":"jacopo.notarstefano@gmail.com","avatar":"https://avatars.githubusercontent.com/u/381280?v=4"},"body":"Redirection operators should have a space before them, but not after them.\n\nSigned-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>\n---\n git-bisect.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 73b4c14..af4d04c 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -365,7 +365,7 @@ bisect_reset() {\n \t}\n \tcase \"$#\" in\n \t0) branch=$(cat \"$GIT_DIR/BISECT_START\") ;;\n-\t1) git rev-parse --quiet --verify \"$1^{commit}\" > /dev/null || {\n+\t1) git rev-parse --quiet --verify \"$1^{commit}\" >/dev/null || {\n \t\t\tinvalid=\"$1\"\n \t\t\tdie \"$(eval_gettext \"'\\$invalid' is not a valid commit\")\"\n \t\t}\n@@ -458,13 +458,13 @@ exit code \\$res from '\\$command' is < 0 or >= 128\" >&2\n \t\tfi\n \n \t\t# We have to use a subshell because \"bisect_state\" can exit.\n-\t\t( bisect_state $state > \"$GIT_DIR/BISECT_RUN\" )\n+\t\t( bisect_state $state >\"$GIT_DIR/BISECT_RUN\" )\n \t\tres=$?\n \n \t\tcat \"$GIT_DIR/BISECT_RUN\"\n \n \t\tif sane_grep \"first bad commit could be any of\" \"$GIT_DIR/BISECT_RUN\" \\\n-\t\t\t> /dev/null\n+\t\t\t>/dev/null\n \t\tthen\n \t\t\tgettextln \"bisect run cannot continue any more\" >&2\n \t\t\texit $res\n@@ -477,7 +477,7 @@ exit code \\$res from '\\$command' is < 0 or >= 128\" >&2\n \t\t\texit $res\n \t\tfi\n \n-\t\tif sane_grep \"is the first bad commit\" \"$GIT_DIR/BISECT_RUN\" > /dev/null\n+\t\tif sane_grep \"is the first bad commit\" \"$GIT_DIR/BISECT_RUN\" >/dev/null\n \t\tthen\n \t\t\tgettextln \"bisect run success\"\n \t\t\texit 0;\n-- \n1.9.0.1.g641f09f\n"},{"id":"235973","messageId":"xmqqzjl6lmot.fsf@gitster.dls.corp.google.com","threadId":"36045","inReplyTo":"1393892503-12765-1-git-send-email-jacopo.notarstefano@gmail.com","subject":"Re: [PATCH] git-bisect.sh: fix a few style issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-04T02:30:58Z","receivedAt":"2014-03-04T02:30:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jacopo Notarstefano <jacopo.notarstefano@gmail.com> writes:\n\n> Redirection operators should have a space before them, but not after them.\n>\n> Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>\n> ---\n\nLooks obviously harmless ;-)\n\nThanks.\n"}]}