{"thread":{"id":"36042","subject":"Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c","startedAt":"2014-03-03T21:11:14Z","lastAt":"2014-03-03T22:14:26Z","messageCount":2,"participants":["saikrishna.sripada","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"235922","messageId":"d7af2c2bcb07168ecddedf76ca776cd0@students.iiit.ac.in","threadId":"36042","inReplyTo":null,"subject":"Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c","fromName":"saikrishna.sripada","fromEmail":"saikrishna.sripada@students.iiit.ac.in","sentAt":"2014-03-03T21:11:14Z","receivedAt":"2014-03-03T21:11:14Z","isPatch":false,"sender":{"key":"saikrishna.sripada@students.iiit.ac.in","avatar":null},"body":"Hi ,\nI am trying do complete the microproject 4, inorder to apply to GSOC.\nI have made the below changes:\n\nhttps://gist.github.com/anhsirksai/9334565\n\nPost my changes compilation is succes in the source directory.\nBut when I ran the tests[make in t/ directory] my tests are failing \nsaying\n\n\"\n  free(): invalid pointer: 0x3630376532353636 ***\n======= Backtrace: =========\n/lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x2b5f3b540b96]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4fb829]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x47d425]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4064ad]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405a04]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x404cbd]\n/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x2b5f3b4e376d]\n/home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405109]\n\"\n\nCan some one please help me with the memory allacation and \nstrbuf_release()\n\nThanks,\n--sai krishna\n"},{"id":"235926","messageId":"CAPig+cTE7wtVpmjN=p56JB6avL8n_JhDC6g5cAgGcmJQ8OVt5g@mail.gmail.com","threadId":"36042","inReplyTo":"d7af2c2bcb07168ecddedf76ca776cd0@students.iiit.ac.in","subject":"Re: Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-03T22:14:26Z","receivedAt":"2014-03-03T22:14:26Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Mar 3, 2014 at 4:11 PM, saikrishna.sripada\n<saikrishna.sripada@students.iiit.ac.in> wrote:\n> I am trying do complete the microproject 4, inorder to apply to GSOC.\n> I have made the below changes:\n>\n> https://gist.github.com/anhsirksai/9334565\n>\n> Post my changes compilation is succes in the source directory.\n> But when I ran the tests[make in t/ directory] my tests are failing saying\n>\n> \"\n>  free(): invalid pointer: 0x3630376532353636 ***\n> ======= Backtrace: =========\n> /lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x2b5f3b540b96]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4fb829]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x47d425]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4064ad]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405a04]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x404cbd]\n> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x2b5f3b4e376d]\n> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405109]\n> \"\n>\n> Can some one please help me with the memory allacation and strbuf_release()\n\nRead the microproject text carefully and _fully_. It provides the clue\nyou need to understand the problem.\n\n    Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for\n    handling packname, and explain why this is useful. Also check if\n    the first argument of pack-write.c:finish_tmp_packfile() can be\n    made const.\n\nIf, after making a closer examination of the mentioned functions, the\nproblem still eludes you, ask here again.\n"}]}