{"thread":{"id":"36018","subject":"[PATCH v3] write_pack_file: use correct variable in diagnostic","startedAt":"2014-03-02T07:30:11Z","lastAt":"2014-03-03T18:43:09Z","messageCount":4,"participants":["Sun He","Eric Sunshine","He Sun","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"235785","messageId":"1393745411-30980-1-git-send-email-sunheehnus@gmail.com","threadId":"36018","inReplyTo":null,"subject":"[PATCH v3] write_pack_file: use correct variable in diagnostic","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-02T07:30:11Z","receivedAt":"2014-03-02T07:30:11Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"'pack_tmp_name' is the subject of the utime() check, so report it in the\nwarning, not the uninitialized 'tmpname'\n\nSigned-off-by: Sun He \n---\n\n Changing the subject and adding valid information as tutored by \n Eric Sunshine.\n Thanks to him.\n\n builtin/pack-objects.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\nindex c733379..4922ce5 100644\n--- a/builtin/pack-objects.c\n+++ b/builtin/pack-objects.c\n@@ -823,7 +823,7 @@ static void write_pack_file(void)\n \t\t\t\tutb.modtime = --last_mtime;\n \t\t\t\tif (utime(pack_tmp_name, &utb) < 0)\n \t\t\t\t\twarning(\"failed utime() on %s: %s\",\n-\t\t\t\t\t\ttmpname, strerror(errno));\n+\t\t\t\t\t\tpack_tmp_name, strerror(errno));\n \t\t\t}\n \n \t\t\t/* Enough space for \"-.pack\"? */\n-- \n1.9.0.138.g2de3478.dirty\n"},{"id":"235804","messageId":"CAPig+cSuBfuzL-NXYkvFoz5+jPrEUNfTqoMf-iAYyMSv3jDsqg@mail.gmail.com","threadId":"36018","inReplyTo":"1393745411-30980-1-git-send-email-sunheehnus@gmail.com","subject":"Re: [PATCH v3] write_pack_file: use correct variable in diagnostic","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-02T18:42:21Z","receivedAt":"2014-03-02T18:42:21Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Mar 2, 2014 at 2:30 AM, Sun He wrote:\n> 'pack_tmp_name' is the subject of the utime() check, so report it in the\n> warning, not the uninitialized 'tmpname'\n>\n> Signed-off-by: Sun He \n> ---\n>\n> Changing the subject and adding valid information as tutored by\n> Eric Sunshine.\n> Thanks to him.\n>\n> builtin/pack-objects.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\n> index c733379..4922ce5 100644\n> --- a/builtin/pack-objects.c\n> +++ b/builtin/pack-objects.c\n> @@ -823,7 +823,7 @@ static void write_pack_file(void)\n> utb.modtime = --last_mtime;\n> if (utime(pack_tmp_name, &utb) < 0)\n> warning(\"failed utime() on %s: %s\",\n> - tmpname, strerror(errno));\n> + pack_tmp_name, strerror(errno));\n> }\n>\n> /* Enough space for \"-.pack\"? */\n> --\n> 1.9.0.138.g2de3478.dirty\n\nNicely done. Everything is where it ought to be.\n\nAs this is an actual bug fix (not just a GSoC microproject):\n\nReviewed-by: Eric Sunshine \n"},{"id":"235820","messageId":"CAJr59C1Azr9EnoeRPKZF+AB9GBw1RR7fUkvaYChyTfHwoJSvFA@mail.gmail.com","threadId":"36018","inReplyTo":"CAPig+cSuBfuzL-NXYkvFoz5+jPrEUNfTqoMf-iAYyMSv3jDsqg@mail.gmail.com","subject":"Re: [PATCH v3] write_pack_file: use correct variable in diagnostic","fromName":"He Sun","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-03T01:20:21Z","receivedAt":"2014-03-03T01:20:21Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"2014-03-03 2:42 GMT+08:00 Eric Sunshine :\n> On Sun, Mar 2, 2014 at 2:30 AM, Sun He wrote:\n>> 'pack_tmp_name' is the subject of the utime() check, so report it in the\n>> warning, not the uninitialized 'tmpname'\n>>\n>> Signed-off-by: Sun He \n>> ---\n>>\n>> Changing the subject and adding valid information as tutored by\n>> Eric Sunshine.\n>> Thanks to him.\n>>\n>> builtin/pack-objects.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\n>> index c733379..4922ce5 100644\n>> --- a/builtin/pack-objects.c\n>> +++ b/builtin/pack-objects.c\n>> @@ -823,7 +823,7 @@ static void write_pack_file(void)\n>> utb.modtime = --last_mtime;\n>> if (utime(pack_tmp_name, &utb) < 0)\n>> warning(\"failed utime() on %s: %s\",\n>> - tmpname, strerror(errno));\n>> + pack_tmp_name, strerror(errno));\n>> }\n>>\n>> /* Enough space for \"-.pack\"? */\n>> --\n>> 1.9.0.138.g2de3478.dirty\n>\n> Nicely done. Everything is where it ought to be.\n>\n> As this is an actual bug fix (not just a GSoC microproject):\n>\n> Reviewed-by: Eric Sunshine \n\nThank you so much for everything you have done.\nI am honored to do this with all your support and kindness.\n\nRegards，\nHe Sun\n"},{"id":"235901","messageId":"xmqqfvmzqg1u.fsf@gitster.dls.corp.google.com","threadId":"36018","inReplyTo":"1393745411-30980-1-git-send-email-sunheehnus@gmail.com","subject":"Re: [PATCH v3] write_pack_file: use correct variable in diagnostic","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-03-03T18:43:09Z","receivedAt":"2014-03-03T18:43:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sun He writes:\n\n> 'pack_tmp_name' is the subject of the utime() check, so report it in the\n> warning, not the uninitialized 'tmpname'\n>\n> Signed-off-by: Sun He \n> ---\n>\n> Changing the subject and adding valid information as tutored by \n> Eric Sunshine.\n> Thanks to him.\n>\n> builtin/pack-objects.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\n> index c733379..4922ce5 100644\n> --- a/builtin/pack-objects.c\n> +++ b/builtin/pack-objects.c\n> @@ -823,7 +823,7 @@ static void write_pack_file(void)\n> \t\t\t\tutb.modtime = --last_mtime;\n> \t\t\t\tif (utime(pack_tmp_name, &utb) < 0)\n> \t\t\t\t\twarning(\"failed utime() on %s: %s\",\n> -\t\t\t\t\t\ttmpname, strerror(errno));\n> +\t\t\t\t\t\tpack_tmp_name, strerror(errno));\n> \t\t\t}\n> \n> \t\t\t/* Enough space for \"-.pack\"? */\n\nVery nicely done. Thanks.\n\nAnd big Thanks to Eric guiding this patch through.\n"}]}