{"thread":{"id":"36015","subject":"[PATCH v2] Place cache.h at the first place to match general rule","startedAt":"2014-03-02T02:18:17Z","lastAt":"2014-03-02T07:59:53Z","messageCount":3,"participants":["Sun He","Eric Sunshine","He Sun"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"235768","messageId":"1393726697-2816-1-git-send-email-sunheehnus@gmail.com","threadId":"36015","inReplyTo":null,"subject":"[PATCH v2] Place cache.h at the first place to match general rule","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-02T02:18:17Z","receivedAt":"2014-03-02T02:18:17Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"Signed-off-by: Sun He \nHelped-by: Duy Nguyen \n---\n\n \"PATCH v2\" Fix the spelling bug of general in subject as is suggested\n by brain m.calson \n\n The general rule is if cache.h or git-compat-util.h is included,\n it is the first #include.\n\n I parsed all the source files, and find many files start with builtin.h.\n And git-compat-util.h is the first in it. So they don't need any change.\n\n sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n I checked sigchain.h, and it didn't import any bug.\n But to keep consistant with general rule, we should take this patch.\n\n Thanks.\n\n sigchain.c | 2 +-\n test-sigchain.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/sigchain.c b/sigchain.c\nindex 1118b99..faa375d 100644\n--- a/sigchain.c\n+++ b/sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define SIGCHAIN_MAX_SIGNALS 32\n \ndiff --git a/test-sigchain.c b/test-sigchain.c\nindex 42db234..e499fce 100644\n--- a/test-sigchain.c\n+++ b/test-sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define X(f) \\\n static void f(int sig) { \\\n-- \n1.9.0.138.g2de3478.dirty\n"},{"id":"235780","messageId":"CAPig+cRAni1m2xReUvFkx1muvzTLGo1PF8iTuQdXUzLn3yXNkg@mail.gmail.com","threadId":"36015","inReplyTo":"1393726697-2816-1-git-send-email-sunheehnus@gmail.com","subject":"Re: [PATCH v2] Place cache.h at the first place to match general rule","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-03-02T04:34:28Z","receivedAt":"2014-03-02T04:34:28Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sat, Mar 1, 2014 at 9:18 PM, Sun He wrote:\n> Signed-off-by: Sun He \n> Helped-by: Duy Nguyen \n\nFooters should follow a temporal order. For instance:\n\n1. Duy helped you.\n2. You revised your patch based upon his input.\n3. You signed off before submitting the patch.\n\nHence, your Signed-off-by: should follow Helped-by:.\n\n> ---\n> \"PATCH v2\" Fix the spelling bug of general in subject as is suggested\n> by brain m.calson \n\nThere are two type of information you want to convey to readers:\n\n1. Explanation and justification of the change itself. This is\nrecorded for all time in the project history as the commit message. It\nis placed above the \"---\" line.\n\n2. Commentary related to this version / submission of the patch which\nis not likely to be helpful or meaningful to people reading the\n\"official\" project history via the commit messages. It is placed below\nthe \"---\" line.\n\nExplaining what you changed since the previous version of the patch,\nas you do above, is a good thing. It's not meaningful once the patch\nis officially accepted into the project; it's only meaningful to\npeople following the progression of the patch on the mailing list, so\nit definitely belongs below the \"---\" line, as you did here.\n\nHowever...\n\n> The general rule is if cache.h or git-compat-util.h is included,\n> it is the first #include.\n\nThis information explains the patch's purpose, thus it is relevant to\nthe project history. It belongs above the \"---\" line.\n\n> I parsed all the source files, and find many files start with builtin.h.\n> And git-compat-util.h is the first in it. So they don't need any change.\n\nThis could go either way. It tells how you arrived at this version of\nthe patch (relevant below \"---\"), but also explains why the patch does\nnot have to touch additional files (relevant above \"---\"). It's\nprobably okay to leave it below \"---\".\n\n> sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n> I checked sigchain.h, and it didn't import any bug.\n> But to keep consistant with general rule, we should take this patch.\n\nCommentary suitable for below \"---\".\n\n> Thanks.\n>\n> sigchain.c | 2 +-\n> test-sigchain.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/sigchain.c b/sigchain.c\n> index 1118b99..faa375d 100644\n> --- a/sigchain.c\n> +++ b/sigchain.c\n> @@ -1,5 +1,5 @@\n> -#include \"sigchain.h\"\n> #include \"cache.h\"\n> +#include \"sigchain.h\"\n>\n> #define SIGCHAIN_MAX_SIGNALS 32\n>\n> diff --git a/test-sigchain.c b/test-sigchain.c\n> index 42db234..e499fce 100644\n> --- a/test-sigchain.c\n> +++ b/test-sigchain.c\n> @@ -1,5 +1,5 @@\n> -#include \"sigchain.h\"\n> #include \"cache.h\"\n> +#include \"sigchain.h\"\n>\n> #define X(f) \\\n> static void f(int sig) { \\\n> --\n> 1.9.0.138.g2de3478.dirty\n"},{"id":"235788","messageId":"CAJr59C2xV43P2cZv-V5rm0-ea3G1W7BGK9exA=0obPgEHUsGEA@mail.gmail.com","threadId":"36015","inReplyTo":"CAPig+cRAni1m2xReUvFkx1muvzTLGo1PF8iTuQdXUzLn3yXNkg@mail.gmail.com","subject":"Re: [PATCH v2] Place cache.h at the first place to match general rule","fromName":"He Sun","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-02T07:59:53Z","receivedAt":"2014-03-02T07:59:53Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"2014-03-02 12:34 GMT+08:00 Eric Sunshine :\n> On Sat, Mar 1, 2014 at 9:18 PM, Sun He wrote:\n>> Signed-off-by: Sun He \n>> Helped-by: Duy Nguyen \n>\n> Footers should follow a temporal order. For instance:\n>\n> 1. Duy helped you.\n> 2. You revised your patch based upon his input.\n> 3. You signed off before submitting the patch.\n>\n> Hence, your Signed-off-by: should follow Helped-by:.\n>\n\nOK, got it.\nThank you very much.\n\n>> ---\n>> \"PATCH v2\" Fix the spelling bug of general in subject as is suggested\n>> by brain m.calson \n>\n> There are two type of information you want to convey to readers:\n>\n> 1. Explanation and justification of the change itself. This is\n> recorded for all time in the project history as the commit message. It\n> is placed above the \"---\" line.\n>\n> 2. Commentary related to this version / submission of the patch which\n> is not likely to be helpful or meaningful to people reading the\n> \"official\" project history via the commit messages. It is placed below\n> the \"---\" line.\n>\n> Explaining what you changed since the previous version of the patch,\n> as you do above, is a good thing. It's not meaningful once the patch\n> is officially accepted into the project; it's only meaningful to\n> people following the progression of the patch on the mailing list, so\n> it definitely belongs below the \"---\" line, as you did here.\n>\n> However...\n>\n>> The general rule is if cache.h or git-compat-util.h is included,\n>> it is the first #include.\n>\n> This information explains the patch's purpose, thus it is relevant to\n> the project history. It belongs above the \"---\" line.\n>\n\nOK, Got it. I will move above the \"---\" line soon, and I will pay attention\nnot to make mistakes like this from now on.\nThank you very much.\n\n>> I parsed all the source files, and find many files start with builtin.h.\n>> And git-compat-util.h is the first in it. So they don't need any change.\n>\n> This could go either way. It tells how you arrived at this version of\n> the patch (relevant below \"---\"), but also explains why the patch does\n> not have to touch additional files (relevant above \"---\"). It's\n> probably okay to leave it below \"---\".\n>\n>> sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n>> I checked sigchain.h, and it didn't import any bug.\n>> But to keep consistant with general rule, we should take this patch.\n>\n> Commentary suitable for below \"---\".\n>\n>> Thanks.\n>>\n>> sigchain.c | 2 +-\n>> test-sigchain.c | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/sigchain.c b/sigchain.c\n>> index 1118b99..faa375d 100644\n>> --- a/sigchain.c\n>> +++ b/sigchain.c\n>> @@ -1,5 +1,5 @@\n>> -#include \"sigchain.h\"\n>> #include \"cache.h\"\n>> +#include \"sigchain.h\"\n>>\n>> #define SIGCHAIN_MAX_SIGNALS 32\n>>\n>> diff --git a/test-sigchain.c b/test-sigchain.c\n>> index 42db234..e499fce 100644\n>> --- a/test-sigchain.c\n>> +++ b/test-sigchain.c\n>> @@ -1,5 +1,5 @@\n>> -#include \"sigchain.h\"\n>> #include \"cache.h\"\n>> +#include \"sigchain.h\"\n>>\n>> #define X(f) \\\n>> static void f(int sig) { \\\n>> --\n>> 1.9.0.138.g2de3478.dirty\n\n\nI am honored to get detailed guidance from you.\nThank you very very much.\n\nHe Sun\n"}]}