{"thread":{"id":"36010","subject":"[PATCH] Place cache.h at the first place to match generl rule","startedAt":"2014-03-01T15:05:23Z","lastAt":"2014-03-01T18:05:06Z","messageCount":2,"participants":["Sun He","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"235752","messageId":"1393686323-20978-1-git-send-email-sunheehnus@gmail.com","threadId":"36010","inReplyTo":null,"subject":"[PATCH] Place cache.h at the first place to match generl rule","fromName":"Sun He","fromEmail":"sunheehnus@gmail.com","sentAt":"2014-03-01T15:05:23Z","receivedAt":"2014-03-01T15:05:23Z","isPatch":true,"sender":{"key":"sunheehnus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2889804?v=4"},"body":"Signed-off-by: Sun He <sunheehnus@gmail.com>\nHelped-by: Duy Nguyen <pclouds@gmail.com>\n---\n\n The general rule is if cache.h or git-compat-util.h is included,\n it is the first #include.\n\n I parsed all the source files, and find many files start with builtin.h.\n And git-compat-util.h is the first in it. So they don't need any change.\n\n sigchain.c and test-sigchain.c are started with \"sigchain.h\"\n I checked sigchain.h, and it didn't import any bug.\n But to keep consistant with general rule, we should take this patch.\n\n Thanks.\n\n sigchain.c      | 2 +-\n test-sigchain.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/sigchain.c b/sigchain.c\nindex 1118b99..faa375d 100644\n--- a/sigchain.c\n+++ b/sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define SIGCHAIN_MAX_SIGNALS 32\n \ndiff --git a/test-sigchain.c b/test-sigchain.c\nindex 42db234..e499fce 100644\n--- a/test-sigchain.c\n+++ b/test-sigchain.c\n@@ -1,5 +1,5 @@\n-#include \"sigchain.h\"\n #include \"cache.h\"\n+#include \"sigchain.h\"\n \n #define X(f) \\\n static void f(int sig) { \\\n-- \n1.9.0.138.g2de3478.dirty\n"},{"id":"235758","messageId":"20140301180506.GD681289@vauxhall.crustytoothpaste.net","threadId":"36010","inReplyTo":"1393686323-20978-1-git-send-email-sunheehnus@gmail.com","subject":"Re: [PATCH] Place cache.h at the first place to match generl rule","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-03-01T18:05:06Z","receivedAt":"2014-03-01T18:05:06Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Sat, Mar 01, 2014 at 11:05:23PM +0800, Sun He wrote:\n> Signed-off-by: Sun He <sunheehnus@gmail.com>\n> Helped-by: Duy Nguyen <pclouds@gmail.com>\n\nYour commit summary has \"generl\" instead of \"general\".\n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"}]}