{"thread":{"id":"3592","subject":"[PATCH] Allow git-repack to optionally run git-prune-packed.","startedAt":"2006-03-07T15:16:12Z","lastAt":"2006-03-09T18:50:43Z","messageCount":5,"participants":["Martin Atukunda","Alex Riesen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"17297","messageId":"11417445722524-git-send-email-matlads@dsmagic.com","threadId":"3592","inReplyTo":null,"subject":"[PATCH] Allow git-repack to optionally run git-prune-packed.","fromName":"Martin Atukunda","fromEmail":"matlads@dsmagic.com","sentAt":"2006-03-07T15:16:12Z","receivedAt":"2006-03-07T15:16:12Z","isPatch":true,"sender":{"key":"matlads@dsmagic.com","avatar":null},"body":"Signed-off-by: Martin Atukunda \n\n---\n\n Documentation/git-repack.txt | 6 +++++-\n git-repack.sh | 9 +++++++--\n 2 files changed, 12 insertions(+), 3 deletions(-)\n\n84104979482df25e6c70e17f8bf2307cdad1faff\ndiff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt\nindex d2f9a44..835e698 100644\n--- a/Documentation/git-repack.txt\n+++ b/Documentation/git-repack.txt\n@@ -9,7 +9,7 @@ objects into pack files.\n \n SYNOPSIS\n --------\n-'git-repack' [-a] [-d] [-f] [-l] [-n] [-q]\n+'git-repack' [-a] [-d] [-f] [-l] [-n] [-q] [-p]\n \n DESCRIPTION\n -----------\n@@ -55,6 +55,10 @@ OPTIONS\n Do not update the server information with\n `git update-server-info`.\n \n+-p::\n+\tRun `git-prune-packed` after packing, see\n+\tgitlink:git-prune-packed[1]\n+\n Author\n ------\n Written by Linus Torvalds \ndiff --git a/git-repack.sh b/git-repack.sh\nindex 3d6fec1..970f4ca 100755\n--- a/git-repack.sh\n+++ b/git-repack.sh\n@@ -3,11 +3,11 @@\n # Copyright (c) 2005 Linus Torvalds\n #\n \n-USAGE='[-a] [-d] [-f] [-l] [-n] [-q]'\n+USAGE='[-a] [-d] [-f] [-l] [-n] [-q] [-p]'\n . git-sh-setup\n \t\n no_update_info= all_into_one= remove_redundant=\n-local= quiet= no_reuse_delta=\n+local= quiet= no_reuse_delta= run_prune=\n while case \"$#\" in 0) break ;; esac\n do\n \tcase \"$1\" in\n@@ -17,6 +17,7 @@ do\n \t-q)\tquiet=-q ;;\n \t-f)\tno_reuse_delta=--no-reuse-delta ;;\n \t-l)\tlocal=--local ;;\n+\t-p)\trun_prune=t;;\n \t*)\tusage ;;\n \tesac\n \tshift\n@@ -77,6 +78,10 @@ then\n \tfi\n fi\n \n+case \"$run_prune\" in\n+t) git-prune-packed;;\n+esac\n+\n case \"$no_update_info\" in\n t) : ;;\n *) git-update-server-info ;;\n-- \n1.2.4.g84104\n"},{"id":"17310","messageId":"20060307212918.GA9474@steel.home","threadId":"3592","inReplyTo":"11417445722524-git-send-email-matlads@dsmagic.com","subject":"Re: [PATCH] Allow git-repack to optionally run git-prune-packed.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-03-07T21:29:18Z","receivedAt":"2006-03-07T21:29:18Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Martin Atukunda, Tue, Mar 07, 2006 16:16:12 +0100:\n> +-p::\n> +\tRun `git-prune-packed` after packing, see\n> +\tgitlink:git-prune-packed[1]\n> +\n\nMaybe just make \"-d\" work? I.e. \"git repack -a -d\" repacks and prunes\neverything, and \"git repack -d\" prunes just what was packed\nincrementally.\nSomething like this:\n\ndiff --git a/git-repack.sh b/git-repack.sh\nindex 3d6fec1..be6c7ab 100755\n--- a/git-repack.sh\n+++ b/git-repack.sh\n@@ -74,6 +74,8 @@ then\n \t\t\tesac\n \t\t done\n \t\t)\n+\telse\n+\t\tgit-prune-packed\n \tfi\n fi\n \n"},{"id":"17362","messageId":"20060309102419.GA9961@igloo.ds.co.ug","threadId":"3592","inReplyTo":"20060307212918.GA9474@steel.home","subject":"Re: [PATCH] Allow git-repack to optionally run git-prune-packed.","fromName":"Martin Atukunda","fromEmail":"matlads@dsmagic.com","sentAt":"2006-03-09T10:24:19Z","receivedAt":"2006-03-09T10:24:19Z","isPatch":true,"sender":{"key":"matlads@dsmagic.com","avatar":null},"body":"Your suggestion has merit, though it's different from the behaviour I\ndesired. I _sometimes_ need the pruning, and it felt appropriate to make\nit an option as opposed to default behaviour.\n\nWhat do you think?\n\n- Martin -\n\nOn Tue, Mar 07, 2006 at 10:29:18PM +0100, Alex Riesen wrote:\n> Martin Atukunda, Tue, Mar 07, 2006 16:16:12 +0100:\n> > +-p::\n> > +\tRun `git-prune-packed` after packing, see\n> > +\tgitlink:git-prune-packed[1]\n> > +\n> \n> Maybe just make \"-d\" work? I.e. \"git repack -a -d\" repacks and prunes\n> everything, and \"git repack -d\" prunes just what was packed\n> incrementally.\n> Something like this:\n> \n> diff --git a/git-repack.sh b/git-repack.sh\n> index 3d6fec1..be6c7ab 100755\n> --- a/git-repack.sh\n> +++ b/git-repack.sh\n> @@ -74,6 +74,8 @@ then\n> \t\t\tesac\n> \t\t done\n> \t\t)\n> +\telse\n> +\t\tgit-prune-packed\n> \tfi\n> fi\n> \n> \n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n-- \nGirl on cell: Can you hear me when I roll my eyes?\n\t-- www.overheardinnewyourk.com\n"},{"id":"17376","messageId":"81b0412b0603090648w4a3e4e4bwceb0ad19a2a4d15f@mail.gmail.com","threadId":"3592","inReplyTo":"20060309102419.GA9961@igloo.ds.co.ug","subject":"Re: [PATCH] Allow git-repack to optionally run git-prune-packed.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-03-09T14:48:28Z","receivedAt":"2006-03-09T14:48:28Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 3/9/06, Martin Atukunda wrote:\n> Your suggestion has merit, though it's different from the behaviour I\n> desired. I _sometimes_ need the pruning, and it felt appropriate to make\n> it an option as opposed to default behaviour.\n>\n> What do you think?\n>\n\nI think that my patch didn't change the default. git-prune-packed is called\nonly if -d is given, which is not the default.\n"},{"id":"17394","messageId":"7vy7zj4flo.fsf@assigned-by-dhcp.cox.net","threadId":"3592","inReplyTo":"81b0412b0603090648w4a3e4e4bwceb0ad19a2a4d15f@mail.gmail.com","subject":"Re: [PATCH] Allow git-repack to optionally run git-prune-packed.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-03-09T18:50:43Z","receivedAt":"2006-03-09T18:50:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alex Riesen\" writes:\n\n> On 3/9/06, Martin Atukunda wrote:\n>> Your suggestion has merit, though it's different from the behaviour I\n>> desired. I _sometimes_ need the pruning, and it felt appropriate to make\n>> it an option as opposed to default behaviour.\n>>\n>> What do you think?\n>\n> I think that my patch didn't change the default. git-prune-packed is called\n> only if -d is given, which is not the default.\n\nI am inclined to say I prefer Alex' one.\n"}]}