{"thread":{"id":"35915","subject":"release-notes could be clearer on git-fetch changes","startedAt":"2014-02-19T18:53:32Z","lastAt":"2014-02-20T17:54:34Z","messageCount":6,"participants":["Jan Engelhardt","Junio C Hamano","Michael Haggerty"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"235060","messageId":"alpine.LSU.2.11.1402191952070.31131@nerf08.vanv.qr","threadId":"35915","inReplyTo":null,"subject":"release-notes could be clearer on git-fetch changes","fromName":"Jan Engelhardt","fromEmail":"jengelh@inai.de","sentAt":"2014-02-19T18:53:32Z","receivedAt":"2014-02-19T18:53:32Z","isPatch":false,"sender":{"key":"jengelh@inai.de","avatar":"https://avatars.githubusercontent.com/u/8861948?v=4"},"body":"Greetings.\n\n\nThe release notes for 1.9.0 read:\n\n> * The \"--tags\" option to \"git fetch\" no longer tells the command to\n> fetch _only_ the tags. It instead fetches tags _in addition to_\n> what are fetched by the same command line without the option.\n\nI think the release notes should also say -- like it was done\nextensively for git add -- how to get back the old\nbehavior (perhaps through now-different commands).\n\n\nthanks,\nJan\n"},{"id":"235064","messageId":"xmqqtxbu98ie.fsf@gitster.dls.corp.google.com","threadId":"35915","inReplyTo":"alpine.LSU.2.11.1402191952070.31131@nerf08.vanv.qr","subject":"Re: release-notes could be clearer on git-fetch changes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-02-19T20:01:45Z","receivedAt":"2014-02-19T20:01:45Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jan Engelhardt writes:\n\n> The release notes for 1.9.0 read:\n>\n>> * The \"--tags\" option to \"git fetch\" no longer tells the command to\n>> fetch _only_ the tags. It instead fetches tags _in addition to_\n>> what are fetched by the same command line without the option.\n>\n> I think the release notes should also say -- like it was done\n> extensively for git add -- how to get back the old\n> behavior (perhaps through now-different commands).\n\nPerhaps, but the release note is not a place to repeat what the\ndocumentation already teaches---it primarily is to enumerate the\nchanged areas, to highlight the things users may want to look up in the\ndocumentation, to give them a starting point.\n\nYou would do something like this, I would think:\n\n\tgit fetch $there 'refs/tags/*:refs/tags/*'\n"},{"id":"235079","messageId":"alpine.LSU.2.11.1402192356480.1491@nerf08.vanv.qr","threadId":"35915","inReplyTo":"xmqqtxbu98ie.fsf@gitster.dls.corp.google.com","subject":"Re: release-notes could be clearer on git-fetch changes","fromName":"Jan Engelhardt","fromEmail":"jengelh@inai.de","sentAt":"2014-02-19T22:58:00Z","receivedAt":"2014-02-19T22:58:00Z","isPatch":false,"sender":{"key":"jengelh@inai.de","avatar":"https://avatars.githubusercontent.com/u/8861948?v=4"},"body":"\nOn Wednesday 2014-02-19 21:01, Junio C Hamano wrote:\n>Jan Engelhardt writes:\n>> The release notes for 1.9.0 read:\n>>\n>>> * The \"--tags\" option to \"git fetch\" no longer tells the command to\n>>> fetch _only_ the tags. It instead fetches tags _in addition to_\n>>> what are fetched by the same command line without the option.\n>>\n>> I think the release notes should also say -- like it was done\n>> extensively for git add -- how to get back the old\n>> behavior (perhaps through now-different commands).\n>\n>Perhaps, but the release note is not a place to repeat what the\n>documentation already teaches---it primarily is to enumerate the\n>changed areas, to highlight the things users may want to look up in the\n>documentation, to give them a starting point.\n>\n>You would do something like this, I would think:\n>\n>\tgit fetch $there 'refs/tags/*:refs/tags/*'\n\nLooking at it from one more angle, `git fetch r --tags` and\n`git push r --tags` is now no longer symmetric :(\n"},{"id":"235091","messageId":"alpine.LSU.2.11.1402200821010.6991@nerf08.vanv.qr","threadId":"35915","inReplyTo":"CAPc5daUgs8cKNnXcdjLy+S7jGN8BnjNzF66HMSz8infmo9Ws3Q@mail.gmail.com","subject":"Re: release-notes could be clearer on git-fetch changes","fromName":"Jan Engelhardt","fromEmail":"jengelh@inai.de","sentAt":"2014-02-20T09:51:23Z","receivedAt":"2014-02-20T09:51:23Z","isPatch":false,"sender":{"key":"jengelh@inai.de","avatar":"https://avatars.githubusercontent.com/u/8861948?v=4"},"body":"On Thursday 2014-02-20 00:40, Junio C Hamano wrote:\n\n>On Wed, Feb 19, 2014 at 2:58 PM, Jan Engelhardt wrote:\n> Looking at it from one more angle, `git fetch r --tags` and\n>`git push r --tags` is now no longer symmetric :(\n>\n>\n>I would have loved to hear such comments _during_ the discussion, not after\n>a release is made,\n\nPerhaps, though I only became aware of this change because LWN reported \nabout git 1.9.0.\n"},{"id":"235092","messageId":"5305E1A9.1050203@alum.mit.edu","threadId":"35915","inReplyTo":"alpine.LSU.2.11.1402192356480.1491@nerf08.vanv.qr","subject":"Re: release-notes could be clearer on git-fetch changes","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2014-02-20T11:06:17Z","receivedAt":"2014-02-20T11:06:17Z","isPatch":false,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On 02/19/2014 11:58 PM, Jan Engelhardt wrote:\n> On Wednesday 2014-02-19 21:01, Junio C Hamano wrote:\n>> Jan Engelhardt writes:\n>>> The release notes for 1.9.0 read:\n>>>\n>>>> * The \"--tags\" option to \"git fetch\" no longer tells the command to\n>>>> fetch _only_ the tags. It instead fetches tags _in addition to_\n>>>> what are fetched by the same command line without the option.\n>>>\n>>> I think the release notes should also say -- like it was done\n>>> extensively for git add -- how to get back the old\n>>> behavior (perhaps through now-different commands).\n>>\n>> Perhaps, but the release note is not a place to repeat what the\n>> documentation already teaches---it primarily is to enumerate the\n>> changed areas, to highlight the things users may want to look up in the\n>> documentation, to give them a starting point.\n>>\n>> You would do something like this, I would think:\n>>\n>> \tgit fetch $there 'refs/tags/*:refs/tags/*'\n> \n> Looking at it from one more angle, `git fetch r --tags` and\n> `git push r --tags` is now no longer symmetric :(\n\nI'm glad you brought this up, because I didn't really think about\nwhether \"git push\" would need changes parallel to those in \"git fetch\".\n\nI use \"git push\" in very conservative ways, so I don't know its ins and\nouts. What scenarios do you find asymmetric? Were they more symmetric\nbefore?\n\nPerhaps you don't like that when some branch is configured for pushing\nvia remote.$remote.push, so that\n\n git push $remote\n\nwould push something, then you would expect\n\n git push --tags $remote\n\nto push the same something *plus* the tags. But I'm not sure that is\ndesirable. Pushing is a lot more traumatic than fetching, because any\nmistakes are obvious to all of your collaborators. So I think it is OK\nthat the command is more reticent about pushing things that were\nspecified implicitly.\n\nOne thing I personally don't like is that\n\n git push $remote --all --tags\n\nis not allowed. I would expect it to push all branches and all tags.\nBut at least it just emits an error rather than doing something unexpected.\n\nMichael\n\n-- \nMichael Haggerty\nmhagger@alum.mit.edu\nhttp://softwareswirl.blogspot.com/\n"},{"id":"235100","messageId":"alpine.LSU.2.11.1402201754370.11221@nerf08.vanv.qr","threadId":"35915","inReplyTo":"alpine.LSU.2.11.1402192356480.1491@nerf08.vanv.qr","subject":"Re: release-notes could be clearer on git-fetch changes","fromName":"Jan Engelhardt","fromEmail":"jengelh@inai.de","sentAt":"2014-02-20T17:54:34Z","receivedAt":"2014-02-20T17:54:34Z","isPatch":false,"sender":{"key":"jengelh@inai.de","avatar":"https://avatars.githubusercontent.com/u/8861948?v=4"},"body":"\nOn Thu, 20 Feb 2014 12:06:17, Michael Haggerty wrote:\n>On 02/19/2014 11:58 PM, Jan Engelhardt wrote:\n>> \n>> Looking at it from one more angle, `git fetch r --tags` and\n>> `git push r --tags` is now no longer symmetric :(\n>\n>I'm glad you brought this up, because I didn't really think about\n>whether \"git push\" would need changes parallel to those in \"git fetch\".\n>\n>I use \"git push\" in very conservative ways, so I don't know its ins and\n>outs. What scenarios do you find asymmetric? Were they more symmetric\n>before?\n\n`git push r --tags` pushes only tags, and `git fetch r --tags` only\nfetched tags.\n\nStarting from 1.9.0, `git fetch r --tags`, according to the release\nsummary, changed to \"tags and other things\".\n\nThat's the asymmetric change I find. It is, as you say,\nundesirable to have `git push r --tags` push more than tags, which\nis why I am objecting (acknowledging it's after-the-fact) that\nthe change to git-fetch was so-so.\n\nA new option `git fetch r --only-tags` could remedy the\nhard-to-remember syntax `git fetch r \"refs/tags/*:refs/tags/*\"`,\nthough it would not fix the asymmetry.\n"}]}