{"thread":{"id":"35732","subject":"[PATCH] Makefile: remove redundant object in git-http{fetch,push}","startedAt":"2014-01-25T13:11:44Z","lastAt":"2014-01-25T13:11:44Z","messageCount":1,"participants":["John Keeping"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"233749","messageId":"9f32a674457f4016136fa4e214921e00a31032bd.1390655504.git.john@keeping.me.uk","threadId":"35732","inReplyTo":null,"subject":"[PATCH] Makefile: remove redundant object in git-http{fetch,push}","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2014-01-25T13:11:44Z","receivedAt":"2014-01-25T13:11:44Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"revision.o is included in libgit.a which is in $(GITLIBS), so we don't\nneed to include is separately.  This fixes compilation with\n\"-fwhole-program\" which otherwise fails with messages like this:\n\n  libgit.a(revision.o): In function `mark_tree_uninteresting':\n  /home/john/src/git/revision.c:108: multiple definition of `mark_tree_uninteresting'\n  /tmp/ccKQRkZV.ltrans2.ltrans.o:/home/john/src/git/revision.c:108: first defined here\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n Makefile | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex b4af1e2..b3a408d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2050,10 +2050,10 @@ git-imap-send$X: imap-send.o GIT-LDFLAGS $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)\n \n-git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o GIT-LDFLAGS $(GITLIBS)\n+git-http-fetch$X: http.o http-walker.o http-fetch.o GIT-LDFLAGS $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL)\n-git-http-push$X: revision.o http.o http-push.o GIT-LDFLAGS $(GITLIBS)\n+git-http-push$X: http.o http-push.o GIT-LDFLAGS $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)\n \n-- \n1.9.rc0.187.g6292fff\n"}]}