{"thread":{"id":"35682","subject":"BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","startedAt":"2014-01-17T20:23:18Z","lastAt":"2014-01-17T23:38:27Z","messageCount":5,"participants":["Strainu","Jonathan Nieder","Jerry Xinyu Zhao"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"233319","messageId":"CAC9meRKiR+60YaGiuCu4twEt6dyWksEjHSH8YPTEvmD=LoB=aw@mail.gmail.com","threadId":"35682","inReplyTo":null,"subject":"BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","fromName":"Strainu","fromEmail":"strainu10@gmail.com","sentAt":"2014-01-17T20:23:18Z","receivedAt":"2014-01-17T20:23:18Z","isPatch":false,"sender":{"key":"strainu10@gmail.com","avatar":null},"body":"I was trying to send a new version of a patch to a gerrit server from\na new computer, so I made a change with a ChangeId in the description\nand tried to review it:\n\nstrainu@emily:~/core> git branch archivebot\nstrainu@emily:~/core> git checkout archivebot\nM pywikibot/page.py\nSwitched to branch 'archivebot'\nstrainu@emily:~/core> git diff\nstrainu@emily:~/core> git add .\nstrainu@emily:~/core> git commit\n[archivebot 282ad24] Update getFileVersionHistoryTable.\n 1 file changed, 3 insertions(+), 4 deletions(-)\nstrainu@emily:~/core> git review -f\nCreating a git remote called \"gerrit\" that maps to:\n ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git\nYour change was committed before the commit hook was installed.\nAmending the commit to add a gerrit change id.\n\n\nAt this point I ended the transaction, as I was confused by the last\nmessage: I was afraid the ChangeId would have changed, causing the\npatch to be attached to another review.\n\nI think git should not show this message if the change description\nalready has a change id, or at least add another message that\nclarifies the fact that the change id has not changed.\n\nThanks,\n Strainu\n"},{"id":"233321","messageId":"20140117204132.GB18964@google.com","threadId":"35682","inReplyTo":"CAC9meRKiR+60YaGiuCu4twEt6dyWksEjHSH8YPTEvmD=LoB=aw@mail.gmail.com","subject":"Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-01-17T20:41:32Z","receivedAt":"2014-01-17T20:41:32Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nStrainu wrote:\n\n> strainu@emily:~/core> git review -f\n> Creating a git remote called \"gerrit\" that maps to:\n> ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git\n> Your change was committed before the commit hook was installed.\n> Amending the commit to add a gerrit change id.\n>\n> At this point I ended the transaction, as I was confused by the last\n> message: I was afraid the ChangeId would have changed, causing the\n> patch to be attached to another review.\n>\n> I think git should not show this message if the change description\n> already has a change id\n\nThis message doesn't come from git. It comes from the git-review\ntool (in git_review/cmd.py), so cc-ing the authors in case they\nhave thoughts on that.\n\nThanks,\nJonathan\n"},{"id":"233323","messageId":"CAC9meR+78_EvoqHNcuPyDKOZDjSsUngziGDa2aV1QDtOb8eOXw@mail.gmail.com","threadId":"35682","inReplyTo":"20140117204132.GB18964@google.com","subject":"Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","fromName":"Strainu","fromEmail":"strainu10@gmail.com","sentAt":"2014-01-17T21:10:27Z","receivedAt":"2014-01-17T21:10:27Z","isPatch":false,"sender":{"key":"strainu10@gmail.com","avatar":null},"body":"2014/1/17 Jonathan Nieder :\n> Hi,\n>\n> Strainu wrote:\n>\n>> strainu@emily:~/core> git review -f\n>> Creating a git remote called \"gerrit\" that maps to:\n>> ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git\n>> Your change was committed before the commit hook was installed.\n>> Amending the commit to add a gerrit change id.\n>>\n>> At this point I ended the transaction, as I was confused by the last\n>> message: I was afraid the ChangeId would have changed, causing the\n>> patch to be attached to another review.\n>>\n>> I think git should not show this message if the change description\n>> already has a change id\n>\n> This message doesn't come from git. It comes from the git-review\n> tool (in git_review/cmd.py), so cc-ing the authors in case they\n> have thoughts on that.\n\nThanks for clarifying that. I'll log a bug on launchpad then.\n\nStrainu\n"},{"id":"233325","messageId":"CAE3ttVgs=F2bWbx5qa=dp1kNzgc5djtB3r+2Qp6tvYv-iZKoCw@mail.gmail.com","threadId":"35682","inReplyTo":"CAC9meR+78_EvoqHNcuPyDKOZDjSsUngziGDa2aV1QDtOb8eOXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org","subject":"Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","fromName":"Jerry Xinyu Zhao","fromEmail":"xyzjerry-re5jqeeqqe8avxtiumwx3w@public.gmane.org","sentAt":"2014-01-17T23:24:21Z","receivedAt":"2014-01-17T23:24:21Z","isPatch":false,"sender":{"key":"xyzjerry-re5jqeeqqe8avxtiumwx3w@public.gmane.org","avatar":null},"body":"I think if you hadn't installed the commit hook for generating change ID,\nthe commit indeed wouldn't have included a change ID, which is necessary\nfor referencing the change when you submit a patch over it. There is\nnothing wrong with the message. git review tool will install the hook and\nadd a change ID for you automatically(a new feature of recent git-review\nrelease).\n\n\n\nOn Fri, Jan 17, 2014 at 1:10 PM, Strainu wrote:\n\n> 2014/1/17 Jonathan Nieder :\n> > Hi,\n> >\n> > Strainu wrote:\n> >\n> >> strainu@emily:~/core> git review -f\n> >> Creating a git remote called \"gerrit\" that maps to:\n> >> ssh://strainu-pdwPRaUiG6tP5deQkEKVHGD2FQJk+8+b@public.gmane.org:29418/pywikibot/core.git\n> >> Your change was committed before the commit hook was installed.\n> >> Amending the commit to add a gerrit change id.\n> >>\n> >> At this point I ended the transaction, as I was confused by the last\n> >> message: I was afraid the ChangeId would have changed, causing the\n> >> patch to be attached to another review.\n> >>\n> >> I think git should not show this message if the change description\n> >> already has a change id\n> >\n> > This message doesn't come from git. It comes from the git-review\n> > tool (in git_review/cmd.py), so cc-ing the authors in case they\n> > have thoughts on that.\n>\n> Thanks for clarifying that. I'll log a bug on launchpad then.\n>\n> Strainu\n>\n> _______________________________________________\n> OpenStack-Infra mailing list\n> OpenStack-Infra-ZwoEplunGu0gQVYkTtqAhEB+6BGkLq7r@public.gmane.org\n> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra\n>\n\n\n_______________________________________________\nOpenStack-Infra mailing list\nOpenStack-Infra-ZwoEplunGu0gQVYkTtqAhEB+6BGkLq7r@public.gmane.org\nhttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra\n"},{"id":"233327","messageId":"CAC9meR+zViFN5PEZxvYp_4XY28OvcR9SeiOP_5DbBCmChYPONg@mail.gmail.com","threadId":"35682","inReplyTo":"CAE3ttVgs=F2bWbx5qa=dp1kNzgc5djtB3r+2Qp6tvYv-iZKoCw@mail.gmail.com","subject":"Re: [OpenStack-Infra] BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed","fromName":"Strainu","fromEmail":"strainu10@gmail.com","sentAt":"2014-01-17T23:38:27Z","receivedAt":"2014-01-17T23:38:27Z","isPatch":false,"sender":{"key":"strainu10@gmail.com","avatar":null},"body":"Perhaps I haven't been clear enough: the commit already had a change\nID, added manually, so with or without the hook it would have been\nattached to the correct review.\n\nIn this case, the hook will actually do nothing, making the current\nwording of the message confusing IMO. My suggestion was [1] to change\nthe mesage to \"Amending the commit to add a gerrit change id if none\nis available.\" or something similar.\n\nStrainu\n\n[1] https://bugs.launchpad.net/git-review/+bug/1270301\n\n2014/1/18 Jerry Xinyu Zhao :\n> I think if you hadn't installed the commit hook for generating change ID,\n> the commit indeed wouldn't have included a change ID, which is necessary for\n> referencing the change when you submit a patch over it. There is nothing\n> wrong with the message. git review tool will install the hook and add a\n> change ID for you automatically(a new feature of recent git-review release).\n>\n>\n>\n> On Fri, Jan 17, 2014 at 1:10 PM, Strainu wrote:\n>>\n>> 2014/1/17 Jonathan Nieder :\n>> > Hi,\n>> >\n>> > Strainu wrote:\n>> >\n>> >> strainu@emily:~/core> git review -f\n>> >> Creating a git remote called \"gerrit\" that maps to:\n>> >> ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git\n>> >> Your change was committed before the commit hook was installed.\n>> >> Amending the commit to add a gerrit change id.\n>> >>\n>> >> At this point I ended the transaction, as I was confused by the last\n>> >> message: I was afraid the ChangeId would have changed, causing the\n>> >> patch to be attached to another review.\n>> >>\n>> >> I think git should not show this message if the change description\n>> >> already has a change id\n>> >\n>> > This message doesn't come from git. It comes from the git-review\n>> > tool (in git_review/cmd.py), so cc-ing the authors in case they\n>> > have thoughts on that.\n>>\n>> Thanks for clarifying that. I'll log a bug on launchpad then.\n>>\n>> Strainu\n>>\n>> _______________________________________________\n>> OpenStack-Infra mailing list\n>> OpenStack-Infra@lists.openstack.org\n>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra\n>\n>\n"}]}