{"thread":{"id":"35610","subject":"[PATCH 1/2] send-pack.c: mark a file-local function static","startedAt":"2014-01-05T23:55:01Z","lastAt":"2014-01-05T23:55:01Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"232683","messageId":"52C9F0D5.9080800@ramsay1.demon.co.uk","threadId":"35610","inReplyTo":null,"subject":"[PATCH 1/2] send-pack.c: mark a file-local function static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-01-05T23:55:01Z","receivedAt":"2014-01-05T23:55:01Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit f2c681cf (\"send-pack: support pushing from a shallow clone\nvia http\", 05-12-2013) adds the 'advertise_shallow_grafts_buf'\nfunction as an external symbol.\n\nNoticed by sparse. (\"'advertise_shallow_grafts_buf' was not declared.\nShould it be static?\")\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n send-pack.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/send-pack.c b/send-pack.c\nindex 2a199cc..6129b0f 100644\n--- a/send-pack.c\n+++ b/send-pack.c\n@@ -183,7 +183,7 @@ static int advertise_shallow_grafts_cb(const struct commit_graft *graft, void *c\n \treturn 0;\n }\n \n-void advertise_shallow_grafts_buf(struct strbuf *sb)\n+static void advertise_shallow_grafts_buf(struct strbuf *sb)\n {\n \tif (!is_repository_shallow())\n \t\treturn;\n-- \n1.8.5\n"}]}