{"thread":{"id":"35603","subject":"[PATCH] Documentation/gitmodules: Only 'update' and 'url' are required","startedAt":"2014-01-03T18:31:22Z","lastAt":"2014-01-04T22:59:16Z","messageCount":3,"participants":["W. Trevor King","Heiko Voigt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"232626","messageId":"c22c81472bb8b8943d34bdf1ac9ef61f5a489a16.1388773808.git.wking@tremily.us","threadId":"35603","inReplyTo":null,"subject":"[PATCH] Documentation/gitmodules: Only 'update' and 'url' are required","fromName":"W. Trevor King","fromEmail":"wking@tremily.us","sentAt":"2014-01-03T18:31:22Z","receivedAt":"2014-01-03T18:31:22Z","isPatch":true,"sender":{"key":"wking@tremily.us","avatar":"https://avatars.githubusercontent.com/u/209920?v=4"},"body":"From: \"W. Trevor King\" <wking@tremily.us>\n\nBefore this commit, all the settings fell under the initial \"Each\nsubmodule section also contains the following required keys:\".  The\nexample shows sections with just 'update' and 'url' entries, but we\nshould still make the required/optional distinction explicit for the\ndescriptions.\n\nSigned-off-by: W. Trevor King <wking@tremily.us>\n---\n Documentation/gitmodules.txt | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt\nindex f7be93f..347a9f7 100644\n--- a/Documentation/gitmodules.txt\n+++ b/Documentation/gitmodules.txt\n@@ -35,6 +35,8 @@ submodule.<name>.url::\n \tlinkgit:git-clone[1] or (if it begins with ./ or ../) a location\n \trelative to the superproject's origin repository.\n \n+In addition, there are a number of optional keys:\n+\n submodule.<name>.update::\n \tDefines what to do when the submodule is updated by the superproject.\n \tIf 'checkout' (the default), the new commit specified in the\n-- \n1.8.5.2.gaa5d535.dirty\n"},{"id":"232651","messageId":"20140104221754.GB5697@book-mint","threadId":"35603","inReplyTo":"c22c81472bb8b8943d34bdf1ac9ef61f5a489a16.1388773808.git.wking@tremily.us","subject":"Re: [PATCH] Documentation/gitmodules: Only 'update' and 'url' are required","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2014-01-04T22:17:54Z","receivedAt":"2014-01-04T22:17:54Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Fri, Jan 03, 2014 at 10:31:22AM -0800, W. Trevor King wrote:\n> From: \"W. Trevor King\" <wking@tremily.us>\n> \n> Before this commit, all the settings fell under the initial \"Each\n> submodule section also contains the following required keys:\".  The\n> example shows sections with just 'update' and 'url' entries, but we\n\nYou mean:\n\n\t...with just 'path' and 'url' entries...\n\n?\n\nOther than that, the patch looks good to me.\n\nCheers Heiko\n"},{"id":"232653","messageId":"20140104225916.GB3156@odin.tremily.us","threadId":"35603","inReplyTo":"20140104221754.GB5697@book-mint","subject":"Re: [PATCH] Documentation/gitmodules: Only 'update' and 'url' are required","fromName":"W. Trevor King","fromEmail":"wking@tremily.us","sentAt":"2014-01-04T22:59:16Z","receivedAt":"2014-01-04T22:59:16Z","isPatch":true,"sender":{"key":"wking@tremily.us","avatar":"https://avatars.githubusercontent.com/u/209920?v=4"},"body":"On Sat, Jan 04, 2014 at 11:17:54PM +0100, Heiko Voigt wrote:\n> On Fri, Jan 03, 2014 at 10:31:22AM -0800, W. Trevor King wrote:\n> > Before this commit, all the settings fell under the initial \"Each\n> > submodule section also contains the following required keys:\".  The\n> > example shows sections with just 'update' and 'url' entries, but we\n> \n> You mean:\n> \n> \t...with just 'path' and 'url' entries...\n\nOops, yes.  And in the summary/subject as well.  I can submit a v2 if\nfolks want, or just deputize Junio to fix it if/when this is applied.\n\nCheers,\nTrevor\n\n-- \nThis email may be signed or encrypted with GnuPG (http://www.gnupg.org).\nFor more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\n"}]}