{"thread":{"id":"3558","subject":"[PATCH] Use core.sharedrepository consistently.","startedAt":"2006-03-04T22:51:25Z","lastAt":"2006-03-04T23:16:40Z","messageCount":3,"participants":["Fernando J. Pereda","Linus Torvalds"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"17156","messageId":"20060304225125.GB8891@ferdyx.org","threadId":"3558","inReplyTo":null,"subject":"[PATCH] Use core.sharedrepository consistently.","fromName":"Fernando J. Pereda","fromEmail":"ferdy@gentoo.org","sentAt":"2006-03-04T22:51:25Z","receivedAt":"2006-03-04T22:51:25Z","isPatch":true,"sender":{"key":"ferdy@gentoo.org","avatar":null},"body":"'git init-db --shared' sets 'core.sharedRepository' but in\nsetup.c 'core.sharedrepository' is checked instead. This\ntrivial patch makes both init-db.c and its documentation to\nuse 'core.sharedrepository'.\n\nSigned-off-by: Fernando J. Pereda <ferdy@gentoo.org>\n\n---\n\n Documentation/git-init-db.txt |    2 +-\n init-db.c                     |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n531df8e5c78ca67746b7a651ac4486eae8b114c6\ndiff --git a/Documentation/git-init-db.txt b/Documentation/git-init-db.txt\nindex ea4d849..2d818d6 100644\n--- a/Documentation/git-init-db.txt\n+++ b/Documentation/git-init-db.txt\n@@ -34,7 +34,7 @@ environment variable then the sha1 direc\n otherwise the default `$GIT_DIR/objects` directory is used.\n \n A shared repository allows users belonging to the same group to push into that\n-repository. When specifying `--shared` the config variable \"core.sharedRepository\" \n+repository. When specifying `--shared` the config variable \"core.sharedrepository\"\n is set to 'true' so that directories under `$GIT_DIR` are made group writable\n (and g+sx, since the git group may be not the primary group of all users).\n \ndiff --git a/init-db.c b/init-db.c\nindex ff29496..e77a749 100644\n--- a/init-db.c\n+++ b/init-db.c\n@@ -285,7 +285,7 @@ int main(int argc, char **argv)\n \tsafe_create_dir(path, 1);\n \n \tif (shared_repository)\n-\t\tgit_config_set(\"core.sharedRepository\", \"true\");\n+\t\tgit_config_set(\"core.sharedrepository\", \"true\");\n \n \treturn 0;\n }\n-- \n1.2.4\n\n"},{"id":"17157","messageId":"20060304230245.GA28469@ferdyx.org","threadId":"3558","inReplyTo":"20060304225125.GB8891@ferdyx.org","subject":"Re: [PATCH] Use core.sharedrepository consistently.","fromName":"Fernando J. Pereda","fromEmail":"ferdy@gentoo.org","sentAt":"2006-03-04T23:02:45Z","receivedAt":"2006-03-04T23:02:45Z","isPatch":true,"sender":{"key":"ferdy@gentoo.org","avatar":null},"body":"On Sat, Mar 04, 2006 at 11:51:25PM +0100, Fernando J. Pereda wrote:\n> [snip]\n\nNevermind that one... I screwed almost every possible header in my mail.\nSorry.\n\n-- \nFernando J. Pereda Garcimartín\nGentoo Developer (Alpha,net-mail,mutt,git)\n20BB BDC3 761A 4781 E6ED  ED0B 0A48 5B0C 60BD 28D4\n"},{"id":"17160","messageId":"Pine.LNX.4.64.0603041514050.22647@g5.osdl.org","threadId":"3558","inReplyTo":"20060304225125.GB8891@ferdyx.org","subject":"Re: [PATCH] Use core.sharedrepository consistently.","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-03-04T23:16:40Z","receivedAt":"2006-03-04T23:16:40Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sat, 4 Mar 2006, Fernando J. Pereda wrote:\n>\n> 'git init-db --shared' sets 'core.sharedRepository' but in\n> setup.c 'core.sharedrepository' is checked instead.\n\nIt really shouldn't matter.\n\nCase in a git config option name is always converted to lower case when \nthe config file is read, exactly so that you can use mixed case without \nthe actual readers caring. Lots of people prefer mixed-case for \nhuman-readable info, ie\n\n\t[Core]\n\t\tName=Linus Torvalds\n\nwill actually generate\n\n\tcore.name=Linus Torvalds\n\nas the config variable.\n\nSo the code should have worked fine.  Unless there is some bug somewhere.\n\n\t\tLinus\n"}]}