{"thread":{"id":"35536","subject":"Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches","startedAt":"2013-12-17T09:59:14Z","lastAt":"2013-12-17T18:00:57Z","messageCount":2,"participants":["Gunnar Strand","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"232092","messageId":"CAEsF1LtJBA8gT9nEJv0_4CKRLGL7eWD19ghUGzQ9uWUCmj8X7w@mail.gmail.com","threadId":"35536","inReplyTo":null,"subject":"Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches","fromName":"Gunnar Strand","fromEmail":"gurra.strand@gmail.com","sentAt":"2013-12-17T09:59:14Z","receivedAt":"2013-12-17T09:59:14Z","isPatch":false,"sender":{"key":"gurra.strand@gmail.com","avatar":null},"body":"Hi,\n\nThe patch submission document has an inconsistency regarding who should be\n\"To\" and \"Cc\" for approved patches:\n\nTo maintainer, cc list:\n\n212 After the list reached a consensus that it is a good idea to apply the\n213 patch, re-send it with \"To:\" set to the maintainer [*1*] and \"cc:\" the\n214 list [*2*] for inclusion.\n\n\nTo list, cc maintainer:\n\n339  (4) The list forms consensus that the last round of your patch is\n340      good.  Send it to the list and cc the maintainer.\n\n\nRef 1:\nhttps://github.com/git/git/blob/master/Documentation/SubmittingPatches#L212\nRef 2:\nhttps://github.com/git/git/blob/master/Documentation/SubmittingPatches#L339\n\n\nBR\nGunnar\n"},{"id":"232108","messageId":"xmqqob4fmk6e.fsf@gitster.dls.corp.google.com","threadId":"35536","inReplyTo":"CAEsF1LtJBA8gT9nEJv0_4CKRLGL7eWD19ghUGzQ9uWUCmj8X7w@mail.gmail.com","subject":"Re: Document SubmittingPatches: inconsistency regarding to: and cc: for approved patches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-12-17T18:00:57Z","receivedAt":"2013-12-17T18:00:57Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Gunnar Strand <gurra.strand@gmail.com> writes:\n\n> The patch submission document has an inconsistency regarding who should be\n> \"To\" and \"Cc\" for approved patches:\n>\n> To maintainer, cc list:\n>\n> 212 After the list reached a consensus that it is a good idea to apply the\n> 213 patch, re-send it with \"To:\" set to the maintainer [*1*] and \"cc:\" the\n> 214 list [*2*] for inclusion.\n>\n>\n> To list, cc maintainer:\n>\n> 339  (4) The list forms consensus that the last round of your patch is\n> 340      good.  Send it to the list and cc the maintainer.\n\nThanks. In the latter, they are swapped.\n\nPerhaps the whole section can be dropped?  Back when the section was\nwritten, the top section did not describe the review iteration and\nlines 212-214 you quoted above did not exist, but the top section of\nthe current document already cover everything in the \"ideal patch\nflow\" section, I think.\n"}]}