{"thread":{"id":"35315","subject":"[RFC/PATCH 0/4] Remove deprecated commands","startedAt":"2013-11-10T15:47:27Z","lastAt":"2013-12-04T10:23:31Z","messageCount":12,"participants":["John Keeping","Junio C Hamano","Jonathan Nieder","Michael J Gruber"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"230367","messageId":"cover.1384098226.git.john@keeping.me.uk","threadId":"35315","inReplyTo":null,"subject":"[RFC/PATCH 0/4] Remove deprecated commands","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-10T15:47:27Z","receivedAt":"2013-11-10T15:47:27Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"\"git repo-config\", \"git tar-tree\", \"git lost-found\" and \"git\npeek-remote\" have all been deprecated since at least Git 1.5.4.\n\nWith Git 2.0 approaching, I think that would be a good point to remove\nthen completely, which is what this series does.\n\nJohn Keeping (4):\n  repo-config: remove deprecated alias for \"git config\"\n  tar-tree: remove deprecated command\n  lost-found: remove deprecated command\n  peek-remote: remove deprecated alias of ls-remote\n\n .gitignore                             |  4 --\n Documentation/git-lost-found.txt       | 74 ------------------------------\n Documentation/git-peek-remote.txt      | 43 ------------------\n Documentation/git-repo-config.txt      | 23 ----------\n Documentation/git-tar-tree.txt         | 82 ----------------------------------\n Makefile                               |  3 --\n builtin.h                              |  1 -\n builtin/config.c                       |  6 ---\n builtin/tar-tree.c                     | 62 -------------------------\n command-list.txt                       |  4 --\n contrib/completion/git-completion.bash |  4 --\n contrib/examples/git-whatchanged.sh    |  4 +-\n git-lost-found.sh                      | 33 --------------\n git.c                                  |  3 --\n t/t4116-apply-reverse.sh               |  4 +-\n t/t5000-tar-tree.sh                    | 16 ++-----\n t/t5001-archive-attr.sh                | 10 -----\n 17 files changed, 7 insertions(+), 369 deletions(-)\n delete mode 100644 Documentation/git-lost-found.txt\n delete mode 100644 Documentation/git-peek-remote.txt\n delete mode 100644 Documentation/git-repo-config.txt\n delete mode 100644 Documentation/git-tar-tree.txt\n delete mode 100755 git-lost-found.sh\n\n-- \n1.8.5.rc0.170.g772b8ec\n"},{"id":"230368","messageId":"2a4079dbc0501d2ac33386e7d38123408fe4a54b.1384098226.git.john@keeping.me.uk","threadId":"35315","inReplyTo":"cover.1384098226.git.john@keeping.me.uk","subject":"[RFC/PATCH 1/4] repo-config: remove deprecated alias for \"git config\"","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-10T15:47:28Z","receivedAt":"2013-11-10T15:47:28Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"The release notes for Git 1.5.4 say that \"git repo-config\" will be\nremoved in the next feature release.  Since Git 2.0 is nearly here,\nremove it.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n .gitignore                             |  1 -\n Documentation/git-repo-config.txt      | 23 -----------------------\n Makefile                               |  1 -\n builtin.h                              |  1 -\n builtin/config.c                       |  6 ------\n command-list.txt                       |  1 -\n contrib/completion/git-completion.bash |  1 -\n contrib/examples/git-whatchanged.sh    |  4 ++--\n git.c                                  |  1 -\n 9 files changed, 2 insertions(+), 37 deletions(-)\n delete mode 100644 Documentation/git-repo-config.txt\n\ndiff --git a/.gitignore b/.gitignore\nindex 66199ed..3bc1b08 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -131,7 +131,6 @@\n /git-remote-testsvn\n /git-repack\n /git-replace\n-/git-repo-config\n /git-request-pull\n /git-rerere\n /git-reset\ndiff --git a/Documentation/git-repo-config.txt b/Documentation/git-repo-config.txt\ndeleted file mode 100644\nindex 9ec115b..0000000\n--- a/Documentation/git-repo-config.txt\n+++ /dev/null\n@@ -1,23 +0,0 @@\n-git-repo-config(1)\n-==================\n-\n-NAME\n-----\n-git-repo-config - Get and set repository or global options\n-\n-\n-SYNOPSIS\n---------\n-[verse]\n-'git repo-config' ...\n-\n-\n-DESCRIPTION\n------------\n-\n-This is a synonym for linkgit:git-config[1].  Please refer to the\n-documentation of that command.\n-\n-GIT\n----\n-Part of the linkgit:git[1] suite\ndiff --git a/Makefile b/Makefile\nindex af847f8..4fc2378 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -591,7 +591,6 @@ BUILT_INS += git-get-tar-commit-id$X\n BUILT_INS += git-init$X\n BUILT_INS += git-merge-subtree$X\n BUILT_INS += git-peek-remote$X\n-BUILT_INS += git-repo-config$X\n BUILT_INS += git-show$X\n BUILT_INS += git-stage$X\n BUILT_INS += git-status$X\ndiff --git a/builtin.h b/builtin.h\nindex b56cf07..d4afbfe 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -103,7 +103,6 @@ extern int cmd_remote(int argc, const char **argv, const char *prefix);\n extern int cmd_remote_ext(int argc, const char **argv, const char *prefix);\n extern int cmd_remote_fd(int argc, const char **argv, const char *prefix);\n extern int cmd_repack(int argc, const char **argv, const char *prefix);\n-extern int cmd_repo_config(int argc, const char **argv, const char *prefix);\n extern int cmd_rerere(int argc, const char **argv, const char *prefix);\n extern int cmd_reset(int argc, const char **argv, const char *prefix);\n extern int cmd_rev_list(int argc, const char **argv, const char *prefix);\ndiff --git a/builtin/config.c b/builtin/config.c\nindex 20e89fe..92ebf23 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -671,9 +671,3 @@ int cmd_config(int argc, const char **argv, const char *prefix)\n \n \treturn 0;\n }\n-\n-int cmd_repo_config(int argc, const char **argv, const char *prefix)\n-{\n-\tfprintf(stderr, \"WARNING: git repo-config is deprecated in favor of git config.\\n\");\n-\treturn cmd_config(argc, argv, prefix);\n-}\ndiff --git a/command-list.txt b/command-list.txt\nindex 08b04e2..f2bf684 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -102,7 +102,6 @@ git-relink                              ancillarymanipulators\n git-remote                              ancillarymanipulators\n git-repack                              ancillarymanipulators\n git-replace                             ancillarymanipulators\n-git-repo-config                         ancillarymanipulators\tdeprecated\n git-request-pull                        foreignscminterface\n git-rerere                              ancillaryinterrogators\n git-reset                               mainporcelain common\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex dba3c15..c6063c9 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -694,7 +694,6 @@ __git_list_porcelain_commands ()\n \t\tread-tree)        : plumbing;;\n \t\treceive-pack)     : plumbing;;\n \t\tremote-*)         : transport;;\n-\t\trepo-config)      : deprecated;;\n \t\trerere)           : plumbing;;\n \t\trev-list)         : plumbing;;\n \t\trev-parse)        : plumbing;;\ndiff --git a/contrib/examples/git-whatchanged.sh b/contrib/examples/git-whatchanged.sh\nindex 1fb9feb..2edbdc6 100755\n--- a/contrib/examples/git-whatchanged.sh\n+++ b/contrib/examples/git-whatchanged.sh\n@@ -9,12 +9,12 @@ case \"$0\" in\n *whatchanged)\n \tcount=\n \ttest -z \"$diff_tree_flags\" &&\n-\t\tdiff_tree_flags=$(git-repo-config --get whatchanged.difftree)\n+\t\tdiff_tree_flags=$(git config --get whatchanged.difftree)\n \tdiff_tree_default_flags='-c -M --abbrev' ;;\n *show)\n \tcount=-n1\n \ttest -z \"$diff_tree_flags\" &&\n-\t\tdiff_tree_flags=$(git-repo-config --get show.difftree)\n+\t\tdiff_tree_flags=$(git config --get show.difftree)\n \tdiff_tree_default_flags='--cc --always' ;;\n esac\n test -z \"$diff_tree_flags\" &&\ndiff --git a/git.c b/git.c\nindex cb5208d..0c9dde2 100644\n--- a/git.c\n+++ b/git.c\n@@ -421,7 +421,6 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"remote-fd\", cmd_remote_fd },\n \t\t{ \"repack\", cmd_repack, RUN_SETUP },\n \t\t{ \"replace\", cmd_replace, RUN_SETUP },\n-\t\t{ \"repo-config\", cmd_repo_config, RUN_SETUP_GENTLY },\n \t\t{ \"rerere\", cmd_rerere, RUN_SETUP },\n \t\t{ \"reset\", cmd_reset, RUN_SETUP },\n \t\t{ \"rev-list\", cmd_rev_list, RUN_SETUP },\n-- \n1.8.5.rc0.170.g772b8ec\n"},{"id":"230371","messageId":"d29327f6eb6e999ef31c3130ad2bab712a5d280b.1384098226.git.john@keeping.me.uk","threadId":"35315","inReplyTo":"cover.1384098226.git.john@keeping.me.uk","subject":"[RFC/PATCH 2/4] tar-tree: remove deprecated command","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-10T15:47:29Z","receivedAt":"2013-11-10T15:47:29Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"\"git tar-tree\" has been a thin wrapper around \"git archive\" since commit\nfd88d9c (Remove upload-tar and make git-tar-tree a thin wrapper to\ngit-archive, 2006-09-24), which also made it print a message indicating\nthat git-tar-tree is deprecated.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n .gitignore                             |  1 -\n Documentation/git-tar-tree.txt         | 82 ----------------------------------\n builtin/tar-tree.c                     | 62 -------------------------\n command-list.txt                       |  1 -\n contrib/completion/git-completion.bash |  1 -\n git.c                                  |  1 -\n t/t4116-apply-reverse.sh               |  4 +-\n t/t5000-tar-tree.sh                    | 16 ++-----\n t/t5001-archive-attr.sh                | 10 -----\n 9 files changed, 5 insertions(+), 173 deletions(-)\n delete mode 100644 Documentation/git-tar-tree.txt\n\ndiff --git a/.gitignore b/.gitignore\nindex 3bc1b08..88b313a 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -158,7 +158,6 @@\n /git-svn\n /git-symbolic-ref\n /git-tag\n-/git-tar-tree\n /git-unpack-file\n /git-unpack-objects\n /git-update-index\ndiff --git a/Documentation/git-tar-tree.txt b/Documentation/git-tar-tree.txt\ndeleted file mode 100644\nindex f7362dc..0000000\n--- a/Documentation/git-tar-tree.txt\n+++ /dev/null\n@@ -1,82 +0,0 @@\n-git-tar-tree(1)\n-===============\n-\n-NAME\n-----\n-git-tar-tree - Create a tar archive of the files in the named tree object\n-\n-\n-SYNOPSIS\n---------\n-[verse]\n-'git tar-tree' [--remote=<repo>] <tree-ish> [ <base> ]\n-\n-DESCRIPTION\n------------\n-THIS COMMAND IS DEPRECATED.  Use 'git archive' with `--format=tar`\n-option instead (and move the <base> argument to `--prefix=base/`).\n-\n-Creates a tar archive containing the tree structure for the named tree.\n-When <base> is specified it is added as a leading path to the files in the\n-generated tar archive.\n-\n-'git tar-tree' behaves differently when given a tree ID versus when given\n-a commit ID or tag ID.  In the first case the current time is used as\n-modification time of each file in the archive.  In the latter case the\n-commit time as recorded in the referenced commit object is used instead.\n-Additionally the commit ID is stored in a global extended pax header.\n-It can be extracted using 'git get-tar-commit-id'.\n-\n-OPTIONS\n--------\n-\n-<tree-ish>::\n-\tThe tree or commit to produce tar archive for.  If it is\n-\tthe object name of a commit object.\n-\n-<base>::\n-\tLeading path to the files in the resulting tar archive.\n-\n---remote=<repo>::\n-\tInstead of making a tar archive from local repository,\n-\tretrieve a tar archive from a remote repository.\n-\n-CONFIGURATION\n--------------\n-\n-tar.umask::\n-\tThis variable can be used to restrict the permission bits of\n-\ttar archive entries.  The default is 0002, which turns off the\n-\tworld write bit.  The special value \"user\" indicates that the\n-\tarchiving user's umask will be used instead.  See umask(2) for\n-\tdetails.\n-\n-EXAMPLES\n---------\n-`git tar-tree HEAD junk | (cd /var/tmp/ && tar xf -)`::\n-\n-\tCreate a tar archive that contains the contents of the\n-\tlatest commit on the current branch, and extracts it in\n-\t`/var/tmp/junk` directory.\n-\n-`git tar-tree v1.4.0 git-1.4.0 | gzip >git-1.4.0.tar.gz`::\n-\n-\tCreate a tarball for v1.4.0 release.\n-\n-`git tar-tree v1.4.0^{tree} git-1.4.0 | gzip >git-1.4.0.tar.gz`::\n-\n-\tCreate a tarball for v1.4.0 release, but without a\n-\tglobal extended pax header.\n-\n-`git tar-tree --remote=example.com:git.git v1.4.0 >git-1.4.0.tar`::\n-\n-\tGet a tarball v1.4.0 from example.com.\n-\n-`git tar-tree HEAD:Documentation/ git-docs > git-1.4.0-docs.tar`::\n-\n-\tPut everything in the current head's Documentation/ directory\n-\tinto 'git-1.4.0-docs.tar', with the prefix 'git-docs/'.\n-\n-GIT\n----\n-Part of the linkgit:git[1] suite\ndiff --git a/builtin/tar-tree.c b/builtin/tar-tree.c\nindex ba3ffe6..aa72596 100644\n--- a/builtin/tar-tree.c\n+++ b/builtin/tar-tree.c\n@@ -7,71 +7,9 @@\n #include \"builtin.h\"\n #include \"quote.h\"\n \n-static const char tar_tree_usage[] =\n-\"git tar-tree [--remote=<repo>] <tree-ish> [basedir]\\n\"\n-\"*** Note that this command is now deprecated; use \\\"git archive\\\" instead.\";\n-\n static const char builtin_get_tar_commit_id_usage[] =\n \"git get-tar-commit-id < <tarfile>\";\n \n-int cmd_tar_tree(int argc, const char **argv, const char *prefix)\n-{\n-\t/*\n-\t * \"git tar-tree\" is now a wrapper around \"git archive --format=tar\"\n-\t *\n-\t * $0 --remote=<repo> arg... ==>\n-\t *\tgit archive --format=tar --remote=<repo> arg...\n-\t * $0 tree-ish ==>\n-\t *\tgit archive --format=tar tree-ish\n-\t * $0 tree-ish basedir ==>\n-\t * \tgit archive --format-tar --prefix=basedir tree-ish\n-\t */\n-\tconst char **nargv = xcalloc(sizeof(*nargv), argc + 3);\n-\tstruct strbuf sb = STRBUF_INIT;\n-\tchar *basedir_arg;\n-\tint nargc = 0;\n-\n-\tnargv[nargc++] = \"archive\";\n-\tnargv[nargc++] = \"--format=tar\";\n-\n-\tif (2 <= argc && !prefixcmp(argv[1], \"--remote=\")) {\n-\t\tnargv[nargc++] = argv[1];\n-\t\targv++;\n-\t\targc--;\n-\t}\n-\n-\t/*\n-\t * Because it's just a compatibility wrapper, tar-tree supports only\n-\t * the old behaviour of reading attributes from the work tree.\n-\t */\n-\tnargv[nargc++] = \"--worktree-attributes\";\n-\n-\tswitch (argc) {\n-\tdefault:\n-\t\tusage(tar_tree_usage);\n-\t\tbreak;\n-\tcase 3:\n-\t\t/* base-path */\n-\t\tbasedir_arg = xmalloc(strlen(argv[2]) + 11);\n-\t\tsprintf(basedir_arg, \"--prefix=%s/\", argv[2]);\n-\t\tnargv[nargc++] = basedir_arg;\n-\t\t/* fallthru */\n-\tcase 2:\n-\t\t/* tree-ish */\n-\t\tnargv[nargc++] = argv[1];\n-\t}\n-\tnargv[nargc] = NULL;\n-\n-\tfprintf(stderr,\n-\t\t\"*** \\\"git tar-tree\\\" is now deprecated.\\n\"\n-\t\t\"*** Running \\\"git archive\\\" instead.\\n***\");\n-\tsq_quote_argv(&sb, nargv, 0);\n-\tstrbuf_addch(&sb, '\\n');\n-\tfputs(sb.buf, stderr);\n-\tstrbuf_release(&sb);\n-\treturn cmd_archive(nargc, nargv, prefix);\n-}\n-\n /* ustar header + extended global header content */\n #define RECORDSIZE\t(512)\n #define HEADERSIZE (2 * RECORDSIZE)\ndiff --git a/command-list.txt b/command-list.txt\nindex f2bf684..f8fc5b8 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -126,7 +126,6 @@ git-submodule                           mainporcelain\n git-svn                                 foreignscminterface\n git-symbolic-ref                        plumbingmanipulators\n git-tag                                 mainporcelain common\n-git-tar-tree                            plumbinginterrogators\tdeprecated\n git-unpack-file                         plumbinginterrogators\n git-unpack-objects                      plumbingmanipulators\n git-update-index                        plumbingmanipulators\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c6063c9..1081ad1 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -706,7 +706,6 @@ __git_list_porcelain_commands ()\n \t\tssh-*)            : transport;;\n \t\tstripspace)       : plumbing;;\n \t\tsymbolic-ref)     : plumbing;;\n-\t\ttar-tree)         : deprecated;;\n \t\tunpack-file)      : plumbing;;\n \t\tunpack-objects)   : plumbing;;\n \t\tupdate-index)     : plumbing;;\ndiff --git a/git.c b/git.c\nindex 0c9dde2..5c9858f 100644\n--- a/git.c\n+++ b/git.c\n@@ -437,7 +437,6 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"stripspace\", cmd_stripspace },\n \t\t{ \"symbolic-ref\", cmd_symbolic_ref, RUN_SETUP },\n \t\t{ \"tag\", cmd_tag, RUN_SETUP },\n-\t\t{ \"tar-tree\", cmd_tar_tree },\n \t\t{ \"unpack-file\", cmd_unpack_file, RUN_SETUP },\n \t\t{ \"unpack-objects\", cmd_unpack_objects, RUN_SETUP },\n \t\t{ \"update-index\", cmd_update_index, RUN_SETUP },\ndiff --git a/t/t4116-apply-reverse.sh b/t/t4116-apply-reverse.sh\nindex 2298ece..1e4d438 100755\n--- a/t/t4116-apply-reverse.sh\n+++ b/t/t4116-apply-reverse.sh\n@@ -48,12 +48,12 @@ test_expect_success 'apply in reverse' '\n \n test_expect_success 'setup separate repository lacking postimage' '\n \n-\tgit tar-tree initial initial | $TAR xf - &&\n+\tgit archive --format=tar --prefix=initial/ initial | $TAR xf - &&\n \t(\n \t\tcd initial && git init && git add .\n \t) &&\n \n-\tgit tar-tree second second | $TAR xf - &&\n+\tgit archive --format=tar --prefix=second/ second | $TAR xf - &&\n \t(\n \t\tcd second && git init && git add .\n \t)\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex c2023b1..11bf0b8 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -3,7 +3,7 @@\n # Copyright (C) 2005 Rene Scharfe\n #\n \n-test_description='git tar-tree and git get-tar-commit-id test\n+test_description='git archive and git get-tar-commit-id test\n \n This test covers the topics of file contents, commit date handling and\n commit id embedding:\n@@ -13,11 +13,11 @@ commit id embedding:\n   binary file (/bin/sh).  Only paths shorter than 99 characters are\n   used.\n \n-  git tar-tree applies the commit date to every file in the archive it\n+  git archive applies the commit date to every file in the archive it\n   creates.  The test sets the commit date to a specific value and checks\n   if the tar archive contains that value.\n \n-  When giving git tar-tree a commit id (in contrast to a tree id) it\n+  When giving git archive a commit id (in contrast to a tree id) it\n   embeds this commit id into the tar archive as a comment.  The test\n   checks the ability of git get-tar-commit-id to figure it out from the\n   tar file.\n@@ -196,16 +196,6 @@ test_expect_success \\\n     'git get-tar-commit-id <b.tar >b.commitid &&\n      test_cmp .git/$(git symbolic-ref HEAD) b.commitid'\n \n-test_expect_success 'git tar-tree' '\n-\tgit tar-tree HEAD >tar-tree.tar &&\n-\ttest_cmp b.tar tar-tree.tar\n-'\n-\n-test_expect_success 'git tar-tree with prefix' '\n-\tgit tar-tree HEAD prefix >tar-tree_with_prefix.tar &&\n-\ttest_cmp with_prefix.tar tar-tree_with_prefix.tar\n-'\n-\n test_expect_success 'git archive with --output, override inferred format' '\n \tgit archive --format=tar --output=d4.zip HEAD &&\n \ttest_cmp b.tar d4.zip\ndiff --git a/t/t5001-archive-attr.sh b/t/t5001-archive-attr.sh\nindex f47d871..51dedab 100755\n--- a/t/t5001-archive-attr.sh\n+++ b/t/t5001-archive-attr.sh\n@@ -87,14 +87,4 @@ test_expect_success 'export-subst' '\n \ttest_cmp substfile2 archive/substfile2\n '\n \n-test_expect_success 'git tar-tree vs. git archive with worktree attributes' '\n-\tgit tar-tree HEAD >tar-tree.tar &&\n-\ttest_cmp worktree.tar tar-tree.tar\n-'\n-\n-test_expect_success 'git tar-tree vs. git archive with worktree attrs, bare' '\n-\t(cd bare && git tar-tree HEAD) >bare-tar-tree.tar &&\n-\ttest_cmp bare-worktree.tar bare-tar-tree.tar\n-'\n-\n test_done\n-- \n1.8.5.rc0.170.g772b8ec\n"},{"id":"230370","messageId":"7c5fd82b538fd8e1137b06904d39c42e0755fc0e.1384098226.git.john@keeping.me.uk","threadId":"35315","inReplyTo":"cover.1384098226.git.john@keeping.me.uk","subject":"[RFC/PATCH 3/4] lost-found: remove deprecated command","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-10T15:47:30Z","receivedAt":"2013-11-10T15:47:30Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"\"git lost-found\" has been deprecated since commit fc8b5f0 (Deprecate\ngit-lost-found, 2007-11-08), included in version 1.5.4.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n .gitignore                             |  1 -\n Documentation/git-lost-found.txt       | 74 ----------------------------------\n Makefile                               |  1 -\n command-list.txt                       |  1 -\n contrib/completion/git-completion.bash |  1 -\n git-lost-found.sh                      | 33 ---------------\n 6 files changed, 111 deletions(-)\n delete mode 100644 Documentation/git-lost-found.txt\n delete mode 100755 git-lost-found.sh\n\ndiff --git a/.gitignore b/.gitignore\nindex 88b313a..c141b2a 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -75,7 +75,6 @@\n /git-init-db\n /git-instaweb\n /git-log\n-/git-lost-found\n /git-ls-files\n /git-ls-remote\n /git-ls-tree\ndiff --git a/Documentation/git-lost-found.txt b/Documentation/git-lost-found.txt\ndeleted file mode 100644\nindex d549328..0000000\n--- a/Documentation/git-lost-found.txt\n+++ /dev/null\n@@ -1,74 +0,0 @@\n-git-lost-found(1)\n-=================\n-\n-NAME\n-----\n-git-lost-found - Recover lost refs that luckily have not yet been pruned\n-\n-SYNOPSIS\n---------\n-[verse]\n-'git lost-found'\n-\n-DESCRIPTION\n------------\n-\n-*NOTE*: this command is deprecated.  Use linkgit:git-fsck[1] with\n-the option '--lost-found' instead.\n-\n-Finds dangling commits and tags from the object database, and\n-creates refs to them in the .git/lost-found/ directory.  Commits and\n-tags that dereference to commits are stored in .git/lost-found/commit,\n-and other objects are stored in .git/lost-found/other.\n-\n-\n-OUTPUT\n-------\n-Prints to standard output the object names and one-line descriptions\n-of any commits or tags found.\n-\n-EXAMPLE\n--------\n-\n-Suppose you run 'git tag -f' and mistype the tag to overwrite.\n-The ref to your tag is overwritten, but until you run 'git\n-prune', the tag itself is still there.\n-\n-------------\n-$ git lost-found\n-[1ef2b196d909eed523d4f3c9bf54b78cdd6843c6] GIT 0.99.9c\n-...\n-------------\n-\n-Also you can use gitk to browse how any tags found relate to each\n-other.\n-\n-------------\n-$ gitk $(cd .git/lost-found/commit && echo ??*)\n-------------\n-\n-After making sure you know which the object is the tag you are looking\n-for, you can reconnect it to your regular `refs` hierarchy by using\n-the `update-ref` command.\n-\n-------------\n-$ git cat-file -t 1ef2b196\n-tag\n-$ git cat-file tag 1ef2b196\n-object fa41bbce8e38c67a218415de6cfa510c7e50032a\n-type commit\n-tag v0.99.9c\n-tagger Junio C Hamano <junkio@cox.net> 1131059594 -0800\n-\n-GIT 0.99.9c\n-\n-This contains the following changes from the \"master\" branch, since\n-...\n-$ git update-ref refs/tags/not-lost-anymore 1ef2b196\n-$ git rev-parse not-lost-anymore\n-1ef2b196d909eed523d4f3c9bf54b78cdd6843c6\n-------------\n-\n-GIT\n----\n-Part of the linkgit:git[1] suite\ndiff --git a/Makefile b/Makefile\nindex 4fc2378..7ffd705 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -452,7 +452,6 @@ SCRIPT_SH += git-am.sh\n SCRIPT_SH += git-bisect.sh\n SCRIPT_SH += git-difftool--helper.sh\n SCRIPT_SH += git-filter-branch.sh\n-SCRIPT_SH += git-lost-found.sh\n SCRIPT_SH += git-merge-octopus.sh\n SCRIPT_SH += git-merge-one-file.sh\n SCRIPT_SH += git-merge-resolve.sh\ndiff --git a/command-list.txt b/command-list.txt\nindex f8fc5b8..7bf2420 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -64,7 +64,6 @@ git-init                                mainporcelain common\n git-instaweb                            ancillaryinterrogators\n gitk                                    mainporcelain\n git-log                                 mainporcelain common\n-git-lost-found                          ancillarymanipulators\tdeprecated\n git-ls-files                            plumbinginterrogators\n git-ls-remote                           plumbinginterrogators\n git-ls-tree                             plumbinginterrogators\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 1081ad1..c071614 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -673,7 +673,6 @@ __git_list_porcelain_commands ()\n \t\tindex-pack)       : plumbing;;\n \t\tinit-db)          : deprecated;;\n \t\tlocal-fetch)      : plumbing;;\n-\t\tlost-found)       : infrequent;;\n \t\tls-files)         : plumbing;;\n \t\tls-remote)        : plumbing;;\n \t\tls-tree)          : plumbing;;\ndiff --git a/git-lost-found.sh b/git-lost-found.sh\ndeleted file mode 100755\nindex 0b3e8c7..0000000\n--- a/git-lost-found.sh\n+++ /dev/null\n@@ -1,33 +0,0 @@\n-#!/bin/sh\n-\n-USAGE=''\n-SUBDIRECTORY_OK='Yes'\n-OPTIONS_SPEC=\n-. git-sh-setup\n-\n-echo \"WARNING: '$0' is deprecated in favor of 'git fsck --lost-found'\" >&2\n-\n-if [ \"$#\" != \"0\" ]\n-then\n-    usage\n-fi\n-\n-laf=\"$GIT_DIR/lost-found\"\n-rm -fr \"$laf\" && mkdir -p \"$laf/commit\" \"$laf/other\" || exit\n-\n-git fsck --full --no-reflogs |\n-while read dangling type sha1\n-do\n-\tcase \"$dangling\" in\n-\tdangling)\n-\t\tif git rev-parse -q --verify \"$sha1^0\" >/dev/null\n-\t\tthen\n-\t\t\tdir=\"$laf/commit\"\n-\t\t\tgit show-branch \"$sha1\"\n-\t\telse\n-\t\t\tdir=\"$laf/other\"\n-\t\tfi\n-\t\techo \"$sha1\" >\"$dir/$sha1\"\n-\t\t;;\n-\tesac\n-done\n-- \n1.8.5.rc0.170.g772b8ec\n"},{"id":"230369","messageId":"06b9203a9ac991772d6114b983860dda5ff3d8f7.1384098226.git.john@keeping.me.uk","threadId":"35315","inReplyTo":"cover.1384098226.git.john@keeping.me.uk","subject":"[RFC/PATCH 4/4] peek-remote: remove deprecated alias of ls-remote","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-10T15:47:31Z","receivedAt":"2013-11-10T15:47:31Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"This has been deprecated since commit 87194d2 (Deprecate peek-remote,\n2007-11-24), included in version 1.5.4.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n .gitignore                             |  1 -\n Documentation/git-peek-remote.txt      | 43 ----------------------------------\n Makefile                               |  1 -\n command-list.txt                       |  1 -\n contrib/completion/git-completion.bash |  1 -\n git.c                                  |  1 -\n 6 files changed, 48 deletions(-)\n delete mode 100644 Documentation/git-peek-remote.txt\n\ndiff --git a/.gitignore b/.gitignore\nindex c141b2a..c2ad802 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -104,7 +104,6 @@\n /git-pack-refs\n /git-parse-remote\n /git-patch-id\n-/git-peek-remote\n /git-prune\n /git-prune-packed\n /git-pull\ndiff --git a/Documentation/git-peek-remote.txt b/Documentation/git-peek-remote.txt\ndeleted file mode 100644\nindex 87ea3fb..0000000\n--- a/Documentation/git-peek-remote.txt\n+++ /dev/null\n@@ -1,43 +0,0 @@\n-git-peek-remote(1)\n-==================\n-\n-NAME\n-----\n-git-peek-remote - List the references in a remote repository\n-\n-\n-SYNOPSIS\n---------\n-[verse]\n-'git peek-remote' [--upload-pack=<git-upload-pack>] [<host>:]<directory>\n-\n-DESCRIPTION\n------------\n-This command is deprecated; use 'git ls-remote' instead.\n-\n-OPTIONS\n--------\n---upload-pack=<git-upload-pack>::\n-\tUse this to specify the path to 'git-upload-pack' on the\n-\tremote side, if it is not found on your $PATH. Some\n-\tinstallations of sshd ignores the user's environment\n-\tsetup scripts for login shells (e.g. .bash_profile) and\n-\tyour privately installed git may not be found on the system\n-\tdefault $PATH.  Another workaround suggested is to set\n-\tup your $PATH in \".bashrc\", but this flag is for people\n-\twho do not want to pay the overhead for non-interactive\n-\tshells, but prefer having a lean .bashrc file (they set most of\n-\tthe things up in .bash_profile).\n-\n-<host>::\n-\tA remote host that houses the repository.  When this\n-\tpart is specified, 'git-upload-pack' is invoked via\n-\tssh.\n-\n-<directory>::\n-\tThe repository to sync from.\n-\n-\n-GIT\n----\n-Part of the linkgit:git[1] suite\ndiff --git a/Makefile b/Makefile\nindex 7ffd705..504931f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -589,7 +589,6 @@ BUILT_INS += git-fsck-objects$X\n BUILT_INS += git-get-tar-commit-id$X\n BUILT_INS += git-init$X\n BUILT_INS += git-merge-subtree$X\n-BUILT_INS += git-peek-remote$X\n BUILT_INS += git-show$X\n BUILT_INS += git-stage$X\n BUILT_INS += git-status$X\ndiff --git a/command-list.txt b/command-list.txt\nindex 7bf2420..cf36c3d 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -87,7 +87,6 @@ git-pack-redundant                      plumbinginterrogators\n git-pack-refs                           ancillarymanipulators\n git-parse-remote                        synchelpers\n git-patch-id                            purehelpers\n-git-peek-remote                         purehelpers\tdeprecated\n git-prune                               ancillarymanipulators\n git-prune-packed                        plumbingmanipulators\n git-pull                                mainporcelain common\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c071614..874611d 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -686,7 +686,6 @@ __git_list_porcelain_commands ()\n \t\tpack-refs)        : plumbing;;\n \t\tparse-remote)     : plumbing;;\n \t\tpatch-id)         : plumbing;;\n-\t\tpeek-remote)      : plumbing;;\n \t\tprune)            : plumbing;;\n \t\tprune-packed)     : plumbing;;\n \t\tquiltimport)      : import;;\ndiff --git a/git.c b/git.c\nindex 5c9858f..727e380 100644\n--- a/git.c\n+++ b/git.c\n@@ -408,7 +408,6 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"pack-redundant\", cmd_pack_redundant, RUN_SETUP },\n \t\t{ \"pack-refs\", cmd_pack_refs, RUN_SETUP },\n \t\t{ \"patch-id\", cmd_patch_id },\n-\t\t{ \"peek-remote\", cmd_ls_remote, RUN_SETUP_GENTLY },\n \t\t{ \"pickaxe\", cmd_blame, RUN_SETUP },\n \t\t{ \"prune\", cmd_prune, RUN_SETUP },\n \t\t{ \"prune-packed\", cmd_prune_packed, RUN_SETUP },\n-- \n1.8.5.rc0.170.g772b8ec\n"},{"id":"230406","messageId":"xmqq4n7in6c0.fsf@gitster.dls.corp.google.com","threadId":"35315","inReplyTo":"cover.1384098226.git.john@keeping.me.uk","subject":"Re: [RFC/PATCH 0/4] Remove deprecated commands","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-11-11T18:25:51Z","receivedAt":"2013-11-11T18:25:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Keeping <john@keeping.me.uk> writes:\n\n> \"git repo-config\", \"git tar-tree\", \"git lost-found\" and \"git\n> peek-remote\" have all been deprecated since at least Git 1.5.4.\n>\n> With Git 2.0 approaching, I think that would be a good point to remove\n> then completely, which is what this series does.\n\nProbably good material to discuss during the next cycle.\n\nAs a totally unscientific sanity check, I asked Google to show these\nsince Nov 13, 2011:\n\n    [git repo-config] vs [git config]: 136 vs 232\n\n    [git peek-remote] vs [git ls-remote]: 62 vs 133\n\n    [git tar-tree] vs [git archive]: 73 vs 189\n\n    [git lost-found] vs [git fsck --lost-found]: 96 vs 83\n\nSo I think 1, 2, and 4 are OK to ship in whatever version that comes\nafter the upcoming 1.8.5, but we might have to hold onto lost-found\na bit longer.  The command does show a deprecation warning, so there\nis nothing to change at this point.\n\nThanks.\n"},{"id":"230411","messageId":"20131111183853.GP24023@serenity.lan","threadId":"35315","inReplyTo":"xmqq4n7in6c0.fsf@gitster.dls.corp.google.com","subject":"Re: [RFC/PATCH 0/4] Remove deprecated commands","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-11T18:38:53Z","receivedAt":"2013-11-11T18:38:53Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote:\n> John Keeping <john@keeping.me.uk> writes:\n> \n> > \"git repo-config\", \"git tar-tree\", \"git lost-found\" and \"git\n> > peek-remote\" have all been deprecated since at least Git 1.5.4.\n> >\n> > With Git 2.0 approaching, I think that would be a good point to remove\n> > then completely, which is what this series does.\n> \n> Probably good material to discuss during the next cycle.\n>\n> As a totally unscientific sanity check, I asked Google to show these\n> since Nov 13, 2011:\n> \n>     [git repo-config] vs [git config]: 136 vs 232\n> \n>     [git peek-remote] vs [git ls-remote]: 62 vs 133\n> \n>     [git tar-tree] vs [git archive]: 73 vs 189\n> \n>     [git lost-found] vs [git fsck --lost-found]: 96 vs 83\n> \n> So I think 1, 2, and 4 are OK to ship in whatever version that comes\n> after the upcoming 1.8.5, but we might have to hold onto lost-found\n> a bit longer.  The command does show a deprecation warning, so there\n> is nothing to change at this point.\n\nI was assuming these would be queued as a \"held until 2.0\" branch, but\nif you think some can go earlier I can re-send this once 1.8.5 is out of\nthe way.\n"},{"id":"230415","messageId":"20131111191345.GL10302@google.com","threadId":"35315","inReplyTo":"20131111183853.GP24023@serenity.lan","subject":"Re: [RFC/PATCH 0/4] Remove deprecated commands","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-11-11T19:13:45Z","receivedAt":"2013-11-11T19:13:45Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"John Keeping wrote:\n> On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote:\n>> John Keeping <john@keeping.me.uk> writes:\n\n>>> \"git repo-config\", \"git tar-tree\", \"git lost-found\" and \"git\n>>> peek-remote\" have all been deprecated since at least Git 1.5.4.\n[...]\n>> Probably good material to discuss during the next cycle.\n[...]\n> I was assuming these would be queued as a \"held until 2.0\" branch, but\n\nPlease no. :)  We already have a nice set of features for 2.0 and I\nhope people have as few excuses not to upgrade as possible.  Anything\nthat actually needs the same kind of treatment that is introduced now\nshould wait for 3.0.\n\nRemoving repo-config, tar-tree, and peek-remote sounds fine to me\n(though I haven't thought much about it either way) and I agree that\nit wouldn't need to wait for an x.0 release.\n\nThanks,\nJonathan\n"},{"id":"230434","messageId":"20131111211042.GR24023@serenity.lan","threadId":"35315","inReplyTo":"20131111191345.GL10302@google.com","subject":"Re: [RFC/PATCH 0/4] Remove deprecated commands","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-11-11T21:10:42Z","receivedAt":"2013-11-11T21:10:42Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Mon, Nov 11, 2013 at 11:13:45AM -0800, Jonathan Nieder wrote:\n> John Keeping wrote:\n> > On Mon, Nov 11, 2013 at 10:25:51AM -0800, Junio C Hamano wrote:\n> >> John Keeping <john@keeping.me.uk> writes:\n> \n> >>> \"git repo-config\", \"git tar-tree\", \"git lost-found\" and \"git\n> >>> peek-remote\" have all been deprecated since at least Git 1.5.4.\n> [...]\n> >> Probably good material to discuss during the next cycle.\n> [...]\n> > I was assuming these would be queued as a \"held until 2.0\" branch, but\n> \n> Please no. :)  We already have a nice set of features for 2.0 and I\n> hope people have as few excuses not to upgrade as possible.  Anything\n> that actually needs the same kind of treatment that is introduced now\n> should wait for 3.0.\n> \n> Removing repo-config, tar-tree, and peek-remote sounds fine to me\n> (though I haven't thought much about it either way) and I agree that\n> it wouldn't need to wait for an x.0 release.\n\nFor \"git repo-config\", the 1.5.4 release notes say that it will \"be\nremoved in the next feature release\".  I'm not sure what a \"feature\nrelease\" is, but if 1.6.0 wasn't one, then I think 2.0 will be the next\none.\n\nAlthough, I now see that howto/maintain-git.txt says a feature release\nis numbered vX.Y.Z, so perhaps it should have been removed long before\nnow...\n"},{"id":"231398","messageId":"20131202233710.GB29959@google.com","threadId":"35315","inReplyTo":"d29327f6eb6e999ef31c3130ad2bab712a5d280b.1384098226.git.john@keeping.me.uk","subject":"[PATCH jk/remove-deprecated] stop installing git-tar-tree link","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-12-02T23:37:10Z","receivedAt":"2013-12-02T23:37:10Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"When the built-in \"git tar-tree\" command (a thin wrapper around \"git\narchive\") was removed in 925ceccf (tar-tree: remove deprecated\ncommand, 2013-11-10), the build continued to install a non-functioning\ngit-tar-tree command in gitexecdir by mistake:\n\n\t$ PATH=$(git --exec-path):$PATH\n\t$ git-tar-tree -h\n\tfatal: cannot handle tar-tree internally\n\nThe list of links in gitexecdir is populated from BUILTIN_OBJS, which\nincludes builtin/tar-tree.o to implement \"git get-tar-commit-id\".\nRename the get-tar-commit-id source file to builtin/get-tar-commit-id.c\nto reflect its purpose and fix 'make install'.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nHi,\n\nJohn Keeping wrote:\n\n>  builtin/tar-tree.c                     | 62 -------------------------\n\nHere's a quick fixup on top.  Thoughts?\n\nThanks,\nJonathan\n\n Makefile                                    | 3 +--\n builtin/{tar-tree.c => get-tar-commit-id.c} | 0\n 2 files changed, 1 insertion(+), 2 deletions(-)\n rename builtin/{tar-tree.c => get-tar-commit-id.c} (100%)\n\ndiff --git a/Makefile b/Makefile\nindex 504931f..37beb73 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -586,7 +586,6 @@ BUILT_INS += git-cherry$X\n BUILT_INS += git-cherry-pick$X\n BUILT_INS += git-format-patch$X\n BUILT_INS += git-fsck-objects$X\n-BUILT_INS += git-get-tar-commit-id$X\n BUILT_INS += git-init$X\n BUILT_INS += git-merge-subtree$X\n BUILT_INS += git-show$X\n@@ -929,6 +928,7 @@ BUILTIN_OBJS += builtin/fmt-merge-msg.o\n BUILTIN_OBJS += builtin/for-each-ref.o\n BUILTIN_OBJS += builtin/fsck.o\n BUILTIN_OBJS += builtin/gc.o\n+BUILTIN_OBJS += builtin/get-tar-commit-id.o\n BUILTIN_OBJS += builtin/grep.o\n BUILTIN_OBJS += builtin/hash-object.o\n BUILTIN_OBJS += builtin/help.o\n@@ -980,7 +980,6 @@ BUILTIN_OBJS += builtin/show-ref.o\n BUILTIN_OBJS += builtin/stripspace.o\n BUILTIN_OBJS += builtin/symbolic-ref.o\n BUILTIN_OBJS += builtin/tag.o\n-BUILTIN_OBJS += builtin/tar-tree.o\n BUILTIN_OBJS += builtin/unpack-file.o\n BUILTIN_OBJS += builtin/unpack-objects.o\n BUILTIN_OBJS += builtin/update-index.o\ndiff --git a/builtin/tar-tree.c b/builtin/get-tar-commit-id.c\nsimilarity index 100%\nrename from builtin/tar-tree.c\nrename to builtin/get-tar-commit-id.c\n-- \n1.8.4.1\n"},{"id":"231466","messageId":"20131203201944.GC3163@serenity.lan","threadId":"35315","inReplyTo":"20131202233710.GB29959@google.com","subject":"Re: [PATCH jk/remove-deprecated] stop installing git-tar-tree link","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-12-03T20:19:44Z","receivedAt":"2013-12-03T20:19:44Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"On Mon, Dec 02, 2013 at 03:37:10PM -0800, Jonathan Nieder wrote:\n> When the built-in \"git tar-tree\" command (a thin wrapper around \"git\n> archive\") was removed in 925ceccf (tar-tree: remove deprecated\n> command, 2013-11-10), the build continued to install a non-functioning\n> git-tar-tree command in gitexecdir by mistake:\n> \n> \t$ PATH=$(git --exec-path):$PATH\n> \t$ git-tar-tree -h\n> \tfatal: cannot handle tar-tree internally\n> \n> The list of links in gitexecdir is populated from BUILTIN_OBJS, which\n> includes builtin/tar-tree.o to implement \"git get-tar-commit-id\".\n> Rename the get-tar-commit-id source file to builtin/get-tar-commit-id.c\n> to reflect its purpose and fix 'make install'.\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n> ---\n> Hi,\n> \n> John Keeping wrote:\n> \n> >  builtin/tar-tree.c                     | 62 -------------------------\n> \n> Here's a quick fixup on top.  Thoughts?\n\nThis is the obvious tidy-up on top of my series.  I avoided doing it\nbecause I thought it would just add unnecessary noise, but I had not\nrealised that the names of the built-in object files was important, so\nit's not just noise but a part of doing the job properly.\n\n>  Makefile                                    | 3 +--\n>  builtin/{tar-tree.c => get-tar-commit-id.c} | 0\n>  2 files changed, 1 insertion(+), 2 deletions(-)\n>  rename builtin/{tar-tree.c => get-tar-commit-id.c} (100%)\n> \n> diff --git a/Makefile b/Makefile\n> index 504931f..37beb73 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -586,7 +586,6 @@ BUILT_INS += git-cherry$X\n>  BUILT_INS += git-cherry-pick$X\n>  BUILT_INS += git-format-patch$X\n>  BUILT_INS += git-fsck-objects$X\n> -BUILT_INS += git-get-tar-commit-id$X\n>  BUILT_INS += git-init$X\n>  BUILT_INS += git-merge-subtree$X\n>  BUILT_INS += git-show$X\n> @@ -929,6 +928,7 @@ BUILTIN_OBJS += builtin/fmt-merge-msg.o\n>  BUILTIN_OBJS += builtin/for-each-ref.o\n>  BUILTIN_OBJS += builtin/fsck.o\n>  BUILTIN_OBJS += builtin/gc.o\n> +BUILTIN_OBJS += builtin/get-tar-commit-id.o\n>  BUILTIN_OBJS += builtin/grep.o\n>  BUILTIN_OBJS += builtin/hash-object.o\n>  BUILTIN_OBJS += builtin/help.o\n> @@ -980,7 +980,6 @@ BUILTIN_OBJS += builtin/show-ref.o\n>  BUILTIN_OBJS += builtin/stripspace.o\n>  BUILTIN_OBJS += builtin/symbolic-ref.o\n>  BUILTIN_OBJS += builtin/tag.o\n> -BUILTIN_OBJS += builtin/tar-tree.o\n>  BUILTIN_OBJS += builtin/unpack-file.o\n>  BUILTIN_OBJS += builtin/unpack-objects.o\n>  BUILTIN_OBJS += builtin/update-index.o\n> diff --git a/builtin/tar-tree.c b/builtin/get-tar-commit-id.c\n> similarity index 100%\n> rename from builtin/tar-tree.c\n> rename to builtin/get-tar-commit-id.c\n> -- \n> 1.8.4.1\n"},{"id":"231499","messageId":"529F02A3.2030704@drmicha.warpmail.net","threadId":"35315","inReplyTo":"20131202233710.GB29959@google.com","subject":"Re: [PATCH jk/remove-deprecated] stop installing git-tar-tree link","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2013-12-04T10:23:31Z","receivedAt":"2013-12-04T10:23:31Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Jonathan Nieder venit, vidit, dixit 03.12.2013 00:37:\n> When the built-in \"git tar-tree\" command (a thin wrapper around \"git\n> archive\") was removed in 925ceccf (tar-tree: remove deprecated\n> command, 2013-11-10), the build continued to install a non-functioning\n> git-tar-tree command in gitexecdir by mistake:\n> \n> \t$ PATH=$(git --exec-path):$PATH\n> \t$ git-tar-tree -h\n> \tfatal: cannot handle tar-tree internally\n> \n> The list of links in gitexecdir is populated from BUILTIN_OBJS, which\n> includes builtin/tar-tree.o to implement \"git get-tar-commit-id\".\n\n... \"which still resides in builtin/tar-tree.c\"\n\nHad me scratch my head quite a bit as is ;)\n\n> Rename the get-tar-commit-id source file to builtin/get-tar-commit-id.c\n> to reflect its purpose and fix 'make install'.\n> \n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n> ---\n> Hi,\n> \n> John Keeping wrote:\n> \n>>  builtin/tar-tree.c                     | 62 -------------------------\n> \n> Here's a quick fixup on top.  Thoughts?\n> \n> Thanks,\n> Jonathan\n> \n>  Makefile                                    | 3 +--\n>  builtin/{tar-tree.c => get-tar-commit-id.c} | 0\n>  2 files changed, 1 insertion(+), 2 deletions(-)\n>  rename builtin/{tar-tree.c => get-tar-commit-id.c} (100%)\n> \n> diff --git a/Makefile b/Makefile\n> index 504931f..37beb73 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -586,7 +586,6 @@ BUILT_INS += git-cherry$X\n>  BUILT_INS += git-cherry-pick$X\n>  BUILT_INS += git-format-patch$X\n>  BUILT_INS += git-fsck-objects$X\n> -BUILT_INS += git-get-tar-commit-id$X\n>  BUILT_INS += git-init$X\n>  BUILT_INS += git-merge-subtree$X\n>  BUILT_INS += git-show$X\n> @@ -929,6 +928,7 @@ BUILTIN_OBJS += builtin/fmt-merge-msg.o\n>  BUILTIN_OBJS += builtin/for-each-ref.o\n>  BUILTIN_OBJS += builtin/fsck.o\n>  BUILTIN_OBJS += builtin/gc.o\n> +BUILTIN_OBJS += builtin/get-tar-commit-id.o\n>  BUILTIN_OBJS += builtin/grep.o\n>  BUILTIN_OBJS += builtin/hash-object.o\n>  BUILTIN_OBJS += builtin/help.o\n> @@ -980,7 +980,6 @@ BUILTIN_OBJS += builtin/show-ref.o\n>  BUILTIN_OBJS += builtin/stripspace.o\n>  BUILTIN_OBJS += builtin/symbolic-ref.o\n>  BUILTIN_OBJS += builtin/tag.o\n> -BUILTIN_OBJS += builtin/tar-tree.o\n>  BUILTIN_OBJS += builtin/unpack-file.o\n>  BUILTIN_OBJS += builtin/unpack-objects.o\n>  BUILTIN_OBJS += builtin/update-index.o\n> diff --git a/builtin/tar-tree.c b/builtin/get-tar-commit-id.c\n> similarity index 100%\n> rename from builtin/tar-tree.c\n> rename to builtin/get-tar-commit-id.c\n> \n"}]}