{"thread":{"id":"35310","subject":"[PATCH 1/4] Minor grammatical fixes in \"git log\" man page","startedAt":"2013-11-09T00:32:07Z","lastAt":"2013-11-11T17:59:28Z","messageCount":3,"participants":["Jason St. John","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"230258","messageId":"1383957130-2979-1-git-send-email-jstjohn@purdue.edu","threadId":"35310","inReplyTo":null,"subject":"[PATCH 1/4] Minor grammatical fixes in \"git log\" man page","fromName":"Jason St. John","fromEmail":"jstjohn@purdue.edu","sentAt":"2013-11-09T00:32:07Z","receivedAt":"2013-11-09T00:32:07Z","isPatch":true,"sender":{"key":"jstjohn@purdue.edu","avatar":"https://avatars.githubusercontent.com/u/1393510?v=4"},"body":"git-log.txt: grammatical fixes under --log-size option\n\nSigned-off-by: Jason St. John <jstjohn@purdue.edu>\n---\n Documentation/git-log.txt | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 34097ef..243a9c5 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -56,10 +56,10 @@ Note that this affects all diff-based output types, e.g. those\n produced by --stat etc.\n \n --log-size::\n-\tBefore the log message print out its size in bytes. Intended\n+\tBefore the log message, print out its size in bytes. Intended\n \tmainly for porcelain tools consumption. If Git is unable to\n-\tproduce a valid value size is set to zero.\n-\tNote that only message is considered, if also a diff is shown\n+\tproduce a valid value size, this is set to zero.\n+\tNote that only message is considered. Also, if a diff is shown,\n \tits size is not included.\n \n -L <start>,<end>:<file>::\n-- \n1.8.4.2\n"},{"id":"230262","messageId":"20131109010048.GG10302@google.com","threadId":"35310","inReplyTo":"1383957130-2979-1-git-send-email-jstjohn@purdue.edu","subject":"Re: [PATCH 1/4] Minor grammatical fixes in \"git log\" man page","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-11-09T01:00:48Z","receivedAt":"2013-11-09T01:00:48Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nJason St. John wrote:\n\n> git-log.txt: grammatical fixes under --log-size option\n\nThanks.\n\n[...]\n> --- a/Documentation/git-log.txt\n> +++ b/Documentation/git-log.txt\n> @@ -56,10 +56,10 @@ Note that this affects all diff-based output types, e.g. those\n>  produced by --stat etc.\n> \n>  --log-size::\n> -\tBefore the log message print out its size in bytes. Intended\n> +\tBefore the log message, print out its size in bytes. Intended\n>  \tmainly for porcelain tools consumption. If Git is unable to\n> -\tproduce a valid value size is set to zero.\n> -\tNote that only message is considered, if also a diff is shown\n> +\tproduce a valid value size, this is set to zero.\n> +\tNote that only message is considered. Also, if a diff is shown,\n>  \tits size is not included.\n\nI have no idea what this option does, before or after the change.\n\nThe commit that introduced --log-size says the following in its\nchange description:\n\n\t$ git log --grep=--log-size\n\tcommit 9fa3465d6be83c08ed24762c82eb33cb005729f3\n\tAuthor: Marco Costalba <mcostalba@gmail.com>\n\tDate:   Fri Jul 20 20:15:13 2007 +0200\n\n\t    Add --log-size to git log to print message size\n\n\t    With this option git-log prints log message size\n\t    just before the corresponding message.\n\n\t    Porcelain tools could use this to speedup parsing\n\t    of git-log output.\n\n\t    Note that size refers to log message only. If also\n\t    patch content is shown its size is not included.\n\nPerhaps some of the above could make it into a clearer description?\nE.g.,\n\n\t--log-size::\n\t\tInclude a line \"log size <number>\" in the output for each\n\t\tcommit, where <number> is the length of that commit's\n\t\tmessage in bytes.  Intended to speed up tools that\n\t\tread log messages from 'git log' output by allowing them\n\t\tto allocate space in advance.\n\nThe commit introducing --log-size also says:\n\n\t    In case it is not possible to know the size upfront\n\t    size value is set to zero.\n\nIs this still true?  When is it not possible to know the size up\nfront?\n\nThe implementation of --log-size is\n\n\tif (opt->show_log_size) {\n\t\tprintf(\"log size %i\\n\", (int)msgbuf.len);\n\t\tgraph_show_oneline(opt->graph);\n\t}\n\nWhat happens if the commit message is long enough to overflow a 32-bit\ninteger?  Is that impossible for other reasons?  If it is possible,\n(not about this patch) should this be using a 64-bit integer to print\ninstead?\n\nThanks and hope that helps,\nJonathan\n"},{"id":"230402","messageId":"xmqqd2m6n7jz.fsf@gitster.dls.corp.google.com","threadId":"35310","inReplyTo":"20131109010048.GG10302@google.com","subject":"Re: [PATCH 1/4] Minor grammatical fixes in \"git log\" man page","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-11-11T17:59:28Z","receivedAt":"2013-11-11T17:59:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Jason St. John wrote:\n>\n>> git-log.txt: grammatical fixes under --log-size option\n>\n> Thanks.\n>\n> [...]\n>> --- a/Documentation/git-log.txt\n>> +++ b/Documentation/git-log.txt\n>> @@ -56,10 +56,10 @@ Note that this affects all diff-based output types, e.g. those\n>>  produced by --stat etc.\n>> \n>>  --log-size::\n>> -\tBefore the log message print out its size in bytes. Intended\n>> +\tBefore the log message, print out its size in bytes. Intended\n\nEither reads well at least for me.\n\n>>  \tmainly for porcelain tools consumption. If Git is unable to\n>> -\tproduce a valid value size is set to zero.\n>> -\tNote that only message is considered, if also a diff is shown\n>> +\tproduce a valid value size, this is set to zero.\n>> +\tNote that only message is considered. Also, if a diff is shown,\n>>  \tits size is not included.\n>\n> I have no idea what this option does, before or after the change.\n\nThe original is probably more accurate, if harder to read.  The\nbyte-size of the message part of log output is reported, so that\ntools like QGit can slurp that many bytes and then treat the\nremainder as a patch (if -p, --stat, etc. were given).\n\n> Perhaps some of the above could make it into a clearer description?\n> E.g.,\n>\n> \t--log-size::\n> \t\tInclude a line \"log size <number>\" in the output for each\n> \t\tcommit, where <number> is the length of that commit's\n> \t\tmessage in bytes.  Intended to speed up tools that\n> \t\tread log messages from 'git log' output by allowing them\n> \t\tto allocate space in advance.\n\nYeah, that reads better. We do not have to single out \"if also a\ndiff is shown\", as there are other kinds of output that can follow\nthe message proper, and they are not counted.\n\n> The commit introducing --log-size also says:\n>\n> \t    In case it is not possible to know the size upfront\n> \t    size value is set to zero.\n>\n> Is this still true?  When is it not possible to know the size up\n> front?\n\nI have no idea ;-)  Perhaps Marco can enlighten us?\n\n> The implementation of --log-size is\n>\n> \tif (opt->show_log_size) {\n> \t\tprintf(\"log size %i\\n\", (int)msgbuf.len);\n> \t\tgraph_show_oneline(opt->graph);\n> \t}\n>\n> What happens if the commit message is long enough to overflow a 32-bit\n> integer?  Is that impossible for other reasons?  If it is possible,\n> (not about this patch) should this be using a 64-bit integer to print\n> instead?\n\nA nice low-hanging fruit ;-)\n\nThanks\n"}]}