{"thread":{"id":"35236","subject":"[PATCH] Add a scrollbar for commit history in gitk","startedAt":"2013-10-29T13:53:23Z","lastAt":"2013-10-30T06:35:01Z","messageCount":2,"participants":["Nicolas Cornu","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"229723","messageId":"CAMXp-VN=CMRdXwJ3+LRZegm-bwiDmJd66-YnZb65BNpqyHQCLA@mail.gmail.com","threadId":"35236","inReplyTo":null,"subject":"[PATCH] Add a scrollbar for commit history in gitk","fromName":"Nicolas Cornu","fromEmail":"ncornu@aldebaran-robotics.com","sentAt":"2013-10-29T13:53:23Z","receivedAt":"2013-10-29T13:53:23Z","isPatch":true,"sender":{"key":"ncornu@aldebaran-robotics.com","avatar":null},"body":">From b3570290bd761a1bf952ea491fa62b123231fe61 Mon Sep 17 00:00:00 2001\nFrom: Nicolas Cornu <ncornu@aldebaran-robotics.com>\nDate: Tue, 29 Oct 2013 14:51:29 +0100\nSubject: [PATCH] Add a scrollbar for commit history in gitk\n\n---\n gitk-git/gitk | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex d6f5e07..e517253 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -2124,11 +2124,17 @@ proc makewindow {} {\n     # create three canvases\n     set cscroll .tf.histframe.csb\n     set canv .tf.histframe.pwclist.canv\n+    set cscrollhl .tf.histframe.pwclist.canv.csb\n     canvas $canv \\\n     -selectbackground $selectbgcolor \\\n     -background $bgcolor -bd 0 \\\n-    -yscrollincr $linespc -yscrollcommand \"scrollcanv $cscroll\"\n+    -yscrollincr $linespc -yscrollcommand \"scrollcanv $cscroll\" \\\n+    -xscrollcommand \"scrollcanv $cscrollhl\"\n     .tf.histframe.pwclist add $canv\n+    ${NS}::scrollbar $cscrollhl -command {$canv xview} -orient horizontal\n+    if {!$use_ttk} {$cscrollhl configure -highlightthickness 0}\n+    pack $cscrollhl -fill x -side bottom\n+\n     set canv2 .tf.histframe.pwclist.canv2\n     canvas $canv2 \\\n     -selectbackground $selectbgcolor \\\n-- \n1.8.4.2\n"},{"id":"229781","messageId":"87fvrjgtbe.fsf@linux-k42r.v.cablecom.net","threadId":"35236","inReplyTo":"CAMXp-VN=CMRdXwJ3+LRZegm-bwiDmJd66-YnZb65BNpqyHQCLA@mail.gmail.com","subject":"Re: [PATCH] Add a scrollbar for commit history in gitk","fromName":"Thomas Rast","fromEmail":"tr@thomasrast.ch","sentAt":"2013-10-30T06:35:01Z","receivedAt":"2013-10-30T06:35:01Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Hi Nicolas,\n\nThanks for your patch.\n\nYou should Cc Paul Mackerras <paulus@samba.org> on gitk patches.\n\nNicolas Cornu <ncornu@aldebaran-robotics.com> writes:\n\n> From b3570290bd761a1bf952ea491fa62b123231fe61 Mon Sep 17 00:00:00 2001\n> From: Nicolas Cornu <ncornu@aldebaran-robotics.com>\n> Date: Tue, 29 Oct 2013 14:51:29 +0100\n> Subject: [PATCH] Add a scrollbar for commit history in gitk\n\nYou don't need these headers, they'll be taken from the email.  You only\nneed to put them if they don't agree (e.g., you are sending someone\nelse's patch).\n\nCan you describe your patch in more detail, and spin a commit message\nfrom it?  My first reaction to \"Add a scrollbar for commit history in\ngitk\" is \"there *is* a scrollbar\".\n\nThe code hints that the scrollbar may be horizontal?  Is this worth the\nvertical space it spends?  Should it be optional?  The commit message\nshould address these questions.\n\n> ---\n>  gitk-git/gitk | 8 +++++++-\n\nYou should eventually base your patch against the gitk.git repository,\nwhich does not have the toplevel gitk-git/ prefix.\n\n>  1 file changed, 7 insertions(+), 1 deletion(-)\n>\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index d6f5e07..e517253 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -2124,11 +2124,17 @@ proc makewindow {} {\n>      # create three canvases\n>      set cscroll .tf.histframe.csb\n>      set canv .tf.histframe.pwclist.canv\n> +    set cscrollhl .tf.histframe.pwclist.canv.csb\n>      canvas $canv \\\n>      -selectbackground $selectbgcolor \\\n>      -background $bgcolor -bd 0 \\\n> -    -yscrollincr $linespc -yscrollcommand \"scrollcanv $cscroll\"\n> +    -yscrollincr $linespc -yscrollcommand \"scrollcanv $cscroll\" \\\n> +    -xscrollcommand \"scrollcanv $cscrollhl\"\n>      .tf.histframe.pwclist add $canv\n> +    ${NS}::scrollbar $cscrollhl -command {$canv xview} -orient horizontal\n> +    if {!$use_ttk} {$cscrollhl configure -highlightthickness 0}\n> +    pack $cscrollhl -fill x -side bottom\n> +\n>      set canv2 .tf.histframe.pwclist.canv2\n>      canvas $canv2 \\\n>      -selectbackground $selectbgcolor \\\n\n-- \nThomas Rast\ntr@thomasrast.ch\n"}]}