{"thread":{"id":"35234","subject":"[PATCH] Add option --no-tags","startedAt":"2013-10-29T10:44:06Z","lastAt":"2013-10-30T15:06:56Z","messageCount":2,"participants":["Nicolas Cornu","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"229720","messageId":"CAMXp-VP9DDJ-L=e=7=-bO+ZFVRMVz-PAs0gGv8Q7RrZ-OWof9Q@mail.gmail.com","threadId":"35234","inReplyTo":null,"subject":"[PATCH] Add option --no-tags","fromName":"Nicolas Cornu","fromEmail":"ncornu@aldebaran-robotics.com","sentAt":"2013-10-29T10:44:06Z","receivedAt":"2013-10-29T10:44:06Z","isPatch":true,"sender":{"key":"ncornu@aldebaran-robotics.com","avatar":null},"body":">From 1cbc2c49454581a67cce09ada1386dac4ffa2828 Mon Sep 17 00:00:00 2001\nFrom: Nicolas Cornu <ncornu@aldebaran-robotics.com>\nDate: Tue, 29 Oct 2013 11:31:10 +0100\nSubject: [PATCH] Add option --no-tags\n\n---\n gitk-git/gitk | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 5cd00d8..d6f5e07 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -156,7 +156,7 @@ proc unmerged_files {files} {\n\n proc parseviewargs {n arglist} {\n     global vdatemode vmergeonly vflags vdflags vrevs vfiltered vorigargs env\n-    global worddiff git_version\n+    global worddiff git_version no_tags\n\n     set vdatemode($n) 0\n     set vmergeonly($n) 0\n@@ -167,6 +167,7 @@ proc parseviewargs {n arglist} {\n     set origargs $arglist\n     set allknown 1\n     set filtered 0\n+    set no_tags 0\n     set i -1\n     foreach arg $arglist {\n     incr i\n@@ -183,6 +184,9 @@ proc parseviewargs {n arglist} {\n         set origargs [lreplace $origargs $i $i]\n         incr i -1\n         }\n+      \"--no-tags\" {\n+        set no_tags 1\n+      }\n         \"-[puabwcrRBMC]\" -\n         \"--no-renames\" - \"--full-index\" - \"--binary\" - \"--abbrev=*\" -\n         \"--find-copies-harder\" - \"-l*\" - \"--ext-diff\" - \"--no-ext-diff\" -\n@@ -6394,13 +6398,16 @@ proc drawtags {id x xt y1} {\n     global headbgcolor headfgcolor headoutlinecolor remotebgcolor\n     global tagbgcolor tagfgcolor tagoutlinecolor\n     global reflinecolor\n+    global no_tags\n\n     set marks {}\n     set ntags 0\n     set nheads 0\n     if {[info exists idtags($id)]} {\n-    set marks $idtags($id)\n-    set ntags [llength $marks]\n+      if {$no_tags < 1} {\n+        set marks $idtags($id)\n+        set ntags [llength $marks]\n+      }\n     }\n     if {[info exists idheads($id)]} {\n     set marks [concat $marks $idheads($id)]\n--\n1.8.4.2\n"},{"id":"229818","messageId":"87ob66g5m7.fsf@linux-k42r.v.cablecom.net","threadId":"35234","inReplyTo":"CAMXp-VP9DDJ-L=e=7=-bO+ZFVRMVz-PAs0gGv8Q7RrZ-OWof9Q@mail.gmail.com","subject":"Re: [PATCH] Add option --no-tags","fromName":"Thomas Rast","fromEmail":"tr@thomasrast.ch","sentAt":"2013-10-30T15:06:56Z","receivedAt":"2013-10-30T15:06:56Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Nicolas Cornu <ncornu@aldebaran-robotics.com> writes:\n\n> From 1cbc2c49454581a67cce09ada1386dac4ffa2828 Mon Sep 17 00:00:00 2001\n> From: Nicolas Cornu <ncornu@aldebaran-robotics.com>\n> Date: Tue, 29 Oct 2013 11:31:10 +0100\n> Subject: [PATCH] Add option --no-tags\n>\n> ---\n>  gitk-git/gitk | 13 ++++++++++---\n>  1 file changed, 10 insertions(+), 3 deletions(-)\n\nThis patch suffers from the same problems as the one for the horizontal\nscroll bar.  In particular the commit message should (from\nDocumentation/SubmittingPatches):\n\n  . [explain] the problem the change tries to solve, iow, what is wrong\n    with the current code without the change.\n\n  . [justify] the way the change solves the problem, iow, why the\n    result with the change is better.\n\n  . [describe] alternate solutions considered but discarded, if any.\n\n\nOn the change itself: from a brief glance it seems you are trying to\nhide the tags shown alongside commits (presumably because there are too\nmany).\n\nHowever we already have one feature in a similar vein: the tickbox \"Hide\nremote refs\" in Edit->Preferences.  Shouldn't your feature go alongside\nit, and be configured in the same way?\n\n-- \nThomas Rast\ntr@thomasrast.ch\n"}]}