{"thread":{"id":"35229","subject":"Git v1.8.4.2 test failure in ./t5570-git-daemon.sh","startedAt":"2013-10-29T00:54:31Z","lastAt":"2013-10-30T07:00:16Z","messageCount":4,"participants":["Simon Ruderich","Jeff King","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"229686","messageId":"20131029005430.GA23920@ruderich.org","threadId":"35229","inReplyTo":null,"subject":"Git v1.8.4.2 test failure in ./t5570-git-daemon.sh","fromName":"Simon Ruderich","fromEmail":"simon@ruderich.org","sentAt":"2013-10-29T00:54:31Z","receivedAt":"2013-10-29T00:54:31Z","isPatch":false,"sender":{"key":"simon@ruderich.org","avatar":"https://avatars.githubusercontent.com/u/390994?v=4"},"body":"Hello,\n\nI just compiled Git v1.8.4.2 on Debian Wheezy amd64 and test\nt5570 fails (with GIT_TEST_GIT_DAEMON=1):\n\n    --- expect      2013-10-28 23:27:26.792409631 +0000\n    +++ output      2013-10-28 23:27:26.788409614 +0000\n    @@ -1 +1,2 @@\n    +Cloning into 'nowhere'...\n     fatal: remote error: access denied or repository not exported: /nowhere.git\n    [18908] [19625] Disconnected (with error)\n    not ok 9 - clone non-existent\n\n    --- expect      2013-10-28 23:27:26.944410377 +0000\n    +++ output      2013-10-28 23:27:26.944410377 +0000\n    @@ -1 +1,2 @@\n    +Cloning into 'nowhere'...\n    fatal: remote error: no such repository: /nowhere.git\n    [19727] [19747] Disconnected (with error)\n    not ok 13 - clone non-existent\n\nBisecting leads to this commit:\n\n    commit 68b939b2f097b6675c4aaa178655559aa81b25cb\n    Author: Jeff King <peff@peff.net>\n    Date:   Wed Sep 18 16:05:13 2013 -0400\n\n        clone: send diagnostic messages to stderr\n\n        Putting messages like \"Cloning into..\" and \"done\" on stdout\n        is un-Unix and uselessly clutters the stdout channel. Send\n        them to stderr.\n\n        We have to tweak two tests to accommodate this:\n\n        1. t5601 checks for doubled output due to forking, and\n            doesn't actually care where the output goes; adjust it\n            to check stderr.\n\n        2. t5702 is trying to test whether progress output was\n            sent to stderr, but naively does so by checking\n            whether stderr produced any output. Instead, have it\n            look for \"%\", a token found in progress output but not\n            elsewhere (and which lets us avoid hard-coding the\n            progress text in the test).\n\n        This should not regress any scripts that try to parse the\n        current output, as the output is already internationalized\n        and therefore unstable.\n\nRegards\nSimon\n-- \n+ privacy is necessary\n+ using gnupg http://gnupg.org\n+ public key id: 0x92FEFDB7E44C32F9\n"},{"id":"229691","messageId":"20131029013024.GA11861@sigill.intra.peff.net","threadId":"35229","inReplyTo":"20131029005430.GA23920@ruderich.org","subject":"Re: Git v1.8.4.2 test failure in ./t5570-git-daemon.sh","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-10-29T01:30:24Z","receivedAt":"2013-10-29T01:30:24Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Oct 29, 2013 at 01:54:31AM +0100, Simon Ruderich wrote:\n\n> I just compiled Git v1.8.4.2 on Debian Wheezy amd64 and test\n> t5570 fails (with GIT_TEST_GIT_DAEMON=1):\n> [...]\n> Bisecting leads to this commit:\n> \n>     commit 68b939b2f097b6675c4aaa178655559aa81b25cb\n>     Author: Jeff King <peff@peff.net>\n>     Date:   Wed Sep 18 16:05:13 2013 -0400\n> \n>         clone: send diagnostic messages to stderr\n\nThis is already fixed by Brian Gernhardt's 360a326 (t5570: Update for\nclone-progress-to-stderr branch, 2013-10-21).\n\nJunio, that patch seems to have gone onto jc/upload-pack-send-symref,\nbut should have gone onto jk/clone-progress-to-stderr. The latter made\nit into maint for v1.8.4.2, but the former did not.\n\nI think it was just a simple mixup caused by Brian sending two fixups to\nt5570 as series, when they are really fixups for two different topics.\nNot worth an immediate v1.8.4.3, I think, but you may want to\ncherry-pick 360a326 onto maint if there is another release before\nv1.8.5.\n\n-Peff\n"},{"id":"229752","messageId":"xmqqr4b3d0it.fsf@gitster.dls.corp.google.com","threadId":"35229","inReplyTo":"20131029013024.GA11861@sigill.intra.peff.net","subject":"Re: Git v1.8.4.2 test failure in ./t5570-git-daemon.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-10-30T01:12:58Z","receivedAt":"2013-10-30T01:12:58Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Tue, Oct 29, 2013 at 01:54:31AM +0100, Simon Ruderich wrote:\n>\n>> I just compiled Git v1.8.4.2 on Debian Wheezy amd64 and test\n>> t5570 fails (with GIT_TEST_GIT_DAEMON=1):\n>> [...]\n>> Bisecting leads to this commit:\n>> \n>>     commit 68b939b2f097b6675c4aaa178655559aa81b25cb\n>>     Author: Jeff King <peff@peff.net>\n>>     Date:   Wed Sep 18 16:05:13 2013 -0400\n>> \n>>         clone: send diagnostic messages to stderr\n>\n> This is already fixed by Brian Gernhardt's 360a326 (t5570: Update for\n> clone-progress-to-stderr branch, 2013-10-21).\n>\n> Junio, that patch seems to have gone onto jc/upload-pack-send-symref,\n> but should have gone onto jk/clone-progress-to-stderr. The latter made\n> it into maint for v1.8.4.2, but the former did not.\n>\n> I think it was just a simple mixup caused by Brian sending two fixups to\n> t5570 as series, when they are really fixups for two different topics.\n> Not worth an immediate v1.8.4.3, I think, but you may want to\n> cherry-pick 360a326 onto maint if there is another release before\n> v1.8.5.\n\nI am torn on this, actually.  I've been hoping that the other topic\nthat fixes a long-standing bug will also be a part of maintenance\ntrack.\n"},{"id":"229786","messageId":"20131030070016.GD11317@sigill.intra.peff.net","threadId":"35229","inReplyTo":"xmqqr4b3d0it.fsf@gitster.dls.corp.google.com","subject":"Re: Git v1.8.4.2 test failure in ./t5570-git-daemon.sh","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-10-30T07:00:16Z","receivedAt":"2013-10-30T07:00:16Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Oct 29, 2013 at 06:12:58PM -0700, Junio C Hamano wrote:\n\n> > I think it was just a simple mixup caused by Brian sending two fixups to\n> > t5570 as series, when they are really fixups for two different topics.\n> > Not worth an immediate v1.8.4.3, I think, but you may want to\n> > cherry-pick 360a326 onto maint if there is another release before\n> > v1.8.5.\n> \n> I am torn on this, actually.  I've been hoping that the other topic\n> that fixes a long-standing bug will also be a part of maintenance\n> track.\n\nThat is fine, too. Mainly I just did not want it to get forgotten. :)\n\n-Peff\n"}]}