{"thread":{"id":"35224","subject":"Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly","startedAt":"2013-10-28T14:04:13Z","lastAt":"2013-10-28T14:04:13Z","messageCount":1,"participants":["Paolo Giarrusso"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"229639","messageId":"CAAcnjCRcU8L+F3BuGtm2c+XJxyVsROyY1pwVynK9qdvS8zfFZw@mail.gmail.com","threadId":"35224","inReplyTo":null,"subject":"Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly","fromName":"Paolo Giarrusso","fromEmail":"p.giarrusso@gmail.com","sentAt":"2013-10-28T14:04:13Z","receivedAt":"2013-10-28T14:04:13Z","isPatch":true,"sender":{"key":"p.giarrusso@gmail.com","avatar":"https://gravatar.com/avatar/323ea8c76793d9193ad88ccff30f44d2ee0a51c63abe58d950b6454859e09bb6?d=mp&s=160"},"body":"(Resending without HTML, so that it reaches the ML).\n\nOn Fri, Oct 11, 2013 at 11:32 AM, Paolo Giarrusso <p.giarrusso@gmail.com> wrote:\n>\n> On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:\n> > Paolo Giarrusso wrote:\n> >\n> >> Seeing the email, I wonder whether there's hope something like that\n> >> can be preserved in an email, and whether the code should use some\n> >> escape sequence instead.\n> >\n> > Yes, please.  Mind if I amend it to\n> >\n> >         printf \"%s\\r\" \"$revcount/$revmax ($createcount)\" >&2\n> >\n> > ?\n>\n> Please do go ahead, by all means (arguably as a different commit, but\n> those are minor details).\n\nWhat happened? Did you go ahead, as you wrote? Is the patch somewhere?\nArguably it should go into the maint branch, but I think it didn't —\notherwise https://github.com/git/git/pull/61 should have stopped being\nmergeable.\n\nThis also makes me wonder whether you use any tracker at all — but\nunless there is one that I missed, that's a separate discussion.\n\n> > [...]\n> >>>         say()\n> >>>         {\n> >>>                 if [ -z \"$quiet\" ]; then\n> >>>                         echo \"$@\" >&2\n> >>>                fi\n> >>>         }\n> >\n> > I agree with the other reviewers that this should be fixed to use\n> > printf, too, but that's another topic.\n> Seconded.\n\n-- \nPaolo G. Giarrusso - Ph.D. Student, Philipps-University Marburg\nhttp://www.informatik.uni-marburg.de/~pgiarrusso/\n"}]}