{"thread":{"id":"35208","subject":"PATCH] t3200: do not open a HTML manual page when DEFAULT_MAN_FORMAT is html","startedAt":"2013-10-26T18:48:46Z","lastAt":"2013-10-26T18:48:46Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"229571","messageId":"526C0E8E.30605@kdbg.org","threadId":"35208","inReplyTo":null,"subject":"PATCH] t3200: do not open a HTML manual page when DEFAULT_MAN_FORMAT is html","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2013-10-26T18:48:46Z","receivedAt":"2013-10-26T18:48:46Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"We have the build configuration option DEFAULT_MAN_FORMAT to choose a\nformat different from man pages to be used by 'git help' when no format\nis requested explicitly. Since 65db0443 (Set the default help format to\nhtml for msys builds, 2013-06-04) we use html on Windows by default.\n\nThere is one test in t3200-branch.sh that invokes a help page. The\nintent of the redirections applied to the command invocation is to avoid\nthat the man page viewer interferes with the automated test. But when\nthe default format is not \"man\", this does not have the intended effect,\nand the HTML manual page is opened during the test run. Request \"man\"\nformat explicitly to keep the test silent.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n I've posted this patch to the msysgit list in July, and Dscho has picked\n it up for Git on Windows.\n\n t/t3200-branch.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3200-branch.sh b/t/t3200-branch.sh\nindex 44ec6a4..e9823a0 100755\n--- a/t/t3200-branch.sh\n+++ b/t/t3200-branch.sh\n@@ -17,7 +17,7 @@ test_expect_success 'prepare a trivial repository' '\n \tHEAD=$(git rev-parse --verify HEAD)'\n \n test_expect_success 'git branch --help should not have created a bogus branch' '\n-\ttest_might_fail git branch --help </dev/null >/dev/null 2>/dev/null &&\n+\ttest_might_fail git branch --man --help </dev/null >/dev/null 2>&1 &&\n \ttest_path_is_missing .git/refs/heads/--help\n '\n \n-- \n1.8.4.33.gd68f7e8\n\n-- \n-- \n*** Please reply-to-all at all times ***\n*** (do not pretend to know who is subscribed and who is not) ***\n*** Please avoid top-posting. ***\nThe msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.\n\nYou received this message because you are subscribed to the Google\nGroups \"msysGit\" group.\nTo post to this group, send email to msysgit@googlegroups.com\nTo unsubscribe from this group, send email to\nmsysgit+unsubscribe@googlegroups.com\nFor more options, and view previous threads, visit this group at\nhttp://groups.google.com/group/msysgit?hl=en_US?hl=en\n\n--- \nYou received this message because you are subscribed to the Google Groups \"msysGit\" group.\nTo unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.\nFor more options, visit https://groups.google.com/groups/opt_out.\n"}]}