{"thread":{"id":"35174","subject":"[PATCH 1/2] t5570: Update for symref capability","startedAt":"2013-10-21T17:54:11Z","lastAt":"2013-10-21T18:41:54Z","messageCount":3,"participants":["Brian Gernhardt","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"229252","messageId":"1382378052-89929-1-git-send-email-brian@gernhardtsoftware.com","threadId":"35174","inReplyTo":null,"subject":"[PATCH 1/2] t5570: Update for symref capability","fromName":"Brian Gernhardt","fromEmail":"brian@gernhardtsoftware.com","sentAt":"2013-10-21T17:54:11Z","receivedAt":"2013-10-21T17:54:11Z","isPatch":true,"sender":{"key":"brian@gernhardtsoftware.com","avatar":"https://avatars.githubusercontent.com/u/133455?v=4"},"body":"git-daemon now uses the symref capability to send the correct HEAD\nreference, so the test for that in t5570 now passes.\n\nSigned-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>\n---\n t/t5570-git-daemon.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh\nindex f01edff..dc55e51 100755\n--- a/t/t5570-git-daemon.sh\n+++ b/t/t5570-git-daemon.sh\n@@ -37,7 +37,7 @@ test_expect_success 'fetch changes via git protocol' '\n \ttest_cmp file clone/file\n '\n \n-test_expect_failure 'remote detects correct HEAD' '\n+test_expect_success 'remote detects correct HEAD' '\n \tgit push public master:other &&\n \t(cd clone &&\n \t git remote set-head -d origin &&\n-- \n1.8.3.4 (Apple Git-47)\n"},{"id":"229253","messageId":"1382378052-89929-2-git-send-email-brian@gernhardtsoftware.com","threadId":"35174","inReplyTo":"1382378052-89929-1-git-send-email-brian@gernhardtsoftware.com","subject":"[PATCH 2/2] t5570: Update for clone-progress-to-stderr branch","fromName":"Brian Gernhardt","fromEmail":"brian@gernhardtsoftware.com","sentAt":"2013-10-21T17:54:12Z","receivedAt":"2013-10-21T17:54:12Z","isPatch":true,"sender":{"key":"brian@gernhardtsoftware.com","avatar":"https://avatars.githubusercontent.com/u/133455?v=4"},"body":"git clone now reports its progress to standard error, which throws off\nt5570.  Using test_i18ngrep instead of test_cmp allows the test to be\nmore flexible by only looking for the expected error and ignoring any\nother output from the program.\n\nSigned-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>\n---\n t/t5570-git-daemon.sh | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/t/t5570-git-daemon.sh b/t/t5570-git-daemon.sh\nindex dc55e51..e061468 100755\n--- a/t/t5570-git-daemon.sh\n+++ b/t/t5570-git-daemon.sh\n@@ -122,8 +122,7 @@ test_remote_error()\n \tfi\n \n \ttest_must_fail git \"$cmd\" \"$GIT_DAEMON_URL/$repo\" \"$@\" 2>output &&\n-\techo \"fatal: remote error: $msg: /$repo\" >expect &&\n-\ttest_cmp expect output\n+\ttest_i18ngrep \"fatal: remote error: $msg: /$repo\" output &&\n \tret=$?\n \tchmod +x \"$GIT_DAEMON_DOCUMENT_ROOT_PATH/repo.git\"\n \t(exit $ret)\n-- \n1.8.3.4 (Apple Git-47)\n"},{"id":"229257","messageId":"20131021184154.GA29681@sigill.intra.peff.net","threadId":"35174","inReplyTo":"1382378052-89929-2-git-send-email-brian@gernhardtsoftware.com","subject":"Re: [PATCH 2/2] t5570: Update for clone-progress-to-stderr branch","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-10-21T18:41:54Z","receivedAt":"2013-10-21T18:41:54Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Oct 21, 2013 at 01:54:12PM -0400, Brian Gernhardt wrote:\n\n> git clone now reports its progress to standard error, which throws off\n> t5570.  Using test_i18ngrep instead of test_cmp allows the test to be\n> more flexible by only looking for the expected error and ignoring any\n> other output from the program.\n\nThanks, this is due to my 68b939b. I dealt with the fallout elsewhere in\nthe test suite, but I did not run with GIT_TEST_GIT_DAEMON set (and I do\nnot think Junio does, either). I'll start doing so.\n\nI already have GIT_TEST_HTTPD set, and after a quick grep I don't think\nI am missing any others (I do skip the svn, cvs, and p4 tests, though,\nas I do not have them installed).\n\n-Peff\n"}]}