{"thread":{"id":"35140","subject":"What's cooking in git.git (Oct 2013, #01; Mon, 14)","startedAt":"2013-10-14T18:45:24Z","lastAt":"2013-10-16T17:53:30Z","messageCount":9,"participants":["Jonathan Nieder","Ramkumar Ramachandra","Junio C Hamano","Jens Lehmann"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"228939","messageId":"20131014184524.GW9464@google.com","threadId":"35140","inReplyTo":null,"subject":"What's cooking in git.git (Oct 2013, #01; Mon, 14)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-10-14T18:45:24Z","receivedAt":"2013-10-14T18:45:24Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"What's cooking in git.git (Oct 2013, #01; Mon, 14)\n--------------------------------------------------\n\nHere are the topics that have been cooking.  Commits prefixed with\n'-' are only in 'pu' (proposed updates) while commits prefixed with\n'+' are in 'next'.\n\nJunio is back (yay!) and is picking maintainership back up.  Here is\nthe state of topics in flight.  As usual, help moving topics forward\nand pointing out patches that fell through the cracks is appreciated.\n\nYou can find the changes described here in the integration branches at\n\n    https://googlers.googlesource.com/jrn/git\n    git://repo.or.cz/git/jrn.git\n    git://gitorious.org/git/jrn.git\n    https://github.com/jrn/git\n\n--------------------------------------------------\n[New Topics]\n\n* ak/submodule-foreach-quoting (2013-09-27) 1 commit\n  (merged to 'next' on 2013-10-14 at d77c5f1)\n + submodule foreach: skip eval for more than one argument\n\n A behavior change, but a worthwhile one: \"git submodule foreach\"\n was treating its arguments as part of a single command to be\n concatenated and passed to a shell, making writing buggy\n scripts too easy.\n\n This patch preserves the old \"just pass it to the shell\" behavior\n when a single argument is passed to 'git submodule foreach' and\n moves to a new \"skip the shell and use the arguments passed\n unmolested\" behavior when more than one argument is passed.\n\n The old behavior (always concatenating and passing to the shell)\n was similar to the 'ssh' command, while the new behavior (switching\n on the number of arguments) is what 'xterm -e' does.\n\n May need more thought to make sure this change is advertised well\n so that scripts that used multiple arguments but added their own\n extra layer of quoting are not broken.\n\n* ew/keepalive (2013-10-14) 1 commit\n  (merged to 'next' on 2013-10-14 at 24d786f)\n + http: enable keepalive on TCP sockets\n\n\n* hu/cherry-pick-previous-branch (2013-10-10) 1 commit\n  (merged to 'next' on 2013-10-14 at 090934f)\n + cherry-pick: handle \"-\" after parsing options\n\n \"git cherry-pick\" without further options would segfault.\n\n Could use a follow-up to handle '-' after argv[1] better.\n\n\n* jc/pack-objects (2013-02-04) 1 commit\n  (merged to 'next' on 2013-10-14 at 8e8feb6)\n + pack-objects: shrink struct object_entry\n\n\n* jc/prompt-upstream (2013-10-14) 1 commit\n  (merged to 'next' on 2013-10-14 at 270ef7b)\n + git-prompt.sh: optionally show upstream branch name\n\n An enhancement to the GIT_PS1_SHOWUPSTREAM facility.\n\n\n* jk/http-auth-redirects (2013-09-30) 3 commits\n  (merged to 'next' on 2013-10-14 at a0642be)\n + http: refactor options to http_get_*\n + http_request: factor out curlinfo_strbuf\n + http_get_file: style fixes\n\n Cleanups from the beginning of a larger series.\n\n\n* jl/submodule-mv (2013-10-13) 1 commit\n - mv: Fix spurious warning when moving a file in presence of submodules\n\n Moving a regular file in a repository with a .gitmodules file was\n producing a warning 'Could not find section in .gitmodules where\n path=<filename>'.\n\n The test can use a little cleanup.  Otherwise looks good.\n\n\n* yt/shortened-rename (2013-10-13) 1 commit\n - diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.\n\n Expecting a reroll.\n\n--------------------------------------------------\n[Stalled]\n\n* tr/merge-recursive-index-only (2013-07-07) 3 commits\n - merge-recursive: -Xindex-only to leave worktree unchanged\n - merge-recursive: untangle double meaning of o->call_depth\n - merge-recursive: remove dead conditional in update_stages()\n\n Will hold until there is a caller to learn from.\n\n\n* jc/ref-excludes (2013-09-03) 2 commits\n - document --exclude option\n - revision: introduce --exclude=<glob> to tame wildcards\n\n People often wished a way to tell \"git log --branches\" (and \"git\n log --remotes --not --branches\") to exclude some local branches\n from the expansion of \"--branches\" (similarly for \"--tags\", \"--all\"\n and \"--glob=<pattern>\").  Now they have one.\n\n Needs a matching change to rev-parse.\n\n\n* rv/send-email-cache-generated-mid (2013-08-21) 2 commits\n - git-send-email: Cache generated message-ids, use them when prompting\n - git-send-email: add optional 'choices' parameter to the ask sub\n\n\n* rj/read-default-config-in-show-ref-pack-refs (2013-06-17) 3 commits\n - ### DONTMERGE: needs better explanation on what config they need\n - pack-refs.c: Add missing call to git_config()\n - show-ref.c: Add missing call to git_config()\n\n The changes themselves are probably good, but it is unclear what\n basic setting needs to be read for which exact operation.\n\n Waiting for clarification.\n $gmane/228294\n\n\n* jh/shorten-refname (2013-05-07) 4 commits\n - t1514: refname shortening is done after dereferencing symbolic refs\n - shorten_unambiguous_ref(): Fix shortening refs/remotes/origin/HEAD to origin\n - t1514: Demonstrate failure to correctly shorten \"refs/remotes/origin/HEAD\"\n - t1514: Add tests of shortening refnames in strict/loose mode\n\n When remotes/origin/HEAD is not a symbolic ref, \"rev-parse\n --abbrev-ref remotes/origin/HEAD\" ought to show \"origin\", not\n \"origin/HEAD\", which is fixed with this series (if it is a symbolic\n ref that points at remotes/origin/something, then it should show\n \"origin/something\" and it already does).\n\n Expecting a reroll, as an early part of a larger series.\n $gmane/225137\n\n\n* mg/more-textconv (2013-05-10) 7 commits\n  (merged to 'next' on 2013-10-14 at 8a12490)\n + grep: honor --textconv for the case rev:path\n + grep: allow to use textconv filters\n + t7008: demonstrate behavior of grep with textconv\n + cat-file: do not die on --textconv without textconv filters\n + show: honor --textconv for blobs\n + diff_opt: track whether flags have been set explicitly\n + t4030: demonstrate behavior of show with textconv\n\n Make \"git grep\" and \"git show\" pay attention to --textconv when\n dealing with blob objects.\n\n There was a question about how defaulting to 'git show --textconv'\n would interact with the \"git show HEAD:file.c >file.c\" habit.\n $gmane/221833\n\n\n* jc/format-patch (2013-04-22) 2 commits\n - format-patch: --inline-single\n - format-patch: rename \"no_inline\" field\n\n A new option to send a single patch to the standard output to be\n appended at the bottom of a message.  I personally have no need for\n this, but it was easy enough to cobble together.  Tests, docs and\n stripping out more MIMEy stuff are left as exercises to interested\n parties.\n\n\n* jk/gitweb-utf8 (2013-04-08) 4 commits\n - gitweb: Fix broken blob action parameters on blob/commitdiff pages\n - gitweb: Don't append ';js=(0|1)' to external links\n - gitweb: Make feed title valid utf8\n - gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch\n\n Various fixes to gitweb.\n\n Drew Northup volunteered to take a look into this.\n $gmane/226216\n\n\n* jc/show-branch (2013-06-07) 5 commits\n - show-branch: use commit slab to represent bitflags of arbitrary width\n - show-branch.c: remove \"all_mask\"\n - show-branch.c: abstract out \"flags\" operation\n - show-branch.c: lift all_mask/all_revs to a global static\n - show-branch.c: update comment style\n\n Waiting for the final step to lift the hard-limit before sending it out.\n\n--------------------------------------------------\n[Cooking]\n\n* bc/gnome-keyring (2013-09-23) 15 commits\n - contrib/git-credential-gnome-keyring.c: support really ancient gnome-keyring\n - contrib/git-credential-gnome-keyring.c: support ancient gnome-keyring\n - contrib/git-credential-gnome-keyring.c: report failure to store password\n - contrib/git-credential-gnome-keyring.c: use glib messaging functions\n - contrib/git-credential-gnome-keyring.c: use glib memory allocation functions\n - contrib/git-credential-gnome-keyring.c: use secure memory for reading passwords\n - contrib/git-credential-gnome-keyring.c: use secure memory functions for passwds\n - contrib/git-credential-gnome-keyring.c: use gnome helpers in keyring_object()\n - contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessing\n - contrib/git-credential-gnome-keyring.c: strlen() returns size_t, not ssize_t\n - contrib/git-credential-gnome-keyring.c: set Gnome application name\n - contrib/git-credential-gnome-keyring.c: exit non-zero when called incorrectly\n - contrib/git-credential-gnome-keyring.c: add static where applicable\n - contrib/git-credential-gnome-keyring.c: remove unused die() function\n - contrib/git-credential-gnome-keyring.c: remove unnecessary pre-declarations\n\n Cleanups and tweaks for credential handling to work with ancient versions\n of the gnome-keyring library that are still in use.\n\n This is version 1 of the series, to give it more exposure.  Waiting for\n the series to stabilize before including in 'next'.\n\n\n* kb/fast-hashmap (2013-09-25) 6 commits\n - fixup! diffcore-rename.c: simplify finding exact renames\n - diffcore-rename.c: use new hash map implementation\n - diffcore-rename.c: simplify finding exact renames\n - diffcore-rename.c: move code around to prepare for the next patch\n - buitin/describe.c: use new hash map implementation\n - add a hashtable implementation that supports O(1) removal\n\n Improvements to our hash table to get it to meet the needs of the\n msysgit fscache project, with some nice performance improvements.\n\n Looks promising.  Needs style review and a sanity-check on the\n design before including in 'next'.  Expecting a reroll once review\n settles down.\n\n\n* jc/revision-range-unpeel (2013-09-20) 2 commits\n - (possible fixup) jc/revision-range-unpeel - peel only when necessary\n - revision: do not peel tags used in range notation\n\n \"git rev-list --objects ^v1.0^ v1.0\" gave v1.0 tag itself in the\n output, but \"git rev-list --objects v1.0^..v1.0\" did not.\n\n Need to decide either squashing the top fixup in, or dropping it\n and then merge to 'next'.\n\n\n* tg/perf-lib-test-perf-cleanup (2013-09-19) 2 commits\n - perf-lib: add test_perf_cleanup target\n - perf-lib: split starting the test from the execution\n\n Add test_perf_cleanup shell function to the perf suite, that allows\n the script writers to define a test with a clean-up action.\n\n Holding until needed.\n\n\n* jk/format-patch-from (2013-09-20) 1 commit\n  (merged to 'next' on 2013-09-20 at 0506530)\n + format-patch: print in-body \"From\" only when needed\n\n \"format-patch --from=<whom>\" forgot to omit unnecessary in-body\n from line, i.e. when <whom> is the same as the real author.\n\n Will merge to 'master'.\n\n\n* es/name-hash-no-trailing-slash-in-dirs (2013-09-17) 4 commits\n  (merged to 'next' on 2013-09-20 at 9633d9a)\n + dir: revert work-around for retired dangerous behavior\n + name-hash: stop storing trailing '/' on paths in index_state.dir_hash\n + employ new explicit \"exists in index?\" API\n + name-hash: refactor polymorphic index_name_exists()\n\n Clean up the internal of the name-hash mechanism used to work\n around case insensitivity on some filesystems to cleanly fix a\n long-standing API glitch where the caller of cache_name_exists()\n that ask about a directory with a counted string was required to\n have '/' at one location past the end of the string.\n\n Will merge to 'master'.\n\n\n* po/dot-url (2013-09-13) 2 commits\n  (merged to 'next' on 2013-09-20 at 6a12786)\n + config doc: update dot-repository notes\n + doc: command line interface (cli) dot-repository dwimmery\n\n Explain how '.' can be used to refer to the \"current repository\"\n in the documentation.\n\n Will merge to 'master'.\n\n\n* jc/upload-pack-send-symref (2013-09-17) 7 commits\n - clone: test the new HEAD detection logic\n - connect: annotate refs with their symref information in get_remote_head()\n - connect.c: make parse_feature_value() static\n - upload-pack: send non-HEAD symbolic refs\n - upload-pack: send symbolic ref information as capability\n - upload-pack.c: do not pass confusing cb_data to mark_our_ref()\n - t5505: fix \"set-head --auto with ambiguous HEAD\" test\n\n One long-standing flaw in the pack transfer protocol used by \"git\n clone\" was that there was no way to tell the other end which branch\n \"HEAD\" points at, and the receiving end needed to guess.  A new\n capability has been defined in the pack protocol to convey this\n information so that cloning from a repository with more than one\n branches pointing at the same commit where the HEAD is at now\n reliably sets the initial branch in the resulting repository.\n\n Will merge to 'next'.\n\n\n* jk/clone-progress-to-stderr (2013-09-18) 3 commits\n  (merged to 'next' on 2013-09-25 at 137af9e)\n + clone: always set transport options\n + clone: treat \"checking connectivity\" like other progress\n + clone: send diagnostic messages to stderr\n\n Some progress and diagnostic messages from \"git clone\" were\n incorrectly sent to the standard output stream, not to the standard\n error stream.\n\n Will merge to 'master'.\n\n\n* jx/relative-path-regression-fix (2013-10-14) 3 commits\n - Use simpler relative_path when set_git_dir\n  (merged to 'next' on 2013-10-14 at 704b9ee)\n + relative_path should honor dos-drive-prefix\n + test: use unambigous leading path (/foo) for MSYS\n\n Waiting for the review to settle.\n\n\n* jc/checkout-detach-doc (2013-09-11) 1 commit\n  (merged to 'next' on 2013-09-17 at 438cf13)\n + checkout: update synopsys and documentation on detaching HEAD\n\n \"git checkout [--detach] <commit>\" was listed poorly in the\n synopsis section of its documentation.\n\n Will merge to 'master'.\n\n\n* jk/trailing-slash-in-pathspec (2013-09-13) 2 commits\n  (merged to 'next' on 2013-09-17 at 18fe277)\n + reset: handle submodule with trailing slash\n + rm: re-use parse_pathspec's trailing-slash removal\n\n Code refactoring.\n\n Will merge to 'master'.\n\n\n* lc/filter-branch-too-many-refs (2013-09-12) 1 commit\n  (merged to 'next' on 2013-09-17 at 31cd01a)\n + Allow git-filter-branch to process large repositories with lots of branches.\n\n \"git filter-branch\" in a repository with many refs blew limit of\n command line length.\n\n Will merge to 'master'.\n\n\n* np/pack-v4 (2013-09-18) 90 commits\n - packv4-parse.c: add tree offset caching\n - t1050: replace one instance of show-index with verify-pack\n - index-pack, pack-objects: allow creating .idx v2 with .pack v4\n - unpack-objects: decode v4 trees\n - unpack-objects: allow to save processed bytes to a buffer\n - ...\n\n Nico and Duy advancing the eternal vaporware pack-v4.  This is here\n primarily for wider distribution of the preview edition.\n\n\n* sb/repack-in-c (2013-09-17) 3 commits\n  (merged to 'next' on 2013-09-25 at 7c47036)\n + repack: improve warnings about failure of renaming and removing files\n + repack: retain the return value of pack-objects\n + repack: rewrite the shell script in C\n\n Rerolled, and I think it is in a reasonably good shape.\n\n Will merge to 'master'.\n\n\n* jc/reflog-doc (2013-06-19) 1 commit\n  (merged to 'next' on 2013-09-25 at 4eb0c14)\n + setup_reflog_action: document the rules for using GIT_REFLOG_ACTION\n\n Document rules to use GIT_REFLOG_ACTION variable in the scripted\n Porcelain.  git-rebase--interactive locally violates them, but it\n is a leaf user that does not call out to or dot-source other\n scripts, so it does not urgently need to be fixed.\n\n Will merge to 'master'.\n\n\n* jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit\n - git add: -u/-A now affects the entire working tree\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/core-checkstat-2.0 (2013-05-06) 1 commit\n - core.statinfo: remove as promised in Git 2.0\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/push-2.0-default-to-simple (2013-06-18) 1 commit\n - push: switch default from \"matching\" to \"simple\"\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/add-2.0-ignore-removal (2013-04-22) 1 commit\n - git add <pathspec>... defaults to \"-A\"\n\n Updated endgame for \"git add <pathspec>\" that defaults to \"--all\"\n aka \"--no-ignore-removal\".\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/hold-diff-remove-q-synonym-for-no-deletion (2013-07-19) 1 commit\n - diff: remove \"diff-files -q\" in a version of Git in a distant future\n\n Will cook in 'next' until a distant future.\n\n--------------------------------------------------\n[Discarded]\n\n* jc/pull-training-wheel (2013-07-19) 1 commit\n  (merged to 'next' on 2013-08-28 at c39bd15)\n + pull: require choice between rebase/merge on non-fast-forward pull\n\n Make \"git pull\" (without arguments that say what branch to\n integrate from where) refuse with \"it does not fast forward; choose\n between 'pull --merge' and 'pull --rebase'\".\n\n This topic has been reverted from 'next'.  Will wait for the\n conclusion of the discussion to seek a more user-friendly\n alternative; it is likely that it will be based on the simpler\n approach Felipe posted earlier.\n"},{"id":"228983","messageId":"20131015001231.GA9464@google.com","threadId":"35140","inReplyTo":"20131014184524.GW9464@google.com","subject":"What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-10-15T00:12:31Z","receivedAt":"2013-10-15T00:12:31Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"What's cooking in git.git (Oct 2013, #02; Mon, 14)\n--------------------------------------------------\n\nHere are the topics that have been cooking.  Commits prefixed with\n'-' are only in 'pu' (proposed updates) while commits prefixed with\n'+' are in 'next'.\n\nTying up loose ends before the hand-off.\n\nThe changes described here are in the integration branches at\n\n    https://googlers.googlesource.com/jrn/git\n    git://repo.or.cz/git/jrn.git\n    git://gitorious.org/git/jrn.git\n    https://github.com/jrn/git\n\n--------------------------------------------------\n[Stalled]\n\n* tr/merge-recursive-index-only (2013-07-07) 3 commits\n - merge-recursive: -Xindex-only to leave worktree unchanged\n - merge-recursive: untangle double meaning of o->call_depth\n - merge-recursive: remove dead conditional in update_stages()\n\n Holding until there is a caller to learn from.\n\n\n* jc/ref-excludes (2013-09-03) 2 commits\n - document --exclude option\n - revision: introduce --exclude=<glob> to tame wildcards\n\n People often wished a way to tell \"git log --branches\" (and \"git\n log --remotes --not --branches\") to exclude some local branches\n from the expansion of \"--branches\" (similarly for \"--tags\", \"--all\"\n and \"--glob=<pattern>\").  Now they have one.\n\n Needs a matching change to rev-parse.\n\n\n* rv/send-email-cache-generated-mid (2013-08-21) 2 commits\n - git-send-email: Cache generated message-ids, use them when prompting\n - git-send-email: add optional 'choices' parameter to the ask sub\n\n\n* rj/read-default-config-in-show-ref-pack-refs (2013-06-17) 3 commits\n - ### DONTMERGE: needs better explanation on what config they need\n - pack-refs.c: Add missing call to git_config()\n - show-ref.c: Add missing call to git_config()\n\n The changes themselves are probably good, but it is unclear what\n basic setting needs to be read for which exact operation.\n\n Waiting for clarification.\n $gmane/228294\n\n\n* jh/shorten-refname (2013-05-07) 4 commits\n - t1514: refname shortening is done after dereferencing symbolic refs\n - shorten_unambiguous_ref(): Fix shortening refs/remotes/origin/HEAD to origin\n - t1514: Demonstrate failure to correctly shorten \"refs/remotes/origin/HEAD\"\n - t1514: Add tests of shortening refnames in strict/loose mode\n\n When remotes/origin/HEAD is not a symbolic ref, \"rev-parse\n --abbrev-ref remotes/origin/HEAD\" ought to show \"origin\", not\n \"origin/HEAD\", which is fixed with this series (if it is a symbolic\n ref that points at remotes/origin/something, then it should show\n \"origin/something\" and it already does).\n\n Expecting a reroll, as an early part of a larger series.\n $gmane/225137\n\n\n* mg/more-textconv (2013-05-10) 7 commits\n  (merged to 'next' on 2013-10-14 at 8a12490)\n + grep: honor --textconv for the case rev:path\n + grep: allow to use textconv filters\n + t7008: demonstrate behavior of grep with textconv\n + cat-file: do not die on --textconv without textconv filters\n + show: honor --textconv for blobs\n + diff_opt: track whether flags have been set explicitly\n + t4030: demonstrate behavior of show with textconv\n\n Make \"git grep\" and \"git show\" pay attention to --textconv when\n dealing with blob objects.\n\n There was a question about how defaulting to 'git show --textconv'\n would interact with the \"git show HEAD:file.c >file.c\" habit.\n $gmane/221833\n\n\n* jc/format-patch (2013-04-22) 2 commits\n - format-patch: --inline-single\n - format-patch: rename \"no_inline\" field\n\n A new option to send a single patch to the standard output to be\n appended at the bottom of a message.  I personally have no need for\n this, but it was easy enough to cobble together.  Tests, docs and\n stripping out more MIMEy stuff are left as exercises to interested\n parties.\n\n\n* jk/gitweb-utf8 (2013-04-08) 4 commits\n - gitweb: Fix broken blob action parameters on blob/commitdiff pages\n - gitweb: Don't append ';js=(0|1)' to external links\n - gitweb: Make feed title valid utf8\n - gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch\n\n Various fixes to gitweb.\n\n Drew Northup volunteered to take a look into this.\n $gmane/226216\n\n\n* jc/show-branch (2013-06-07) 5 commits\n - show-branch: use commit slab to represent bitflags of arbitrary width\n - show-branch.c: remove \"all_mask\"\n - show-branch.c: abstract out \"flags\" operation\n - show-branch.c: lift all_mask/all_revs to a global static\n - show-branch.c: update comment style\n\n Waiting for the final step to lift the hard-limit before sending it out.\n\n--------------------------------------------------\n[Cooking]\n\n* ak/submodule-foreach-quoting (2013-09-27) 1 commit\n  (merged to 'next' on 2013-10-14 at d77c5f1)\n + submodule foreach: skip eval for more than one argument\n\n A behavior change, but a worthwhile one: \"git submodule foreach\"\n was treating its arguments as part of a single command to be\n concatenated and passed to a shell, making writing buggy\n scripts too easy.\n\n This patch preserves the old \"just pass it to the shell\" behavior\n when a single argument is passed to 'git submodule foreach' and\n moves to a new \"skip the shell and use the arguments passed\n unmolested\" behavior when more than one argument is passed.\n\n The old behavior (always concatenating and passing to the shell)\n was similar to the 'ssh' command, while the new behavior (switching\n on the number of arguments) is what 'xterm -e' does.\n\n May need more thought to make sure this change is advertised well\n so that scripts that used multiple arguments but added their own\n extra layer of quoting are not broken.\n\n\n* ew/keepalive (2013-10-14) 1 commit\n  (merged to 'next' on 2013-10-14 at 24d786f)\n + http: enable keepalive on TCP sockets\n\n $gmane/236154 has a follow-up to do more magic with recent curl.\n\n\n* hu/cherry-pick-previous-branch (2013-10-10) 1 commit\n  (merged to 'next' on 2013-10-14 at 090934f)\n + cherry-pick: handle \"-\" after parsing options\n\n \"git cherry-pick\" without further options would segfault.\n\n Could use a follow-up to handle '-' after argv[1] better.\n\n\n* jc/pack-objects (2013-02-04) 1 commit\n  (merged to 'next' on 2013-10-14 at 8e8feb6)\n + pack-objects: shrink struct object_entry\n\n\n* jc/prompt-upstream (2013-10-14) 1 commit\n  (merged to 'next' on 2013-10-14 at 270ef7b)\n + git-prompt.sh: optionally show upstream branch name\n\n An enhancement to the GIT_PS1_SHOWUPSTREAM facility.\n\n\n* jk/http-auth-redirects (2013-10-14) 9 commits\n - remote-curl: rewrite base url from info/refs redirects\n - remote-curl: store url as a strbuf\n - remote-curl: make refs_url a strbuf\n - http: update base URLs when we see redirects\n - http: provide effective url to callers\n - http: hoist credential request out of handle_curl_result\n  (merged to 'next' on 2013-10-14 at a0642be)\n + http: refactor options to http_get_*\n + http_request: factor out curlinfo_strbuf\n + http_get_file: style fixes\n\n\n* jl/submodule-mv (2013-10-13) 1 commit\n - mv: Fix spurious warning when moving a file in presence of submodules\n\n Moving a regular file in a repository with a .gitmodules file was\n producing a warning 'Could not find section in .gitmodules where\n path=<filename>'.\n\n The test can use a little cleanup.  Otherwise looks good.\n\n\n* yt/shortened-rename (2013-10-13) 1 commit\n - diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.\n\n Expecting a reroll.\n\n\n* bc/gnome-keyring (2013-09-23) 15 commits\n - contrib/git-credential-gnome-keyring.c: support really ancient gnome-keyring\n - contrib/git-credential-gnome-keyring.c: support ancient gnome-keyring\n - contrib/git-credential-gnome-keyring.c: report failure to store password\n - contrib/git-credential-gnome-keyring.c: use glib messaging functions\n - contrib/git-credential-gnome-keyring.c: use glib memory allocation functions\n - contrib/git-credential-gnome-keyring.c: use secure memory for reading passwords\n - contrib/git-credential-gnome-keyring.c: use secure memory functions for passwds\n - contrib/git-credential-gnome-keyring.c: use gnome helpers in keyring_object()\n - contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessing\n - contrib/git-credential-gnome-keyring.c: strlen() returns size_t, not ssize_t\n - contrib/git-credential-gnome-keyring.c: set Gnome application name\n - contrib/git-credential-gnome-keyring.c: exit non-zero when called incorrectly\n - contrib/git-credential-gnome-keyring.c: add static where applicable\n - contrib/git-credential-gnome-keyring.c: remove unused die() function\n - contrib/git-credential-gnome-keyring.c: remove unnecessary pre-declarations\n\n Cleanups and tweaks for credential handling to work with ancient versions\n of the gnome-keyring library that are still in use.\n\n This is version 1 of the series, to give it more exposure.  Waiting for\n the series to stabilize before including in 'next'.\n\n\n* kb/fast-hashmap (2013-09-25) 6 commits\n - fixup! diffcore-rename.c: simplify finding exact renames\n - diffcore-rename.c: use new hash map implementation\n - diffcore-rename.c: simplify finding exact renames\n - diffcore-rename.c: move code around to prepare for the next patch\n - buitin/describe.c: use new hash map implementation\n - add a hashtable implementation that supports O(1) removal\n\n Improvements to our hash table to get it to meet the needs of the\n msysgit fscache project, with some nice performance improvements.\n\n Looks promising.  Needs style review and a sanity-check on the\n design before including in 'next'.  Expecting a reroll once review\n settles down.\n\n\n* jc/revision-range-unpeel (2013-09-20) 2 commits\n - (possible fixup) jc/revision-range-unpeel - peel only when necessary\n - revision: do not peel tags used in range notation\n\n \"git rev-list --objects ^v1.0^ v1.0\" gave v1.0 tag itself in the\n output, but \"git rev-list --objects v1.0^..v1.0\" did not.\n\n Need to decide either squashing the top fixup in, or dropping it\n and then merge to 'next'.\n\n\n* tg/perf-lib-test-perf-cleanup (2013-09-19) 2 commits\n - perf-lib: add test_perf_cleanup target\n - perf-lib: split starting the test from the execution\n\n Add test_perf_cleanup shell function to the perf suite, that allows\n the script writers to define a test with a clean-up action.\n\n Holding until needed.\n\n\n* jk/format-patch-from (2013-09-20) 1 commit\n  (merged to 'next' on 2013-09-20 at 0506530)\n + format-patch: print in-body \"From\" only when needed\n\n \"format-patch --from=<whom>\" forgot to omit unnecessary in-body\n from line, i.e. when <whom> is the same as the real author.\n\n Will merge to 'master'.\n\n\n* es/name-hash-no-trailing-slash-in-dirs (2013-09-17) 4 commits\n  (merged to 'next' on 2013-09-20 at 9633d9a)\n + dir: revert work-around for retired dangerous behavior\n + name-hash: stop storing trailing '/' on paths in index_state.dir_hash\n + employ new explicit \"exists in index?\" API\n + name-hash: refactor polymorphic index_name_exists()\n\n Clean up the internal of the name-hash mechanism used to work\n around case insensitivity on some filesystems to cleanly fix a\n long-standing API glitch where the caller of cache_name_exists()\n that ask about a directory with a counted string was required to\n have '/' at one location past the end of the string.\n\n Will merge to 'master'.\n\n\n* po/dot-url (2013-09-13) 2 commits\n  (merged to 'next' on 2013-09-20 at 6a12786)\n + config doc: update dot-repository notes\n + doc: command line interface (cli) dot-repository dwimmery\n\n Explain how '.' can be used to refer to the \"current repository\"\n in the documentation.\n\n Will merge to 'master'.\n\n\n* jc/upload-pack-send-symref (2013-09-17) 7 commits\n - clone: test the new HEAD detection logic\n - connect: annotate refs with their symref information in get_remote_head()\n - connect.c: make parse_feature_value() static\n - upload-pack: send non-HEAD symbolic refs\n - upload-pack: send symbolic ref information as capability\n - upload-pack.c: do not pass confusing cb_data to mark_our_ref()\n - t5505: fix \"set-head --auto with ambiguous HEAD\" test\n\n One long-standing flaw in the pack transfer protocol used by \"git\n clone\" was that there was no way to tell the other end which branch\n \"HEAD\" points at, and the receiving end needed to guess.  A new\n capability has been defined in the pack protocol to convey this\n information so that cloning from a repository with more than one\n branches pointing at the same commit where the HEAD is at now\n reliably sets the initial branch in the resulting repository.\n\n Will merge to 'next'.\n\n\n* jk/clone-progress-to-stderr (2013-09-18) 3 commits\n  (merged to 'next' on 2013-09-25 at 137af9e)\n + clone: always set transport options\n + clone: treat \"checking connectivity\" like other progress\n + clone: send diagnostic messages to stderr\n\n Some progress and diagnostic messages from \"git clone\" were\n incorrectly sent to the standard output stream, not to the standard\n error stream.\n\n Will merge to 'master'.\n\n\n* jx/relative-path-regression-fix (2013-10-14) 3 commits\n - Use simpler relative_path when set_git_dir\n  (merged to 'next' on 2013-10-14 at 704b9ee)\n + relative_path should honor dos-drive-prefix\n + test: use unambigous leading path (/foo) for MSYS\n\n Waiting for the review to settle.\n\n\n* jc/checkout-detach-doc (2013-09-11) 1 commit\n  (merged to 'next' on 2013-09-17 at 438cf13)\n + checkout: update synopsys and documentation on detaching HEAD\n\n \"git checkout [--detach] <commit>\" was listed poorly in the\n synopsis section of its documentation.\n\n Will merge to 'master'.\n\n\n* jk/trailing-slash-in-pathspec (2013-09-13) 2 commits\n  (merged to 'next' on 2013-09-17 at 18fe277)\n + reset: handle submodule with trailing slash\n + rm: re-use parse_pathspec's trailing-slash removal\n\n Code refactoring.\n\n Will merge to 'master'.\n\n\n* lc/filter-branch-too-many-refs (2013-09-12) 1 commit\n  (merged to 'next' on 2013-09-17 at 31cd01a)\n + Allow git-filter-branch to process large repositories with lots of branches.\n\n \"git filter-branch\" in a repository with many refs blew limit of\n command line length.\n\n Will merge to 'master'.\n\n\n* np/pack-v4 (2013-09-18) 90 commits\n - packv4-parse.c: add tree offset caching\n - t1050: replace one instance of show-index with verify-pack\n - index-pack, pack-objects: allow creating .idx v2 with .pack v4\n - unpack-objects: decode v4 trees\n - unpack-objects: allow to save processed bytes to a buffer\n - ...\n\n Nico and Duy advancing the eternal vaporware pack-v4.  This is here\n primarily for wider distribution of the preview edition.\n\n\n* sb/repack-in-c (2013-09-17) 3 commits\n  (merged to 'next' on 2013-09-25 at 7c47036)\n + repack: improve warnings about failure of renaming and removing files\n + repack: retain the return value of pack-objects\n + repack: rewrite the shell script in C\n\n Rerolled, and I think it is in a reasonably good shape.\n\n Will merge to 'master'.\n\n\n* jc/reflog-doc (2013-06-19) 1 commit\n  (merged to 'next' on 2013-09-25 at 4eb0c14)\n + setup_reflog_action: document the rules for using GIT_REFLOG_ACTION\n\n Document rules to use GIT_REFLOG_ACTION variable in the scripted\n Porcelain.  git-rebase--interactive locally violates them, but it\n is a leaf user that does not call out to or dot-source other\n scripts, so it does not urgently need to be fixed.\n\n Will merge to 'master'.\n\n\n* jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit\n - git add: -u/-A now affects the entire working tree\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/core-checkstat-2.0 (2013-05-06) 1 commit\n - core.statinfo: remove as promised in Git 2.0\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/push-2.0-default-to-simple (2013-06-18) 1 commit\n - push: switch default from \"matching\" to \"simple\"\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/add-2.0-ignore-removal (2013-04-22) 1 commit\n - git add <pathspec>... defaults to \"-A\"\n\n Updated endgame for \"git add <pathspec>\" that defaults to \"--all\"\n aka \"--no-ignore-removal\".\n\n Will cook in 'next' until Git 2.0.\n\n\n* jc/hold-diff-remove-q-synonym-for-no-deletion (2013-07-19) 1 commit\n - diff: remove \"diff-files -q\" in a version of Git in a distant future\n\n Will cook in 'next' until a distant future.\n\n--------------------------------------------------\n[Discarded]\n\n* jc/pull-training-wheel (2013-07-19) 1 commit\n  (merged to 'next' on 2013-08-28 at c39bd15)\n + pull: require choice between rebase/merge on non-fast-forward pull\n\n Make \"git pull\" (without arguments that say what branch to\n integrate from where) refuse with \"it does not fast forward; choose\n between 'pull --merge' and 'pull --rebase'\".\n\n This topic has been reverted from 'next'.  Will wait for the\n conclusion of the discussion to seek a more user-friendly\n alternative; it is likely that it will be based on the simpler\n approach Felipe posted earlier.\n"},{"id":"228992","messageId":"CALkWK0nxOSD=8FvZSY-1NdDjxA_RDHd1VKCnYotooM+LsPS=vQ@mail.gmail.com","threadId":"35140","inReplyTo":"20131015001231.GA9464@google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-10-15T05:05:34Z","receivedAt":"2013-10-15T05:05:34Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Jonathan Nieder wrote:\n> What's cooking in git.git (Oct 2013, #02; Mon, 14)\n\nCould you have a look at the minor f-e-r enhancement I posted? [1]\n\nThanks.\n\n[1]: http://thread.gmane.org/gmane.comp.version-control.git/235483\n"},{"id":"229017","messageId":"xmqqiowye66r.fsf@gitster.dls.corp.google.com","threadId":"35140","inReplyTo":"20131015001231.GA9464@google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-10-15T18:32:12Z","receivedAt":"2013-10-15T18:32:12Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> What's cooking in git.git (Oct 2013, #02; Mon, 14)\n> Tying up loose ends before the hand-off.\n\nI'll try:\n\n - slurping your integration branches,\n - teasing the topics apart out of your 'pu',\n - populating my rerere database to match your confict resolution,\n - reconstructing the Meta/Reintegrate insn for 'pu', and\n - rebuilding 'pu' to make sure the end result matches yours\n\nand then push the result out to the usual places listed at\n\n    http://git-blame.blogspot.com/p/git-public-repositories.html\n\nI haven't had enough time to go through the new/updated patches in\ntree to look at them carefully (let alone peeking into patches that\nare not in 'pu'), but it appears to me that the list has been busy\nadding quality fixes and enhancements while I was away.\n\nThanks.\n\n> --------------------------------------------------\n> [Stalled]\n> ...\n> * mg/more-textconv (2013-05-10) 7 commits\n>   (merged to 'next' on 2013-10-14 at 8a12490)\n>  + grep: honor --textconv for the case rev:path\n>  + grep: allow to use textconv filters\n>  + t7008: demonstrate behavior of grep with textconv\n>  + cat-file: do not die on --textconv without textconv filters\n>  + show: honor --textconv for blobs\n>  + diff_opt: track whether flags have been set explicitly\n>  + t4030: demonstrate behavior of show with textconv\n>\n>  Make \"git grep\" and \"git show\" pay attention to --textconv when\n>  dealing with blob objects.\n>\n>  There was a question about how defaulting to 'git show --textconv'\n>  would interact with the \"git show HEAD:file.c >file.c\" habit.\n>  $gmane/221833\n\nI'll move this to the Cooking category (caught it by looking at the\noutput of \"Meta/cook -w\").\n\n> [Cooking]\n>\n> * ak/submodule-foreach-quoting (2013-09-27) 1 commit\n>   (merged to 'next' on 2013-10-14 at d77c5f1)\n>  + submodule foreach: skip eval for more than one argument\n>\n>  A behavior change, but a worthwhile one: \"git submodule foreach\"\n>  was treating its arguments as part of a single command to be\n>  concatenated and passed to a shell, making writing buggy\n>  scripts too easy.\n>\n>  This patch preserves the old \"just pass it to the shell\" behavior\n>  when a single argument is passed to 'git submodule foreach' and\n>  moves to a new \"skip the shell and use the arguments passed\n>  unmolested\" behavior when more than one argument is passed.\n\nWhen scripts give 'echo' and '$path' (two args), does this change\nallow the 'echo' command to see the value of $path (coming from\n$sm_path), or just the not-useful-because-not-exported variable name\n'$path'?\n\n>  The old behavior (always concatenating and passing to the shell)\n>  was similar to the 'ssh' command, while the new behavior (switching\n>  on the number of arguments) is what 'xterm -e' does.\n>\n>  May need more thought to make sure this change is advertised well\n>  so that scripts that used multiple arguments but added their own\n>  extra layer of quoting are not broken.\n\nI suspect no amount of thinking is enough to avoid fallout from this\nchange.  People will not read advertisement and will complain.\n\n> * ew/keepalive (2013-10-14) 1 commit\n>   (merged to 'next' on 2013-10-14 at 24d786f)\n>  + http: enable keepalive on TCP sockets\n>\n>  $gmane/236154 has a follow-up to do more magic with recent curl.\n\nThanks for leaving a good note here.\nWill take a look at that follow-up in tomorrow's integration cycle.\n\n> * jc/revision-range-unpeel (2013-09-20) 2 commits\n>  - (possible fixup) jc/revision-range-unpeel - peel only when necessary\n>  - revision: do not peel tags used in range notation\n>\n>  \"git rev-list --objects ^v1.0^ v1.0\" gave v1.0 tag itself in the\n>  output, but \"git rev-list --objects v1.0^..v1.0\" did not.\n>\n>  Need to decide either squashing the top fixup in, or dropping it\n>  and then merge to 'next'.\n\nFunny that you did not \"decide\" as the interim maintainer ;-)\nI'll squash these two, per $gmane/235339, and have it advance,\nperhaps in tomorrow's integration cycle.\n\n> * jk/format-patch-from (2013-09-20) 1 commit\n>   (merged to 'next' on 2013-09-20 at 0506530)\n>  + format-patch: print in-body \"From\" only when needed\n>\n>  \"format-patch --from=<whom>\" forgot to omit unnecessary in-body\n>  from line, i.e. when <whom> is the same as the real author.\n>\n>  Will merge to 'master'.\n\nThere seem to be many topics marked for 'master' but have been\ncooking in 'next' for very long.  Will start moving them later this\nweek (i.e. not today, not tomorrow).\n\n> * jc/upload-pack-send-symref (2013-09-17) 7 commits\n>  - clone: test the new HEAD detection logic\n> ...\n>  Will merge to 'next'.\n\nLikewise for the ones slated for 'next'.\n\nThanks.\n"},{"id":"229020","messageId":"20131015191656.GD9464@google.com","threadId":"35140","inReplyTo":"xmqqiowye66r.fsf@gitster.dls.corp.google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-10-15T19:16:56Z","receivedAt":"2013-10-15T19:16:56Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n\n> I'll try:\n>\n>  - slurping your integration branches,\n>  - teasing the topics apart out of your 'pu',\n>  - populating my rerere database to match your confict resolution,\n>  - reconstructing the Meta/Reintegrate insn for 'pu', and\n>  - rebuilding 'pu' to make sure the end result matches yours\n>\n> and then push the result out to the usual places\n\nSounds good.  The teased-apart topics can also be found at\n\n    https://github.com/jrn/git\n\n[...]\n>>  This patch preserves the old \"just pass it to the shell\" behavior\n>>  when a single argument is passed to 'git submodule foreach' and\n>>  moves to a new \"skip the shell and use the arguments passed\n>>  unmolested\" behavior when more than one argument is passed.\n>\n> When scripts give 'echo' and '$path' (two args), does this change\n> allow the 'echo' command to see the value of $path (coming from\n> $sm_path), or just the not-useful-because-not-exported variable name\n> '$path'?\n\nThe latter.  A quick search (web search + codesearch.debian.net)\nreveals that most callers to submodule foreach either pass a script as\na single quoted argument (e.g.,\nhttp://stackoverflow.com/questions/8364738/bash-git-submodule-foreach:\n\n\tgit submodule foreach '[ \"$path\" = \"Libraries/JSONKit\" ] \\\n\t  && branch=experimental \\\n\t  || branch=master; git co $branch'\n\nor http://sources.debian.net/src/jquery/1.7.2+dfsg-3/Makefile?hl=131#L131:\n\n\tgit submodule foreach \"git pull \\$(git config remote.origin.url)\"\n\n) or pass a one-off command with no arguments intended for the shell\n(e.g., http://sources.debian.net/src/libreoffice/1:4.1.1-1/g?hl=352#L352,\nhttp://sources.debian.net/src/swi-prolog/6.4.1-3/scripts/newversion?hl=81#L81):\n\n\tgit submodule foreach git push \"$@\"\n\tgit submodule foreach git tag -s -f -F $tmp  $gittag\n\nSo I suspect this will fix more scripts than it breaks, though it may\nstill break some. :/\n\nIt might make sense to warn when passed multiple arguments and some\ninclude shell metacharacters, since that's probably rare, too, except\nit's punishing people who use multiple arguments as a way to avoid\nquoting issues.  Probably there's no replacement for just advertising\nthe change loudly and seeking out scripts it could break.\n\nThanks,\nJonathan\n"},{"id":"229021","messageId":"525D9A96.6050209@web.de","threadId":"35140","inReplyTo":"20131015191656.GD9464@google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2013-10-15T19:42:14Z","receivedAt":"2013-10-15T19:42:14Z","isPatch":false,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 15.10.2013 21:16, schrieb Jonathan Nieder:\n> So I suspect this will fix more scripts than it breaks, though it may\n> still break some. :/\n\nHmm, I'm really not sure if we should do this or not.\n\n> It might make sense to warn when passed multiple arguments and some\n> include shell metacharacters, since that's probably rare, too, except\n> it's punishing people who use multiple arguments as a way to avoid\n> quoting issues.  Probably there's no replacement for just advertising\n> the change loudly and seeking out scripts it could break.\n\nAnd maybe only change that on a major version bump where people should\nnot be terribly surprised about such a change in behavior and are more\nlikely to read release notes?\n\nI've thought about issuing a warning on certain quoting patterns too,\nbut dismissed that for not helping much in the scripting case. E.g. at\n$dayjob we have foreach commands running in the shell execution for\nquite some jobs on our Jenkins server; nobody would see any warnings\nthere until we'd have the reason to dig deeper int the logs because\nsomething breaks.\n"},{"id":"229022","messageId":"525D9B6D.2090201@web.de","threadId":"35140","inReplyTo":"20131015001231.GA9464@google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2013-10-15T19:45:49Z","receivedAt":"2013-10-15T19:45:49Z","isPatch":false,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 15.10.2013 02:12, schrieb Jonathan Nieder:\n> * jl/submodule-mv (2013-10-13) 1 commit\n>  - mv: Fix spurious warning when moving a file in presence of submodules\n> \n>  Moving a regular file in a repository with a .gitmodules file was\n>  producing a warning 'Could not find section in .gitmodules where\n>  path=<filename>'.\n> \n>  The test can use a little cleanup.  Otherwise looks good.\n\nWhat cleanups do you have in mind? The new test is basically a copy from\nanother one from the same file, so maybe some other tests there need some\ncleanups too? ;-)\n"},{"id":"229023","messageId":"20131015200528.GE9464@google.com","threadId":"35140","inReplyTo":"525D9A96.6050209@web.de","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-10-15T20:05:28Z","receivedAt":"2013-10-15T20:05:28Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jens Lehmann wrote:\n> Am 15.10.2013 21:16, schrieb Jonathan Nieder:\n\n>> So I suspect this will fix more scripts than it breaks, though it may\n>> still break some. :/\n>\n> Hmm, I'm really not sure if we should do this or not.\n\nWhat convinced me was Anders's observation that the current behavior\ncan have very bad consequences if a script is passing untrusted input\nin multiple arguments to git submodule foreach.\n\nI still haven't found any examples that pass input intended for the\nshell to git submodule foreach in multiple arguments.  I suspect no\none will notice, except that some scripts (like libreoffice's \"g\")\nstart to work better when passed arguments containing shell\nmetacharacters.\n\n> And maybe only change that on a major version bump where people should\n> not be terribly surprised about such a change in behavior and are more\n> likely to read release notes?\n\nOk with me, but please don't make it 2.0. :)\n\n[...]\n>                                                                E.g. at\n> $dayjob we have foreach commands running in the shell execution for\n> quite some jobs on our Jenkins server; nobody would see any warnings\n> there until we'd have the reason to dig deeper int the logs because\n> something breaks.\n\nYes, I think that's typical.  Warning to stderr probably wouldn't\nhelp.\n\nThanks,\nJonathan\n"},{"id":"229074","messageId":"525ED29A.1020507@web.de","threadId":"35140","inReplyTo":"20131015200528.GE9464@google.com","subject":"Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2013-10-16T17:53:30Z","receivedAt":"2013-10-16T17:53:30Z","isPatch":false,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 15.10.2013 22:05, schrieb Jonathan Nieder:\n> Jens Lehmann wrote:\n>> Am 15.10.2013 21:16, schrieb Jonathan Nieder:\n> \n>>> So I suspect this will fix more scripts than it breaks, though it may\n>>> still break some. :/\n>>\n>> Hmm, I'm really not sure if we should do this or not.\n> \n> What convinced me was Anders's observation that the current behavior\n> can have very bad consequences if a script is passing untrusted input\n> in multiple arguments to git submodule foreach.\n\nOk, that makes sense.\n\n>> And maybe only change that on a major version bump where people should\n>> not be terribly surprised about such a change in behavior and are more\n>> likely to read release notes?\n> \n> Ok with me, but please don't make it 2.0. :)\n\nBut we don't want to wait for 3.0, no? ;-)\n"}]}