{"thread":{"id":"35098","subject":"[PATCH] Fix: Handle ampersand in branch names properly","startedAt":"2013-10-10T14:19:55Z","lastAt":"2013-10-10T14:19:55Z","messageCount":1,"participants":["Alexander Kurz"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"228695","messageId":"5256B78B.6050801@heliocentris.com","threadId":"35098","inReplyTo":null,"subject":"[PATCH] Fix: Handle ampersand in branch names properly","fromName":"Alexander Kurz","fromEmail":"alexander.kurz@heliocentris.com","sentAt":"2013-10-10T14:19:55Z","receivedAt":"2013-10-10T14:19:55Z","isPatch":true,"sender":{"key":"alexander.kurz@heliocentris.com","avatar":null},"body":"Hello git maintainer crew,\n  recently I stumbled about gitweb generating improper HTML after \nsomebody merged from a branch contining an ampersand, e.g. branch \nname=fixes&features.\n  Thanks, Alexander Kurz\n\n\n>From beccd85ba8b8421213056883f31365f33d6e4490 Mon Sep 17 00:00:00 2001\nFrom: kurz <kurz@DP-KURZ.heliocentris.com>\nDate: Thu, 10 Oct 2013 16:09:46 +0200\nSubject: [PATCH] Fix: Handle ampersand in branch names properly\n\n---\n gitweb/gitweb.perl |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 68c77f6..2963b1d 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2026,7 +2026,7 @@ sub format_ref_marker {\n \t\t\t\t-href => href(\n \t\t\t\t\taction=>$dest_action,\n \t\t\t\t\thash=>$dest\n-\t\t\t\t)}, $name);\n+\t\t\t\t)}, esc_attr($name));\n \n \t\t\t$markers .= \" <span class=\\\"\".esc_attr($class).\"\\\" title=\\\"\".esc_attr($ref).\"\\\">\" .\n \t\t\t\t$link . \"</span>\";\n-- \n1.7.10.4\n\n"}]}