{"thread":{"id":"35012","subject":"[PATCH v2] doc: don't claim that cherry calls patch-id","startedAt":"2013-09-24T22:33:36Z","lastAt":"2013-09-24T22:33:36Z","messageCount":1,"participants":["Michael S. Tsirkin"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"228183","messageId":"1380061947-2353-1-git-send-email-mst@redhat.com","threadId":"35012","inReplyTo":null,"subject":"[PATCH v2] doc: don't claim that cherry calls patch-id","fromName":"Michael S. Tsirkin","fromEmail":"mst@redhat.com","sentAt":"2013-09-24T22:33:36Z","receivedAt":"2013-09-24T22:33:36Z","isPatch":true,"sender":{"key":"mst@kernel.org","avatar":null},"body":"The id is already different for binary files.\nThe hash used is an implementation detail, so\nlet's just document how diffs are compared.\n\nCc: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Michael S. Tsirkin <mst@redhat.com>\n---\n\nChanges from v1:\n\taddress comments by Jonathan\n\n Documentation/git-cherry.txt | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt\nindex f6c19c7..2d0daae 100644\n--- a/Documentation/git-cherry.txt\n+++ b/Documentation/git-cherry.txt\n@@ -14,8 +14,7 @@ DESCRIPTION\n -----------\n The changeset (or \"diff\") of each commit between the fork-point and <head>\n is compared against each commit between the fork-point and <upstream>.\n-The commits are compared with their 'patch id', obtained from\n-the 'git patch-id' program.\n+The diffs are compared after removing any whitespace and line numbers.\n \n Every commit that doesn't exist in the <upstream> branch\n has its id (sha1) reported, prefixed by a symbol.  The ones that have\n-- \nMST\n"}]}