{"thread":{"id":"35004","subject":"[PATCH] sample pre-commit hook: Use --bool when retrieving config var","startedAt":"2013-09-24T07:52:56Z","lastAt":"2013-09-25T10:10:58Z","messageCount":3,"participants":["Johan Herland","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"228144","messageId":"1380009176-10490-1-git-send-email-johan@herland.net","threadId":"35004","inReplyTo":null,"subject":"[PATCH] sample pre-commit hook: Use --bool when retrieving config var","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2013-09-24T07:52:56Z","receivedAt":"2013-09-24T07:52:56Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"Signed-off-by: Johan Herland <johan@herland.net>\n---\n\nResend/reminder...\n\n...Johan\n\n templates/hooks--pre-commit.sample | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/templates/hooks--pre-commit.sample b/templates/hooks--pre-commit.sample\nindex 586e3bf..68d62d5 100755\n--- a/templates/hooks--pre-commit.sample\n+++ b/templates/hooks--pre-commit.sample\n@@ -16,7 +16,7 @@ else\n fi\n \n # If you want to allow non-ASCII filenames set this variable to true.\n-allownonascii=$(git config hooks.allownonascii)\n+allownonascii=$(git config --bool hooks.allownonascii)\n \n # Redirect output to stderr.\n exec 1>&2\n-- \n1.8.1.rc2.269.g5aaac94\n"},{"id":"228169","messageId":"20130924192259.GN9464@google.com","threadId":"35004","inReplyTo":"1380009176-10490-1-git-send-email-johan@herland.net","subject":"Re: [PATCH] sample pre-commit hook: Use --bool when retrieving config var","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-09-24T19:22:59Z","receivedAt":"2013-09-24T19:22:59Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Johan Herland wrote:\n\n> Signed-off-by: Johan Herland <johan@herland.net>\n\nThanks.\n\nWhat symptoms does this alleviate?  Is this to allow configurations like\n\n\t[hooks]\n\t\tallowNonAscii = 1\n\nand\n\n\t[hooks]\n\t\tallowNonAscii\n\t\t\nto do the expected thing, or is it something more subtle than that?\n\nCurious,\nJonathan\n"},{"id":"228199","messageId":"CALKQrgc_5PhN-PsnCPnxcoN+zNKGo1CEJZw0CZzPXvu6aG23uA@mail.gmail.com","threadId":"35004","inReplyTo":"20130924192259.GN9464@google.com","subject":"Re: [PATCH] sample pre-commit hook: Use --bool when retrieving config var","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2013-09-25T10:10:58Z","receivedAt":"2013-09-25T10:10:58Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Tue, Sep 24, 2013 at 9:22 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:\n> Johan Herland wrote:\n>> Signed-off-by: Johan Herland <johan@herland.net>\n>\n> Thanks.\n>\n> What symptoms does this alleviate?  Is this to allow configurations like\n>\n>         [hooks]\n>                 allowNonAscii = 1\n>\n> and\n>\n>         [hooks]\n>                 allowNonAscii\n>\n> to do the expected thing, or is it something more subtle than that?\n\nNothing subtle. Just what you list. And for consistency with the other\nsample hooks' use of \"git config\".\n\n...Johan\n\n-- \nJohan Herland, <johan@herland.net>\nwww.herland.net\n"}]}