{"thread":{"id":"34962","subject":"suspected bug(s) in git-cvsexportcommit.perl","startedAt":"2013-09-18T19:00:46Z","lastAt":"2013-09-22T21:26:23Z","messageCount":2,"participants":["Loyall, David","Robin Rosenberg"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"227854","messageId":"FCEE4469EE8B234199968ECA9B0661E230EB7623@STNEEX10MB01.stone.ne.gov","threadId":"34962","inReplyTo":null,"subject":"suspected bug(s) in git-cvsexportcommit.perl","fromName":"Loyall, David","fromEmail":"david.loyall@nebraska.gov","sentAt":"2013-09-18T19:00:46Z","receivedAt":"2013-09-18T19:00:46Z","isPatch":false,"sender":{"key":"david.loyall@nebraska.gov","avatar":null},"body":"Hello.\n\nI don't believe that git-cvsexportcommit.perl is working properly.\n\nFirst off, invocations of \"git-apply\" fail on my system.  \"git apply\" works.  (The aforementioned script uses the former.)\n\nSecond, please have a look at this output (specific strings have been replaced with 'foo')\n\nhobbes@metalbaby:~/src/foo$ git cvsexportcommit -v fecc8b4bb3d91d204f4eb3ebd112f6cec6004819\nApplying to CVS commit fecc8b4bb3d91d204f4eb3ebd112f6cec6004819 from parent 695a544fbdcf7e0614c35d1dab9a3eac0cc57b4c\nChecking if patch will apply\ncvs status: nothing known about `WebContent/WEB-INF/lib/commons-lang-2.6.jar'\ncvs status: nothing known about `WebContent/WEB-INF/lib/commons-configuration-1.9.jar'\ncvs status: nothing known about `JavaSource/foo/ConfigManager.java'\ncvs status: nothing known about `JavaSource/config.xml'\nHuh? Status 'Unknown' reported for unexpected file 'no file commons-lang-2.6.jar'\nHuh? Status 'Unknown' reported for unexpected file 'no file commons-configuration-1.9.jar'\nHuh? Status 'Unknown' reported for unexpected file 'no file ConfigManager.java'\nHuh? Status 'Unknown' reported for unexpected file 'no file config.xml'\nApplying\n<stdin>:7: trailing whitespace.\n<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n<stdin>:8: trailing whitespace.\n<config>\n<stdin>:9: trailing whitespace.\n                <masterthread>\n<stdin>:10: trailing whitespace.\n                                <queuemappings>\n<stdin>:11: trailing whitespace.\n                                                <mapping threadtype=\"foo\" service=\"foo\" action=\"foo_test\" />\nerror: patch failed: JavaSource/foo/QueueMapping.java:67\nerror: JavaSource/foo/QueueMapping.java: patch does not apply\nContext reduced to (2/2) to apply fragment at 43\ncannot patch at /usr/lib/git-core/git-cvsexportcommit line 333.\nhobbes@metalbaby:~/src/foo$ \n\nEven after I altered my copy of the script to invoke 'git apply' in two places, I still get the erroneous \"unknown\" lines.  My suspicion is that it has something to do with the $basename stuff, but, who am I kidding? I don't grok perl.\n\nI haven't yet explored the error lines after \"Applying\".\n\nSo, what do I want?  I want somebody to test git-cvsexportcommit.perl.  If it passes tests, then I'd like help creating a test that it does fail. (Perhaps my workspace can help.  Perhaps it is as simple as the presence of a new file in a subdirectory.)\n\nCheers, thanks,\n--Dave\n"},{"id":"228038","messageId":"134834661.2525155.1379885183181.JavaMail.zimbra@dewire.com","threadId":"34962","inReplyTo":"FCEE4469EE8B234199968ECA9B0661E230EB7623@STNEEX10MB01.stone.ne.gov","subject":"Re: suspected bug(s) in git-cvsexportcommit.perl","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg@dewire.com","sentAt":"2013-09-22T21:26:23Z","receivedAt":"2013-09-22T21:26:23Z","isPatch":false,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"\n\n----- Ursprungligt meddelande -----\n> Från: \"David Loyall\" <david.loyall@nebraska.gov>\n> Till: git@vger.kernel.org\n> Skickat: onsdag, 18 sep 2013 21:00:46\n> Ämne: suspected bug(s) in git-cvsexportcommit.perl\n> \n> Hello.\n> \n> I don't believe that git-cvsexportcommit.perl is working properly.\n> \n> First off, invocations of \"git-apply\" fail on my system.  \"git apply\" works.\n>   (The aforementioned script uses the former.)\n\ngit-apply is only available from scripts invoked by the git wrapper. Same applies\nto all the other git<dash>-scripts.\n \n> Second, please have a look at this output (specific strings have been\n> replaced with 'foo')\n> \n> hobbes@metalbaby:~/src/foo$ git cvsexportcommit -v\n> fecc8b4bb3d91d204f4eb3ebd112f6cec6004819\n> Applying to CVS commit fecc8b4bb3d91d204f4eb3ebd112f6cec6004819 from parent\n> 695a544fbdcf7e0614c35d1dab9a3eac0cc57b4c\n> Checking if patch will apply\n> cvs status: nothing known about `WebContent/WEB-INF/lib/commons-lang-2.6.jar'\n> cvs status: nothing known about\n> `WebContent/WEB-INF/lib/commons-configuration-1.9.jar'\n> cvs status: nothing known about `JavaSource/foo/ConfigManager.java'\n> cvs status: nothing known about `JavaSource/config.xml'\n> Huh? Status 'Unknown' reported for unexpected file 'no file\n> commons-lang-2.6.jar'\n> Huh? Status 'Unknown' reported for unexpected file 'no file\n> commons-configuration-1.9.jar'\n> Huh? Status 'Unknown' reported for unexpected file 'no file\n> ConfigManager.java'\n> Huh? Status 'Unknown' reported for unexpected file 'no file config.xml'\n> Applying\n> <stdin>:7: trailing whitespace.\n> <?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n> <stdin>:8: trailing whitespace.\n> <config>\n> <stdin>:9: trailing whitespace.\n>                 <masterthread>\n> <stdin>:10: trailing whitespace.\n>                                 <queuemappings>\n> <stdin>:11: trailing whitespace.\n>                                                 <mapping threadtype=\"foo\"\n>                                                 service=\"foo\"\n>                                                 action=\"foo_test\" />\n> error: patch failed: JavaSource/foo/QueueMapping.java:67\n> error: JavaSource/foo/QueueMapping.java: patch does not apply\n> Context reduced to (2/2) to apply fragment at 43\n> cannot patch at /usr/lib/git-core/git-cvsexportcommit line 333.\n> hobbes@metalbaby:~/src/foo$\n\nYour CVS directory is not up to date or you are, in some other way,\ntrying to export something that does not match the content of your CVS\ndirectory. Keep in mind that you cannot export any commit, it must be \npossible to apply the changes in the commit to the CVS checkout, much\nas patch(1) would.\n\nThe -u flag to cvsexportcommit will perform an update from CVS\nfor you, unless you want to do it manually.\n\n> Even after I altered my copy of the script to invoke 'git apply' in two\n> places, I still get the erroneous \"unknown\" lines.  My suspicion is that it\n> has something to do with the $basename stuff, but, who am I kidding? I don't\n> grok perl.\n>\n> I haven't yet explored the error lines after \"Applying\".\n\nSame explanation as for the Unknown status. It's not that the status is not\nknown. The status is \"Uknown\", as in \"CVS does not know about the file\".\n\n> So, what do I want?  I want somebody to test git-cvsexportcommit.perl.  If it\n> passes tests, then I'd like help creating a test that it does fail. (Perhaps\n> my workspace can help.  Perhaps it is as simple as the presence of a new\n> file in a subdirectory.)\n\n-- robin\n"}]}