{"thread":{"id":"34929","subject":"[PATCH v2] sequencer: trivial cleanup","startedAt":"2013-09-13T22:15:06Z","lastAt":"2013-09-13T22:15:06Z","messageCount":1,"participants":["Ramkumar Ramachandra"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"227660","messageId":"1379110506-21721-1-git-send-email-artagnon@gmail.com","threadId":"34929","inReplyTo":null,"subject":"[PATCH v2] sequencer: trivial cleanup","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-09-13T22:15:06Z","receivedAt":"2013-09-13T22:15:06Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Consider that the return values of allow_empty() could either be\nnegative, zero, or one. However, there is no reason to be overtly\nconservative about it: we might as well return positive values as well\nsince the callsite has no problems with it.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n sequencer.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex 351548f..ae25b5b 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -463,13 +463,7 @@ static int allow_empty(struct replay_opts *opts, struct commit *commit)\n \tif (opts->keep_redundant_commits)\n \t\treturn 1;\n \n-\tempty_commit = is_original_commit_empty(commit);\n-\tif (empty_commit < 0)\n-\t\treturn empty_commit;\n-\tif (!empty_commit)\n-\t\treturn 0;\n-\telse\n-\t\treturn 1;\n+\treturn is_original_commit_empty(commit);\n }\n \n static int do_pick_commit(struct commit *commit, struct replay_opts *opts)\n-- \n1.8.4.299.gb3e7d24.dirty\n"}]}